5d9d9b8221
From Wonil Kim: Enable statistics menu register for the tap plug-in. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7466
...
svn path=/trunk/; revision=43726
2012-07-15 16:24:35 +00:00
7deecbf36b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7479 :
...
Provide an empty string when data pointer is not NULL (regression introduced in r43703)
svn path=/trunk/; revision=43724
2012-07-15 15:26:57 +00:00
83c83a0c05
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7356 :
...
Print only visible columns.
svn path=/trunk/; revision=43722
2012-07-15 14:56:40 +00:00
e173f01c5c
Be sure to assign the return value of tvb_length_remaining() to a signed integer and not an unsigned integer, and then check that value is > 0.
...
svn path=/trunk/; revision=43720
2012-07-15 14:31:40 +00:00
0d41b6edad
tvb_length_remaining() can return -1, so check that it's > 0, and not != 0. If tvb_length_remaining() is > 0, then tvb_reported_length_remaining() should also be > 0, so I don't think there's a need for further checks there.
...
svn path=/trunk/; revision=43719
2012-07-15 14:29:06 +00:00
c788e585a9
[Automatic manuf, services and enterprise-numbers update for 2012-07-15]
...
svn path=/trunk/; revision=43718
2012-07-15 14:03:28 +00:00
5ca89cfed3
Sanity checks to avoid a crash if no file is open
...
svn path=/trunk/; revision=43717
2012-07-14 19:59:13 +00:00
1ff8c1fcba
Don't pass the return value of tvb_length_remaining() to fragment_add_check(), as it might have been -1.
...
Fixes Coverity CID 280510: Improper use of negative value.
svn path=/trunk/; revision=43716
2012-07-14 19:52:18 +00:00
590cec6962
tvb_length_remaining() can return -1, so be sure to deal with it if it does. Should fix a bunch of Coverity CID's.
...
svn path=/trunk/; revision=43715
2012-07-14 19:28:40 +00:00
adfe9d3ced
Fix a few 'value stored is never read' warnings and a typo error
...
svn path=/trunk/; revision=43714
2012-07-14 18:54:32 +00:00
d6959d2715
As suggested by Richard Sharpe in http://www.wireshark.org/lists/wireshark-dev/201207/msg00111.html :
...
Make the NTLMSSP Unknown message type string more explicit
svn path=/trunk/; revision=43713
2012-07-14 18:31:08 +00:00
a4ec2596bc
If the offset is out of range, just assign to len to 0 so we don't end up passing a huge value to fragment_add().
...
Fixes Coverity CID 280246: Improper use of negative value.
svn path=/trunk/; revision=43712
2012-07-14 16:29:45 +00:00
a14d130713
Add support for SCSI SBC ORWRITE command
...
svn path=/trunk/; revision=43711
2012-07-14 08:00:03 +00:00
285ee0f9b5
Add support for SCSI SBC COMPARE_AND_WRITE opcode
...
svn path=/trunk/; revision=43709
2012-07-14 02:19:32 +00:00
33b0d13dec
tvb_length_remaining() can return -1, so be sure to deal with it if it does.
...
svn path=/trunk/; revision=43708
2012-07-13 22:20:09 +00:00
7320ebcfd9
Various minor cleanup, including:
...
- remove unneeded #includes;
- remove some unneeded initializers;
- use tvb_reported_length() instead of tvb_length();
- use val_to_str_const() instead of val_to_str();
- fix some typos;
- do some whitespace changes and some reformatting.
svn path=/trunk/; revision=43707
2012-07-13 22:06:40 +00:00
b1eb22bd51
Minor cleanup;
...
- Remove unneeded #includes;
- Create/use value_string_ext for some value_string arrays;
- Do some whitespace changes and reformat some lines.
svn path=/trunk/; revision=43706
2012-07-13 21:59:25 +00:00
5e12ba51e6
If there's not enough data left for a timestamp, be sure there's at least some data to pass off to the generic data dissector.
...
svn path=/trunk/; revision=43705
2012-07-13 21:58:58 +00:00
a099ae38f5
tvb_length_remaining() can return -1, so be sure to deal with it if it does.
...
svn path=/trunk/; revision=43704
2012-07-13 21:46:27 +00:00
472db7609c
tvb_length_remaining() can return -1, so be sure to deal with it if it does.
...
svn path=/trunk/; revision=43703
2012-07-13 21:43:46 +00:00
ad3c388b4b
tvb_length_remaining() can return -1, so check if its return value is <= 0 when aborting and not just == 0.
...
svn path=/trunk/; revision=43702
2012-07-13 21:32:15 +00:00
ff63dcfa8e
Jeff Morriss indicated the following and I obliged:
...
Actually I suppose what was meant is more about whether tp->name[0] is the NULL character (that is, that the name is empty).
But since the result of the lookup is already there in 'found' the whole condition can probably be taken out.
svn path=/trunk/; revision=43701
2012-07-13 21:20:00 +00:00
ba376235da
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7474 :
...
Dissect LTE RADIUS AVP 3GPP-User-Location-Info
svn path=/trunk/; revision=43700
2012-07-13 21:18:35 +00:00
f8d42e6f61
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer and don't check it against non-zero but greater than zero.
...
svn path=/trunk/; revision=43699
2012-07-13 21:14:43 +00:00
a592bd657c
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID 281367: Improper use of negative value.
...
svn path=/trunk/; revision=43698
2012-07-13 21:03:54 +00:00
4d180fbe32
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID's 280233 and 280234.
...
svn path=/trunk/; revision=43697
2012-07-13 20:47:08 +00:00
7e3019c186
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID's 280233 and 280234.
...
svn path=/trunk/; revision=43696
2012-07-13 20:43:55 +00:00
86b2f69672
tp->name can't be NULL, but perhaps tp can be?
...
Fixes Coverity CID 709597: Array compared against 0.
svn path=/trunk/; revision=43695
2012-07-13 20:09:29 +00:00
5f6a3400dc
Fix Coverity CID 709600: Resource leak.
...
svn path=/trunk/; revision=43694
2012-07-13 20:04:28 +00:00
ed47e7bae4
Remove unused filters found by checkhf.pl
...
svn path=/trunk/; revision=43693
2012-07-13 17:16:28 +00:00
e31dfd95ea
From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7476 :
...
UMA dissector incorrectly passes MAC addresses to wireshark core
svn path=/trunk/; revision=43692
2012-07-13 17:04:43 +00:00
484016cb87
Update 3GPP-RAT-Type values
...
svn path=/trunk/; revision=43691
2012-07-13 16:56:11 +00:00
30e481a804
Update dissector to match asn1/pkcs1 sources.
...
svn path=/trunk/; revision=43690
2012-07-13 12:34:36 +00:00
e6818f164e
Fix incorrect(duplicate) value in artnet_oem_code_vals[] value string array;
...
{ 0x0ae0, "chainzone:RoundTable:0 DMX Inputs,
...
- { 0x0ae0, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:...
+ { 0x0b00, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:...
Correct value obtained from Bug #7407 attachment #8684 :
"Art-Net OEM manufacturer codes for 1.4be specification"
https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8684
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407
(Issue noticed because value_string_ext search was 'linear' for this array).
svn path=/trunk/; revision=43689
2012-07-13 04:52:40 +00:00
dd5e3dcfea
Fix crash in geoip_db_pref_init() when changing to a new profile.
...
(Use g_free() not free() for g_malloc'd memory).
svn path=/trunk/; revision=43688
2012-07-13 00:54:53 +00:00
b92733dc39
Add some comments, remove more left-overs from tcp_graph.c.
...
svn path=/trunk/; revision=43687
2012-07-13 00:35:18 +00:00
99bd7cfe44
Add a preference to that when the window scaling options are not
...
visible, we can still configure a scaling factor and therefore get
better TCP sequence analysis and see better stream graphs.
A single preference is used for any/all streams for which the true value
isn't known. I tried to make it obvious when showing the calculated
window size that it came fromt he preference setting. The default value
for this preference is off, i.e. it won't change existing behaviour.
This was discussed a little at Sharkfest and raised on the developers
list last week.
svn path=/trunk/; revision=43686
2012-07-12 23:57:51 +00:00
bc1b0fd21d
Try not to print funny characters.
...
svn path=/trunk/; revision=43685
2012-07-12 23:39:25 +00:00
5d4638e95c
Fix building (and running) on OS X.
...
svn path=/trunk/; revision=43684
2012-07-12 22:39:04 +00:00
5150511879
Do expert "telegrams lost" only of field is > 0;
...
Don't call expert...() under 'if (tree)'
svn path=/trunk/; revision=43683
2012-07-12 20:08:34 +00:00
d5b965176a
Don't call subdissector / expert...() under 'if (tree)'
...
Reformat hf[] entries.
svn path=/trunk/; revision=43682
2012-07-12 19:36:35 +00:00
859affc2bd
Don't call subdissectors / expert...() / col...() under 'if (tree)'
...
Also:
Remove some uneeded initializers;
Do some whitespace cleanup and re-formatting.
svn path=/trunk/; revision=43681
2012-07-12 17:22:47 +00:00
02d23f97b0
Add crc7 calculation abillity.
...
svn path=/trunk/; revision=43680
2012-07-12 14:24:19 +00:00
5a63e1b79a
Add svn:keywords & svn:eol-style properties
...
svn path=/trunk/; revision=43679
2012-07-12 14:23:25 +00:00
409cdcc5ed
Speed up reading of out-header values, and add a couple of 'monitor'
...
fields.
svn path=/trunk/; revision=43678
2012-07-12 01:26:08 +00:00
bdea70585d
Use win32_open_file in qtshark on Windows.
...
svn path=/trunk/; revision=43677
2012-07-12 00:04:53 +00:00
c7c73e44b5
MSDN says DIALOG resources are obsolete. Use DIALOGEXes instead. We aren't
...
adding extra controls to the save dialog any more so remove its template.
svn path=/trunk/; revision=43676
2012-07-11 21:25:42 +00:00
e7b8e93e27
memcpy() is quite a bit faster than g_strlcpy()!
...
svn path=/trunk/; revision=43675
2012-07-11 20:53:24 +00:00
220958548c
Fix compile error.
...
svn path=/trunk/; revision=43674
2012-07-11 20:52:52 +00:00
26fd1cf862
Add some initializers to prevent some not really valid compiler warnings.
...
svn path=/trunk/; revision=43673
2012-07-11 20:49:35 +00:00
Anders Broman