Commit Graph

43846 Commits

Author SHA1 Message Date
Chris Maynard 4ca2e780bf Fix trivial typo.
svn path=/trunk/; revision=46448
2012-12-07 20:02:01 +00:00
Anders Broman 8f3f87a931 Bump revission.
svn path=/trunk/; revision=46447
2012-12-07 19:15:34 +00:00
Gerald Combs 739c90f0ad Move a lot of common fuzz-test and randpkt-test code to its own file
(test-common.sh). Add build information to the error output as suggested
in http://www.wireshark.org/lists/wireshark-dev/201212/msg00037.html

svn path=/trunk/; revision=46446
2012-12-07 17:57:09 +00:00
Anders Broman 5505655199 From hannes:
'Fix for displaying the payload of the first chunk correctly.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8068

svn path=/trunk/; revision=46445
2012-12-07 16:57:14 +00:00
Bill Meier 65384d0091 General cleanup:
- Don't call col...() & expert...() under 'if (tree)';
- Localize some variables; Remove uneeded initializers;
- Remove incorret _U_ from certain function parameters;
- Reformat long-lines; Do whitespace changes;
- Misc.


svn path=/trunk/; revision=46444
2012-12-07 16:25:56 +00:00
Anders Broman 6e0208c98e Correct dissection of RNC ID in two places.
svn path=/trunk/; revision=46443
2012-12-07 14:41:05 +00:00
Michael Tüxen 0f3f4eb79a Don't leak a string.
svn path=/trunk/; revision=46442
2012-12-07 12:58:19 +00:00
Irene Rüngeler df8cb34370 Fix Bug reported by Anders Broman concerning the capture filter.
svn path=/trunk/; revision=46440
2012-12-07 12:08:12 +00:00
Anders Broman 2f827154f8 Bug 3974 - wrong decoding of gtp.target identification.
Use the IE description from 3GPP TS 29.060 version 10.4.0 Release 10.
- Fix bugs with RAI and LAC in other parts of the code.

svn path=/trunk/; revision=46439
2012-12-07 12:06:40 +00:00
Stig Bjørlykke 38aeb0e1e3 Added deltaRevocationList.
svn path=/trunk/; revision=46438
2012-12-07 11:40:29 +00:00
Anders Broman 264ac136ef Make it easier to make full extended value string if required.
svn path=/trunk/; revision=46437
2012-12-07 09:34:39 +00:00
Anders Broman e7c9ade670 From hannes:
Enable the plugin to detect and reassemble chunked UA messages for displaying them correctly.

From me:
- Partly applied by hand.
- move hf and ett asignments inseide the register routine as per convention.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8068

svn path=/trunk/; revision=46436
2012-12-07 09:33:40 +00:00
Gerald Combs e5d5ea7db7 Use 16x16 icons for small toolbars as well as menus.
svn path=/trunk/; revision=46435
2012-12-07 01:57:05 +00:00
Gerald Combs 59cd52b5ca Implement the items under "Edit→Copy", "Analyze→Apply as Filter" and
"Analyze→Prepare a Filter". Add a context menu to the protocol tree and
fill in the items we've implemented so far.

Add an "applyAllPreferences" method and corresponding
"preferencesUpdated" signal to wsApp. Use it to set the maximum display
filter combo count.

Move the packet filtering code from the display filter edit to the main
window (which makes more sense and matches what we're doing in the GTK+
version and gets rid of more global cfile references). Try to center the
display filter edit button images.

Use a different "close" button in the main toolbar. It looks better but
is still wrong (on OS X at least).

svn path=/trunk/; revision=46434
2012-12-07 01:46:20 +00:00
Gerald Combs 2b240a299b Fix an apparent copy/paste error.
svn path=/trunk/; revision=46433
2012-12-07 00:39:28 +00:00
Guy Harris 6913fe06ba Revert previous change - maybe we shouldn't enable -Wshadow with crufty
old GCCs that complain about that.

svn path=/trunk/; revision=46432
2012-12-06 23:43:00 +00:00
Guy Harris eed1e3c91b Squelch some -Wshadow warnings (inappropriate warnings - they're just
names in a prototype declaration - but maybe that's what you get with
older compilers).

svn path=/trunk/; revision=46431
2012-12-06 23:19:13 +00:00
Bill Meier 9384bedb13 Revert SVN #46429 again (for now);
It appears that the compiler on
the OSX-10.5-x86 buildbot must be pretty old.

All the other *nix buildbot compilers do not
check the dummy param names used in the definition
of 'xxx' below to see if they are shadowing
anything.

void foo(tvbuff_t tvb, ...) {
  'void (*xxx)(tvbuff_t tvb, ....) = NULL;'
  ...
}

I do seem to remember reading that gcc once
had this issue but was fixed eventually.


svn path=/trunk/; revision=46430
2012-12-06 23:11:54 +00:00
Bill Meier c2639439e4 Enable [-Wshadow] as default for *nix compilers] (C only): 2nd try.
svn path=/trunk/; revision=46429
2012-12-06 22:15:21 +00:00
Bill Meier 62d0eacfc7 Fix two more incorrect s/link/linkr/ done by me in SVN #46426.
svn path=/trunk/; revision=46428
2012-12-06 21:35:03 +00:00
Bill Meier 60fd1d6d27 Fix compile error;
svn path=/trunk/; revision=46427
2012-12-06 21:27:04 +00:00
Bill Meier ae68f42297 Fix [-Wshadow] warnings.
svn path=/trunk/; revision=46426
2012-12-06 20:59:53 +00:00
Bill Meier 35b912bcbf Fix "MPLS payload starting with valid-looking ethernet address dissected twice".
Fixes Bug #8043
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8043


svn path=/trunk/; revision=46420
2012-12-06 15:15:05 +00:00
Jeff Morriss f448c1d1c8 As requested in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7735 :
Finish splitting source and destination address fields into their own hf's.

Also remove a couple unused hf's, remove (mostly 4-space) tabs, and reindent
some.

svn path=/trunk/; revision=46418
2012-12-06 04:57:23 +00:00
Jeff Morriss 97bbd2fc0a Fix inifite loop in the R3 dissector reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8040 :

If the alarm length is 0, raise an expert_info and break out of the loop.

svn path=/trunk/; revision=46415
2012-12-06 01:43:37 +00:00
Gerald Combs ecad8311ca Add the new toolbar icons.
svn path=/trunk/; revision=46414
2012-12-05 22:30:02 +00:00
Gerald Combs 07898cae39 Create 16x16 and 24x24 versions of the document icon with a contrasting
border. Add them as pixbufs to ui/gtk/toolbar_icons.h and use them to
replace the file icon XPM in stock_icons.c. Add modelines.

svn path=/trunk/; revision=46413
2012-12-05 22:28:12 +00:00
Gerald Combs 025f5d1ecd Make it more obvious that we're locking and unlocking.
svn path=/trunk/; revision=46412
2012-12-05 22:22:52 +00:00
Martin Mathieson d1457cfca8 Choose direction properly if launching graph based upon channel of
selected frame.

svn path=/trunk/; revision=46411
2012-12-05 22:05:18 +00:00
Gerald Combs 41a8f22c3c Add more missing #includes.
svn path=/trunk/; revision=46410
2012-12-05 20:33:40 +00:00
Gerald Combs 874c87610b Fix some C++ abuses that Guy found via LLVM.
svn path=/trunk/; revision=46408
2012-12-05 19:04:59 +00:00
Anders Broman a85be64367 Found non-ASCII characters on line 7323 of packet-isup.c
svn path=/trunk/; revision=46407
2012-12-05 17:45:54 +00:00
Anders Broman 59af28f911 unused variable 'length'
svn path=/trunk/; revision=46406
2012-12-05 17:08:34 +00:00
Anders Broman f06a499b83 Dissect more Japanese ISUP parameters.
svn path=/trunk/; revision=46405
2012-12-05 16:21:09 +00:00
Bill Meier 95a64a667d Fix another instance of a variable/parameter name "shadowing" a library function name;
(At least some (gcc ?) compilers give a "shadow" warning for these).

svn path=/trunk/; revision=46404
2012-12-05 16:19:12 +00:00
Jörg Mayer fed92f6ee2 Whitespace changes
svn path=/trunk/; revision=46403
2012-12-05 16:05:04 +00:00
Bill Meier 7cd0417af5 Fix numerous instances of a variable/parameter name "shadowing" a library function name;
(At least some (gcc ?) compilers give a "shadow" warning for these).

svn path=/trunk/; revision=46402
2012-12-05 15:56:36 +00:00
Jeff Morriss f8ba6b5a07 Reduce the level of the warning about the padding on the final parameter from
PI_ERROR to PI_NOTE.  (If FreeBSD's been living with the wrong behavior for
years then apparently it doesn't cause interop problems.)

svn path=/trunk/; revision=46401
2012-12-05 15:27:30 +00:00
Jeff Morriss ff8e679df2 Add some generated header files to GENERATED_NODIST_HEADER_FILES (to fix
distcheck).

svn path=/trunk/; revision=46400
2012-12-05 15:14:20 +00:00
Jeff Morriss 0dc1b8b4b2 Run checkAPIs on DISSECTOR_SUPPORT_SRC too. This means we check register.c
(not very useful) but it means we'll also check the IPMI subparsers and
usb.c .  (Yes, register.c could be split out into Yet Another Variable but
I'm not sure it's worth it...)

svn path=/trunk/; revision=46399
2012-12-05 15:11:08 +00:00
Pascal Quantin 57f7171c87 Update USB vendor and product ids and escape non ASCII characters
svn path=/trunk/; revision=46398
2012-12-05 12:56:41 +00:00
Alexis La Goutte da700a93b6 From François-Xavier Le Bail via https://www.wireshark.org/lists/wireshark-dev/201212/msg00027.html
Add some missing RFC references in DHCPv6 dissector

svn path=/trunk/; revision=46397
2012-12-05 09:38:28 +00:00
Anders Broman ca4bb77022 From Patrik Lundquist:
Improvements to BitTorrent DHT dissector

Fixed filtering on protocol "bt-dht".

Improved heuristics. Can probably be enabled by default now (but I'll let someone else make that decision).

Unexpected IP address (first packet in capture file) and binary "tokens" (packet 17) were incorrectly printed as UTF-8 strings.

Moved duplicate code into bencoded_string_length().

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8044

svn path=/trunk/; revision=46396
2012-12-05 09:27:58 +00:00
Anders Broman b81575cd6e From Michal Labedzki:
RTP: Make addresses more generic and use ensure that
 used generic address instead of net address

Address can be various, not only "IP", for example Bluetooth addr/name.
Also specify address used to find stream by RTP Player to be
generic address (src/dst), not network address (net_src/net_dst),
this allow to find RTP stream where those addresses are not the same.


Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893

svn path=/trunk/; revision=46395
2012-12-05 09:21:26 +00:00
Anders Broman a4e26f6600 From Mike Morrin:
fix handling of some EGPRS Coding and Puncturing Schemes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8062

svn path=/trunk/; revision=46394
2012-12-05 09:10:18 +00:00
Anders Broman 4d1a788872 From Martin Kaiser:
Looking at RFC 6424, the whole approach is unclear to me. We seem to read subtlv_type and _length only once and then do the while loop. Section 3.3 of RFC6424 says that there's a list of subtlvs, I'd expect type and length to be read in the while loop...

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8039

svn path=/trunk/; revision=46391
2012-12-05 09:04:37 +00:00
Guy Harris 829ab57742 Regenerate manuf again.
svn path=/trunk/; revision=46389
2012-12-05 08:56:51 +00:00
Guy Harris 4e3f76bebd Add a bunch of #defines for converting between tm_year/tm_mon/tm_mday to
a DOS date.

Use them - which fixes a bug, bug 7998, wherein we were doing the wrong
check to see whether tm_year would fit in a DOS date or not.

svn path=/trunk/; revision=46387
2012-12-05 08:29:22 +00:00
Guy Harris d0cb71e6d0 Broadcom "donated" one of their OUIs for use in Fibre Channel over
Ethernet group MAC-48 addresses:

	http://www.t11.org/ftp/t11/pub/fc/bb-5/08-334v0.pdf

so we add entries for the three group addresses in question and an entry
to cover all unassigned group addresses in that range.

Regenerate manuf file.

Fixes bug 8046.

svn path=/trunk/; revision=46386
2012-12-05 03:45:11 +00:00
Martin Mathieson 5589af9699 Use g_malloc0() to initialize the counters. MAC was using uninitialized
memory...

svn path=/trunk/; revision=46385
2012-12-05 03:12:43 +00:00