The notifications that were added are for pNFS deviceid's, which
generally have a name in the spec like "notify_deviceid_type4". The
generic "notify" name is used for the directory change notifications.
Rename the old deviceid notifier functions and variables to a more
appropriate name.
Change-Id: Ibf80a41c7e2369bdd8ce669265cd549772a56338
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Instead of using g_strsplit, split the custom column format string
from the right. The ocurrence and "show resolved" tokens appear at
the end, but there could be a ':' internal to the filter, if we
later update what custom column filter strings are allowed in
order to support slices.
Necessary (but not sufficent) for #10154
When syn cookie support was added, a new tree was added under
the TCP timestamp option TSVal. Unfortunately, it was done
so by reusing the proto_item pointer that was pointing to the
tree item for the top level of the option, before it was done
having text appended to it.
Add a new proto_item pointer so that the text gets appended
to the original place.
Fixup acc0260c84
blf_pull_next_logcontainer() shuld check, aftre calling
blf_find_next_logcontainer() to see if the size of the
GArray of log containers is 0; if so, that means no log container was
found, probably because there aren't any to find.
This fixes a case where attempting to read a file with no log containers
causes a crash.
Put the priority and VCID into the Info column - and the top-level
protocol item.
And, again, don't fetch values in advance and set the Info column and
top-level protocol item text early. Instead, add each field to the Info
column and top-level protocol item when we add the field to the protocol
tree, so that if the frame is cut short, we dissect as much of it as we
can and put as much of it as we can into the Info column and top-level
protocol item.
Don't fetch values in advance and set the Info column and top-level
protocol item text early. Instead, add each field to the Info column
and top-level protocol item when we add the field to the protocol tree,
so that if the frame is cut short, we dissect as much of it as we can
and put as much of it as we can into the Info column and top-level
protocol item.
When generating DVFM code, tell the return function what
register has the final set of fvalues for filters that are
functions, arithmetic, or slices (that is, that compare one
or more fvalues to see if they are all zero.) Make sure
that these functions return an empty ptr array, unlike
tests that return a null ptr array.
For fields, we could return the fvalues, but currently we
don't bother loading the fvalues into registers since display
filters that just have a field test existence, so the generated
code would have to change. It's also a little more complicated
because there can be multiple fields that have different types
(sometimes not commensurable, which is an error noted by some of
the checks.) The logic in custom columns handles the field cases
currently.
Show all 8 hex digits for extended IDs, show all 3 hex digits for
standard IDs.
Also, show the length with %u, not %d, as it's unsigned (it won't be
bigger than 2^32-1, so that doesn't affect the output, but it's a better
type match.
The "flags" field in CAN classic and CAN FD is relly a "flags and ID"
field; rename appropriatey.
Rename can_..._flags_id_fd fields to canfd_..._flags_id, so as not to
mix up "flags_id" and "fd" - the latter refers to CAN FD, the former
refers to the two values in the item.
Allow subdissectors to register for particular CAN XL SDU types, e.g.
some Ethernet dissector (which one - the "always with FCS" one or the
"never with FCS done" - would depends on whether the FCS is included in
the tunneled frame; lacking access to the spec, I don't know which is
the case) would register in that table with the two tunneling types.
Provide SDU type #defines in packet-socketcan.h.
We don't need to read or use the column format string in
the recent settings column width info, because now they're
in sync with the indices used in prefs.col_list.
Continue to write it when writing out the recent settings for
backwards compatibility with older version.
We can also remove the workaround for #14177 from
commit c62dadd31f as it's
not needed.
This solves the width and alignment part of #15529. Hidden
states are still to do.
Those links are to questions with answers that indicate how to show a
folder window with a particular file selected using system APIs rather
than firing up programs.
Change the "fd" gboolean in can_info_t to a guint, and give it a value
of 2 for CAN XL. That preserves source and binary compatiility, at
least in the case where a plugin would never be handed a CAN XL frame.
Update code to treat it as such, to make it clearer what that code is
doing.
Add CAN XL support to the SocketCAN dissector - and to the
LINKTYPE_LINUX_SLL detector. Note that the fields in the
LINKTYPE_CAN_SOCKETCAN header for CAN XL frames are *little-endian*, as
most if not all existing captures were probably done on little-endian
machines - libpcap does that so that LINKTYPE_CAN_SOCKETCAN doesn't
become one of those annoying link-layer types with *host-endian* (as in
"the byte order of the host that last processed this file") fields
(which require special processing in pcap/pcapng file readers *and* in
rpcap clients).
If the CANFD_FDF flag isn't set, treat the frame as CAN FD if it's
exactly 72 bytes long; this works around a libpcap 1.10.{2,3,4} bug
(which should be fixed in the next libpcap release) that inadvertantly
cleared that flag for CAN FD frames.
Keep the recent column width list in sync with the order of the
prefs.col_list by appending, inserting, and moving the recent
column width list at the same time, instead of allowing them
to get out of sync (as we use the format for a key.)
Fix an issue where column_prefs_add_custom did not always return
the position of the column added (when a column number was passed
in that was less than the maximum number of columns.)
Preparation for the width and alignment part of #15529
Add the ability to change the width and alignment of columns
from the Column Preferences.
This also makes it easier to eventually fix#15529 by having all
the column-relevant details edited at once. In order to properly
solve that issue, the column indices from the preferences and the
recent settings need to be kept in sync, instead of using the format
as the unique key.
Related to #15529
Heuristics should not filter out packets that have destinationPAN ID != IEEE802154_BCAST_PAN, since GPD frames MAY inform PAN ID - GPD spec v1.1.1 section A.1.7.1.2 MAC addressing fields
The DCM tag/status/uid lookup tables are only ever read. const-ifying them
moves about 220 kBytes of data to a read-only data section.
packet-dcm.h was regenerated using the make-packet-dcm.py script.
The Well-Known Frames of Reference data have moved to Table A-2, so the script
is updated to integrate the data from that table into the UID list.
Ran "tools/make-packet-dcm.py > epan/dissectors/packet-dcm.h".
MR !14295 ran into trouble with the license checker because three added lines
in tools/make-packet-dcm.py moved the important piece of text outside the
150-line window in which it was checking.
This change maintains the status quo by expanding the window to 160 lines.
Pass the sysdig.param.asyncevent.data start and offset to the Falco Bridge
dissector, and use that to highlight the evt.buffer and fd fields.
Pass the data to the ELF dissector if we find an ELF magic ID.
Lawful Interception (LI) is the main area and should be located first
in name, which will be more easy of use for new user when want to
filter messages
Be a little more careful in TrafficTab about whether we
want the Proxy Model or the Source Model, since the tap
filter doesn't exclude rows from the source model (since
the non-displayed rows are used to as part of the percentages
of the total.)
When we want to respect the display filtering or the sorting,
use the proxy model.
In the tap data model, only claim we have GeoIPData (which makes
the map available) if a row that isn't filtered out has data.
Fix#18530
Jeff Layton