CaptureOptionsDialog allocates a SparkLineDelegate in its constructor.
It should set itself as parent of the SparkLineDelegate.
Without a parent, the SparkLineDelegate is never freed and each
invocation of Capture / Options leaks memory.
Change
case DATA_FRAME:
if (condition) {
do stuff;
break;
}
do other stuff;
break;
to
case DATA_FRAME:
if (condition) {
do stuff;
} else {
do other stuff;
}
break;
to make it clearer that it's "do this if condition is true, else do
that".
The Get Attribute Response Info contains attributes requested by the
Get Attributes message. It contains the same attributes which can be part
an OML message.
Change the wording of the sequence number context information from
"Wrong" to the more accurate description that this is a retransmit.
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Add context information for next expected sequence number so that
analysing for acknowledgedment or request for retransmit can be done
without comparing packets manually.
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
If check the 'preload_protos' on, the .proto files will be loaded
on startup. That make tshark can use 'protobuf fields as wireshark
fields' feature by providing protobuf field name in display filter
(-Y option).
close#17036
Big Sur goes to 11, and it appears that next year's (San Juan Capistrano?)
will go to 12, and so on.
Split version numbers into major and minor, and do version-number
comparison (alas, whilst CMake has that built in, the Bourne shell
doesn't, and neither does the Bourne-again shell).
This should fix issue #17043.
On Windows, we do pipe I/O in a separate thread, as we can't do select()
- or even WaitForMultipleObjects() - on pipes, so
cap_pipe_read_data_bytes() is used only on sockets.
Update a comment.
We check for that when *writing* the block, but the error message for
that is not at all clear; check for it after we've read the block total
length, and report it with a better error message.
Clean up some other error messages while we're at it.
- IP header compression configuration
- DS-TT Ethernet port MAC address
- UE-DS-TT residence time
- Port management information container
- Ethernet header compression configuration
When there is no do_dissection cf is missing some variables
for cf_close() call. Therefore we have to set them explicitly.
Fixes: wireshark/wireshark#17021
Get value of message type from the buffer before displaying it
in the info column of the packet list pane. Also, make sure
there is enough bytes in the buffer to get the RPCoRDMA header.