Commit Graph

5352 Commits

Author SHA1 Message Date
Guy Harris 16d52f4f29 From Joerg Mayer: mark unused arguments as such.
svn path=/trunk/; revision=5380
2002-05-04 09:05:44 +00:00
Richard Sharpe e626714c31 Add the packet len to the protocol tree as well, since it is often not visible in the summary display.
svn path=/trunk/; revision=5379
2002-05-04 02:54:48 +00:00
Guy Harris 71f8208bf9 From Didieer Gautheron:
Don't show progress bar for quick "Find Frame" searches
	Add "Find Next" and "Find Previous" to repeat searches

Add documentation for "Find Next" and "Find Previous".

svn path=/trunk/; revision=5378
2002-05-03 21:55:15 +00:00
Guy Harris 7aba39031e From Didier Gautheron: add a "frame.marked" hidden field, set if the
frame is marked, so that you can use Find Frame to find the next marked
frame, and can filter the display to show only marked frames.

Update the documentation to note that "frame.marked" is set on marked
frames.

svn path=/trunk/; revision=5377
2002-05-03 21:38:20 +00:00
Guy Harris 04ad5f17ea From Didier Gautheron:
afp :
	more calls.
    asp :
	move release transaction to atp.
	dissect asp call.
	fix a bug with transaction handling (conversation +tid are not
	enough as key ).
    atp :
	deal with one packet transaction without ATP_EOM.
    dsi:
	safeguard against overflow for unreassembled packet.
	more flags decoded.

Update the "packet-atalk.c" comment to reflect all the protocols in it.

svn path=/trunk/; revision=5376
2002-05-03 21:25:43 +00:00
Nathan Neulinger 185fb53e72 fix field names, break down flood and trace control packets, other cosmetics
svn path=/trunk/; revision=5375
2002-05-03 20:34:14 +00:00
Nathan Neulinger 84d448e702 split opnums out onto separate tree
svn path=/trunk/; revision=5374
2002-05-03 19:47:09 +00:00
Nathan Neulinger 3fb5815bb4 added dissection of various query, report, admin operations
svn path=/trunk/; revision=5373
2002-05-03 19:31:02 +00:00
Nathan Neulinger c76c6580bc added full copy of protocol header, small updates
svn path=/trunk/; revision=5372
2002-05-03 16:23:25 +00:00
Nathan Neulinger 699de0ebbc Add initial support for udp packets of the Distributed Checksum Clearhouse protocol
svn path=/trunk/; revision=5371
2002-05-03 15:50:11 +00:00
Ronnie Sahlberg e6b32ff74a Added some new discovered names for some NETLOGON functions
svn path=/trunk/; revision=5370
2002-05-03 11:16:55 +00:00
Guy Harris 4df4388b91 Make the filter list combo box case-sensitive, as filter expressions are
case-sensitive.

Squelch a compiler complaint.

svn path=/trunk/; revision=5369
2002-05-03 03:30:15 +00:00
Guy Harris 433e8801a1 Clean up the handling of filter strings:
have "filter_packets()" make a copy of the filter string handed
	to it, as it may save the filter string in the "capture_file"
	structure, and the caller of "filter_packets()" shouldn't have
	to worry about the string it passed to "filter_packets()" being
	stashed away somewhere so that it can't just free that string or
	change it;

	have callers of "filter_packets()" free up the string they
	handed to it, if the string was allocated and they're done with
	it;

	plug some memory leaks in "match_selected_cb_do()".

Check for an illegal "action" argument being passed to
"match_selected_cb_do()".

Move some keys out of "keys.h" into "gtk/main.c", as they're only used
in "gtk/main.c".

Make the pointer to the filter list a data item for the combo box, as
it's a copy of the list of strings for the combo box, rather than
attaching it to the widgets that activate the filter (a pointer to the
combo box *itself* is a data item for those widgets).

In "filter_activate_cb()", make a copy of the text from the text entry
field as soon as we fetch it, and use that copy.  Free that copy if
we didn't add the filter to the filter list.

Don't make a copy of the entire filter list and use that to set the
combo box's list of items - just use the list itself.  Also, when the
list is changed, make the new value the data for the combo box (the list
pointer will actually not be changed, because we happen to be using
"g_list_append()", but let's not rely on that).

svn path=/trunk/; revision=5368
2002-05-03 03:24:47 +00:00
Guy Harris 0705d7ff0b Remove some no-longer-applicable XXX comments.
When you click "OK" on the dialog box, destroy the dialog box *before*
activating any text widget into which we've stuffed the filter
expression, so we don't get the dialog box destroyed out from under us
before we try to destroy it ourselves.

svn path=/trunk/; revision=5367
2002-05-02 23:49:21 +00:00
Guy Harris f7724391aa From Joerg Mayer: get rid of some unused variables and arguments, and
mark other unused arguments as such.

svn path=/trunk/; revision=5366
2002-05-02 21:47:47 +00:00
Guy Harris f7570d4440 From Joerg Mayer: get rid of unused arguments, and "#if" out an unused
stub routine.

svn path=/trunk/; revision=5365
2002-05-02 19:39:05 +00:00
Guy Harris 5d7d5bb2d0 From Joerg Mayer: get rid of unused arguments.
svn path=/trunk/; revision=5364
2002-05-02 19:32:19 +00:00
Guy Harris cedbe93a26 Only say "IPv6" once in the Info column for "no next header" packets.
svn path=/trunk/; revision=5363
2002-05-02 11:52:52 +00:00
Guy Harris 50e7338c51 From Joerg Mayer:
Prefer IEEE entries over CaveBear entries, as the former list
	seems to be the better maintained one.

svn path=/trunk/; revision=5362
2002-05-02 11:07:47 +00:00
Guy Harris 8245e425ff From Joerg Mayer: flag unused arguments as such.
svn path=/trunk/; revision=5361
2002-05-02 11:05:44 +00:00
Guy Harris a2de5f613b From Joerg Mayer: flag unused arguments as such.
svn path=/trunk/; revision=5360
2002-05-02 10:59:37 +00:00
Guy Harris b41c5cf529 Put the protocol version into the ICQ v2/v3/v4 tree.
svn path=/trunk/; revision=5359
2002-05-02 10:53:03 +00:00
Guy Harris 0949b2667c From Joerg Mayer: get rid of some unused arguments.
Put a minimal protocol tree in for ICQ v2, v3, and v4.

Add some length checks.

Properly handle the captured and the actual size of the ICQ packet.

svn path=/trunk/; revision=5358
2002-05-02 10:46:23 +00:00
Guy Harris 8c050e6851 From Joerg Mayer: mark unused arguments as such.
Add a check in "dissect_hello_restart_clv()" that the length of the TLV
is correct.

Use "val_to_str()" to get the name of the adjacency state in
"dissect_hello_ptp_adj_clv()".

svn path=/trunk/; revision=5357
2002-05-02 10:13:56 +00:00
Guy Harris 2e44d10e3e Make all routines not used outside this module static.
Get rid of some unused arguments.

Pass the tree argument, not the item argument, to "proto_tree_add"
routines.

svn path=/trunk/; revision=5356
2002-05-02 09:52:20 +00:00
Guy Harris eb3a7f1f5e From Joerg Mayer: get rid of an unused argument.
svn path=/trunk/; revision=5355
2002-05-02 09:34:33 +00:00
Guy Harris b883ca4127 From Joerg Mayer: get rid of unused arguments.
Fix the spelling of "Reserved".

Use "proto_item_append_text()" when dissecting EIGRP TLVs, so they don't
have to put in name of the TLV into the top-level item for the TLV, they
can just append to the name that's already there.

svn path=/trunk/; revision=5354
2002-05-02 09:28:43 +00:00
Guy Harris 4eac41df60 Handle the "no next header" next header value specially - put into the
Info column information about the non-final headers seen in the packet
(or leave the information put in there by the AH dissector alone, if
there were AH's), or, if none were seen, just mark it as a "no next
header" packet, and do that in the code used if there's no match for the
next header value in the protocol table, rather than registering a
dissector for "no next header", which also means we'll dissect the
payload as data if there is any.

Use -1, not "tvb_reported_length_remaining()", when making a subset
tvbuff that runs to the end of the parent tvbuff.

svn path=/trunk/; revision=5353
2002-05-02 08:55:52 +00:00
Guy Harris c6266da2d7 Fix a comment.
svn path=/trunk/; revision=5352
2002-05-02 08:51:47 +00:00
Ronnie Sahlberg aec8996522 Added LSA functions 0x38 and 0x3b. These were the two last LSA functions and now
all functions described in lsarpc.idl had been implemented.

svn path=/trunk/; revision=5351
2002-05-02 08:47:23 +00:00
Ronnie Sahlberg 67682ad896 Added LSAEnumerateTrustedDomainsEX and LSACreateTrustedDomainEX
svn path=/trunk/; revision=5350
2002-05-02 08:38:24 +00:00
Ronnie Sahlberg 49c9f431a0 Added LSAGetUserName
svn path=/trunk/; revision=5349
2002-05-02 08:18:53 +00:00
Guy Harris 2311ede6bc From Joerg Mayer: get rid of unused arguments.
svn path=/trunk/; revision=5348
2002-05-02 07:54:41 +00:00
Guy Harris b3cd38fc24 From Joerg Mayer: get rid of an unused argument.
svn path=/trunk/; revision=5347
2002-05-02 07:49:43 +00:00
Ronnie Sahlberg 478548e282 Added LSALookupSIDs2
svn path=/trunk/; revision=5346
2002-05-02 06:46:31 +00:00
Ronnie Sahlberg 6c963907d9 Added LSACloseTrustedDomainEX
svn path=/trunk/; revision=5345
2002-05-02 06:33:39 +00:00
Ronnie Sahlberg 9dba75997a Added LSAStorePrivateData and LSARetrievePrivateData
svn path=/trunk/; revision=5344
2002-05-02 06:21:52 +00:00
Ronnie Sahlberg 9eee5a67be Added LSALookupPrivilegedDisplayName
svn path=/trunk/; revision=5343
2002-05-02 06:13:07 +00:00
Guy Harris c34a643e58 Add registered fields for more DATA1 and DATA2 values.
Add an "nb_data1()" routine to add DATA1 values to the protocol tree.

Have "nb_data2()" take an hf_ value as an argument and add the field
with "proto_tree_add_item()".

Decode the values for "largest frame".

svn path=/trunk/; revision=5342
2002-05-02 02:42:17 +00:00
Guy Harris 17714f9c4e Add a "remove an argument" change, from Joerg Mayer, that I'd missed.
Put in a comment noting a problem in the code.

svn path=/trunk/; revision=5341
2002-05-01 21:22:06 +00:00
Guy Harris 1a8ca25f45 Mark unused arguments as such.
svn path=/trunk/; revision=5340
2002-05-01 10:05:02 +00:00
Guy Harris 4b8e35553a Mark some unused arguments as such.
Fix white space.

svn path=/trunk/; revision=5339
2002-05-01 10:01:42 +00:00
Guy Harris 9b6bd61082 Use a value_string for NBF command names and for caller name types.
Make the transmit and receive correlators unsigned quantities - they're
just opaque hex packet IDs.

"nb_data2()" always processes 16-bit quantities; get rid of the "len"
argument to it.  Make it use its "label" argument as a format.

Show the data in an unknown command as "Unknown NetBIOS command data".

Add routines to dissect TERMINATE TRACE and SESSION ALIVE commands.

Note where we'd do reassembly were we to do that.

Don't dissect the payload of the packet as NetBIOS payload unless the
command was DATAGRAM, BROADCAST DATAGRAM, DATA FIRST MIDDLE, or DATA
ONLY LAST.

Fix up the lengths and names of some fields.

svn path=/trunk/; revision=5338
2002-05-01 09:50:44 +00:00
Guy Harris 38a57a1212 Add a check for a zero-length IE to "dissect_q2931_shift_ie()".
svn path=/trunk/; revision=5337
2002-05-01 08:40:22 +00:00
Guy Harris 8a9219d10f From Joerg Mayer: get rid of an unused argument.
Make the loop to dissect NBSS packets run to the end of the reported
data, so it throws an exception on a short frame.

Use -1 rather than "tvb_length(tvb)" for the length of items that run to
the end of the frame.

svn path=/trunk/; revision=5336
2002-05-01 08:34:04 +00:00
Guy Harris f106336624 #if out an unused argument, using the same #if as the references to the
argument.

svn path=/trunk/; revision=5335
2002-05-01 08:26:57 +00:00
Guy Harris 2d0be610b8 Get rid of an unused argument.
Get rid of C++ comments.

svn path=/trunk/; revision=5334
2002-05-01 08:23:31 +00:00
Guy Harris ee154a2a11 From Joerg Mayer: get rid of unused arguments.
svn path=/trunk/; revision=5333
2002-05-01 08:17:09 +00:00
Guy Harris 969e0f7dd4 From Joerg Mayer: get rid of an unused argument.
svn path=/trunk/; revision=5332
2002-05-01 08:11:07 +00:00
Guy Harris 6acd4d1028 From Joerg Mayer: mark unused arguments as such (just in case somebody
later wants to make one of the message dissectors add to the Info
column).

Use -1 rather than "tvb_reported_length_remaining(tvb, offset)" to
specify that a subset tvbuff should run to the end of the parent tvbuff.

svn path=/trunk/; revision=5331
2002-05-01 08:08:01 +00:00