Commit Graph

5352 Commits

Author SHA1 Message Date
Guy Harris 0c7c4c6dfc From Joerg Mayer: get rid of unused arguments.
svn path=/trunk/; revision=5330
2002-05-01 07:54:08 +00:00
Guy Harris 28703b8698 Mark unused arguments as such.
svn path=/trunk/; revision=5329
2002-05-01 07:50:38 +00:00
Guy Harris 495ce3b07f Show errors in the desegmentation process in the protocol tree and Info
column.

svn path=/trunk/; revision=5328
2002-05-01 07:26:45 +00:00
Guy Harris fedc54cc90 Fix an error in a blurb.
svn path=/trunk/; revision=5327
2002-05-01 07:21:19 +00:00
Guy Harris 87b66571c5 Get rid of an unused argument.
svn path=/trunk/; revision=5326
2002-05-01 07:07:09 +00:00
Guy Harris 09f812b7c2 Get rid of unused arguments.
svn path=/trunk/; revision=5325
2002-05-01 06:56:16 +00:00
Guy Harris 2793de4cf9 Make more use of "val_to_str()" and "decode_boolean_bitfield()".
svn path=/trunk/; revision=5324
2002-05-01 06:46:52 +00:00
Guy Harris 66bbf2411a Use the bitfield decoding routines for bitfields.
Show the value of flag fields in the top-level item for the field.

Use "%u", not "%d", to display unsigned quantities.

svn path=/trunk/; revision=5323
2002-05-01 06:15:44 +00:00
Tim Potter f7965cfaab Start of support for setprinter calls. Currently on setprinter level 3 is
decoded properly.

Add printer name to COL_INFO field in ClosePrinter request.

svn path=/trunk/; revision=5322
2002-05-01 05:28:56 +00:00
Guy Harris 573530d0e2 Add desegmentation support.
As a result of that, we now construct a tvbuff for each Gryphon message;
this obviates the need to pass a message length to the dissectors for
each message type.

svn path=/trunk/; revision=5321
2002-05-01 05:24:42 +00:00
Guy Harris 44281ebe32 From Joerg Mayer: get rid of an unused argument.
svn path=/trunk/; revision=5320
2002-05-01 00:09:16 +00:00
Guy Harris f2d63e674e From Joerg Mayer: get rid of unused "title" arguments for
"dissect_Ticket()" and "dissect_Addresses()".

svn path=/trunk/; revision=5319
2002-05-01 00:01:57 +00:00
Guy Harris 56ddb63961 From Joerg Mayer: get rid of unused PDU type argument to
"dissect_osi_options()".

svn path=/trunk/; revision=5318
2002-04-30 23:56:58 +00:00
Guy Harris a06dd1c724 From Joerg Mayer: get rid of unused "pinfo" argument to
"dissect_nt_sec_desc()".

Also, get rid of code to handle lengths of -1 in "dissect_nt_sec_desc()"
- we never pass it a length of -1, as security descriptors aren't sent
over the wire with NDR syntax.

svn path=/trunk/; revision=5317
2002-04-30 23:48:15 +00:00
Guy Harris 2d7f732677 From Didier Gautheron:
more calls supported in AFP;

	ATP desegmentation;

	show the name for NBP function 1 (broadcast request);

	"get status" reply for DSI.

svn path=/trunk/; revision=5316
2002-04-30 22:05:33 +00:00
Guy Harris 5973b6f903 Don't bother telling the user twice that the traffic is LLC multiplexed
traffic; once is enough.

svn path=/trunk/; revision=5315
2002-04-30 21:52:15 +00:00
Guy Harris 105efda404 Move the code to guess the traffic type based on the packet contents
into Wiretap, so that if you read a frame from Wiretap you have what
traffic type information could be gleaned from the information in the
capture file, and can write the frame out to a capture file where the
file contains some or all of that information without having to
determine it outside of Wiretap.

svn path=/trunk/; revision=5314
2002-04-30 18:58:16 +00:00
Guy Harris da74615c79 Get rid of some unused arguments, and mark some others as unused.
Remove the declaration of "dissect_nt_sid()" from
"packet-dcerpc-samr.c"; get it by including "packet-smb-common.h",
instead.

svn path=/trunk/; revision=5313
2002-04-30 11:03:08 +00:00
Guy Harris a977e68fbc Mark the "plugin_address_table_t *" argument to "plugin_init()" as
unused if PLUGINS_NEED_ADDRESS_TABLE isn't defined.

Get rid of some other unused arguments.

svn path=/trunk/; revision=5312
2002-04-30 10:37:37 +00:00
Guy Harris 1c715bb383 Mark the "plugin_address_table_t *" argument to "plugin_init()" as
unused if PLUGINS_NEED_ADDRESS_TABLE isn't defined.

svn path=/trunk/; revision=5311
2002-04-30 10:36:26 +00:00
Ronnie Sahlberg 3db3147785 Added LSACreateAccount
svn path=/trunk/; revision=5310
2002-04-30 10:17:53 +00:00
Ronnie Sahlberg f4699e7346 Added LSALookupNames2
svn path=/trunk/; revision=5309
2002-04-30 10:14:34 +00:00
Ronnie Sahlberg 7eae4eaa8c Added LSAFunction_2e , LSAFunction_2f, LSAQueryDomainInformationPolicy and LSASetDomainInformationPolicy
svn path=/trunk/; revision=5308
2002-04-30 10:02:11 +00:00
Ronnie Sahlberg 1812a849c9 Added LSAOpenTrustedDomainByName
svn path=/trunk/; revision=5307
2002-04-30 09:46:48 +00:00
Ronnie Sahlberg d4f5fe8249 Added LSAQueryTrustedDomainInfo and LSASetTrustedDomainInfo
svn path=/trunk/; revision=5306
2002-04-30 09:40:41 +00:00
Ronnie Sahlberg 1931eb5880 Added LSAQueryTrustedDomainByName and LSASetTrustedDomainByName
svn path=/trunk/; revision=5305
2002-04-30 09:35:10 +00:00
Guy Harris b0f59c0ce7 Support writing Sun atmsnoop files.
Map MARS to TRAF_UNKNOWN, not TRAF_ILMI.

Don't support writing WTAP_ENCAP_NULL files.

svn path=/trunk/; revision=5304
2002-04-30 09:23:29 +00:00
Guy Harris 329b59c858 Uniformly use "sizeof (struct netmon_atm_hdr)" for the size of Network
Monitor's ATM pseudo-header.

Fix a message.

svn path=/trunk/; revision=5303
2002-04-30 09:21:41 +00:00
Guy Harris ecb2a3939e Replace the "ngsniffer_atm" with an "atm" pseudo-header, which isn't
just an image of the ATM Sniffer data.  This means that Ethereal doesn't
have to know any ATM Sniffer-specific details (that's all hidden in
Wiretap), and allows us to add to that pseudo-header fields, traffic
types, etc. unknown to ATM Sniffers.

Have Wiretap map VPI 0/VCI 5 to the signalling AAL - for some capture
files, this might not be necessary, as they may mark all signalling
traffic as such, but, on other platforms, we don't know the AAL, so we
assume AAL5 except for 0/5 traffic.  Doing it in Wiretap lets us hide
those details from Ethereal (and lets Ethereal interpret 0/5 traffic as
non-signalling traffic, in case that happens to be what it is).

We may know that traffic is LANE, but not whether it's LE Control or
emulated 802.3/802.5; handle that case.

svn path=/trunk/; revision=5302
2002-04-30 08:48:27 +00:00
Guy Harris d415468153 The first byte of the frame header in atmsnoop does, in fact, contain an
indication of the type of traffic; use it.

svn path=/trunk/; revision=5301
2002-04-30 06:04:33 +00:00
Tim Potter 63aaa78222 Use the string in the DCERPC sub-dissector array instead of providing
another one in the COL_INFO field.

svn path=/trunk/; revision=5300
2002-04-30 01:44:35 +00:00
Tim Potter 72942ecf6f Changed COL_INFO string from 'rqst FOO(...)' to 'FOO request' as per
discussion on dev list.

svn path=/trunk/; revision=5299
2002-04-30 01:43:12 +00:00
Guy Harris 775d1a978d Note that pre-0.6 libpcap didn't handle HP-UX as well as 0.6 and later
versions do, so you should use 0.6 or later.

svn path=/trunk/; revision=5298
2002-04-29 23:09:35 +00:00
Guy Harris 3737a46f31 Remove the deja.com URLs for netnews articles with groups.google.com
URLs for those articles.

Note that the patches mentioned in one article might not be the current
ones.

svn path=/trunk/; revision=5297
2002-04-29 22:55:22 +00:00
Guy Harris 1a2bc5ad11 Additional RAP error code for password changes sent to a BDC, from Devin
Heitmueller.

svn path=/trunk/; revision=5296
2002-04-29 22:43:23 +00:00
Guy Harris 7cfa480fdd Un-#if out "samr_dissect_get_alias_membership_response()", to serve as a
reminder to check whether "samr_dissect_get_alias_membership_reply()"
should dissect the uint32 at the end as an NT status.

Un-#if out "samr_dissect_context_handle_SID()", to serve as a reminder
to figure out whether it should be deleted or used.

Get rid of "samr_dissect_get_user_groups_rqst()" - it's identical to
"samr_dissect_get_groups_for_user_rqst()", but isn't being used.

svn path=/trunk/; revision=5295
2002-04-29 10:30:18 +00:00
Guy Harris d61cb7942d There's no need to allocate and fill in an array of sub-authorities and
then later construct the sub-authority string from that array; we can
just construct the string as we fetch the sub-authorities.

Given that we're doing that, use the cleanup handler to free the string,
so that we don't leak memory if we throw an exception when fetching the
RID, for example.

svn path=/trunk/; revision=5294
2002-04-29 10:23:04 +00:00
Guy Harris d773807f4f Get rid of an unused variable.
svn path=/trunk/; revision=5293
2002-04-29 10:06:01 +00:00
Guy Harris 4943a12e1b Dissect MIP extensions if the packet was claimed to have more data in it
than the fixed-length stuff, even if that runs past the end of the
captured data, so if it *does* run past the end of the captured data, we
report a short frame.

svn path=/trunk/; revision=5292
2002-04-29 09:57:29 +00:00
Guy Harris ffac667c3b Put back an unused variable, as a reminder that the routine it's in
needs more work.

svn path=/trunk/; revision=5291
2002-04-29 09:41:45 +00:00
Guy Harris 49c728b5d2 Un-#if out "dissect_beep_status()", to serve as a reminder to either get
rid of it or use it.

svn path=/trunk/; revision=5290
2002-04-29 09:40:05 +00:00
Guy Harris 0f18641f5b Have separate fields for volume, long file name, short file name, and
Unicode file name offsets.

Display the "UNIX privileges" field as a 4-longword structure, as part
of the AFP 3.0 spec claims; unfortunately, another part claims it's only
4 bytes, but, unless a "long" is 8 bits, one or the other claim must be
false.

Completely get rid of the static "afp_handle" variable - it's not
necessary.

Put the Unicode name offset into the tree, if present, in
"parse_file_bitmap()" and "parse_dir_bitmap()".

Get rid of some unused variables.

Put the newline mask and character into the tree for FPRead.

svn path=/trunk/; revision=5289
2002-04-29 09:38:34 +00:00
Guy Harris 9a80f0a521 Removal (or, at least, #ifdeffing out) of unused variables and
functions, from David Frascone.

svn path=/trunk/; revision=5288
2002-04-29 08:20:18 +00:00
Guy Harris 30f02bc99c Move the code to build the balanced tree of fields into "proto_init()",
move the code from "dfilter_lookup_token()" into
"proto_registrar_get_byname()", and get rid of "dfilter_lookup_token()"
and have its callers call "proto_registrar_get_byname()" instead.

svn path=/trunk/; revision=5287
2002-04-29 07:55:32 +00:00
Ronnie Sahlberg 6c553bf998 Added LSAAddAccountRights and LSARemoveAccountRights
svn path=/trunk/; revision=5286
2002-04-29 06:23:03 +00:00
Ronnie Sahlberg 3508d634d9 Added LSAEnumerateAccountRights
svn path=/trunk/; revision=5285
2002-04-29 06:15:31 +00:00
Guy Harris 8729e8b514 From Ronnie Sahlberg: the LSA_REFERENCED_DOMAIN_LIST pointer in a
LsaLookupNames reply appears to be a UNIQUE pointer rather than a REF
pointer.

svn path=/trunk/; revision=5284
2002-04-29 01:25:51 +00:00
Guy Harris 32567ff10f Use "proto_tree_add_item()" to add the URI string to the protocol tree,
rather than extracting a string and adding that explicitly (which runs
the risk of leaking memory if the "tvb_get_ptr()" throws an exception).

Use "tvb_format_text()" when adding the string to the Info column, so
that non-printable characters are displayed as escapes.

svn path=/trunk/; revision=5283
2002-04-29 00:33:30 +00:00
Guy Harris fd629d84a8 Show unknown AFP command codes in decimal in the summary line, as we
show them in decimal in the protocol tree.

svn path=/trunk/; revision=5282
2002-04-28 23:47:44 +00:00
Guy Harris dd9f02255d Note in a comment that the display filter code has its own mechanism for
looking up filter fields by name.

svn path=/trunk/; revision=5281
2002-04-28 23:39:58 +00:00