Commit graph

14504 commits

Author SHA1 Message Date
Guy Harris
3f01c028ba "Handle" a couple of cases in the switch statement by adding them to the
"not supported" case, to suppress compiler warnings.

svn path=/trunk/; revision=14811
2005-06-28 22:01:18 +00:00
Guy Harris
c1b4b3a760 "mtp3_sum_draw()" is never called with a null "table" argument - the
code before the call would have blown up if "table" were null.  Remove
the check for a null pointer; this squelches some unset-variable
warnings you get from GCC4 because its dataflow analysis runs across
function boundaries.

svn path=/trunk/; revision=14810
2005-06-28 21:43:24 +00:00
Guy Harris
7556ea3783 Declare "decrypt_krb5_data()" for use by the KINK dissector.
svn path=/trunk/; revision=14809
2005-06-28 21:25:56 +00:00
Anders Broman
359ada1199 Fix to SendAuthenticationInfoRes
svn path=/trunk/; revision=14808
2005-06-28 21:14:59 +00:00
Anders Broman
e824655d63 Fix to SendAuthenticationInfoRes.
svn path=/trunk/; revision=14807
2005-06-28 21:14:09 +00:00
Anders Broman
8f962c973f Regenerated Tango with the latest idl2eth and the tango.idl
svn path=/trunk/; revision=14806
2005-06-28 19:14:14 +00:00
Anders Broman
b954db9be8 Add the Tango IDL file from Paolo Frigo.
svn path=/trunk/; revision=14805
2005-06-28 19:13:11 +00:00
Gerald Combs
7f2a239179 Add missing commas.
svn path=/trunk/; revision=14804
2005-06-28 14:46:47 +00:00
Gerald Combs
4c6c39effd Terminate a bunch of value_strings.
svn path=/trunk/; revision=14803
2005-06-28 14:02:21 +00:00
Ronnie Sahlberg
12c3955d1f addition of NBS9
and bugfix for FTAM where we sometimes forgot to check if the tag was implicit.


svn path=/trunk/; revision=14802
2005-06-28 11:23:56 +00:00
Ronnie Sahlberg
52b8c407c7 regenerate FTAM with the bugfix for GraphicString in asn2eth
svn path=/trunk/; revision=14801
2005-06-27 20:45:02 +00:00
Tomas Kukosa
f9d6448624 fix for BER string tags
svn path=/trunk/; revision=14800
2005-06-27 13:45:47 +00:00
Ronnie Sahlberg
05f9375d55 fix two bugs when updating offset incorrectly that could lead to an infinite loop when trying to decode an unknown ber structure
svn path=/trunk/; revision=14799
2005-06-27 11:43:18 +00:00
Ronnie Sahlberg
6838ce2807 remove a \n in the preference string to prevent it from creating a garbage/invalid preference file entry.
svn path=/trunk/; revision=14798
2005-06-27 11:06:40 +00:00
Anders Broman
fa7c5d4aac Missed from previous commit.
svn path=/trunk/; revision=14797
2005-06-27 08:55:39 +00:00
Ronnie Sahlberg
77823f61bc some implementations do provide a CRC in the FCIP frame so skip the
'test for zero' check.
the heuristics are probably strong enough even without this check.



svn path=/trunk/; revision=14796
2005-06-27 08:27:49 +00:00
Anders Broman
06067ecc7c Add som more const qualifiers.
svn path=/trunk/; revision=14795
2005-06-27 08:13:41 +00:00
Ronnie Sahlberg
b913b8f3bf From Chris Bontje
DNP3 Application Layer Object dissection


svn path=/trunk/; revision=14794
2005-06-27 08:12:55 +00:00
Guy Harris
81466a539e The name returned by "get_dns_name()" (and thus by
"get_dns_name_type_class()") is null-terminated - and the length
returned is *NOT* the length of the string, it's the length of the chunk
of DNS data extracted by "get_dns_name()", and that chunk could just
point to a later chunk as part of DNS compression.  When running the
name through "format_text()", just use "strlen()" to get the length, so
you don't get a value that's too large *OR* too small (both are
possible - "too large" if it's uncompressed and includes length
informatioin, "too small" if it contains a pointer to a string longer
than the pointer).

When adding a string value to the protocol tree, add the *raw* name, not
the formatted name - the Ethereal display code will format the string's
value as necessary.

Add formatting code for DNS names in replies.

svn path=/trunk/; revision=14793
2005-06-27 07:50:11 +00:00
Ulf Lamping
004f6a0baf I've removed ethereal-capture-normal.* yesterday, as they are obsolete now
svn path=/trunk/; revision=14792
2005-06-27 07:39:48 +00:00
Ulf Lamping
951961ef97 from Jaap Keuter: fix the graphics path of the edg_html_chunked target
svn path=/trunk/; revision=14791
2005-06-27 07:28:25 +00:00
Anders Broman
e37467eb29 From Alejandro Vaquero
new dissector for the AudioCodes trunk trace protocol. 
This protocol is used to debug the trunk protocol in AudioCodes 
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, 
etc...) trunk protocols. It also add these protocols in the "Voip Calls 
Graph..."

svn path=/trunk/; revision=14790
2005-06-27 06:21:51 +00:00
Anders Broman
8d5958785d From Alejandro Vaquero
new dissector for the AudioCodes trunk trace protocol. 
This protocol is used to debug the trunk protocol in AudioCodes 
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, 
etc...) trunk protocols. It also add these protocols in the "Voip Calls 
Graph..."

svn path=/trunk/; revision=14789
2005-06-27 06:20:23 +00:00
Guy Harris
89e823ea4f Yet more constification.
svn path=/trunk/; revision=14788
2005-06-26 21:11:22 +00:00
Guy Harris
b50dd72e2a More constification.
svn path=/trunk/; revision=14787
2005-06-26 20:39:21 +00:00
Guy Harris
ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Guy Harris
2b07720c2f Set the Info column to the correctly-capitalized name.
Use "val_to_str()" to set the Info column, and give the "hyperscsi.cmd"
field a value_string table.

svn path=/trunk/; revision=14785
2005-06-26 19:55:06 +00:00
Ulf Lamping
6c3b559e21 value_string.c(71) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14784
2005-06-26 11:40:26 +00:00
Ulf Lamping
ba1d304f7a prefs.c(1218) : warning C4761: integral size mismatch in argument; conversion supplied
prefs.c(1230) : warning C4761: integral size mismatch in argument; conversion supplied
prefs.c(1240) : warning C4761: integral size mismatch in argument; conversion supplied
prefs.c(1245) : warning C4761: integral size mismatch in argument; conversion supplied

svn path=/trunk/; revision=14783
2005-06-26 11:32:02 +00:00
Ulf Lamping
d5ae7ee8af proto.c(2941) : warning C4090: 'function' : different 'const' qualifiers
proto.c(2941) : warning C4022: 'g_tree_insert' : pointer mismatch for actual parameter 2

svn path=/trunk/; revision=14782
2005-06-26 11:29:04 +00:00
Ulf Lamping
1e0675a01b packet-x11.c(1780) : warning C4090: 'function' : different 'const' qualifiers
packet-x11.c(1780) : warning C4022: 'g_tree_insert' : pointer mismatch for actual parameter 3
packet-x11.c(2209) : warning C4090: 'initializing' : different 'const' qualifiers

svn path=/trunk/; revision=14781
2005-06-26 11:24:26 +00:00
Ulf Lamping
debc4cd849 packet-smb.c(14406) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14780
2005-06-26 11:21:39 +00:00
Ulf Lamping
0265375589 packet-pgsql.c(891) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14779
2005-06-26 11:18:47 +00:00
Ulf Lamping
10ffd2da48 packet-diameter.c(856) : warning C4090: 'function' : different 'const' qualifiers
packet-diameter.c(856) : warning C4024: 'addVendor' : different types for formal and actual parameter 2
packet-diameter.c(857) : warning C4090: 'function' : different 'const' qualifiers
packet-diameter.c(857) : warning C4024: 'addVendor' : different types for formal and actual parameter 3
packet-diameter.c(863) : warning C4090: 'function' : different 'const' qualifiers
packet-diameter.c(863) : warning C4024: 'addCommand' : different types for formal and actual parameter 2

svn path=/trunk/; revision=14778
2005-06-26 11:10:26 +00:00
Anders Broman
1bad9775dd Add a signal
svn path=/trunk/; revision=14777
2005-06-26 11:03:39 +00:00
Ulf Lamping
c14334db25 packet-dcerpc-samr.c(2795) : warning C4090: '=' : different 'const' qualifiers
packet-dcerpc-samr.c(2900) : warning C4090: '=' : different 'const' qualifiers
packet-dcerpc-samr.c(2933) : warning C4090: '=' : different 'const' qualifiers

svn path=/trunk/; revision=14776
2005-06-26 11:02:13 +00:00
Anders Broman
234594dfc0 Add a signal
svn path=/trunk/; revision=14775
2005-06-26 11:01:04 +00:00
Anders Broman
7e2903bdc8 Fix a compiler warning.
svn path=/trunk/; revision=14774
2005-06-26 11:00:19 +00:00
Anders Broman
cc862131a2 Fix a compiler warning and set eol-style.
svn path=/trunk/; revision=14773
2005-06-26 10:59:15 +00:00
Ulf Lamping
a96c3b0f73 packet-ansi_map.c(760) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14772
2005-06-26 10:58:32 +00:00
Ulf Lamping
ac5e6ff1c6 packet-ansi_a.c(460) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14771
2005-06-26 10:55:34 +00:00
Ulf Lamping
d2081016d5 packet-ansi_801.c(93) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14770
2005-06-26 10:51:56 +00:00
Ulf Lamping
7589aef14f packet-ansi_683.c(93) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14769
2005-06-26 10:48:27 +00:00
Ulf Lamping
c660aa2e54 packet-ansi_637.c(288) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14768
2005-06-26 10:45:25 +00:00
Ulf Lamping
5b9f563924 packet-alcap.c(195) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14767
2005-06-26 10:41:38 +00:00
Ulf Lamping
630881b469 proto_hier_stats_dlg.c(99) : warning C4090: '=' : different 'const' qualifiers
svn path=/trunk/; revision=14766
2005-06-26 10:28:51 +00:00
Ulf Lamping
da12395ac6 sctp_graph_dlg.c(383) : warning C4244: '=' : conversion from 'unsigned int ' to 'float ', possible loss of data
svn path=/trunk/; revision=14765
2005-06-26 10:26:47 +00:00
Ulf Lamping
1c897f0559 remove compiler warnings:
main.c(345) : warning C4090: 'function' : different 'const' qualifiers
main.c(345) : warning C4022: 'simple_dialog_set_cb' : pointer mismatch for actual parameter 3

svn path=/trunk/; revision=14764
2005-06-26 10:23:39 +00:00
Ulf Lamping
f7ceac2ff7 we don't have the capture normal mode any longer
svn path=/trunk/; revision=14763
2005-06-26 09:24:38 +00:00
Ulf Lamping
8549096f37 update text to reflect the current implementation (e.g. we don't have normal/sync mode any longer)
svn path=/trunk/; revision=14762
2005-06-26 09:14:12 +00:00