Commit Graph

16278 Commits

Author SHA1 Message Date
Richard Sharpe 3e92ea7c1f Change the way we handle realloc so that we now compute all the space required
up front and realloc once ...

This will probably be the last changes I make on this dissector, as I want to
concentrate on using asn2eth for LDAP, as time permits.


svn path=/trunk/; revision=16619
2005-11-28 17:32:30 +00:00
Guy Harris 4e4c2942e7 Add support for building dumpcap, and fix dumpcap to build on UN*X.
svn path=/trunk/; revision=16618
2005-11-28 11:40:28 +00:00
Guy Harris bee3824471 Update the offset correctly regardless of whether we're building a
protocol tree or not.

svn path=/trunk/; revision=16617
2005-11-28 10:28:31 +00:00
Guy Harris b7853e1285 Give the RFC number for CHAP.
Don't fetch CHAP fields until we need them, so that we can at least
partially dissect a short frame.

Even if the CHAP length is wrong, put it into the protocol tree using
the registered field.

Use "tvb_format_text()" to put text into the Info column, so we handle
non-printable characters by escaping them.

svn path=/trunk/; revision=16616
2005-11-28 10:26:21 +00:00
Ulf Lamping fc61a1de25 first steps towards a separated capture tool, working title "dumpcap"
personal backup only, not meant for public testing!

I've copied main.c into dumpcap.c and carved out all things not needed

currently won't work as a command line tool, capture_loop.c wants an input pipe
console output is also very ugly and the whole code needs a lot of further cleanup

shouldn't break the unix build as I've only changed the nmake files so far, but who knows ...

svn path=/trunk/; revision=16615
2005-11-28 08:54:52 +00:00
Richard Sharpe 1a77239007 Make sure that we reset the filter pointer after we realloc the filter.
This should be simplified ... calc all the space required once and then realloc once etc.


svn path=/trunk/; revision=16614
2005-11-28 08:31:11 +00:00
Ronnie Sahlberg 74b05ec567 name some infolevels
svn path=/trunk/; revision=16613
2005-11-28 08:20:12 +00:00
Guy Harris a195a01dab Don't show the tag twice.
svn path=/trunk/; revision=16612
2005-11-28 00:48:17 +00:00
Guy Harris 96c2884641 Host-Uniq is binary, not text.
FT_BYTES items don't have a base - the bytes are always dumped in hex -
so use BASE_NONE with them.

svn path=/trunk/; revision=16611
2005-11-28 00:41:01 +00:00
Guy Harris 2646996a82 Fail if *any* of the fields in the per-packet header of the first record
aren't sane, rather than requiring them *all* to have invalid values.

svn path=/trunk/; revision=16610
2005-11-27 12:10:03 +00:00
Guy Harris cf75dd602a Don't do anything to the filter string until we've successfully parsed
the extensibleMatch.

Make sure the filter string is always null-terminated, as we use
"strlen()" to skip to the end of it.

On the (illegal, but not impossible) chance that we have more than one
matching rule ID, attributeDescription, or matchValue, free any we
already have before fetching a new one.

svn path=/trunk/; revision=16609
2005-11-27 02:42:29 +00:00
Ronnie Sahlberg 91126d392b from Martin M
ppp chap updates


svn path=/trunk/; revision=16608
2005-11-26 22:49:18 +00:00
Ronnie Sahlberg 55beaa37cf add endoffile infolevel
svn path=/trunk/; revision=16607
2005-11-26 21:59:48 +00:00
Ronnie Sahlberg f699f011fc more infolevels
svn path=/trunk/; revision=16606
2005-11-26 21:44:37 +00:00
Ronnie Sahlberg 81c46d4c59 update setinfo response dissection
svn path=/trunk/; revision=16605
2005-11-26 21:09:53 +00:00
Ulf Lamping 11a0eb4867 fix #568: disable event "activate" handler for the range entry field. see the added comment for details
svn path=/trunk/; revision=16604
2005-11-26 11:57:54 +00:00
Jörg Mayer 2edee79378 Porperties: replace executable by eol-style and keywords
svn path=/trunk/; revision=16603
2005-11-26 10:05:14 +00:00
Guy Harris d25e4c8e0f Fix typoes in comments.
Update a comment, and get rid of a commented-out unused variable.

Use "get_ber_identifier()" and "get_ber_length()", rather than
"dissect_ber_identifier()" and "dissect_ber_length()", if we're just
fetching the values, rather than dissecting them.  As we're just
fetching the values, if we get an error, put the identifer and length
into the protocol tree (if we've enabled that) with
"dissect_ber_identifier()" and "dissect_ber_length()".

Properly declare class and tag variables as signed.

svn path=/trunk/; revision=16602
2005-11-26 04:16:40 +00:00
Guy Harris 3784eec708 Get rid of unused global variables.
svn path=/trunk/; revision=16601
2005-11-26 03:09:40 +00:00
Guy Harris b95c767299 Get rid of unused function.
svn path=/trunk/; revision=16600
2005-11-26 03:08:17 +00:00
Guy Harris d2f2043218 Fix RFC number.
Use "tvb_reported_length_remaining()" for all length checks and values,
so we get the *actual* packet length, not the *captured* packet length
(it's a *feature* if it reports a "packet cut short" error if the packet
really *was* cut short by slicing).

Set subtree lengths to -1, so that if an exception is throws while
dissecting them, the length includes all the data.

Get rid of unused variables, and mark unused parameters.

In heuristic checks, give up if we don't have enough data to check.

svn path=/trunk/; revision=16599
2005-11-26 03:06:25 +00:00
Ronnie Sahlberg d107130cd4 many commands return a short 8 byte pdu when errors occur.
make ethereal handle these better instead of showing them as unreassembled packet



svn path=/trunk/; revision=16598
2005-11-26 03:06:21 +00:00
Ulf Lamping b847af543d fix #358: instead of simply using tpmnam() for the Win32 print function, use the "official" function to create a temporary file
Well, we actually only need the filename here, so create a temp file with the "official" create_tempfile function, keep that tempfile name and then delete this file again, leaving only the name.

I know that's a bit uncommon, but should work and uses the same mechanisms as with other temporary files. So if there are still problems with the official function, we only have one place to fix :-)

svn path=/trunk/; revision=16597
2005-11-26 01:56:22 +00:00
Ronnie Sahlberg d149d98fc3 assume the four bytes after the fid in notify request is the completion mask
svn path=/trunk/; revision=16596
2005-11-26 00:34:22 +00:00
Ulf Lamping 6244dc8ec9 fix a simple GTK1 warning
svn path=/trunk/; revision=16595
2005-11-25 23:54:19 +00:00
Ronnie Sahlberg 7773d60b9a add decoding of some more opcodes
svn path=/trunk/; revision=16594
2005-11-25 23:52:47 +00:00
Ulf Lamping 5d66658184 from Greg Morris:
Composite Expert statistics, see: 
http://www.ethereal.com/lists/ethereal-dev/200511/msg00002.html
and the following discussions

svn path=/trunk/; revision=16593
2005-11-25 23:42:52 +00:00
Ulf Lamping 03b4388fe0 rephrase the error dialog if an interface couldn't be opened.
made the CaptureSetup wiki page more prominent
added some "headings" so some of the help subtopics are easier for "human grep" IMHO

svn path=/trunk/; revision=16592
2005-11-25 22:38:02 +00:00
Ulf Lamping 680cab1226 add some more help text to the "no packets captured" error dialog:
link to CaptureSetup wiki page
Win32 only: wireless: "try switch off promicuous mode"

This way we might get less user questions on the users-mailing list ...

Especially the second one hopefully could save us from a lot of support mails :-)

svn path=/trunk/; revision=16591
2005-11-25 22:27:27 +00:00
Ronnie Sahlberg 808f2fc111 add decoding of some more opcodes
svn path=/trunk/; revision=16590
2005-11-25 22:06:56 +00:00
Ronnie Sahlberg 85cfb618f9 from metze and modified, fix for in offset/length for transaction request
svn path=/trunk/; revision=16589
2005-11-25 21:55:34 +00:00
Anders Broman 00728fb587 From Martin Warnes:
Add Support for reading of IBM iSeries (AS/400) Comms traces

svn path=/trunk/; revision=16588
2005-11-25 20:30:42 +00:00
Anders Broman b8d097b28b Update the Camel asn1 spec to 3GPP TS 29.078 version 6.4.0 and export needed stuff from gsmmap
svn path=/trunk/; revision=16587
2005-11-25 20:18:36 +00:00
Ronnie Sahlberg 0f9be028ca add dissection of treedisconnect
svn path=/trunk/; revision=16586
2005-11-25 08:26:02 +00:00
Ronnie Sahlberg 704abdc0e5 add some more infolevels
svn path=/trunk/; revision=16585
2005-11-25 08:02:40 +00:00
Ronnie Sahlberg ebe4645322 fix typo it is one in buffer and one out buffer in transaction request not two out buffers
svn path=/trunk/; revision=16584
2005-11-25 06:45:50 +00:00
Ronnie Sahlberg cdec2dd031 transaction update
svn path=/trunk/; revision=16583
2005-11-25 06:30:47 +00:00
Anders Broman b0e921a5e0 From Martin Mathieson:
Here is a patch to the PPPoED and PPPoES dissectors.
- All fields are now filterable
- General prettification
- I've added a preference to PPoED to set whether or not tag values and data lengths should be shown in the tree (default is OFF)

svn path=/trunk/; revision=16582
2005-11-25 06:23:04 +00:00
Ronnie Sahlberg 261aade300 add dissection of the smb2 impersionationlevel field
svn path=/trunk/; revision=16581
2005-11-25 06:19:41 +00:00
Ronnie Sahlberg c76c376968 some info level updates
svn path=/trunk/; revision=16580
2005-11-25 06:04:11 +00:00
Ronnie Sahlberg cfc56af514 some info level updates
svn path=/trunk/; revision=16579
2005-11-25 05:41:00 +00:00
Ronnie Sahlberg d93bd8606c update the transaction code
svn path=/trunk/; revision=16578
2005-11-25 00:28:02 +00:00
Ronnie Sahlberg 64181a533c dissect some more of SMB2 Transaction command
svn path=/trunk/; revision=16577
2005-11-24 15:24:30 +00:00
Ronnie Sahlberg 22d2f325ea dissect some of opcode 0x0b Transaction
svn path=/trunk/; revision=16576
2005-11-24 14:49:46 +00:00
Anders Broman 9d646e76dc From Greg Morris:
ncp2222.py.diff
Fixed decoding of NCP 89,10 reply packet. Fixes malformed packet.
 
packet-ncp.c.diff
Adds NCP protocol preference options for enabling/disabling the echoing of data to the expert table.
Expert: EID to Name Lookups
Expert: NCP Connections
Expert: NCP Errors
Expert: Server Information
 
packet-ncp2222.inc.diff
Adds decoding of ZEN attribute values
zendmSearchType
zendmSearchOrder
Fixes blank name stored in EID to Name table if tuned name was returned in resolve name reply packet
Adds capability of reading hf values from NCP tree for exporting specific NCP info to expert table
Adds support for new NCP protocol preference options
Adds expert options for EID to Name Lookups, NCP connections, and Server Information
Change nwconnection from 16bit value to 32bit
 
Packet-ncp-int.h.diff
Fix function prototypes to match new 32bit nwconnection
Add global variables to allow for new NCP protocol preference options

svn path=/trunk/; revision=16575
2005-11-24 05:55:18 +00:00
Anders Broman f067906362 Pretify TIPC addr.
svn path=/trunk/; revision=16574
2005-11-23 21:32:07 +00:00
Anders Broman 6612fea2ae From greg Morris:
Fixes proper decoding of extended error 2 values
Also adds a number of additional error codes/values

svn path=/trunk/; revision=16573
2005-11-23 21:27:39 +00:00
Anders Broman 81fb46aacd From Greg Morris:
Fixes proper decoding of extended error 2 values
Also adds a number of additional error codes/values

svn path=/trunk/; revision=16572
2005-11-23 21:25:24 +00:00
Anders Broman fc2400ac41 From Greg Morris:
This update adds info column data for srvloc request/reply to display SLP version and XID information.
Also adds expert data for srvloc error conditions

svn path=/trunk/; revision=16571
2005-11-23 21:17:58 +00:00
Tomas Kukosa eca9dac0ae fixed typo
svn path=/trunk/; revision=16570
2005-11-23 09:41:43 +00:00