Commit Graph

9754 Commits

Author SHA1 Message Date
Ulf Lamping 34bddb3c1a adding a function to the help dialog, showing a specific topic (context help),
beautifying the placement of the help button in the button_row,
using the context help for the filter dialog

svn path=/trunk/; revision=9851
2004-01-25 21:27:16 +00:00
Gerald Combs d69016e552 Delete generated files during distclean instead of maintainerclean, so
that we pass distcheck.

svn path=/trunk/; revision=9850
2004-01-25 18:52:33 +00:00
Ulf Lamping c890e29a99 apply automatically generated filters strings to the recent dropdown list,
e.g. when applying a "Follow TCP stream",
fix a bug in the recent function, discarding the newest entries when
saving a full list (now discarding the oldest).

svn path=/trunk/; revision=9849
2004-01-25 18:51:26 +00:00
Ulf Lamping b023bf8c7d fix some filter dialog things
svn path=/trunk/; revision=9848
2004-01-25 18:39:55 +00:00
Gerald Combs a8348ec990 Make the definition of tvb_format_text() match what's in tvbuff.h.
svn path=/trunk/; revision=9847
2004-01-25 17:53:55 +00:00
Gerald Combs 09bf45ab36 Capitalize "Ethereal.icns" to fix a distclean error. Add its description
to README.image.

svn path=/trunk/; revision=9846
2004-01-25 17:51:54 +00:00
Jörg Mayer 4189858920 Fix 'warning: cast discards qualifiers from pointer target type' by removing cast
svn path=/trunk/; revision=9845
2004-01-25 17:33:20 +00:00
Jörg Mayer 111f977cfa Remove the cast again and do the proper fix (add right type to union)
svn path=/trunk/; revision=9844
2004-01-25 17:22:57 +00:00
Jörg Mayer 21c1c34c02 Add a cast to avoid a signedness warning
svn path=/trunk/; revision=9843
2004-01-25 17:07:57 +00:00
Jörg Mayer c61e9f6ed0 Change the first arg to hex_str_to_bytes from guchar* -> char*
svn path=/trunk/; revision=9842
2004-01-25 16:58:25 +00:00
Jörg Mayer 153f554b01 A few signedness warning fixes
svn path=/trunk/; revision=9841
2004-01-25 15:56:04 +00:00
Jörg Mayer a2634a1ed3 The octets in an ip address are unsigned
svn path=/trunk/; revision=9840
2004-01-25 15:35:45 +00:00
Ulf Lamping 24eb4363ef add syntax check and an "Add Expression" button to the filter toolbar
svn path=/trunk/; revision=9839
2004-01-25 15:10:36 +00:00
Ulf Lamping f7dbf0f940 added/changed some tooltips
svn path=/trunk/; revision=9838
2004-01-25 13:47:09 +00:00
Ulf Lamping ad7bc1e358 changed the behaviour of the edit buttons to make more sense,
removed the no longer needed "Edit and "Copy" buttons,
do a lot of code cleanup

svn path=/trunk/; revision=9837
2004-01-25 12:25:57 +00:00
Ulf Lamping 74d16224c4 make resized prefs_dlg look better
svn path=/trunk/; revision=9836
2004-01-25 12:22:20 +00:00
Ulf Lamping 7f0f64c272 minor GTK2 layout change
svn path=/trunk/; revision=9835
2004-01-25 12:10:27 +00:00
Jörg Mayer 61581fb780 Fix a warning by using a function typedef
svn path=/trunk/; revision=9834
2004-01-25 09:49:50 +00:00
Guy Harris a0528c5f82 Report open errors when saving the contents of an RTP stream. Check for
and report write errors as well.

svn path=/trunk/; revision=9833
2004-01-25 02:24:44 +00:00
Guy Harris 557d5430af Check for write errors when writing CSV data as well.
Check for write errors when opening the CSV file to write the reverse
data information.

For some reason (perhaps having to do with the sort indicators in
titles, the column titles don't show up in the GtkCList structure, so
they don't get printed; just directly use the table of column titles.

svn path=/trunk/; revision=9832
2004-01-25 02:14:05 +00:00
Guy Harris 10552e3169 Check whether the "fopen()" that creates a CSV file fails and, if so,
report the error and don't dismiss the file selection dialog box.

svn path=/trunk/; revision=9831
2004-01-25 01:58:58 +00:00
Guy Harris a2c53bff75 Don't have "follow_print_text()" display the error message, leave that
up to its caller.

Show errors as such, not as warnings, and show the right error message
for failures to open/create output files.

svn path=/trunk/; revision=9830
2004-01-25 01:53:24 +00:00
Guy Harris 6efa00c5f4 Add another check for output errors when printing.
svn path=/trunk/; revision=9829
2004-01-25 01:19:48 +00:00
Guy Harris 7502ac216a There's no need to keep a "FILE *" for the file being printed to in a
"capture_file" structure.  Keep it locally, instead.

Check for errors when printing packets.

Report failure to open a print destination and failure to write to a
print destination differently.

Don't have the "print preamble" and "print final" routines return
success/failure indications - revert to the old scheme where they
didn't, and have the callers use "ferror()" to check for errors.

Report write errors when printing dissections in Tethereal.

Report print errors as errors, not warnings.

svn path=/trunk/; revision=9828
2004-01-25 00:58:13 +00:00
Ulf Lamping 064d5e5e07 Added the ability to compile both GTK versions 1 and 2 at the same time.
svn path=/trunk/; revision=9827
2004-01-24 20:01:36 +00:00
Jörg Mayer 6e59f95ceb Fix all fixable warnings
Move addional warnings from extra-gcc-checks to normal compilation flags

svn path=/trunk/; revision=9826
2004-01-24 16:48:12 +00:00
Guy Harris 65f18bb833 As with "file_write_error_message()", so with
"file_close_error_message()" - but just use "file_write_error_message()"
for UNIX-style errors, under the assumption that a close will only fail
because a buffer-flushing write fails or because "close()" itself fails
when, for example, pushing unsynced NFS client-side writes out over the
wire.

Make several routines in "print.c" return success/failure indications.

Check for write errors when printing "Follow TCP Stream" stuff or saving
it to a file.

svn path=/trunk/; revision=9825
2004-01-24 10:53:25 +00:00
Jörg Mayer 7180513677 Trivial signed/unsigned warning fixes
svn path=/trunk/; revision=9824
2004-01-24 02:07:05 +00:00
Guy Harris d8d91ff347 As with "cf_open_error_message()"/"file_open_error_message()", so with
"cf_write_error_message()"/"file_write_error_message()".

Use "file_open_error_message()" instead of "cf_open_error_message()" in
some places we missed in the previous checkin.

Catch ENOSPC and EDQUOT in "file_open_error_message()".

Use "file_open_error_message()" rather than "file_write_error_message()"
to report errors when creating the file to which we're saving the
"Follow TCP Stream" data.

svn path=/trunk/; revision=9823
2004-01-24 02:01:44 +00:00
Jörg Mayer 4377e456d4 Trivial warning fixes
svn path=/trunk/; revision=9822
2004-01-24 01:53:59 +00:00
Guy Harris 46848f0a9e Add a new "file_open_error_message()" routine in "epan/filesystem.c", to
translate UNIX errno values to a somewhat friendly message format
string.

Rename "file_open_error_message()" in "file.c" to
"cf_open_error_message()", make "cf_open_error_message()" use the new
"file_open_error_message()" for UNIX errno values, have "do_capture()"
in "capture.c" use "file_open_error_message()" to report errors from
"open()", and make "cf_open_error_message()" static as nothing outside
"file.c" uses it.

Do similar stuff in "tethereal.c".

svn path=/trunk/; revision=9821
2004-01-24 01:44:29 +00:00
Jörg Mayer 49093048ac Remove extra , at end of enum, change C++ style comment
svn path=/trunk/; revision=9820
2004-01-24 01:30:20 +00:00
Guy Harris 88535b9a99 From Lars Ruoff (who also contributed the previous change; my apologies
to both Larses):

	- Comfort noise (CN) packets and packets following them
	  immediately are excluded from maximum delay calculation (as
	  well as marked packets are)
	- Payload changes between CN and regular packets are ignored.
	- Added a "Marker missing?" status warning for packets following
	  CN that don't have the marker bit set (cf. RFC1890 4.1)
	- Changed status "Ok" to "[ Ok ]", so that when sorting by status
	  column, all non-Oks are grouped together.
	- Minor GUI updates: reduced size of box, borders, spacing,
	  changed highlight colors.

svn path=/trunk/; revision=9819
2004-01-24 01:15:24 +00:00
Guy Harris 89c529db8e Have "font_apply()" return an indication as to whether it succeeded or
failed and, if it failed, how it failed.  Have it leave up to its caller
the job of reporting that it couldn't load the requested font; have its
callers do that, and have them set the zoom level on failure so that we
have a zoom level that is at least more likely to work.  Make the alert
boxes for "font_apply()" failures be error boxes, not warning boxes.

svn path=/trunk/; revision=9818
2004-01-24 01:02:54 +00:00
Guy Harris 89edd94cb3 Do the font loading code as two larger sections of code, one for GTK+
1.2[.x] and one for GTK+ 2.x, rather than as one section peppered with
#ifdefs.

svn path=/trunk/; revision=9817
2004-01-23 21:22:18 +00:00
Guy Harris b64241c4a6 Include the AddStyleName information in the zoomed font name.
svn path=/trunk/; revision=9816
2004-01-23 20:34:11 +00:00
Guy Harris 52faded8d8 If we call "font_apply()", we don't need to call
"redraw_hex_dump_all()".

svn path=/trunk/; revision=9815
2004-01-23 20:13:23 +00:00
Guy Harris 32e5a4bdbc If the zoom factor is zero, don't construct a new font name - the
supplied font name is correct.  That lets us handle fonts whose size we
can't change because this is GTK+ 1.2[.x] and the name isn't an XLFD
name so we don't know where the size is.

In "font_zoom()", remove some code from the GTK+ 1.2[.x] vs. GTK+ 2.x
#ifdefs.

Fix the comment for "font_zoom()".

Get rid of a no-longer-used "simple_dialog()" argument.

svn path=/trunk/; revision=9814
2004-01-23 20:11:59 +00:00
Guy Harris d10d0f20f2 Clean up indentation.
Make "font_zoom()" static - it's not used outside gtk/main.c.

Use "g_strdup()" rather than "strdup()", as we use "g_free()" to free
the result.

Put in a little more information when "font_zoom()" fails due to the
font name not being an XLFD font name, and don't continue if it fails.

Don't continue if the attempt to load the fonts fails, either.

svn path=/trunk/; revision=9813
2004-01-23 19:53:10 +00:00
Guy Harris 9ee952fb77 From Akira Endoh: support for labeled IPv6 unicast in the MP-BGP
dissector.

svn path=/trunk/; revision=9812
2004-01-23 19:19:44 +00:00
Guy Harris d706864ceb From David Fort: NSEC RRs aren't the same as NXT RRs - dissect them
differently.

Remove a redundant "break" statement.

svn path=/trunk/; revision=9811
2004-01-23 19:16:52 +00:00
Ulf Lamping 2a44f5e6ac removed line breaks to be able to compile again
svn path=/trunk/; revision=9810
2004-01-23 18:18:19 +00:00
Ulf Lamping 4adcdaf4e9 fixed various things in "View" menu
svn path=/trunk/; revision=9809
2004-01-23 16:10:09 +00:00
Ulf Lamping b9cf9aeb0b added a comment
svn path=/trunk/; revision=9808
2004-01-23 16:08:38 +00:00
Ulf Lamping 6551f25ee9 fix assert, when failed loading zoomed font,
prepare possibility to put filter toolbar just below the main toolbar

svn path=/trunk/; revision=9807
2004-01-23 16:07:37 +00:00
Guy Harris b06f65e9da "sprint_realloc_value()" takes a "u_char **" as an argument - pass it
one.

svn path=/trunk/; revision=9806
2004-01-23 10:25:08 +00:00
Guy Harris f7bfd7b2e5 From Yuriy Sidelnikov: call ACSE dissector for any presentation context.
svn path=/trunk/; revision=9805
2004-01-23 10:15:37 +00:00
Guy Harris e48383e941 From Yuriy Sidelnikov: call ACSE dissector for any presentation context.
svn path=/trunk/; revision=9804
2004-01-23 09:53:18 +00:00
Guy Harris 506a842a42 "%.*" requires an "int" argument for the length.
svn path=/trunk/; revision=9803
2004-01-23 09:50:47 +00:00
Jörg Mayer 3a60501750 Change msg from guint8* to gchar* (because of tvb_format_text change)
svn path=/trunk/; revision=9802
2004-01-23 09:47:39 +00:00