osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
45832 commits 26 branches 0 tags 795 MiB
Commit graph

45832 commits

This branch
This branch
All branches
Author SHA1 Message Date
Martin Kaiser
3467c98afc coverity 280417: logically dead code 
svn path=/trunk/; revision=48657
 2013-03-30 18:57:44 +00:00
Jaap Keuter
4e09bed012 From Tyson Key: 
The attached patch adds support for dissection of SAMConfiguration request packets, 
and updates the opcode table to identify their corresponding (null/empty) responses.

svn path=/trunk/; revision=48656
 2013-03-30 17:09:26 +00:00
Evan Huus
02dff20783 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509 
Round 2 of Bluetooth SDP updates:
- replace a lot of proto_tree_add_text with named fields
- dissect more of the protocol
- misc fixes

svn path=/trunk/; revision=48655
 2013-03-30 15:53:04 +00:00
Evan Huus
2fba8c0f9d Update -2, -R and -Y to behave consistently as per the concensus reached on 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8223

Mention the new -Y flag and associated changes in the release notes.

svn path=/trunk/; revision=48654
 2013-03-30 15:38:03 +00:00
Evan Huus
6fa584b0db Move wireshark's display filter flag to -Y for consistency with tshark. 
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8223

svn path=/trunk/; revision=48653
 2013-03-30 12:15:42 +00:00
Jaap Keuter
037bb3e614 Have 'Capture file' and 'Stop after' extries left aligned in GTK+ 3 as well. 
svn path=/trunk/; revision=48652
 2013-03-30 11:57:33 +00:00
Martin Kaiser
9ca8ee6c06 dissect CI+ Protection Descriptor 
svn path=/trunk/; revision=48651
 2013-03-30 10:59:30 +00:00
Martin Kaiser
b3bad40c60 use proto_mpeg_descriptor_loop_dissect() in the SDT descriptor loop 
this takes private descriptors into account

svn path=/trunk/; revision=48650
 2013-03-30 10:41:37 +00:00
Martin Kaiser
2528164448 list the new file format in the release notes 
svn path=/trunk/; revision=48649
 2013-03-30 10:30:22 +00:00
Martin Kaiser
62075c88fb list the new file format on the manpage 
svn path=/trunk/; revision=48648
 2013-03-30 10:21:19 +00:00
Martin Kaiser
7a2bdedff6 wiretap support for the CAM Inspector file format 
svn path=/trunk/; revision=48647
 2013-03-30 09:56:57 +00:00
Evan Huus
178fc8852a Note to self: stop using 'index' as a variable name, it triggers -Wshadow on 
some platforms. You'd think I'd have learned by now.

svn path=/trunk/; revision=48646
 2013-03-30 00:11:00 +00:00
Evan Huus
d155b0da19 Implement str_to_val, opposite of val_to_str for value_strings. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48645
 2013-03-29 23:23:28 +00:00
Evan Huus
e964ab4164 Bump two guint16 to guint32 to prevent overflow when reassembling a large 
number of fragments, and add an extra bounds check.

Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8540
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8541

svn path=/trunk/; revision=48644
 2013-03-29 22:20:04 +00:00
Gerald Combs
1606bec857 Add items for Bluetooth and GTK3. 
svn path=/trunk/; revision=48643
 2013-03-29 18:16:45 +00:00
Gerald Combs
6488d8cc53 Convert png → xpm using a higher alpha threshold. 
svn path=/trunk/; revision=48642
 2013-03-29 18:12:29 +00:00
Evan Huus
016f8e8d8c Add some missing #includes to hopefully fix check-abi buildbot. 
svn path=/trunk/; revision=48641
 2013-03-29 17:43:14 +00:00
Evan Huus
ea6d7d8a34 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509 
First round of fixes for Bluetooth SDP.

From me:
- rename one call of match_strval to try_val_to_str instead
- remove a few hf entries that really belong with the second patch (they
  weren't used in this one)

svn path=/trunk/; revision=48640
 2013-03-29 17:25:23 +00:00
Gerald Combs
ce7c8bc9d7 Resurrect wsicon32.xpm using 'svn cp' then update it based on 
wsicon32.png. This should hopefully preserve its history in SVN. Revert
r48565 in debian/.

svn path=/trunk/; revision=48639
 2013-03-29 15:44:14 +00:00
Pascal Quantin
5c46fcea6a From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8506 : 
Fix incompatible display filters using the same name

svn path=/trunk/; revision=48638
 2013-03-29 13:22:53 +00:00
Michael Tüxen
7b7680f3ff Add support for new version of the ID which has been adopted as a WG item. 
The now version will be supported by Firefox soon.

svn path=/trunk/; revision=48637
 2013-03-29 13:01:52 +00:00
Evan Huus
03b48f94c2 Fix two instances of col_set_str being used with ephemeral memory returned 
from val_to_str. Use col_add_str instead.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8537

svn path=/trunk/; revision=48636
 2013-03-29 02:46:06 +00:00
Evan Huus
a0d107beec Remove decode_enumerated_bitfield and decode_enumerated_bitfield_shifted. 
Effectively inline the only remain call (and replace a static buffer with ep
memory). Much of the NFS dissector needs to be converted to use named fields
at which point this code can go away, but that's a much bigger job.

Also, add modelines to packet-nfs.c and mark some internal value_string
functions as WS_DLL_LOCAL.

svn path=/trunk/; revision=48635
 2013-03-29 02:34:23 +00:00
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This 
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
 2013-03-29 00:26:23 +00:00
Evan Huus
6f19d87f4e Greatly clean up value_string.c 
- use consistent indentation and coding style
 - add modelines
 - replace some g_assert calls with DISSECTOR_ASSERT where it makes sense
 - group related functions together and simplify many comments by referring to
   the 'normal' value_string as the canonical version

svn path=/trunk/; revision=48633
 2013-03-28 22:02:04 +00:00
Chris Maynard
2787c28d71 The tshark -R option specifies a read filter, not a display filter. 
svn path=/trunk/; revision=48632
 2013-03-28 21:46:37 +00:00
Gerald Combs
1da35f4a3c Remove a couple of unneeded lines and fix default execution. 
svn path=/trunk/; revision=48631
 2013-03-28 21:22:08 +00:00
Evan Huus
d3fe183eba Include glib.h in emem.h, it needs the definitions 
svn path=/trunk/; revision=48630
 2013-03-28 21:19:58 +00:00
Chris Maynard
07b35a96b7 Add some missing tvb_get_'s, proto_tree_add_'s, fix args and change all little_endian's to encoding. Some detailed descriptions are still missing though. 
svn path=/trunk/; revision=48629
 2013-03-28 20:22:47 +00:00
Chris Maynard
10260116f8 Fix incorrectly duplicated display filter for hf_openwire_throwable_linenumber. 
#BACKPORT(1.8)

svn path=/trunk/; revision=48628
 2013-03-28 18:16:52 +00:00
Gerald Combs
b60e41b984 1.9.2 → 1.9.3. 
svn path=/trunk/; revision=48627
 2013-03-28 18:13:22 +00:00
Chris Maynard
5e7d4af0d0 The uniqueness bit occurs in 2 different places, so go ahead and use both hf_nhrp_flag_U1 and hf_nhrp_flag_U2, but change the common display filter from "nhrp.flag.u1" to simply "nhrp.flag.u". 
#BACKPORT(1.6, 1.8)???

svn path=/trunk/; revision=48626
 2013-03-28 18:13:12 +00:00
Gerald Combs
ffbcd0705e Build 1.9.2. 
svn path=/trunk/; revision=48625
 2013-03-28 17:48:31 +00:00
Jeff Morriss
67172cd3d6 Add a little shell script to install all the RPMs necesary to do Wireshark 
development.  Both the development and runtime packages are installed
although the latter aren't strictly necessary.

Ideally this could automatically pull the packages out of
packaging/rpm/SPECS/wireshark.spec.in but given the variance in package names
between distributions, this seems painful...

Tested on Fedora/Redhat and openSUSE.

svn path=/trunk/; revision=48624
 2013-03-28 16:59:21 +00:00
Anders Broman
8e1b0ac304 Register a dissector table for Normal Vendor/Organization Specific Extension(NVSE) and use it for 3GPP2. 
svn path=/trunk/; revision=48623
 2013-03-28 16:55:06 +00:00
Chris Maynard
fc78e677a8 Fix Coverity CID's 280305-280306: Negative loop bound. (These are yet more annoying instances of not properly dealing with tvb_reported_length_remaining() possibly returning -1.) 
#BACKPORT(1.6,1.8)

svn path=/trunk/; revision=48622
 2013-03-28 16:02:41 +00:00
Chris Maynard
be892e31c0 Fix the remaining instances of Coverity CID's 741992 and 986498, which should have been committed with r47073 and r47830, respectively. (I find Coverity doesn't always make it so obvious that there's more than 1 instance for a given CID.) 
svn path=/trunk/; revision=48621
 2013-03-28 15:41:25 +00:00
Chris Maynard
bbf2beaa53 Fix Coverity CID's 281433 and 281434: Unintended sign extension. (18 instances) 
Fix Coverity CID 702381: Missing break in switch.

Add an "XXX" note regarding the framing_rtp assignment, since something appears to be missing.

#BACKPORT(1.8)

svn path=/trunk/; revision=48620
 2013-03-28 15:28:12 +00:00
Chris Maynard
64f0e71d07 first_flag should be static. 
#BACKPORT(1.6,1.8)

svn path=/trunk/; revision=48619
 2013-03-28 15:07:32 +00:00
Evan Huus
045152353c From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8536 
Fix unrecognised CID session payload in bluetooth if there are multiple sessions
with the same DCID.

svn path=/trunk/; revision=48618
 2013-03-28 15:05:46 +00:00
Evan Huus
63987d2894 From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8506 
Proper authorship and attribution information for
VITA 49 Radio Transport dissector.

svn path=/trunk/; revision=48617
 2013-03-28 15:01:35 +00:00
Chris Maynard
476831d9de Fix the incorrectly duplicated display filter for hf_kdsp_source_name. 
#BACKPORT(1.8)

svn path=/trunk/; revision=48616
 2013-03-28 14:56:58 +00:00
Evan Huus
20e049795f If wireshark is started with a file and a display filter, apply the display 
filter *after* initially reading the file so that we get the expected multi-
pass behaviour and forward-looking filters (like response_in) work properly.

svn path=/trunk/; revision=48615
 2013-03-28 14:54:33 +00:00
Chris Maynard
c9004d102e Fix the incorrectly duplicated display filter for hf_gearman_data_content. 
svn path=/trunk/; revision=48614
 2013-03-28 14:49:41 +00:00
Chris Maynard
9c6325a069 Properly dissect lat and long according to 3GPP TS 23.032. Fix incorrect display filters for hf_gsm_a_geo_loc_deg_of_lat and hf_gsm_a_geo_loc_deg_of_long. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8532
#BACKPORT(1.6,1.8)

svn path=/trunk/; revision=48613
 2013-03-28 14:23:07 +00:00
Jeff Morriss
a995cb8220 Simplify the check for rpmbuild's version. 
svn path=/trunk/; revision=48612
 2013-03-28 14:17:38 +00:00
Pascal Quantin
750b7659bb Add dissection of Terminal Profile byte 32 
svn path=/trunk/; revision=48611
 2013-03-28 14:04:23 +00:00
Jeff Morriss
4cd9d8a2d8 Fix distcheck: put wssplash.h in noinst_HEADERS. 
svn path=/trunk/; revision=48610
 2013-03-28 13:19:16 +00:00
Anders Broman
dafdc19d9e -Wmissing-prototypes 
svn path=/trunk/; revision=48609
 2013-03-28 07:34:13 +00:00
Jaap Keuter
182876540a Make that wssplash *underscore* dev dot png 
svn path=/trunk/; revision=48608
 2013-03-28 07:12:24 +00:00