osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
47127 commits 26 branches 0 tags 795 MiB
Commit graph

17357 commits

Author SHA1 Message Date
Michael Mann
dfa2156e30 Remove check_col() and the occasional tree. 
svn path=/trunk/; revision=49923
 2013-06-14 02:50:46 +00:00
Jeff Morriss
e9a5b16a09 From Katrina Zhang via Anders (manually applied by me): dissect node features. 
From me: remove some tabs and trailing white space.

svn path=/trunk/; revision=49922
 2013-06-14 02:44:15 +00:00
Michael Mann
fa5b45834b Remove check_col() and the occasional tree. 
svn path=/trunk/; revision=49921
 2013-06-14 01:56:28 +00:00
Michael Mann
0f0c111119 Remove check_col() and the occasional tree. 
svn path=/trunk/; revision=49920
 2013-06-14 01:02:11 +00:00
Pascal Quantin
285bc53826 Fix typo error 
svn path=/trunk/; revision=49918
 2013-06-13 14:20:20 +00:00
Pascal Quantin
53c658bb19 Add basic dissection of Prefix Exclude option 
svn path=/trunk/; revision=49917
 2013-06-13 14:18:10 +00:00
Jeff Morriss
5fa16b2008 From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8794 : 
Display the value of unknown sense descriptor codes in the tree item.
Also fix the length of the subtree.

svn path=/trunk/; revision=49916
 2013-06-13 13:51:19 +00:00
Pascal Quantin
32bec58892 From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8791 : 
Improve dissection of GSM SIM payloads in USB CCID packets

svn path=/trunk/; revision=49915
 2013-06-13 10:52:34 +00:00
Michael Mann
e1b7a26463 Adding support of BGP flow spec RFC 5575. 
From Matt Texier, bug 8691 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8691)

svn path=/trunk/; revision=49914
 2013-06-13 02:35:23 +00:00
Michael Mann
53290ee17c Updated the rsync dissector to make it able to parse the newer variants of the protocol, treat binary data consistently and clearly differentiate packets of the client and the server. 
From Benoit Daloze, bug 8743 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8743)

svn path=/trunk/; revision=49913
 2013-06-13 01:06:31 +00:00
Guy Harris
3dbf3b975a Give somewhat more precise names for character encodings ("Unicode" 
doesn't specify a single way to encode characters in an octet stream -
there's UTF-8 and UTF-16BE/LE, as well as UCS-2BE/LE for a subset of
Unicode, and "Latin" really means "ISO 8859-1" a/k/a "ISO Latin 1".

svn path=/trunk/; revision=49912
 2013-06-12 18:17:15 +00:00
Pascal Quantin
41647faaba Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3289 : 
dissector ansi_637 does not have unicode encoding in user data parameter

svn path=/trunk/; revision=49911
 2013-06-12 17:25:04 +00:00
Pascal Quantin
0975d03e8d Fix dissection of 3GPP2 SMS messages when the User Data Header field is present (for fragmented SMS) 
svn path=/trunk/; revision=49910
 2013-06-12 16:59:59 +00:00
Martin Kaiser
7e9d283c15 no need for check_col() 
svn path=/trunk/; revision=49906
 2013-06-12 15:15:26 +00:00
Anders Broman
82e220f2bd Pretify dissection of date and Time. 
svn path=/trunk/; revision=49905
 2013-06-12 15:08:08 +00:00
Martin Kaiser
6de25d3897 simplify the subdissector call 
svn path=/trunk/; revision=49904
 2013-06-12 14:56:37 +00:00
Martin Kaiser
7a82d35280 TABs -> spaces 
add modelines

svn path=/trunk/; revision=49903
 2013-06-12 14:55:37 +00:00
Martin Kaiser
80046abfcb no expert infos under if(tree) 
simplify the code a bit

svn path=/trunk/; revision=49902
 2013-06-12 14:54:13 +00:00
Martin Kaiser
346117c265 From Javier Godoy 
dissect SCSI OSD error identification sense data descriptor 

from me
- TABs -> spaces
- fix compiler errors about unused return values
- don't use another subtree within the descriptor payload

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8790

svn path=/trunk/; revision=49901
 2013-06-12 14:20:36 +00:00
Martin Kaiser
e94463b0df fix compiler warning 
(gcc version 4.4.5 (Debian 4.4.5-8))

cc1: warnings being treated as errors
packet-bthfp.c: In function ‘dissect_at_command’:
packet-bthfp.c:875: error: ‘col_str’ may be used uninitialized in this function

svn path=/trunk/; revision=49900
 2013-06-12 12:20:50 +00:00
Tomas Kukosa
822c02b5d0 Fix wrong offset in H.235 tokens causing malformed packet exception 
svn path=/trunk/; revision=49899
 2013-06-12 09:03:21 +00:00
Martin Kaiser
2e8347a964 no need for check_col() 
svn path=/trunk/; revision=49898
 2013-06-12 08:24:54 +00:00
Martin Kaiser
4131f8fa31 TABs -> spaces 
add modelines

svn path=/trunk/; revision=49897
 2013-06-12 08:15:46 +00:00
Martin Kaiser
a8c1a87662 CID 280301: add a NULL check before dereferencing the pointer 
svn path=/trunk/; revision=49896
 2013-06-12 07:59:27 +00:00
Anders Broman
ddd78fbd78 From Javier Godoy: 
dissect SCSI field pointer sense key specific information

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8789

svn path=/trunk/; revision=49895
 2013-06-12 05:15:45 +00:00
Anders Broman
03a322661f Fix a crash when oid_info->value_typem is NULL 
svn path=/trunk/; revision=49894
 2013-06-12 04:21:40 +00:00
Michael Mann
93be0fb393 Batch of filterable expert infos with some minor cleanup I noticed while doing the filter conversions. 
svn path=/trunk/; revision=49893
 2013-06-12 03:33:44 +00:00
Martin Kaiser
5b38f1d6e4 TABs -> spaces 
add editor modelines

svn path=/trunk/; revision=49891
 2013-06-11 21:33:48 +00:00
Martin Kaiser
6f6e265cf3 From Javier Godoy 
dissect SCSI descriptor format sense data

from me
- replace TABs with spaces
- delete unused variable "flags"
- set format string for proto_tree_add_text()
- use val_to_str_const()

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8786

svn path=/trunk/; revision=49890
 2013-06-11 21:22:58 +00:00
Pascal Quantin
3a0fbea070 Add PDC and TETRA 
svn path=/trunk/; revision=49889
 2013-06-11 18:07:15 +00:00
Jeff Morriss
15adc6a3cd From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8788 : 
ETSI TS 102 221 V8.2.0 (2009-06)
(http://www.etsi.org/deliver/etsi_ts/102200_102299/102221/08.02.00_60/ts_102221v080200p.pdf)
says that file ID 0x7F31 is reserved for use by iDEN network operators (e.g.
Nextel in the USA).

The attached patch updates the GSM SIM dissector's table of recognised FIDs accordingly.

svn path=/trunk/; revision=49888
 2013-06-11 18:05:41 +00:00
Anders Broman
bbb5aacd42 Show DisplayString as a string. 
svn path=/trunk/; revision=49887
 2013-06-11 16:35:06 +00:00
Evan Huus
2a1ad7683c From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8740 
Improve Bluetooth HFP dissection.

svn path=/trunk/; revision=49886
 2013-06-11 14:05:48 +00:00
Anders Broman
a51e384818 Remove blurbs not adding any value. 
svn path=/trunk/; revision=49885
 2013-06-11 05:41:51 +00:00
Anders Broman
cd643e745e From Hauke Mehrtens: 
There were some problems which prevented wireshark from showing the
payload.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49884
 2013-06-11 05:37:17 +00:00
Anders Broman
ed0f343d8b From Hauke Mehrtens: 
In some places String and byte were mixed up which caused problems.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49883
 2013-06-11 05:34:33 +00:00
Anders Broman
cda44b2966 From Hauke Mehrtens: 
There were some changes in how to specify the length or give a bigger
option delta. This is now implemented how it is specified in CoAP draft
17.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49882
 2013-06-11 05:31:10 +00:00
Anders Broman
a9933bf603 From Hauke Mehrtens: 
There is no option length attribute any more there is just the end of
options marker.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49881
 2013-06-11 05:27:47 +00:00
Anders Broman
ae868938aa From Hauke Mehrtens: 
The field named Transaction ID is named Message ID in the RFC draft
version 17
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49880
 2013-06-11 05:23:52 +00:00
Anders Broman
482221763b From Hauke Mehrtens: 
The token is not an option any more, but it is now in the main header.
This was done between CoAP draft 12 and 13 and still exists in CoAP
draft 17.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49879
 2013-06-11 05:20:33 +00:00
Anders Broman
5bc74bdeaf From: Hauke Mehrtens 
DTLS 1.2 adds a supported_signature_algorithms attribute to the CertificateRequest which was not parsed in DTLS.

This code was copied from the ssl code.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8781

svn path=/trunk/; revision=49878
 2013-06-11 05:11:42 +00:00
Anders Broman
3f896af42c From Javier Godoy: 
update SCSI version descriptors defined in SPC-4 revision 36g (scsi_verdesc_val).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8784

svn path=/trunk/; revision=49877
 2013-06-11 05:06:36 +00:00
Gerald Combs
62d87b6cad tools/lemon/lemon.c: Fix an integer shortening issue. (CMake enables 
-Werror here but Autotools doesn't. Which is correct?)

epan/dissectors/dcerpc: idl2wrs isn't an installed executable in
Autotools so don't make it one in CMake.

svn path=/trunk/; revision=49871
 2013-06-10 18:55:03 +00:00
Michael Mann
2ee48f150d Batch of filterable expert infos. 
svn path=/trunk/; revision=49868
 2013-06-10 02:18:55 +00:00
Anders Broman
0d936038c1 From Javier Godoy: 
SCSI (SPC) sense key specific information field must not include SKSV.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8782

#Backport 1.10 1.8

svn path=/trunk/; revision=49863
 2013-06-09 16:51:42 +00:00
Evan Huus
bd62949918 Convince the compiler that a DNS name won't be longer than 2^32 characters, 
even on 64-bit systems.

svn path=/trunk/; revision=49858
 2013-06-09 14:02:22 +00:00
Evan Huus
edd3dfd6f8 From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8776 
Two new DNS tree items: dns.count.labels and dns.qry.name.len.

svn path=/trunk/; revision=49856
 2013-06-09 13:32:03 +00:00
Michael Mann
2d37ec3cb0 Batch of filterable expert infos. 
svn path=/trunk/; revision=49853
 2013-06-09 03:28:05 +00:00
Michael Mann
6229ab6266 Batch of filterable expert infos. 
svn path=/trunk/; revision=49845
 2013-06-08 02:06:24 +00:00
Sake Blok
f3ba09b543 Mark retransmitted SYN and FIN packets as retransmissions. 
svn path=/trunk/; revision=49829
 2013-06-07 06:49:15 +00:00
Pascal Quantin
506b417907 From Mark C. Brown via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8777 : 
Add support for 10Gbe HP-UX drivers IOCXGBE and IQXGBE

svn path=/trunk/; revision=49820
 2013-06-06 20:55:00 +00:00
Pascal Quantin
f5f6293d28 From Andreas Bachmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6126 : 
Add dissection of PTP Signaling TLV types Request unicast transmission, Grant unicast transmission, Cancel unicast transmission and Acknowledge cancel unicast transmission

svn path=/trunk/; revision=49816
 2013-06-06 19:50:55 +00:00
Alexis La Goutte
727f37e804 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=49810
 2013-06-06 16:24:33 +00:00
Alexis La Goutte
0dca89c4f2 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=49809
 2013-06-06 16:24:25 +00:00
Alexis La Goutte
96e874b4c3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=49808
 2013-06-06 16:24:16 +00:00
Alexis La Goutte
2a89034b06 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=49807
 2013-06-06 16:24:07 +00:00
Alexis La Goutte
8b52c9b2e5 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=49806
 2013-06-06 16:23:59 +00:00
Alexis La Goutte
3eb44c5934 Fix typo (double include epan/ipproto.h) 
svn path=/trunk/; revision=49805
 2013-06-06 16:23:50 +00:00
Evan Huus
de3f2847f1 From myself and Julian Cable via (and fixing) 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8717

Don't add a DCP-ETSI fragment for reassembly if the length is wrong.


svn path=/trunk/; revision=49802
 2013-06-06 02:53:36 +00:00
Michael Mann
57fc882623 Simplify the "bad length" expert info into a single filterable item with formatting determining the particulars because the filter names just didn't make much sense to separate. 
svn path=/trunk/; revision=49801
 2013-06-06 02:10:22 +00:00
Gerald Combs
c891784de7 Quick fix for bug 8768. For now assume that only three logical channels 
are valid. If we run into more add expert item and cap the channel
count.

svn path=/trunk/; revision=49787
 2013-06-05 16:38:20 +00:00
Chris Maynard
bb35c1c375 From Peter Van Eynde via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8635: Fix bugs found by Coverity: CID's 1026572-1026574 and 1026572. 
From me: Dissector was a mix of tabs and spaces.  Replace tabs with spaces and set modelines to match.

svn path=/trunk/; revision=49785
 2013-06-05 15:06:20 +00:00
Jeff Morriss
2a3013fbe1 wccp_version_val is not an extended value string; don't use BASE_EXT_STRING. Fixes a crash I got during fuzz testing. 
svn path=/trunk/; revision=49783
 2013-06-05 13:55:22 +00:00
Pascal Quantin
1bb2081fd2 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8746 : 
Add procedure numbers to C12.22 dissection

svn path=/trunk/; revision=49775
 2013-06-04 20:21:17 +00:00
Anders Broman
3bfeaff546 Add subdissection of: 
- SNMPv2-MIB sysDescr
-  SNMPv2-MIB::sysName

svn path=/trunk/; revision=49774
 2013-06-04 20:05:16 +00:00
Pascal Quantin
f37f79b107 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8747 : 
Remove padding characters from CBS page content display

svn path=/trunk/; revision=49756
 2013-06-04 07:09:42 +00:00
Anders Broman
94ff9552c2 From Anthony Coddington: 
SDH dissector calculation fixes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8767

svn path=/trunk/; revision=49750
 2013-06-04 04:19:52 +00:00
Jeff Morriss
779d28d390 Fix the fuzz failure reported (by me) in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8764 : 
Apply the fix from bug 8539 (r48796) to another function (dissect_r3_upstreamcommand_queryconfig()):

Bail out of the item length we get (which we use to increment the offset) is 0.
Otherwise the offset does not advance and we loop forever.

While we're in there: get the item length just once (there's no need to call
tvb_get_guint8() a half dozen times when one will do).

svn path=/trunk/; revision=49744
 2013-06-04 02:01:53 +00:00
Jeff Morriss
29d51623c2 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8762 : 
Remove dead code (condition can never happen).

svn path=/trunk/; revision=49743
 2013-06-04 01:38:53 +00:00
Evan Huus
e129b4aa03 From William Sims via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8755 
The entity offset variable parameter uses either offset or orientation but not
both, this caused the data displayed to be skewed.

svn path=/trunk/; revision=49736
 2013-06-03 23:47:23 +00:00
Evan Huus
05eab3a2e6 From Marko Hrastovec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8737 
Add dissection of Category 009 to the ASTERIX dissector.

svn path=/trunk/; revision=49734
 2013-06-03 23:27:01 +00:00
Martin Kaiser
9475131092 From chen li 
handle list ending delimiter in bt-dth peer list

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8759

svn path=/trunk/; revision=49729
 2013-06-03 21:01:43 +00:00
Martin Kaiser
a5bfcbf2a9 rename expert module to expert_iso7816 
remove unnecessary comma

svn path=/trunk/; revision=49728
 2013-06-03 20:35:53 +00:00
Pascal Quantin
4adcd51676 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8739 : 
Move offset to end of line without assuming that we always have \r\n at the end of it

svn path=/trunk/; revision=49722
 2013-06-03 17:55:20 +00:00
Alexis La Goutte
7397620985 Enhance CERT DNS Type 
svn path=/trunk/; revision=49720
 2013-06-03 13:11:12 +00:00
Alexis La Goutte
c2657de3e9 Enhance KX DNS Type 
(and fix a minor bug.. KX Preference is always = 0...)

svn path=/trunk/; revision=49719
 2013-06-03 13:11:02 +00:00
Alexis La Goutte
8d26213a1f Enhance NXT DNS Type 
svn path=/trunk/; revision=49718
 2013-06-03 13:10:53 +00:00
Alexis La Goutte
86dee256ab Enhance NSEC DNS Type 
svn path=/trunk/; revision=49717
 2013-06-03 13:10:39 +00:00
Alexis La Goutte
3aa62793e8 Enhance LOC DNS Type 
svn path=/trunk/; revision=49716
 2013-06-03 13:10:31 +00:00
Alexis La Goutte
a02411f679 Enhance DNAME DNS Type 
svn path=/trunk/; revision=49715
 2013-06-03 13:10:22 +00:00
Alexis La Goutte
aceab71d28 Enhance A6 DNS Type 
svn path=/trunk/; revision=49714
 2013-06-03 13:10:12 +00:00
Alexis La Goutte
ddf5186981 Enhance AAAA DNS Type 
svn path=/trunk/; revision=49713
 2013-06-03 13:10:02 +00:00
Alexis La Goutte
7e11edaa43 Enhance IPSECKEY DNS Type 
svn path=/trunk/; revision=49712
 2013-06-03 13:09:53 +00:00
Alexis La Goutte
87a5f44fa4 Enhance KEY Type 
svn path=/trunk/; revision=49711
 2013-06-03 13:09:43 +00:00
Anders Broman
5e408534c8 cc1: warnings being treated as errors 
../../asn1/nbap/packet-nbap-template.c: In function 'add_hsdsch_bind':
../../asn1/nbap/packet-nbap-template.c:349: warning: unused parameter 'tree'

svn path=/trunk/; revision=49708
 2013-06-03 04:25:31 +00:00
Michael Mann
7fe5422c4b Convert ASN.1 dissectors to use filterable expert info. 
NOTE: Kerberos ASN.1 template was updated, but not generated to source.

svn path=/trunk/; revision=49707
 2013-06-03 03:42:36 +00:00
Pascal Quantin
b0646c0756 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8756 : 
Compute the number of septets needed for an alphanumeric address

svn path=/trunk/; revision=49698
 2013-06-02 20:57:48 +00:00
Pascal Quantin
05a7a45620 Remove unused cc_type parameter 
svn path=/trunk/; revision=49696
 2013-06-02 18:01:14 +00:00
Michael Mann
cdd65d2eb0 Get out of global variable hell and other optimizations. 
I'm stil not sure the copying of the packet_info structure is necessary (or what the consequences are), but at least it's not global anymore.

col_set_fence may be needed to prevent overwriting by PPP dissector,  Caching COL_INFO (or the other columns) into it's own string was way more work than necessary and could lead to no column info on a malformed packet.


svn path=/trunk/; revision=49689
 2013-06-02 13:45:51 +00:00
Evan Huus
3c2647947f Fix an infinite loop in the GSM CBCH dissector. 
The looping logic is a bit odd, and there was a case where we were never
incrementing any of the multiple loop variables. I suspect the entire function
could be simplified, but this commit fixes the hang and is better suited to
backporting than anything complex.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8730

svn path=/trunk/; revision=49686
 2013-06-01 23:56:32 +00:00
Pascal Quantin
d7638de9b7 Also notify CMAS alerts 
svn path=/trunk/; revision=49685
 2013-06-01 23:27:16 +00:00
Pascal Quantin
c553280339 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8745 : 
Upgrade AP-title ASN.1 description

svn path=/trunk/; revision=49684
 2013-06-01 23:10:37 +00:00
Martin Mathieson
d41ce46c92 Make Earthquake and Tsunami Warning Sytem indications stand out a 
bit more.

svn path=/trunk/; revision=49683
 2013-06-01 22:26:47 +00:00
Pascal Quantin
c310bd7dcc Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8744 : 
Display C12.22 Invocation Id as unsigned integer

svn path=/trunk/; revision=49682
 2013-06-01 20:51:14 +00:00
Guy Harris
e1b276bbc6 More constification. 
svn path=/trunk/; revision=49681
 2013-06-01 19:33:44 +00:00
Guy Harris
1b96c468d2 More constification. 
svn path=/trunk/; revision=49680
 2013-06-01 18:38:36 +00:00
Guy Harris
d957f1d7df More constification. 
svn path=/trunk/; revision=49678
 2013-06-01 17:49:12 +00:00
Sake Blok
cf079d0a6c Check on fh_tree is already done within add_ethernet_trailer() 
svn path=/trunk/; revision=49676
 2013-06-01 12:00:56 +00:00
Sake Blok
b2a6a6c15c Add ethernet protocol preference to manually set the trailer length. 
(some TAPs can slice packets and then add a custom trailer)


svn path=/trunk/; revision=49675
 2013-06-01 09:05:56 +00:00
Guy Harris
9c4488cedf More constification. 
svn path=/trunk/; revision=49674
 2013-06-01 07:02:34 +00:00
Guy Harris
7658263b0e Note which *particular* IDL this is. (Actually, is that the OSF's DCE 
RPC IDL, Microsoft's DCE RPC IDL, or Samba's DCE RPC IDL?)

Constify some stuff to squelch warnings.

svn path=/trunk/; revision=49672
 2013-06-01 03:17:59 +00:00
Jörg Mayer
bbdb29725a Fix buildbot: 
cc1: warnings being treated as errors
packet-wccp.c: In function 'wccp_fmt_ipadddress':
packet-wccp.c:555: warning: declaration of 'index' shadows a global declaration
/usr/include/string.h:125: warning: shadowed declaration is here
packet-wccp.c: In function 'dissect_wccp2_alternate_mask_value_set_element':
packet-wccp.c:2570: warning: declaration of 'index' shadows a global declaration
/usr/include/string.h:125: warning: shadowed declaration is here
make[5]: *** [libdissectors_la-packet-wccp.lo] Error 1
make[5]: *** Waiting for unfinished jobs....


svn path=/trunk/; revision=49667
 2013-06-01 00:11:29 +00:00
Jörg Mayer
3d636a2777 Peter Van Eynde <pevaneyn@cisco.com> 
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8635

This is an enhanced WCCP decoder handling the new draft 2.01 standard from http://tools.ietf.org/html/draft-mclaggan-wccp-v2rev1


svn path=/trunk/; revision=49666
 2013-05-31 23:17:10 +00:00
Jörg Mayer
65e74551b8 Try to port glbp dissector to new expert info infrastructure. 
Compile tested only.

svn path=/trunk/; revision=49665
 2013-05-31 23:11:43 +00:00
Michael Mann
81820b20ce Add UDT dissector. Bug 8741 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8741) 
From Chas Williams

svn path=/trunk/; revision=49654
 2013-05-31 20:37:46 +00:00
Guy Harris
7d17d600b5 Report the operation number in all places where we note that we don't 
know about a given operation number.

svn path=/trunk/; revision=49653
 2013-05-31 19:00:28 +00:00
Michael Mann
5d6a74fd68 Check USB CCID length to see if subdissectors should be called instead of doing it blindly (which could lead to malformed packets). Bug 8735 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8735) 
Also minor cleanup of column info.

svn path=/trunk/; revision=49651
 2013-05-31 12:54:35 +00:00
Jeff Morriss
813dcf79a1 Don't intentionally use -1 as an hfindex: while only naughty before, with the 
changes from r49644 you'll get complaints about the hf being unregistered...

Note that this code also intentionally passes -1 as an ett_index.  It doesn't
currently complain so I'm leaving it alone for now...

svn path=/trunk/; revision=49648
 2013-05-31 02:27:40 +00:00
Jeff Morriss
4361e2a4ed Get rid of most of the if(tree) checks: the proto_tree_add_*() functions 
don't need them any more and, as shown in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290#c16
we really want to check if we're looking at something beyond the end of the TVB
(in order to break out of very long loops).

svn path=/trunk/; revision=49645
 2013-05-31 01:46:40 +00:00
Pascal Quantin
55da3a2254 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8644 : 
SEL RTAC (Real Time Automation Controller) EIA-232 Serial-Line Dissection

svn path=/trunk/; revision=49635
 2013-05-30 20:51:18 +00:00
Jeff Morriss
d4f44f4979 Get rid of C++/C99-style comments. 
svn path=/trunk/; revision=49632
 2013-05-30 12:54:24 +00:00
Sake Blok
dea156c3d5 Rename "http.response_ts" to "http.time" to be inline with other response time fiels (like dns.time and smb.time etc) 
svn path=/trunk/; revision=49630
 2013-05-30 07:16:04 +00:00
Anders Broman
af28c2b9eb From Chris Pane: 
Updates to IEEE 1722.1 dissector for Draft 23R2.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8732

svn path=/trunk/; revision=49628
 2013-05-30 05:24:37 +00:00
Jeff Morriss
34230e736d Fix the infinite recursion problem reported in 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8733 :

We can't solely rely on the port in the URI to determine whether we will be
recursively called by decode_tcp_ports().  Instead also check the conversation
entry too: if we find that we are the subdissector for this conversation
(which we might be--without the port being in our list of ports--if we
heuristically picked up the conversation or the user did Decode-As),
just bail out and dissect the payload as data.

svn path=/trunk/; revision=49623
 2013-05-29 22:43:20 +00:00
Jeff Morriss
a9ce065e49 As described in the thread starting with: 
https://www.wireshark.org/lists/wireshark-dev/201305/msg00207.html

The PC and SSN are mandatory for the SCCP "user table" to work.  Complain if
they are not given.

svn path=/trunk/; revision=49605
 2013-05-28 22:33:33 +00:00
Martin Mathieson
3a80080fe9 Add some info to make it easier to see when SI config changes: 
- show systemInfoModification in info column (and expert info), also
  show number of UEs paged
- add expert item when systemInfoValueTag changes
- for MIB, add SFN to info column

svn path=/trunk/; revision=49603
 2013-05-28 22:11:56 +00:00
Michael Mann
553bec65ba Batch of filterable expert infos. This (mostly) completes the non-ASN.1 list of (built-in) dissectors that only had a small handful of add_expert_info_format calls. 
svn path=/trunk/; revision=49602
 2013-05-28 03:11:44 +00:00
Evan Huus
292e50ed1d Remove unused variable caught by recent GCC 
svn path=/trunk/; revision=49601
 2013-05-28 00:48:09 +00:00
Michael Mann
b0090fd046 Batch of filterable expert infos 
svn path=/trunk/; revision=49600
 2013-05-27 23:21:11 +00:00
Pascal Quantin
0ee4d0a00a Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

svn path=/trunk/; revision=49599
 2013-05-27 20:26:49 +00:00
Pascal Quantin
38d9a87a49 From Chris Hellberg via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8723 : 
M3UA dissector RFC display update

svn path=/trunk/; revision=49598
 2013-05-27 18:58:24 +00:00
Michael Mann
d0c8f60840 Fix compiler warning 
svn path=/trunk/; revision=49597
 2013-05-27 17:35:21 +00:00
Michael Mann
ea177a2575 Batch of filterable expert infos 
svn path=/trunk/; revision=49596
 2013-05-27 17:30:43 +00:00
Anders Broman
c6af00a977 From jamie Neufeld: 
Add an option to selct if payload is to be dissected as SYNC.

svn path=/trunk/; revision=49595
 2013-05-27 16:27:50 +00:00
Alexis La Goutte
8cd231162b From Jouni Malinen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8711 Wi-Fi Display dissector 
This matches the style used for Wi-Fi Display and gets rid of a minimal
header file for functionality that extends packet-ieee80211.c.

svn path=/trunk/; revision=49594
 2013-05-27 16:20:57 +00:00
Alexis La Goutte
816ed3ce0d From Jouni Malinen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8711 Wi-Fi Display dissector 
The attached patch adds initial support for dissecting Wi-Fi Display information element

svn path=/trunk/; revision=49593
 2013-05-27 16:20:29 +00:00
Ronnie Sahlberg
0e06d5ce58 SCSI Add decoding of Block Device Characteristics VPD page 
svn path=/trunk/; revision=49592
 2013-05-27 03:44:06 +00:00
Ronnie Sahlberg
c8a7157414 SCSI: Print the INQUIRY EVPD page name in the info column 
svn path=/trunk/; revision=49591
 2013-05-27 03:13:31 +00:00
Ronnie Sahlberg
78d98f852e SCSI: add dissection of Tiemout Descriptor for REPORT SUPPORTED OPCODES 
svn path=/trunk/; revision=49590
 2013-05-27 01:09:49 +00:00
Ronnie Sahlberg
edd38556aa SCSI: Add dissection of the data-out buffer for SANITIZE service action OVERWRITE 
svn path=/trunk/; revision=49589
 2013-05-26 18:38:56 +00:00
Gerald Combs
08b5086b0f [Automatic manuf, services and enterprise-numbers update for 2013-05-26] 
svn path=/trunk/; revision=49585
 2013-05-26 14:03:39 +00:00
Michael Mann
5bc22a25df Batch of filterable expert infos. 
svn path=/trunk/; revision=49584
 2013-05-26 03:29:07 +00:00
Ronnie Sahlberg
2ab2ad7a42 SCSI: Add basic decoding of SANITIZE opcode 
svn path=/trunk/; revision=49582
 2013-05-25 22:47:10 +00:00
Michael Mann
7e8e5b347e Batch of filterable expert_infos. 
svn path=/trunk/; revision=49581
 2013-05-25 17:06:40 +00:00
Evan Huus
f16996424a From Fabio Tarabelloni: more minor formatting and comment fixes. 
svn path=/trunk/; revision=49576
 2013-05-25 13:01:25 +00:00
Evan Huus
ea416f0377 From Fabio Tarabelloni: fix copy-pasted comment. 
svn path=/trunk/; revision=49575
 2013-05-25 12:25:51 +00:00
Michael Mann
b2027be0f8 Add filterable expert info. 
svn path=/trunk/; revision=49573
 2013-05-25 03:27:31 +00:00
Evan Huus
cf7ec9f1e9 From Fabio Tarabelloni via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387 
ZigBee ZCL OnOff cluster dissection.

Also, fix decryption of APS commands.

svn path=/trunk/; revision=49571
 2013-05-25 01:45:16 +00:00
Anders Broman
9d5b23bc76 use key in all p_add_proto_data() p_get_proto_data() 
svn path=/trunk/; revision=49568
 2013-05-24 22:38:25 +00:00
Pascal Quantin
ec1ebf5dd8 From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708 : 
Add MAC-DATA support to TETRA dissector and other minor improvements

svn path=/trunk/; revision=49567
 2013-05-24 20:55:42 +00:00
Michael Mann
a686f1713a Bluetooth: Highlight correct bytes in some SDP trees (Part 2). Bug 8700 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700) 
svn path=/trunk/; revision=49566
 2013-05-24 19:40:09 +00:00
Michael Mann
5e86cb9bf4 Use new expert info API in idl dissectors. These generated about 50% of the add_expert_info_format() calls. 
svn path=/trunk/; revision=49561
 2013-05-24 18:09:57 +00:00
Michael Mann
45658e1cbd first batch of dissectors to use the new expert info API. 
svn path=/trunk/; revision=49560
 2013-05-24 18:02:54 +00:00
Pascal Quantin
ecd3073813 How to mess with a keyboard... 
svn path=/trunk/; revision=49558
 2013-05-24 17:43:36 +00:00
Pascal Quantin
01da09fcb5 One more compilation fix for gcc 4.3.2 ('toi' may be used uninitialized in this function) 
svn path=/trunk/; revision=49557
 2013-05-24 17:36:19 +00:00
Evan Huus
f953ba8346 Remove unused function parameter, rename variable to avoid shadowing. 
svn path=/trunk/; revision=49556
 2013-05-24 17:24:58 +00:00
Michael Mann
d12fc51afd Overhauled the RMT dissectors. Not sure each needs its own file, but since this involves multiple RFCs, they remain split out by that. More are now a "pure" dissector and not a "decoding function hook". 
Some Notes:
1. Converted to "new style" dissectors with data being passed between dissectors
2. Combined header files into one since there wasn't much that should have really been in the header files.  Implemented functionality is in c module of respective dissector.

Not sure if LCT preferences should just be in the LCT dissector and not the RMT-ALC "parent", but kept for backwards compatibility.

svn path=/trunk/; revision=49555
 2013-05-24 17:06:23 +00:00
Pascal Quantin
608fe54c05 Fix computation of TP-User-Data-Length when SMS is coded with GSM 7 bit default alphabet and TP-User-Data-Header field is present 
svn path=/trunk/; revision=49546
 2013-05-23 20:28:59 +00:00
Michael Mann
7f832c18c3 Support Raptor/Raptor-Q FEC in RMT dissector. Bug 8699 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8699) 
From Igor Slepchin.

svn path=/trunk/; revision=49523
 2013-05-22 20:30:30 +00:00
Pascal Quantin
491b512399 Do not stop dissection when there is no tree: otherwise it prevents successful reassembly of SMS fragments 
svn path=/trunk/; revision=49516
 2013-05-22 18:19:05 +00:00