osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
47127 commits 26 branches 0 tags 795 MiB
Commit graph

17357 commits

Author SHA1 Message Date
Jeff Morriss
f3dfe6b4df One of the unused hf's commented out in r47389 was not used due to a 
cut-n-pasteo.  Fix that cut-n-pasteo and reinstate the hf.

svn path=/trunk/; revision=50049
 2013-06-19 18:38:41 +00:00
Jörg Mayer
b77119aca7 Remove traling whitespace. 
svn path=/trunk/; revision=50048
 2013-06-19 18:33:49 +00:00
Martin Kaiser
d8c2f03573 revert the extended size box changes for now, 
this needs some more work to make things portable

svn path=/trunk/; revision=50044
 2013-06-19 18:10:41 +00:00
Martin Kaiser
df74ddb9e3 explicitly use 64bit variables, g(u)int is not 64bit everywhere 
svn path=/trunk/; revision=50042
 2013-06-19 17:51:59 +00:00
Evan Huus
451e4b878b Convert DNS dissector to wmem, including first actual usage of wmem's red-black 
tree.

svn path=/trunk/; revision=50041
 2013-06-19 17:40:33 +00:00
Martin Kaiser
86c30e2abe support extended size boxes, general cleanup 
svn path=/trunk/; revision=50040
 2013-06-19 17:34:43 +00:00
Pascal Quantin
2eec913a4d Fet rid of a global variable 
svn path=/trunk/; revision=50034
 2013-06-19 07:16:14 +00:00
Pascal Quantin
830ebed406 Get rid of global variables 
svn path=/trunk/; revision=50032
 2013-06-19 06:44:39 +00:00
Pascal Quantin
7a0245d747 Regenerate dissector 
svn path=/trunk/; revision=50031
 2013-06-19 06:23:51 +00:00
Jörg Mayer
32b98e8524 Fix CID 1033205: Dead default in switch (DEADCODE) 
svn path=/trunk/; revision=50030
 2013-06-19 03:30:06 +00:00
Jörg Mayer
d9b5210c61 Fix CID 712341: Dereference null return value (NULL_RETURNS) 
Well, not really. Just catch that case and error out.

svn path=/trunk/; revision=50029
 2013-06-19 03:23:31 +00:00
Jörg Mayer
2bb61fc8ce Fix CID 1034293: Missing break in switch (MISSING_BREAK) 
svn path=/trunk/; revision=50028
 2013-06-19 02:54:45 +00:00
Martin Mathieson
b4c6e0eb1c Add an option (switched off) to decode the Contention Resolution body as 
an RRC UL CCCH PDU.

svn path=/trunk/; revision=50024
 2013-06-18 23:36:35 +00:00
Jeff Morriss
e872569fde From Anders: Fix the highlighted length, add PDU description as a comment. 
svn path=/trunk/; revision=50023
 2013-06-18 23:33:00 +00:00
Pascal Quantin
d09ffee44e Add ability to export decrypted IPsec PDUs 
svn path=/trunk/; revision=50022
 2013-06-18 23:01:46 +00:00
Martin Mathieson
2cf27a92a6 Set PDCP SN length for DRBs for separate RRC element. 
svn path=/trunk/; revision=50021
 2013-06-18 22:38:54 +00:00
Martin Mathieson
868f74d628 Also signal value of PDCP SN (only used if enabled by RLC preferences). 
svn path=/trunk/; revision=50019
 2013-06-18 21:44:48 +00:00
Martin Mathieson
ece132a5ce Configure MAC LCID -> RLC channel settings from RRC. 
svn path=/trunk/; revision=50016
 2013-06-18 21:02:00 +00:00
Pascal Quantin
458dcb7ea2 Add ability to export decrypted SSL/DTLS PDUs 
svn path=/trunk/; revision=50001
 2013-06-18 01:13:07 +00:00
Jeff Morriss
3d1115c2bd From Anders: 
Use integers intead of strings for hf_sync_timestamp
And hf_sync_packet_nr.
Ad ref. to specification.

svn path=/trunk/; revision=50000
 2013-06-18 01:08:17 +00:00
Evan Huus
eba26b89a4 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8810 
Use value_string array names_nfs4_operation_ext for nfs.main_opname, just like
nfs.opname does.

svn path=/trunk/; revision=49992
 2013-06-17 22:41:43 +00:00
Evan Huus
3398ae2aea Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8809 
The LLRP Standard 1.0.1 defines the ProtocolID Parameter as 8 bit value (see
LLRP Standard 1.0.1 document, page 138, AccessSpecParameter) but Wireshark
treats it as 16 bit value and therefore doesn't recognize the
EPCGlobalClass1Gen2 protocol type and marks the whole packet afterwards as
invalid.

svn path=/trunk/; revision=49991
 2013-06-17 22:22:17 +00:00
Pascal Quantin
24623bdff3 More PDU export work: 
- add automatic export of port type when exporting a source / destination port
- add export of SCTP PPID (usefulness to be checked)
- fix some field size

svn path=/trunk/; revision=49989
 2013-06-17 21:54:21 +00:00
Pascal Quantin
20de5f1a9a Fix 7bit ASCII / IA5 SMS dissection broken in r49910 
svn path=/trunk/; revision=49986
 2013-06-17 19:52:01 +00:00
Evan Huus
3098636502 Ensure that the length parameter to dissect_per_length_determinant is 
initialized even in cases where we error or otherwise fail to dissect.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8722

Thanks to Pascal for his help digging through this one.

svn path=/trunk/; revision=49985
 2013-06-17 19:25:45 +00:00
Pascal Quantin
eecfb7c423 Apply r49983 to other dissectors 
svn path=/trunk/; revision=49984
 2013-06-17 18:44:19 +00:00
Chris Maynard
d3c38473b9 tvb_length_remaining() can return -1 so don't cast its return value to an unsigned type when performing integer comparisons. Instead, cast strlen()'s return value to a signed type and perform the comparison that way. 
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49983
 2013-06-17 15:39:56 +00:00
Evan Huus
b777bc825e Misc tweaks to packet-http-urlencoded.c 
- add modelines
- convert emem to wmem
- add cast to satisfy my version of GCC

svn path=/trunk/; revision=49982
 2013-06-17 14:18:23 +00:00
Jakub Zawadzki
f2f2f13db3 Fix for previous commit, don't use string if get_form_key_value() failed. 
svn path=/trunk/; revision=49978
 2013-06-17 07:41:48 +00:00
Jakub Zawadzki
6dd022f14f Add small dissector for application/x-www-form-urlencoded 
svn path=/trunk/; revision=49977
 2013-06-17 07:35:30 +00:00
Pascal Quantin
17fa61c36e Use a more compact display for the status bitmap 
svn path=/trunk/; revision=49974
 2013-06-17 04:26:16 +00:00
Pascal Quantin
503f7daaa9 Remove preceding zeroes 
svn path=/trunk/; revision=49973
 2013-06-17 04:22:45 +00:00
Martin Kaiser
27598e20a2 fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8806 
assign the return values of decode_...() functions to a signed int
check for negative return values

svn path=/trunk/; revision=49963
 2013-06-16 15:29:14 +00:00
Martin Mathieson
f4b3cb0917 Clarify interface/test for DL HARQ id, and remove a trailing comma from 
an enum.

svn path=/trunk/; revision=49961
 2013-06-16 15:11:21 +00:00
Martin Mathieson
562a126ddc Improve the way PDCP status PDUs are shown. 
For the bitmap, present and missing SNs are both
interesting, but only until the last received SN 
(i.e. the last byte of the bitmap will be padded
out with zero bits).

It would be possible to use existing sequence analysis
info, where available, to decide if any zeros beyond the last
received SN are interesting...

svn path=/trunk/; revision=49959
 2013-06-16 14:24:47 +00:00
Martin Kaiser
69f08fd281 display some more box names 
svn path=/trunk/; revision=49955
 2013-06-16 02:52:01 +00:00
Michael Mann
3846abe34d Replace if-else-if with switch statements 
svn path=/trunk/; revision=49948
 2013-06-16 00:14:07 +00:00
Michael Mann
f42e5bc9c0 Remove check_col() and the occasional tree. 
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory.  A small handful of check_col() calls remain outside of the dissectors.

svn path=/trunk/; revision=49941
 2013-06-14 19:46:54 +00:00
Chris Maynard
dd7b71e384 Fix IEEE802a OUI lookups. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3123
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49939
 2013-06-14 17:57:08 +00:00
Michael Mann
de68fd6eea Removed check_col() and the occasional tree. 
svn path=/trunk/; revision=49938
 2013-06-14 17:49:53 +00:00
Martin Kaiser
48dccb60ad remove some unnecessary check_col() calls 
svn path=/trunk/; revision=49936
 2013-06-14 15:53:52 +00:00
Martin Kaiser
2de0e97d65 add editor modelines 
svn path=/trunk/; revision=49935
 2013-06-14 15:50:20 +00:00
Martin Kaiser
3fe6a50c03 new dissector for the MP4/ISOBMFF file format 
svn path=/trunk/; revision=49934
 2013-06-14 15:33:58 +00:00
Martin Kaiser
b19c7d5537 make line endings consistent 
add svn properties

svn path=/trunk/; revision=49933
 2013-06-14 15:08:10 +00:00
Evan Huus
101af7fa2d Mark unused params as such. 
svn path=/trunk/; revision=49932
 2013-06-14 14:56:00 +00:00
Michael Mann
66f10eec2e Add Common Address Redundancy Protocol (CARP) dissector, bug 8633 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633) 
From Uli Heilmeier

CARP shares the same protocol ID as VRRP (and VRRP's is IANA registered), so heuristics are provided.  VRRP and CARP are very similar, so I'm not sure having heuristics for both dissectors will help CARP.

svn path=/trunk/; revision=49931
 2013-06-14 14:35:34 +00:00
Michael Mann
cfc133ddb6 Add heuristic capabilities to the IP dissector. The motivating factor was the CARP dissector, bug 8633 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633) 
This should allow the ugly IPIP/TAPA hack to be replaced with a proper heuristic, but I don't see any sample TAPA traces to feel confident in making the change myself.


svn path=/trunk/; revision=49930
 2013-06-14 14:13:28 +00:00
Jeff Morriss
9c26c32645 Add parentheses around assignment used as truth value. 
svn path=/trunk/; revision=49929
 2013-06-14 13:20:41 +00:00
Michael Mann
2dbf6c59a2 Remove check_col() from ASN.1 dissectors 
svn path=/trunk/; revision=49927
 2013-06-14 12:44:50 +00:00
Martin Kaiser
0d6110e2a4 try_val_to_str() may return NULL 
although this is nearly impossible here,
use val_to_str_const() anyway to be on the safe side

svn path=/trunk/; revision=49924
 2013-06-14 04:01:21 +00:00
Michael Mann
dfa2156e30 Remove check_col() and the occasional tree. 
svn path=/trunk/; revision=49923
 2013-06-14 02:50:46 +00:00
Jeff Morriss
e9a5b16a09 From Katrina Zhang via Anders (manually applied by me): dissect node features. 
From me: remove some tabs and trailing white space.

svn path=/trunk/; revision=49922
 2013-06-14 02:44:15 +00:00
Michael Mann
fa5b45834b Remove check_col() and the occasional tree. 
svn path=/trunk/; revision=49921
 2013-06-14 01:56:28 +00:00
Michael Mann
0f0c111119 Remove check_col() and the occasional tree. 
svn path=/trunk/; revision=49920
 2013-06-14 01:02:11 +00:00
Pascal Quantin
285bc53826 Fix typo error 
svn path=/trunk/; revision=49918
 2013-06-13 14:20:20 +00:00
Pascal Quantin
53c658bb19 Add basic dissection of Prefix Exclude option 
svn path=/trunk/; revision=49917
 2013-06-13 14:18:10 +00:00
Jeff Morriss
5fa16b2008 From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8794 : 
Display the value of unknown sense descriptor codes in the tree item.
Also fix the length of the subtree.

svn path=/trunk/; revision=49916
 2013-06-13 13:51:19 +00:00
Pascal Quantin
32bec58892 From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8791 : 
Improve dissection of GSM SIM payloads in USB CCID packets

svn path=/trunk/; revision=49915
 2013-06-13 10:52:34 +00:00
Michael Mann
e1b7a26463 Adding support of BGP flow spec RFC 5575. 
From Matt Texier, bug 8691 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8691)

svn path=/trunk/; revision=49914
 2013-06-13 02:35:23 +00:00
Michael Mann
53290ee17c Updated the rsync dissector to make it able to parse the newer variants of the protocol, treat binary data consistently and clearly differentiate packets of the client and the server. 
From Benoit Daloze, bug 8743 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8743)

svn path=/trunk/; revision=49913
 2013-06-13 01:06:31 +00:00
Guy Harris
3dbf3b975a Give somewhat more precise names for character encodings ("Unicode" 
doesn't specify a single way to encode characters in an octet stream -
there's UTF-8 and UTF-16BE/LE, as well as UCS-2BE/LE for a subset of
Unicode, and "Latin" really means "ISO 8859-1" a/k/a "ISO Latin 1".

svn path=/trunk/; revision=49912
 2013-06-12 18:17:15 +00:00
Pascal Quantin
41647faaba Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3289 : 
dissector ansi_637 does not have unicode encoding in user data parameter

svn path=/trunk/; revision=49911
 2013-06-12 17:25:04 +00:00
Pascal Quantin
0975d03e8d Fix dissection of 3GPP2 SMS messages when the User Data Header field is present (for fragmented SMS) 
svn path=/trunk/; revision=49910
 2013-06-12 16:59:59 +00:00
Martin Kaiser
7e9d283c15 no need for check_col() 
svn path=/trunk/; revision=49906
 2013-06-12 15:15:26 +00:00
Anders Broman
82e220f2bd Pretify dissection of date and Time. 
svn path=/trunk/; revision=49905
 2013-06-12 15:08:08 +00:00
Martin Kaiser
6de25d3897 simplify the subdissector call 
svn path=/trunk/; revision=49904
 2013-06-12 14:56:37 +00:00
Martin Kaiser
7a82d35280 TABs -> spaces 
add modelines

svn path=/trunk/; revision=49903
 2013-06-12 14:55:37 +00:00
Martin Kaiser
80046abfcb no expert infos under if(tree) 
simplify the code a bit

svn path=/trunk/; revision=49902
 2013-06-12 14:54:13 +00:00
Martin Kaiser
346117c265 From Javier Godoy 
dissect SCSI OSD error identification sense data descriptor 

from me
- TABs -> spaces
- fix compiler errors about unused return values
- don't use another subtree within the descriptor payload

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8790

svn path=/trunk/; revision=49901
 2013-06-12 14:20:36 +00:00
Martin Kaiser
e94463b0df fix compiler warning 
(gcc version 4.4.5 (Debian 4.4.5-8))

cc1: warnings being treated as errors
packet-bthfp.c: In function ‘dissect_at_command’:
packet-bthfp.c:875: error: ‘col_str’ may be used uninitialized in this function

svn path=/trunk/; revision=49900
 2013-06-12 12:20:50 +00:00
Tomas Kukosa
822c02b5d0 Fix wrong offset in H.235 tokens causing malformed packet exception 
svn path=/trunk/; revision=49899
 2013-06-12 09:03:21 +00:00
Martin Kaiser
2e8347a964 no need for check_col() 
svn path=/trunk/; revision=49898
 2013-06-12 08:24:54 +00:00
Martin Kaiser
4131f8fa31 TABs -> spaces 
add modelines

svn path=/trunk/; revision=49897
 2013-06-12 08:15:46 +00:00
Martin Kaiser
a8c1a87662 CID 280301: add a NULL check before dereferencing the pointer 
svn path=/trunk/; revision=49896
 2013-06-12 07:59:27 +00:00
Anders Broman
ddd78fbd78 From Javier Godoy: 
dissect SCSI field pointer sense key specific information

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8789

svn path=/trunk/; revision=49895
 2013-06-12 05:15:45 +00:00
Anders Broman
03a322661f Fix a crash when oid_info->value_typem is NULL 
svn path=/trunk/; revision=49894
 2013-06-12 04:21:40 +00:00
Michael Mann
93be0fb393 Batch of filterable expert infos with some minor cleanup I noticed while doing the filter conversions. 
svn path=/trunk/; revision=49893
 2013-06-12 03:33:44 +00:00
Martin Kaiser
5b38f1d6e4 TABs -> spaces 
add editor modelines

svn path=/trunk/; revision=49891
 2013-06-11 21:33:48 +00:00
Martin Kaiser
6f6e265cf3 From Javier Godoy 
dissect SCSI descriptor format sense data

from me
- replace TABs with spaces
- delete unused variable "flags"
- set format string for proto_tree_add_text()
- use val_to_str_const()

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8786

svn path=/trunk/; revision=49890
 2013-06-11 21:22:58 +00:00
Pascal Quantin
3a0fbea070 Add PDC and TETRA 
svn path=/trunk/; revision=49889
 2013-06-11 18:07:15 +00:00
Jeff Morriss
15adc6a3cd From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8788 : 
ETSI TS 102 221 V8.2.0 (2009-06)
(http://www.etsi.org/deliver/etsi_ts/102200_102299/102221/08.02.00_60/ts_102221v080200p.pdf)
says that file ID 0x7F31 is reserved for use by iDEN network operators (e.g.
Nextel in the USA).

The attached patch updates the GSM SIM dissector's table of recognised FIDs accordingly.

svn path=/trunk/; revision=49888
 2013-06-11 18:05:41 +00:00
Anders Broman
bbb5aacd42 Show DisplayString as a string. 
svn path=/trunk/; revision=49887
 2013-06-11 16:35:06 +00:00
Evan Huus
2a1ad7683c From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8740 
Improve Bluetooth HFP dissection.

svn path=/trunk/; revision=49886
 2013-06-11 14:05:48 +00:00
Anders Broman
a51e384818 Remove blurbs not adding any value. 
svn path=/trunk/; revision=49885
 2013-06-11 05:41:51 +00:00
Anders Broman
cd643e745e From Hauke Mehrtens: 
There were some problems which prevented wireshark from showing the
payload.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49884
 2013-06-11 05:37:17 +00:00
Anders Broman
ed0f343d8b From Hauke Mehrtens: 
In some places String and byte were mixed up which caused problems.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49883
 2013-06-11 05:34:33 +00:00
Anders Broman
cda44b2966 From Hauke Mehrtens: 
There were some changes in how to specify the length or give a bigger
option delta. This is now implemented how it is specified in CoAP draft
17.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49882
 2013-06-11 05:31:10 +00:00
Anders Broman
a9933bf603 From Hauke Mehrtens: 
There is no option length attribute any more there is just the end of
options marker.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49881
 2013-06-11 05:27:47 +00:00
Anders Broman
ae868938aa From Hauke Mehrtens: 
The field named Transaction ID is named Message ID in the RFC draft
version 17
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49880
 2013-06-11 05:23:52 +00:00
Anders Broman
482221763b From Hauke Mehrtens: 
The token is not an option any more, but it is now in the main header.
This was done between CoAP draft 12 and 13 and still exists in CoAP
draft 17.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8780

svn path=/trunk/; revision=49879
 2013-06-11 05:20:33 +00:00
Anders Broman
5bc74bdeaf From: Hauke Mehrtens 
DTLS 1.2 adds a supported_signature_algorithms attribute to the CertificateRequest which was not parsed in DTLS.

This code was copied from the ssl code.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8781

svn path=/trunk/; revision=49878
 2013-06-11 05:11:42 +00:00
Anders Broman
3f896af42c From Javier Godoy: 
update SCSI version descriptors defined in SPC-4 revision 36g (scsi_verdesc_val).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8784

svn path=/trunk/; revision=49877
 2013-06-11 05:06:36 +00:00
Gerald Combs
62d87b6cad tools/lemon/lemon.c: Fix an integer shortening issue. (CMake enables 
-Werror here but Autotools doesn't. Which is correct?)

epan/dissectors/dcerpc: idl2wrs isn't an installed executable in
Autotools so don't make it one in CMake.

svn path=/trunk/; revision=49871
 2013-06-10 18:55:03 +00:00
Michael Mann
2ee48f150d Batch of filterable expert infos. 
svn path=/trunk/; revision=49868
 2013-06-10 02:18:55 +00:00
Anders Broman
0d936038c1 From Javier Godoy: 
SCSI (SPC) sense key specific information field must not include SKSV.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8782

#Backport 1.10 1.8

svn path=/trunk/; revision=49863
 2013-06-09 16:51:42 +00:00
Evan Huus
bd62949918 Convince the compiler that a DNS name won't be longer than 2^32 characters, 
even on 64-bit systems.

svn path=/trunk/; revision=49858
 2013-06-09 14:02:22 +00:00
Evan Huus
edd3dfd6f8 From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8776 
Two new DNS tree items: dns.count.labels and dns.qry.name.len.

svn path=/trunk/; revision=49856
 2013-06-09 13:32:03 +00:00
Michael Mann
2d37ec3cb0 Batch of filterable expert infos. 
svn path=/trunk/; revision=49853
 2013-06-09 03:28:05 +00:00
Michael Mann
6229ab6266 Batch of filterable expert infos. 
svn path=/trunk/; revision=49845
 2013-06-08 02:06:24 +00:00
Sake Blok
f3ba09b543 Mark retransmitted SYN and FIN packets as retransmissions. 
svn path=/trunk/; revision=49829
 2013-06-07 06:49:15 +00:00