Commit Graph

81880 Commits

Author SHA1 Message Date
Alexis La Goutte 203e082a50 nettrace_3gpp (wiretap): Fix Dead Store found by Clang Analyzer
nettrace_3gpp_32_423.c:256:2: warning: Value stored to 'prev_pos' is never read [deadcode.DeadStores]
nettrace_3gpp_32_423.c:295:2: warning: Value stored to 'next_msg_pos' is never read [deadcode.DeadStores]
nettrace_3gpp_32_423.c:487:4: warning: Value stored to 'port_type_defined' is never read [deadcode.DeadStores]
2021-09-06 04:21:14 +00:00
Alexis La Goutte d940352da7 gitlab-ci: enhance cppcheck
display on CI build, the text output (and not xml)
store all cppcheck output files on cppcheck folder

(you need to launch cppcheck twice for generate txt and xml)
2021-09-06 04:04:46 +00:00
Alexis La Goutte da6ef0a3f0 extreme-exeh: fix conflict
'exeh.unknown17' exists multiple times with incompatible types: FT_BOOLEAN and FT_UINT8
2021-09-06 03:47:56 +00:00
Alexis La Goutte 95b63d04d9 dcerpc_spoolss: fix display filter name
found by conflict check
 'spoolss.driverversion' exists multiple times with incompatible types: FT_UINT64 and FT_UINT32
2021-09-06 03:47:56 +00:00
Alexis La Goutte ea6267d12b ncsi: Fix typo (on display name)
found by conflict tools
 'ncsi.mlx.gama.st' exists multiple times with incompatible types: FT_ETHER and FT_UINT8
2021-09-06 03:47:55 +00:00
Gerald Combs 197911dea1 [Automatic update for 2021-09-05]
Update manuf, services enterprise numbers, translations, and other items.
2021-09-05 18:53:03 +00:00
kor 61e1e69218 diameter: add 3GPP 29.234 V11.2.0 (2013-06)
Added new AVP from 3GPP 29.234
2021-09-05 08:12:14 +00:00
Alexis La Goutte 3403e37d47 gitlab-ci: Add artifact for check hf conflict 2021-09-05 07:49:29 +00:00
Ramin Moussavi 03a07e4f1b fix two display issues with remote interfaces window 2021-09-05 07:47:52 +00:00
Uli Heilmeier 86d5606be3 IEEE 802.15.4: Add PAN ID when flag is set
According to IEEE 802.15.4-2020 Section 7.3.5.1 Destination PAN ID field is
present when PAN ID Present bit is set. Therefore we should check for the bit.

Fixes: wireshark/wireshark#17496
2021-09-04 11:17:08 +02:00
Moshe Kaplan 8ef6f04f5a Qt: Debounce Preferences -> Advanced menu : Avoid leaking memory
Free the QTimer in the PreferencesDialog's destructor to
avoid leaking memory.
2021-09-04 07:47:34 +00:00
Chuck Craft eb83421c96 NSIS: expand title area for long program names that wrap
Release candidates (rc blah blah hash) or if WIRESHARK_VERSION_EXTRA
is set for the build, are wrapped/clipped to be unreadable.
2021-09-04 06:19:42 +00:00
Martin Mathieson fb02f423b1 Some spelling fixes 2021-09-03 22:45:06 +00:00
Graham Bloice 436eab0d77 SparkplugB: Fix handling of malformed message
Make the dissector more defensive when handling a message with
a malformed topic string

Fixes #17566
2021-09-03 17:57:07 +01:00
Alexis La Goutte 738670df7e woww: Fix conflict
Typo on display name filter (copy/paste ?)
2021-09-03 13:41:13 +00:00
Martin Mathieson 571c0c9580 ORAN FH CUS: Fix section 6 summary 2021-09-03 10:45:35 +01:00
Taisuke Sasaki b4ef378e5e BGP: Fix BGP-LS TLV offset of IGP TE Metric (RFC8571) 2021-09-03 05:51:39 +00:00
Natale Patriciello 57376bdf3e RTCP: Fix padding dissection in transport feedback
The transport feedback definition, from
(https://datatracker.ietf.org/doc/html/draft-holmer-rmcat-transport-wide-cc-extensions-01#section-3.1)
has the third bit as the padding bit (as any RTCP feedback message). However,
the transport feedback dissector was consuming the padding (if present),
leaving the outer RTCP dissector with a padding bit set, but no padding to
analyze/show. That resulted in a "Malformed packet" error.

With this patch, any padding that is consumed in the transport feedback
dissection clears the outer padding bit set, leaving the RTCP dissector happy.
2021-09-03 05:36:23 +00:00
ismaelrti 00438ef755 RTPS: Fixed structure alignment when dissecting user data samples.
Fixing the initial offset when dissecting user data samples.
2021-09-03 05:20:36 +00:00
Tomas Kukosa dde6fde173 Vector BLF: add WLAN interface name 2021-09-03 05:03:48 +00:00
Tomas Kukosa bf1039a529 Vector BLF: WLAN frame supported 2021-09-03 05:03:48 +00:00
Alexis La Goutte 358df6c80d dot11decrypt_util: Enhance Documentation
Fix typo and add missing doc for a parameter (pmk_r0_len)
2021-09-03 04:46:34 +00:00
Alexis La Goutte 746585fe70 dot11decrypt_util (crypt): Fix -Wdocumentation Warning
Fix parameter 's0kd_id_len' not found in the function declaration [-Wdocumentation]
2021-09-03 04:46:34 +00:00
Guy Harris 7083e70842 Remove an out-of-date comment.
(It appears gsize/gssize are now the same size as size_t, even on 64-bit
Windows, i.e. they're long longs on 64-bit Windows.)
2021-09-02 15:33:55 -07:00
Martin Mathieson 92fb6a72f8 UDP: Add long help text for length field
Because it does include the 8 bytes of the header.
2021-09-02 20:09:54 +01:00
Joakim Karlsson 8684ba27a2 DVB-S2: fix build issues [-Werror=maybe-uninitialized] 2021-09-02 18:04:56 +00:00
Joakim Andersson 5c46e0eac3 btle: Add support for CTE Info field in Data Physical Channel PDUs
Add support for the optional CTE Info field in the Data Physical Channel
PDU header.

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
2021-09-02 17:48:43 +00:00
John Thacker 994bf73f46 IEEE 1722 AVTP: Fix name
AVBTP was used in drafts, but the name has officially been AVTP
in all releases, IEEE Std 1722-2011 and -2016. Change AVBTP to
AVTP and remove "Bridging" where it appears.
2021-09-02 16:23:09 +00:00
Alexis La Goutte 1f4e150ca7 gitlab-ci (Clang): Add Clang Analyzer ouput to artifacts 2021-09-02 16:06:17 +00:00
Alexis La Goutte bbcedb667c clang-check(tools): exit when set illegal option
and not when pass -c parameter, it is break some part of gitlab-ci (Clang Builder)
2021-09-02 16:06:17 +00:00
Martin Mathieson fb6aa10c12 ORAN FH CUS: avoid undefined shift in block fp decompress
Fixes #17552
2021-09-02 15:43:36 +00:00
Dario Lombardo 2e9f33fe09 file_wrapper: fix compilation without LZ4. 2021-09-02 15:17:05 +00:00
Chuck Craft 2be72076f0 f5ethtrailer: greedy conversation filters 2021-09-02 14:07:45 +00:00
Martin Mathieson 124f7ce798 ORAN FH CUS: Add C SectionType=6 2021-09-02 12:11:43 +00:00
Marius Preuten e5e37add9a 802.11 Decrypt: Fix AAD Calculation when HT-Control present in a QoS Data Frame
The current implementation misses an edge case, where bit 15 of the FC Field
must be zeroed in case a QoS Control field is present (IEEE 802.11 12.5.3.3.3),
which results in a wrong AAD and subsequently in the failure of the packet
decryption for QoS Data Frame carrying a HT Control Field (indicated by bit
15 set to 1).

In addition the field 14 must be 1, which is ensured explicitly (the author is
not sure if the code is reachable by frames which do not have bit 14 set to
one).
2021-09-02 10:56:02 +00:00
Alexis La Goutte cfc60b3f6e thrift(.h): Fix Warning about -Wdocumentation
remove extra : after each variable
2021-09-02 10:26:59 +00:00
Anders Broman 062994e089 GSM MAP: Handle Version 1 of ResetArg
Closes #17549
2021-09-02 09:36:44 +00:00
Guy Harris e998a4cc02 Clean up handling of buffer size/offset/etc. types.
Use guint for them, and don't let the buffer sizes get bigger than 2^30,
so they all fit in a guint.
2021-09-02 02:14:28 -07:00
John Thacker 4091b31444 IEEE 1722/AVTP: Update Compressed Video Format
Call existing MJPEG and H.264 dissectors for those subtypes,
and remove duplicate fields. Use common true_false_string.
Warn about invalid length, and only process the payload length
show in the payload field, allowing for Ethernet FCS autodetection,
among other things. Register the MJPEG dissector by name so
that AVTP CVF can call it. Add some value string entries to the
MJPEG dissector.

When the format value is reserved, ignore the subtype field
and add expert info and show the payload as data. (IEEE 1722-2016
8.3.2) Fix #12490
2021-09-01 21:03:35 -04:00
Erik Rigtorp 341a9d099c Fix build for debian and macOS 2021-09-01 23:16:59 +02:00
Erik Rigtorp 5844c469f0 Add support for ZSTD and LZ4 decompression
- Describe zstd and lz4 support in man pages
- Update AUTHORS
- Update mime types to recognize zstd and lz4
2021-09-01 20:59:07 +02:00
Dr. Lars Völker 3f92ae9db9 IEEE1609dot2: fix missing import (BUGFIX)
Closes #17568
2021-09-01 20:09:56 +02:00
Gerald Combs 348d356594 Packaging: Update the macOS notarization failure error message.
Apple provides a status page for various developer services at
https://developer.apple.com/system-status/, including the status of the
Developer ID Notary Service. Show the URL notarization fails so that
troubleshooting is easier.
2021-09-01 10:24:58 -07:00
Gerald Combs 5893d3cd09 CMake: Fix tests.
Pass $<TARGET_FILE_DIR:wmem_test> to test.py, which should be the path
for all of our built executables, instead of ...:tshark, which is the
path for *some* of our built executables on macOS.
2021-09-01 09:31:07 -07:00
Ugur ILTER 43d2655f16 ieee1905: fix dissection of DPP messages
- Handle 'Category' field under 'Encapsulated Frame' field inside 1905 Encap DPP TLVs

![incorrect](/uploads/be54a9e6757aacbccb3625b4aa11db9b/incorrect.png)

![correct](/uploads/285b14d3945c2821ba3606e7da7ae94d/correct.png)
2021-09-01 13:08:21 +00:00
Anders Broman 9cf6caee62 Thrift: Fix warning about unused variable.
/epan/dissectors/packet-thrift.c:1619:9: error: ‘type_pi’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
2021-09-01 13:53:55 +02:00
Alexis La Goutte 875d607892 Aruba(IAP): Add IAP-635 (Norma) 2021-09-01 08:44:54 +00:00
Gerald Combs 4d1357eebe CMake: Get rid of WS_PROGRAM_PATH
Use the $<TARGET_FILE_DIR:tshark> generator expression instead.
2021-09-01 07:16:20 +00:00
John Thacker b04165a57b DVB-S2: Only create composite if used
It violates the tvb_composite API to create composite TVBs if
they're not going to have at least one TVB put in them. Prevent
dissector bug failed assertions in the case of packets incorrectly
identified as DVB Baseband frames carrying TS by the heuristic
dissector.
2021-09-01 07:00:16 +00:00
Tomas Kukosa 033068916d ITS: use custom value format for CPM elements 2021-09-01 06:44:20 +00:00