Pacify checkAPIs.pl
Change-Id: I637a6cd678b99d05cd1b26fd3cba6ad4dd19e8d2
Reviewed-on: https://code.wireshark.org/review/22957
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Add shortcut Ctrl+Alt+Shift+
T for "Follow TCP Stream"
U for "Follow UDP Stream"
H for "Follow HTTP Stream"
S for "Follow SSL Stream"
Bug: 13047
Change-Id: I0fdd5b4d20b976b56694821a9c11424eab40b2b3
Reviewed-on: https://code.wireshark.org/review/22930
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Commit ffea2f8a24 ("ZigBee: fix endian for File Version field in OTA")
fixed the endianness of the file version field but did not update the
masks for the sub-elements of this field now that they are compared
against the value decoded as little-endian.
Change-Id: Icdb9d56cc29da19b9fc26da84979f15936c930d4
Reviewed-on: https://code.wireshark.org/review/22955
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Improve dispaly of Error Cap Flags
Add new Flag for Cap Flag
Misc coding aligmement
Change-Id: I9ad593dbe8bcc116057af9a6324f25451bac2a88
Reviewed-on: https://code.wireshark.org/review/22938
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Pass the remaining line length to process_pwd_success(), and don't treat
the string passed to it as a null-terminated string, check the length
value.
Also, make sure the line is long enough before even calling
process_pwd_success().
Bug: 13946
Change-Id: I67d015854046bbaaa6f55d4221f314e1446e7398
Reviewed-on: https://code.wireshark.org/review/22943
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Update the Windows section for Visual Studio 2015. Copy the content from
README.cmake to its own WSDG section and remove README.cmake.
Remove the PowerShell sections. Our required version (2.0) ships with
every supported version of Windows. Remove the sed section.
Change-Id: Id37c6e71bacc247a3ed1992adb1408ec13f6a187
Reviewed-on: https://code.wireshark.org/review/22940
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Ensure that rsa_load_pem_key() and rsa_load_pkcs12() always return an
error message string if they fail, so that
1) they don't return NULL without supplying an error string;
2) they don't supply an error string if they succeed.
If either of them fails, report the error; if there's no error string,
report an unknown error (that shouldn't happen, but the wsutil/rsa.c
code needs more cleanup before I'll believe it can't happen).
While we're at it, clean up some of those error strings, return NULL
rather than 0 as the failure case from rsa_load_pkcs12() as we do in
rsa_load_pem_key() (they mean the same thing, but NULL makes it a bit
clearer), and de-initialize the private key structure in
rsa_load_pem_key() if we fail (so that we don't leak memory).
Change-Id: Id9dd331800d87b017a500a6f579df446057f555b
Reviewed-on: https://code.wireshark.org/review/22941
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Nothing ensures that will be the case, and if we assume it is the case,
we can crash.
Bug: 13945
Change-Id: I7f6cb47da81efe219e87b06f8def65a332273480
Reviewed-on: https://code.wireshark.org/review/22939
Reviewed-by: Guy Harris <guy@alum.mit.edu>
CMake should check both the 32-bit and 64-bit views automatically.
Change-Id: I856814efcd660260c734c7956ad00ee43a8f666f
Reviewed-on: https://code.wireshark.org/review/22936
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Pass in a QString argument only when we have a placeholder. Fixes a
QString::arg: Argument missing: MainWelcome { ...
warning on Windows.
Change-Id: I42dd155252bd9fd4f21f0112b62044c7397c9810
Reviewed-on: https://code.wireshark.org/review/22934
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
When using a length of -1, use the tvb remaining length instead of 0.
Change-Id: I569e9c9f57531914a3b613c3a6a9bff076fba362
Reviewed-on: https://code.wireshark.org/review/22931
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Remove assignee and other miscellaneous information that changes more
frequently than service name and can be consulted directly in the IANA
registry.
Allow merging identical transports into a single line for convenience
and size/speed optimization (a backward-compatible change).
Remove obsolete make-services.pl.
Change-Id: I3ecbd1a6a68d87c084d77498a0eeb44b7afdab67
Reviewed-on: https://code.wireshark.org/review/22872
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Bug: 13939
Change-Id: I3fbbbb4e806e0732c2d11a7fd5048528c5f6f328
Reviewed-on: https://code.wireshark.org/review/22923
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The OS is now called just macOS, and the rest of the setup scripts are
in tools, so move this one there as well.
Update the documentation to reflect the change.
Change-Id: I4d9ebf0797ffe8862e82c4bcfdeec1d2eabae6ae
Reviewed-on: https://code.wireshark.org/review/22918
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Say it builds "as needed".
Change-Id: I85ce2062da7f168785d0d22160b8f19b85d554e3
Reviewed-on: https://code.wireshark.org/review/22909
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Change-Id: I459208eed4a76b104bc28aa44ab05374e57043de
Reviewed-on: https://code.wireshark.org/review/22873
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
from under the security blob since they're physically placed before the blob.
Also renamed them to clarify their link to the blob
Change-Id: I896ce8eea3f5f41c1887a685247e7fa168cc9061
Reviewed-on: https://code.wireshark.org/review/22823
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Instrumentation code increases the stack usage. Let's deactivate the
check when compiling with ASan or UBSan as the objective here is not
to check the stack consumption and its usage is out of our control.
Change-Id: I9d6e269a0d404dc1833183a070fdbbb7fb0446e0
Reviewed-on: https://code.wireshark.org/review/22888
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Flows records can span multiple PDUs (e.g when using TCP).
This commit adds the preference to reassemble flows.
Bug: 13915
Change-Id: I10eb0d9ee5ff5cc06ff52d0d0c8c468140e0273b
Reviewed-on: https://code.wireshark.org/review/22792
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
As explained by 3GPP TS 44.064 Section 6.4.2.2 there are Dummy UI
Commands which are never generated by a LLC entity, but nevertheless
received by a LLC entity. They are generated by the underlying
network-side RLC/MAC entity a as a means to artificially delay the
release of a downlink TBF.
We introduce a new "llcgprs.dummy_ui" boolean field on which the user
can match to filter our such messages, if needed.
Change-Id: Ie8fcb42cbd66a7e5b77849f0bc5a3630d0d54a9c
Reviewed-on: https://code.wireshark.org/review/22862
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Also, process the packet to the end, even if there are fewer than 3
bytes left; we'll throw an exception if we can't fetch the type and
length, which will report the packet as malformed (which it is).
Change-Id: Iddd5be4be635553ac77bdb7fe232c2edb0e4404c
Reviewed-on: https://code.wireshark.org/review/22882
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The RLC/MAC dissector decodes both signalling (PACCH) and data (PDTCH)
RLC/MAC blocks, so let's make sure we dispatch both logical channels
into that dissector.
Change-Id: Ia26a1ba74468a49da071185cc5ee876ade907207
Reviewed-on: https://code.wireshark.org/review/22861
Reviewed-by: Michael Mann <mmann78@netscape.net>
PDCH is the physical channel name, while PDTCH is one of the logical
channels (goether with PTCCH and PACCH) on the PDTCH. Let's call it
by its proper name, rather than keeping the misnomer.
Change-Id: I724fcfba595c9c861b64a30d5510468ec007424c
Reviewed-on: https://code.wireshark.org/review/22860
Reviewed-by: Michael Mann <mmann78@netscape.net>
The original code made all columns read-only; making only the info
column read-only makes the packet summary look weird, with the contained
protocol shown but the info from MSDP shown.
Change-Id: Iaa8afcb98a26a94230d5f344261f202ea658d077
Reviewed-on: https://code.wireshark.org/review/22878
Reviewed-by: Guy Harris <guy@alum.mit.edu>