Commit Graph

52 Commits

Author SHA1 Message Date
João Valverde 7322c35a47 Remove keep alives from "Bad TCP" coloring rules
Change-Id: Ie0c2160f469ba32535f52e074670318739cfa81a
Reviewed-on: https://code.wireshark.org/review/35869
Reviewed-by: Jasper Bongertz <jasper@packet-foo.com>
Reviewed-by: João Valverde <j@v6e.pt>
2020-03-02 14:48:09 +00:00
Gerald Combs b5444c3af9 Add a coloring rule for system events.
Add a coloring rule for sdjournal and sysdig events.

Change-Id: I92f0bea238a9f0242d4790c58867144f0e256097
Reviewed-on: https://code.wireshark.org/review/31369
Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-01-06 02:11:33 +00:00
Gerald Combs 5d97cee7da Remove IPX from our default filters.
Remove IPX items from the default capture, color, and display filter
files. Suggested by Laura Chappell at SharkFest 2018.

Change-Id: I5e14caaa69efc638a5da7c795bf8a9e5e890b3fd
Reviewed-on: https://code.wireshark.org/review/28489
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-27 20:46:17 +00:00
Michael Mann ad6fc87d64 Add proto_tree_add_checksum.
This is an attempt to standardize display/handling of checksum fields for all dissectors.
The main target is for dissectors that do validation, but dissectors that just report the
checksum were also included just to make them easier to find in the future.

Bug: 10620
Bug: 12058
Ping-Bug: 8859
Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf
Reviewed-on: https://code.wireshark.org/review/16380
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-21 12:35:22 +00:00
Joerg Mayer 97014f6d6b OSPF database packets and OSPF hellos in DC mode are unicast. At
least Cisco sends out these packets with a TTL of 1.

Change-Id: I9ef0cd486d200a768329cfb758b87e20e3456663
Reviewed-on: https://code.wireshark.org/review/10188
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-08-22 01:50:26 +00:00
Jesse Gross 1e2867cdf0 Clean up STT plugin
This adds some essential features for STT dissection including
using a heuristic IP dissector to ensure we get the right traffic,
segment reassembly, and additional field decoding.

Based on work original done by Andrew Evans.

Change-Id: Ic89d6b16803185c7f58b73935c2646d532d0ae14
Reviewed-on: https://code.wireshark.org/review/8187
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-27 04:43:51 +00:00
Alexis La Goutte 14d0a15869 Add HTTP2 to colorfilters
svn path=/trunk/; revision=51593
2013-08-30 11:14:26 +00:00
Michael Mann a7043bf787 Update "TTL low or unexpected" coloring rule to ignore vrrp, carp and MulticastDNS all of which intentionally use TTL 255. Bug 5010 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5010)
Add carp to routing protocols while we're at it.

svn path=/trunk/; revision=50014
2013-06-18 20:48:42 +00:00
Gerald Combs bf579224ae Add a "profiles" directory. Add a Bluetooth global profile with the
current default+Bluetooth colors and a Classic global profile with the
old 1.8 colors. Remove the Bluetooth rules from the default profile.

svn path=/trunk/; revision=49116
2013-05-01 20:31:50 +00:00
Gerald Combs b2e88f3d5e Darken and saturate the "trouble" backgrounds a bit.
svn path=/trunk/; revision=49084
2013-04-29 17:13:24 +00:00
Evan Huus ff9c205f94 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
Add basic support for Bluetooth GNSS profile. It uses NMEA-0183, but that is not
free, so all we can do is add filtering and displaying for ASCII content.

Also add colors for DUN, GNSS to show them in contrast to RFCOMM.

svn path=/trunk/; revision=48662
2013-03-30 21:54:42 +00:00
Alexis La Goutte 6c6d8f1629 Enhance 802.11 FCS check - Replace proto_tree_add_* by proto_tree_add_item - Add bad FCS to colorfilters
svn path=/trunk/; revision=48361
2013-03-17 19:22:19 +00:00
Evan Huus 32c23fba25 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8396
Add Bluetooth HCRP dissector.

From me: rename a preference to be a bit clearer.

svn path=/trunk/; revision=47878
2013-02-25 17:55:32 +00:00
Evan Huus c1f3dd7242 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8366
Add support for bluetooth MCAP Protocol.

svn path=/trunk/; revision=47804
2013-02-21 18:43:26 +00:00
Anders Broman 2ec15712c5 From Michal Labedzki:
[PATCH 18] Bluetooth: Add colofilter for ATT protocol

Add colofilter for ATT protocol. 
Why "green"? Looks good and ATT seems to be similar to SDP - use attributes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=45826
2012-10-29 12:57:09 +00:00
Gerald Combs 17f959dc74 Revert the background color for TCP and lighten it for UDP. Change the
ARP background to differntiate it from UDP.

svn path=/trunk/; revision=45658
2012-10-19 15:25:06 +00:00
Gerald Combs 4bbbc326c6 Reduce the contrast for many of the rules. Most of the color values were
taken from http://emilis.info/other/extended_tango/ .

svn path=/trunk/; revision=45350
2012-10-06 19:27:48 +00:00
Anders Broman b2eab3e0d4 From Michal Labedzki:
Bluetooth: fix order of colors

For Bluetooth each color is assigned to dissector,
but higher position on that list is needed for meet encapsulation
requirements, for example AVRCP is on top of AVCTP,
AVCTP is on top of L2CAP, etc.


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=45122
2012-09-25 08:10:09 +00:00
Anders Broman 3bc8e5ff68 From Michal Labedzki:
Add Bluetooth Profile AVRCP. Supported version: 1.5.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740

svn path=/trunk/; revision=45099
2012-09-24 12:46:30 +00:00
Anders Broman b6360ae35a From Michal Labedzki:
Bluetooth: Add colorfilter for SAP dissector.


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715

svn path=/trunk/; revision=45098
2012-09-24 12:35:45 +00:00
Anders Broman 577dec01c5 From Michal Labedzki:
Add Bluetooth Protocol AVCTP. Supported version: 1.4.


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7675

svn path=/trunk/; revision=45097
2012-09-24 12:30:30 +00:00
Anders Broman 9795ec3534 From Michal Labedzki:
Bluetooth: Add color for HID dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=44897
2012-09-14 11:30:07 +00:00
Anders Broman 0a21adec4b From Michal Labedzki:
Add Bluetooth Protocol BNEP. Supported version: 1.0.

I changed offset to be an int to follow WS convention.While at it I changed other types to fit the tvb_get routines.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7719

svn path=/trunk/; revision=44894
2012-09-14 11:02:24 +00:00
Jakub Zawadzki 8de84bacaf Revert r44869
svn path=/trunk/; revision=44878
2012-09-11 12:05:53 +00:00
Pascal Quantin 4d339f040e Use correct protocol name for Bluetooth Handsfree color filters
svn path=/trunk/; revision=44869
2012-09-11 07:35:59 +00:00
Anders Broman 4c3e0d28de From Michal Labedzki:
Bluetooth: Add colors for Bluetooth dissectors

Add color for: HCI_CMD, HCI_EVT, SCO, L2CAP, RFCOMM, HFP and OBEX.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=44834
2012-09-10 11:52:44 +00:00
Jeff Morriss beef3c0791 From Stephen Donnelly via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7500 :
The default colorfilter for "Bad Checksum" does not include the Ethernet Frame
Check Sequence (FCS) test.

It seems reasonable that it should be included in this filter rule. It is only
indicated if the Ethernet dissector "Validate the Ethernet checksum if
possible" preference is set and the FCS is believed to be present (via wiretap
heuristic/dissector preference).


From me: re-order the list of bad checksum fields.

svn path=/trunk/; revision=44010
2012-07-25 20:27:46 +00:00
Chris Maynard 94159d5d0e Don't colorize TCP window updates as "Bad TCP". This change was made in response to a user request at Sharkfest '11.
svn path=/trunk/; revision=37836
2011-06-29 18:45:14 +00:00
Jeff Morriss 53e5c3422c Add default color filters for SCTP abort messages and checksum errors.
svn path=/trunk/; revision=36944
2011-04-29 01:28:28 +00:00
Jeff Morriss 5695d835f5 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 :
A small patch to add color rules for ICMPv6 Error (some error as ICMP(v4)..)

With this patch, Wireshark is ready for IPv6 Day ;)

svn path=/trunk/; revision=35611
2011-01-21 17:12:02 +00:00
Jaap Keuter c084355412 From Chris Maynard:
Take into account PIM protocol specifics with regards to TTL when colorizing packets.

svn path=/trunk/; revision=31807
2010-02-05 22:39:14 +00:00
Jaap Keuter 118a07bfde From Steve Karg:
Corrected the size of the for-loop counter declaration, added expert info and checksum_[good|bad] flags.
Added the MS/TP checksum bad setting to Checksum color filter.

svn path=/trunk/; revision=27670
2009-03-09 06:04:00 +00:00
Stig Bjørlykke 500b9039bd Use same coloring rule for icmp and icmpv6.
svn path=/trunk/; revision=27557
2009-02-26 21:30:33 +00:00
Stig Bjørlykke e2555e1176 Removed colorfilters for infiniband, as this dissector is not available when
building/running without plugins.

svn path=/trunk/; revision=26710
2008-11-06 16:11:30 +00:00
Anders Broman de0ca39861 From Stephen Donnelly:
Infiniband Dissector Plugin 1.2.0

svn path=/trunk/; revision=25876
2008-07-30 15:47:11 +00:00
Stig Bjørlykke da2f447a9b Note to self: read documentation first.
Reverted previous change...

svn path=/trunk/; revision=25353
2008-05-22 12:04:03 +00:00
Stig Bjørlykke de74a63802 Fix multicast address for "TTL low or unexpected".
svn path=/trunk/; revision=25352
2008-05-22 11:41:00 +00:00
Jaap Keuter 1afba5344f Fix for Bug 2151:
Mask out all multicast addresses by their prefix, which is 4 bit wide i.s.o. 24 bit

svn path=/trunk/; revision=23990
2008-01-03 07:05:05 +00:00
Stig Bjørlykke 92e15d965c Cosmetic change to order the icmp.type
svn path=/trunk/; revision=23533
2007-11-21 19:00:20 +00:00
Bill Meier 7c72f71f96 On 2nd thought: change color filter name from "Low TTL" to "TTL low or unexpected"
svn path=/trunk/; revision=22717
2007-08-28 21:24:34 +00:00
Bill Meier ac04f94a3d From Todd Martin: "Flag IP TTL more intelligently".
Also: Change default "Low TTL" color filter to match.

svn path=/trunk/; revision=22715
2007-08-28 20:58:50 +00:00
Stephen Fisher 3785851d84 Add checksum verification to the CDP dissector and add an entry for this
in the main colorfilters file.


svn path=/trunk/; revision=20134
2006-12-14 03:34:26 +00:00
Ulf Lamping 68187697a0 make the checksum fields visible for TCP and UDP
svn path=/trunk/; revision=19727
2006-10-29 13:53:07 +00:00
Jaap Keuter 4e01adf36e Do it properly now: "ipx || stx" -> "ipx || spx"
svn path=/trunk/; revision=18620
2006-06-30 08:05:10 +00:00
Jaap Keuter ed916f056b From Stephen Fisher:
The default colorfilters file in Wireshark has an entry titled IPX.  It
matches "ipx || stp" which should probably be "ipx || spx".

svn path=/trunk/; revision=18618
2006-06-30 05:59:06 +00:00
Ronnie Sahlberg f0b33a4789 ethereal->wireshark updates
svn path=/trunk/; revision=18206
2006-05-22 08:14:01 +00:00
Gerald Combs 22b9245605 Add redirects to the ICMP filter.
svn path=/trunk/; revision=17284
2006-02-13 20:11:43 +00:00
Jörg Mayer 4a9a14f2c6 - Add checksum verification
- Add checksum check to colorfilters


svn path=/trunk/; revision=15563
2005-08-27 05:33:50 +00:00
Ulf Lamping 8615ff5f80 fix #378:
use "ip.checksum_bad == 1" instead of simply "ip.checksum_bad" in the example colorfilter file, as the implementation of that filter string changed

install the global example files unconditionally by the win32 installer, to fix this problem and be compatible with the unix install process

svn path=/trunk/; revision=15535
2005-08-26 00:01:49 +00:00
Ulf Lamping eba6c1a70f fix a syntax error in the "Routing" rule, reported by Jeff Morriss
svn path=/trunk/; revision=14898
2005-07-11 20:14:43 +00:00