Commit Graph

82297 Commits

Author SHA1 Message Date
Chuck Craft 1998e7f34b capinfos: man page typos; add longopts to Usage:
The verbiage for first/last packets and start/end times seem
to not be consistent. Changing will also require a change to
Capture File Statistics in the Wireshark Gui. Future MR.
2021-10-12 20:35:15 +00:00
David Perry fd076e6ca8 Proposed rewording of filter tooltips
For #16186. Proposed changes to the tooltips which appear when a filter
expression is potentially problematic.

Rename references to "User's Guide" to "Help" since the link to the
User's Guide in the Help menu is just called *Contents*.

Name specific sections within the help which pertain to the warning
tooltip being shown. Gives first-time users some help in finding the
right part of the sizeable User's Guide.
2021-10-12 06:54:25 +00:00
Chuck Craft fefad2e7cf dumpcap: double received count when using threads
Closes #17089
2021-10-12 06:37:46 +00:00
John Thacker 634650f1e4 TCP: Follow: Don't treat placeholder value 0 as a real ACK number
Since the wraparound aware GT_SEQ is used, passing in 0 for the
ACK number can result in thinking that bytes are missing and
dropping frames from the follow stream tap.
2021-10-12 04:09:11 +00:00
Eugene Adell f6b0de6b12 TCP: Port reuse ends with false Retransmissions
In rare circumstances when a connection could not established on
the first try, succeeding in establishing it later would generate
many Retransmissions. Closes 17616.
2021-10-12 03:52:01 +00:00
Gerald Combs ed98abe208 BT-DHT: Exit a loop.
Always make sure our offset advances in dissect_bencoded_list.
Fixes #17651.
2021-10-12 03:35:32 +00:00
Gerald Combs 643fbe52ae Docs: Use Asciidoctor to copy ws.css.
Use the `copycss` attribute in the release notes and FAQ to copy ws.css
to the right location.
2021-10-12 01:02:53 +00:00
João Valverde 07371d4557 dfilter: Split tostr() into debug and pretty print 2021-10-11 21:55:45 +00:00
João Valverde 5dd90e3b30 dfilter: Cache stnode_tostr()
This avoids having to save/free the pointer for each tostr()
invocation (or leak memory).
2021-10-11 21:55:45 +00:00
Guy Harris c2b6a27e97 autosar_nm: get rid of unused protocol IDs.
We fetch the protocol IDs for several protocols, but use none of them.
Get rid of them.
2021-10-11 20:44:41 +00:00
Balint Reczey 9f92da75b8 wsutil: Provide static inline g_memdup2 in glib-compat.h to not export it
Shared libraries should not export symbols exported by other libraries to avoid
collisions.

Fixes #17645.
2021-10-11 21:51:35 +02:00
Lin Sun fdd1a82ed9 packet-btmesh: fix build without GCRYPT 2021-10-11 19:10:41 +00:00
João Valverde 5481bffa5c proto: Check for reserved keywords in filter names 2021-10-11 19:15:26 +01:00
Gerald Combs 11c58e78f7 Qt: More new-style signals+slot conversions. 2021-10-11 17:03:21 +00:00
Gerald Combs e5bcf6b402 Qt: Use new-style signals+slots in more places. 2021-10-11 16:32:49 +00:00
Dr. Lars Völker 7f9b8874b5 BPSEC, BPv7, COSE: Bugfix MacOS build
The usage of PRIi64 and PRIu64 may lead to failed builds on MacOS - at
least it did for me.

This patch fixes this.
2021-10-11 11:58:23 +02:00
Chuck Craft 92ab6d0704 Rawshark: is not a CamelCase word 2021-10-11 08:03:31 +00:00
Martin Mathieson a5df18e51e Fix some spelling errors 2021-10-11 04:44:49 +00:00
Gerald Combs ab34ebbc7b [Automatic update for 2021-10-10]
Update manuf, services enterprise numbers, translations, and other items.
2021-10-10 23:00:00 +00:00
João Valverde 041aa24a37 ftypes: Rewrite FT_PROTOCOL comparison operator
For efficiency do the comparison in a single function call
instead of trying to preserving exactly the previous semantics.

Still I tried not to deviate much.
2021-10-10 20:48:29 +00:00
João Valverde 13e9e7199c ftypes: Use an order function to compare ftypes
All the order operators can be defined in terms of 'lt'
and 'eq' so use that to reduce the number of required
methods from 6 to 2.

Further reduce to one by combining those two into a single
function that has memcmp semantics: negative return is
"less than", positive is "greater than" and zero is equal.
2021-10-10 20:48:29 +00:00
Gerald Combs 6299a66a92 Revert "GitLab CI: Add an "Update Numbers" job."
This reverts commit f773bb4391. Maybe some
other time.
2021-10-10 20:32:28 +00:00
Dr. Lars Völker 9aa87dae84 TECMP: Bugfix: TECMP should not decode NULL frames
Null frames are frames with invalid data. This patches makes sure that
the invalid data is not further dissected.

Closes #17644

Bug present since Wireshark 3.4.
2021-10-10 20:16:13 +00:00
Dr. Lars Völker 0d276b47d1 AUTOSAR NM: Bugfix: wrong filters for user defined elements
When UDP-NM was renamed into AUTOSAR-NM (as well as filename changed)
the author of that patch missed the dynamic filters. This patch fixes
this oversight and makes sure all filters of AUTOSAR NM start with
"autosar-nm.".

Fixes #17643
2021-10-10 20:00:15 +00:00
Balint Reczey ba4bec7d09 debian: Report upstream and package version instead of git revision 2021-10-10 19:26:17 +00:00
Balint Reczey 6617c7fc5d debian/rules: Don't pass --parallel to dh, it is the default now 2021-10-10 19:26:17 +00:00
Balint Reczey a1d964fa1c debian/rules: Turn on BUILD_corbaidl2wrs to ship idl2wrs man page 2021-10-10 19:26:17 +00:00
Balint Reczey a9c1d1ac9e debian: Bump compat level to 12 keeping backports in mind 2021-10-10 19:26:17 +00:00
Balint Reczey d87bc0d74d debian/control: Drop Conflists: and Replaces: referring to very old versions 2021-10-10 19:26:17 +00:00
Balint Reczey d74afba1f1 debian: Make wireshark depend on the same version of wireshark-qt 2021-10-10 19:26:17 +00:00
Balint Reczey aed6c130b9 debian/copyright: Fix typo and remove patterns for removed files 2021-10-10 19:26:17 +00:00
Gerald Combs 51e1381b23 Tools: Quote some elements in html2text.
Quote <code> spans with backticks and <span class=menuseq> spans with
double quotes.
2021-10-10 13:47:45 +00:00
Brian Sipos ce0592514c BPv7: Add Bundle Protocol version 7 and BPSec dissectors from dtn-wireshark 2021-10-10 13:27:17 +00:00
John Thacker 35d09a7854 BT-DHT, BT-uTP: Use conversation_set_dissector_from_frame_number
Since the UDP connection switches back and forth between DHT and uTP,
use conversation_set_dissector_from_frame_number so that the dissector
called by try_conversation_dissector in packet-udp.c doesn't change for
a given frame based on the last packet clicked in the GUI.

Split out a heuristic dissector from uTP so that conversation_set_dissector
is only called from the heuristic dissector.

This doesn't make a difference when the heuristics are accurate but
might in some edge cases.
2021-10-10 11:31:06 +00:00
David Fort faf6fabfe3 rdpudp: update parsing of AckVec packets to last spec
Last version of MS-RDPEUDP2 has detailled the interpretation of ackvec packets. The
patch also adds the interpretation of ack vector items (bitmap or RLE encoded).
2021-10-10 09:59:44 +00:00
Dr. Lars Völker 08a8429125 TECMP: Bugfix wrong payload length for payloadtvb
The TECMP dissector did not set the length to the correct value but by
accident just used all bytes present. This is not correct.

This bugfix is for Wireshark 3.4 and newer.

Closes #17638
2021-10-10 06:49:22 +00:00
Dr. Lars Völker a534b7aed0 ISO15765: Bugfix, LIN config influenced CAN
This patch fixes the update_config routine, which turned off the CAN
config, when LIN diagnostic frame parsing is deactivated.

Closes #17639
2021-10-10 06:33:15 +00:00
Gerald Combs f9d3b9d51a Qt: Remove more Q_OBJECT macro calls. 2021-10-09 17:07:03 -07:00
Gerald Combs f26ef902b2 GitLab CI: Initial macOS Intel build.
Add a "macOS Intel Package" job to .gitlab-ci.yml.
2021-10-09 09:32:32 -07:00
John Thacker ac9e95acca BT-uTP: Strengthen heuristic
Strengthen the heuristic, including fixing a typo, disabling via
preference the pre-release "Version 0" of the protocol that hasn't been
supported by any clients for a decade, and putting a limit on the maximum
window size by default via preference. This might be enough to enable it
by default, but hold off on doing so for until more testing.

Also fix a couple of typos and add unit strings.
2021-10-09 13:06:44 +00:00
Chuck Craft 48e740f8e4 text2pcap: typo on Help -> Manual Pages 2021-10-09 02:46:01 -05:00
Gerald Combs f773bb4391 GitLab CI: Add an "Update Numbers" job.
Add an "Update Numbers" job that updates our various "numbers",
translations, and other files.
2021-10-08 15:34:26 -07:00
Chris Caldwell ee6d020288 OptoMMP: Added expanded memory ranges and descriptions.
Added the expanded memory ranges and descriptions as found in Opto 22's document on the OptoMMP Protocol Guide at: https://documents.opto22.com/1465_OptoMMP_Protocol_Guide.pdf
Removed trailing new-line at end of file.
2021-10-08 20:25:40 +00:00
João Valverde 2c701ddf6f dfilter: Improve grammar to parse ranges
Do the integer conversion for ranges in the parser. This is more
conventional, I think, and allows removing the unnecessary integer
syntax tree node type.

Try to minimize the number and complexity of lexical rules for
ranges. But it seems we need to keep different states for integer
and punctuation because of the need to disambiguate the ranges
[-n-n] and [-n--n].
2021-10-08 19:18:56 +01:00
João Valverde 9d87c4712e dfilter: Fix parsing of value strings
If we have a STRING value in an expression and a numeric comparison
we must also check if it matches a value string before throwing
a type error.

Add appropriate tests to the test suite.

Fixes 4d2f469212.
2021-10-08 18:53:15 +01:00
John Thacker 39e0b3155f RPC: Don't defragment without the entire fragment
If the RPC dissector doesn't have all the bytes of the a fragment
and thus needs to do TCP desegmentation, but can't or won't for some
reason, then don't try to defragment either, regardless of what the
defragmentation preference says.  Fix #11198.
2021-10-08 06:10:46 +00:00
Chuck Craft 9371f102c8 NEWS: tshark folders; WSUG and download page links 2021-10-08 05:54:12 +00:00
John Thacker 3757b69f2d lisp: convert get_addr_str to use pinfo->pool 2021-10-08 04:17:28 +00:00
João Valverde 92285e6258 dfilter: Improve grammar to parse functions
A function is grammatically an identifier that is followed by '(' and ')'
according to some rules. We should avoid assuming a token is a function
just because it matches a registered function name.

Before:
  Filter: foobar(http.user_agent) contains "UPDATE"
  dftest: Syntax error near "(".

After:
  Filter: foobar(http.user_agent) contains "UPDATE"
  dftest: The function 'foobar' does not exist.

This has the problem that a function cannot have the same name
as a protocol but that limitation already existed before.
2021-10-08 04:01:24 +00:00
João Valverde db85625af9 dfilter: Rewrite ws_assert_magic() again 2021-10-08 04:01:24 +00:00