RTP has two dissector tables, one directly associated with payload types, and
one which is associated with strings that appear in SDP commands. This makes
all dissectors that are registered as a dynamic payload type that can be
configured by SDP appear as a Decode As option for the RTP PT table.
Some protocols were registered in the table for configuration by SDP but
had no way to register with the rtp.pt table. These include EVRC, H.223,
and v150fw.
Other protocols had a long standing preference to set a dynamic payload type,
but they still did not appear in the Decode As menu unless that preference
was changed from the default, largely because of the way that the preference
was not actually registered with the rtp.pt table unless it had a value in
the dynamic payload type range. These include EVS, H.263P, H.264, H.265,
ISMACryp, IuUP, LAPD, MP4V-ES, RTP-MIDI, and VP8.
RFC 3551 says that not just the dynamic payload types, but also the unassigned
and even the statically assigned payload types MAY be dynamically reassigned as
necessary, so this patch also allows these preferences to be set for payload
types less than 96. The only payload type not allowed is 0 (which RFCs 3551 and
7007 say must be μ-law PCM), which is handy anyone for backwards compatibility
with preferences that used to be uints (where 0 meant disabled.)
All protcols which formerly used a uint preference are all converted to a
range preference, and the text is changed to be similar for each. This works
in a backwards compatible fashion, and any defaults are maintained.
The patch also adds some of the dissector variants as PINOs so that they will
show up with distinct names in the Decode As menus, and changes some of the
protocol short names so that the entry in Decode As is clearer and matches
what is used for other similar protocols.
Change-Id: I68627b5c3e495d9fc813d88208f3b62e47e0c4de
Reviewed-on: https://code.wireshark.org/review/37396
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Two things were broken with command 77 decoding:
1. There's an additional byte in the request, which is not present in
the response, so the offsets where misplaced for all requests by one.
2. The embedded command (like all the other HART pass-through commands)
distinguishes between long and short addresses, depending on the
delimiter byte in front. When using that long address (which is the
usual thing for all embedded commands except command 0) the remaining
fields where also displaced.
Both points lead to obviously broken decoding due to misplaced offsets.
Fixes: 0ee1445ada ("Improve HART dissector")
Signed-off-by: Alexander Dahl <ada@thorsis.com>
Change-Id: I4355fe73b5164a4f03e522127ed487749279da65
Reviewed-on: https://code.wireshark.org/review/37411
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
There was a problem in FETCH response parsing when the server had more data than the requested
maximal return size. In such case the server checks if the first chunk of data fits into buffer. If it does not,
the first chunk is returned as a whole to the requestor. Otherwise it is assumed that the client is capable
of discarding invalid content and the server pushes maximum available block. It makes sense, because
the default block is 10MB and pushing it opaque leverages zero-copy IO from the file system to the network.
In the existing implementation it was assumed that the last batch is aligned with the end of the buffer.
Actually, if there is some data more, the last part is delivered truncated.
This patch:
* fixes the last part alignment handling
* adds opaque field for truncated content
* moves preferred replica field to the proper context
Bug: 16623
Change-Id: Iee6d513ce6711091e5561646a3fd563501eabdda
Reviewed-on: https://code.wireshark.org/review/37446
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This feature introduced in V15.5.0 allows to have up to 15 DRBs by
adding LCID 32 to 38
Change-Id: I4442e26d115efe484eda4f2d8921483cf4278b99
Reviewed-on: https://code.wireshark.org/review/37462
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Add an option of '-x' to tools/cppcheck.sh to support XML output.
Change-Id: I2921d7cd57ee9c925419247a0238b572f637c854
Reviewed-on: https://code.wireshark.org/review/37424
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Use the raw value for the block "More Flag", not the already adjusted one.
Change-Id: I13ddd24c4f9b9201798d18abe008945879f03774
Reviewed-on: https://code.wireshark.org/review/37442
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Add an option to list our allowed licenses.
Remove a couple of GTK+ entries while we're here.
Change-Id: I1c8cf3314cff369766f1ba25438f16c69f42a1ba
Reviewed-on: https://code.wireshark.org/review/37409
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Remove #defines not needed in any part of the sourcecode
Change-Id: I042ed4ae5750c07e3316b9a18516359213cf7998
Reviewed-on: https://code.wireshark.org/review/37438
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Mark the "Reassembled in" link item as generated.
Change-Id: Id8f7b26cf77aa5bc82de07799bb1468c8b8a4209
Reviewed-on: https://code.wireshark.org/review/37441
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
On Windows, cleaning up the filename inside the zip
failed due to the backslash not properly being recognized.
This lead to profiles, which could not be imported on another
machine, if the filename contained a path not existing there.
Bug: 16608
Change-Id: Ib30b2370e30c30ac60f283edf6376c07258c25b6
Reviewed-on: https://code.wireshark.org/review/37437
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Found by Rajan Vijayaraghavan
Bug: 16610
Change-Id: Iac4888d53fa282e7e73fb75b0d58a3a568e094b9
Reviewed-on: https://code.wireshark.org/review/37384
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
5GSM cause (9.11.4.2) is using TV format
in PDU session modification request messgae
based on 24.501/chapter 8.3.7.1
Change-Id: I7e072e2b4c3422ec75e8bcebebb534905028eb2a
Reviewed-on: https://code.wireshark.org/review/37433
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
No Internet-style checksumming is done here, so we don't need
epan/in_cksum.h.
Change-Id: Ib125d155f46a4b6168fb910fd7265f0878bda3e0
Reviewed-on: https://code.wireshark.org/review/37431
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
ip_checksum_tvb() does the exact same thing shim6_checksum() does;
there's no need for the shim6 dissector to have its own version.
(Perhaps ip_checksum_tvb() didn't exist at the time shim6_checksum() was
written.)
Change-Id: I015f5f0a6e45d6ac125250bf7071a6aa7caeef7b
Reviewed-on: https://code.wireshark.org/review/37429
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
Clean up other stuff while we're at it.
Change-Id: Ia544df0b0c9549cb28944b15c6e84ee0700dd08e
Reviewed-on: https://code.wireshark.org/review/37423
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
Do as we do elsewhere; use proto_tree_add_none_format().
(Should this be done with an expert info?)
Change-Id: I7f4514b6f4b6687b21c1912292f1153593bf8440
Reviewed-on: https://code.wireshark.org/review/37416
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
fix the wording in one place, remove an obsolete comment nearby
Change-Id: I1df9078366f460cd8a3cbe00f96806c97b05f8a0
Reviewed-on: https://code.wireshark.org/review/37415
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Callers of this function (such as packet-btatt) can pass usb_conv_info = NULL.
In this case just skip the storing of the report.
Bug: 16589
Change-Id: I29e7a15d20def5ce90aa3e1b1b3b960f11949e59
Reviewed-on: https://code.wireshark.org/review/37368
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Filipe Laíns <lains@archlinux.org>
Reviewed-by: Tomasz Moń <desowin@gmail.com>
Detected using a messy modification to CHECK_HF_VALUE(), which
runs when ENABLE_CHECK_FILTER is defined. There are doubtless more,
but finding specs is often hard and time-consuming.
Change-Id: Ifae3fa0d2361e15c71a3e26ad22536dbed0ca246
Reviewed-on: https://code.wireshark.org/review/37406
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Use more accurate terminology.
Change-Id: Ie753010640ee831650e408d0989971741e43ba70
Reviewed-on: https://code.wireshark.org/review/37399
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The scopes used by wmem_map_new_autoreset and wmem_tree_new_autoreset
store the metadata and data for each structure. Use those terms instead
of "master" and "slave".
Change-Id: I3b7c958b4caf3a1245e680f5ca960431b75ad5be
Reviewed-on: https://code.wireshark.org/review/37398
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
"Allowed" is a perfectly fine, non-biased word for designating things
that are allowed.
Change-Id: Ia1e0642a073210f0475fba3d437eac654ec36cb5
Reviewed-on: https://code.wireshark.org/review/37397
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Update the list of PIM Hello options based on the current IANA list
of PIM parameters.
Bug: 16614
Change-Id: I4147362ae554423bcc118f72c1ff43034ba3fb63
Reviewed-on: https://code.wireshark.org/review/37389
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Check for btle_context before accessing it.
Bug: 16612
Change-Id: I8ad0237a6f742f4091e886b0151917542d2eea82
Reviewed-on: https://code.wireshark.org/review/37387
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
SM PDU DN request container (9.11.4.15) is using TLV format
in PDU session establishment request messgae
based on 24.501/chapter 8.3.1.1
Change-Id: I9a85b321c051b798a207fdf251a273c1e7a5490e
Reviewed-on: https://code.wireshark.org/review/37386
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
The added header is UDP, like in DTLS, and unlike all other
protocols which have IP+UDP.
Simplify also DTLS handling while at it.
Change-Id: Ie76a19087991c4f5c0d16586b67aaab69d0c5aaf
Reviewed-on: https://code.wireshark.org/review/37378
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
John Thacker