Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Reviewer: daniel <1000008@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
daniel 2019-02-22 12:16:10 +00:00 committed by Gerrit Code Review
parent a6f87131ad
commit c7911a5183
1 changed files with 24 additions and 0 deletions

View File

@ -22,6 +22,30 @@
"revId": "0199f6caf17ddda1b6d14d580c502439011a8ca3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "adf76285_453e96b8",
"filename": "doc/examples/osmo-sysmon.cfg",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 1000008
},
"writtenOn": "2019-02-22T12:16:10Z",
"side": 1,
"message": "I\u0027m on the fence on this one. On one hand example.com does resolve and ping, so we can tell that we have a connection to the internet. On the other hand the example should choose sane defaults that work for most people and I would guess most would want to change this line.\n\nSo having it commented out would be good - I\u0027d rather not have an (active) ping in here that doesn\u0027t even resolve.",
"parentUuid": "97953d3b_8f6a951a",
"range": {
"startLine": 14,
"startChar": 5,
"endLine": 14,
"endChar": 16
},
"revId": "0199f6caf17ddda1b6d14d580c502439011a8ca3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
}
]
}