mirror of https://gerrit.osmocom.org/osmo-sysmon
51 lines
2.0 KiB
Plaintext
51 lines
2.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "97953d3b_8f6a951a",
|
|
"filename": "doc/examples/osmo-sysmon.cfg",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 1000147
|
|
},
|
|
"writtenOn": "2019-02-22T10:00:13Z",
|
|
"side": 1,
|
|
"message": "Is there any downside if we comment out that line by default?\n\nIt would be unexpected for me from a user\u0027s perspective, if I ran the example config, and it started pinging a random server on the Internet. That\u0027s why I recommended a domain that will never resolve in my comment on the first patch set.\n\n(With that being said, I don\u0027t really know how to use osmo-sysmon - there seems to be no README/wiki page/pdf docs about it yet.)",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 5,
|
|
"endLine": 14,
|
|
"endChar": 16
|
|
},
|
|
"revId": "0199f6caf17ddda1b6d14d580c502439011a8ca3",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "adf76285_453e96b8",
|
|
"filename": "doc/examples/osmo-sysmon.cfg",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2019-02-22T12:16:10Z",
|
|
"side": 1,
|
|
"message": "I\u0027m on the fence on this one. On one hand example.com does resolve and ping, so we can tell that we have a connection to the internet. On the other hand the example should choose sane defaults that work for most people and I would guess most would want to change this line.\n\nSo having it commented out would be good - I\u0027d rather not have an (active) ping in here that doesn\u0027t even resolve.",
|
|
"parentUuid": "97953d3b_8f6a951a",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 5,
|
|
"endLine": 14,
|
|
"endChar": 16
|
|
},
|
|
"revId": "0199f6caf17ddda1b6d14d580c502439011a8ca3",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |