Commit Graph

1139 Commits

Author SHA1 Message Date
Oliver Smith 9223287228 repo-install-test: sort centos pkgs from repoquery
Apparently the output of repoquery isn't always sorted, it started
failing on jenkins after moving the test inside qemu. Add an explicit
sort.

Fix for:
  + comm -23 osmocom_packages_all.txt blacklist.txt
  comm: file 1 is not in sorted order

Related: OS#5365
Change-Id: Icb00df102555e06b66b1c2597488b625e3c77f1c
2022-12-09 11:56:03 +01:00
Oliver Smith c551a3c297 repo-install-test: print osmocom_packages_all.txt
While I'm developing this, Jenkins is currently failing here. Make it
easier to debug this by printing the file contents.

Related: OS#5365
Change-Id: Ifbf4ca7f49c1f4441f84695aea0936515e01ffd4
2022-12-09 11:56:03 +01:00
Oliver Smith d5106e3d25 jobs/repo-install-test: adjust for qemu
Related: OS#5365
Change-Id: Ie7675811d1a5d6b7cf7e4378c86d747ef6f7a249
2022-12-09 11:56:03 +01:00
Oliver Smith 9f68d7d370 repo-install-test: update test_binaries
Related: OS#5365
Change-Id: Iaad0260b5872d29b41a97aac3ea5ba0af81c6adb
2022-12-09 11:56:03 +01:00
Oliver Smith 36215cfff2 repo-install-test: fix osmo-trx-usrp1 check
The DISTRO variable is either debian10 or debian11, fix the broken
check. This condition is there in the first place, because we don't
build the usrp1 backend for centos8.

Change-Id: I987f27db257961faf06824df2dcc8f9db1fedccf
Related: OS#5365
2022-12-09 11:56:03 +01:00
Oliver Smith f5bd274018 repo-install-test: update services list
Add services from new projects and enable previously disabled services,
now that this test runs in qemu and services have more permissions like
setting realtime priorities.

Related: OS#5365
Change-Id: Iec7db433cac4c77226e0f1ae2ba502de0d1a8a2b
2022-12-09 11:56:03 +01:00
Oliver Smith ed2d877bc6 repo-install-test: fix check for Release.key
$release_key is not defined, replace it with the path.

Change-Id: I6bd13cc6149db1f2ba25ef1ee343115d3c53cf3b
2022-12-09 10:55:15 +00:00
Oliver Smith aae43b731f repo-install-test: add SKIP_PREPARE_VM env var
Change-Id: I96c7aef70d9d2c6318ce4e43c24450461bc00d91
2022-12-09 10:55:15 +00:00
Oliver Smith 048492d1c8 repo-install-test: run inside qemu + kvm
Change repo-install-test to run inside of qemu instead of docker. This
job needs to run systemd to verify that the systemd services start up
properly. Running systemd inside docker was never officially supported,
it worked with cgroups1 but does not work anymore with cgroups2.

An alternative approach was running inside podman instead of docker
(running systemd inside of podman is officially supported). However we
would have needed various workarounds with podman and wouldn't be able
to test all Osmocom systemd services in the end, due to lack of
permissions (see review of I394918fc61de36acce65ffb33defcb8fc21801c4).

By running with a separate kernel inside qemu we can run all Osmocom
services.

Related: OS#5365
Change-Id: Ie7f1bccb05779cb3614016c0b965b810bbb1471b
2022-12-09 10:55:15 +00:00
Oliver Smith d198fe6b38 Cosmetic: repo-install-test: sort env vars comment
Related: OS#5365
Change-Id: Ic21b46e614c7bfd8e0306599b4d33a1b963db376
2022-12-09 10:55:15 +00:00
Oliver Smith 47dde8559f ansible: add rules to install qemu images
Prepare to run repo-install-test inside qemu with kvm instead of
docker, see following patches.

Related: OS#5365
Change-Id: Ia7626fcd397d32e1180e320d4a76a65bcad01b7b
2022-12-09 10:55:15 +00:00
Oliver Smith 21a641d6c2 scripts/docker-cleanup: remove fallback code
Remove the fallback clean up code, as it also may lead to images getting
removed right before we need to use them. Besides that, it should be
dead code by now since docuum should be running on all our jenkins nodes
to clean up old images based on last use date.

Change-Id: I9ca0c2ba245bdd75d9fb8eaf341055e8c2ab1b55
2022-12-09 10:40:58 +01:00
Oliver Smith a7df704d4d scripts/docker-cleanup: fix timing problems
Don't delete images while they are being used, to fix these errors we
see from time to time in the middle of "docker build" on jenkins:
unknown parent image ID sha256:1b072e35048cd8b680eddabdc641ac678edb1184d222d5e7b3fbe0b3c333129a

This happens because "docker build" creates so-called dangling images
for each step processed of a Dockerfile. The "docker system prune" call
deletes these dangling images (among other things).

Remove the "docker system prune" call. We already have the docuum daemon
to deal with unused images (dangling and not dangling), it removes them
based on last use date so that the used space is always below a
configured limit. As it deletes images that haven't been used the
longest when it reaches the limit, it will not result in the problem
explained above.

Besides images, "docker system prune" also removes unused containers
(instances of images created with 'docker run' without --rm) and
networks. Add "docker container prune" and "docker network prune"
commands to remove them from now on.

Also remove the redundant container removal logic (previous it was
redundant with "docker system prune", now redundant with "docker
container prune").

Related: https://docs.docker.com/config/pruning/
Change-Id: Ia1b466eea43dd135373949e8e3e6b005c169ea0c
2022-12-09 10:40:33 +01:00
Oliver Smith 4fe56c0968 obs: build_deb/rpm: show contents after build
After building packages with the OBS scripts, show their contents. This
allows easy checking if config files were correctly packaged etc. By
adding it here, it will also show up at the end of the related jenkins
jobs for gerrit verifications.

Related: OS#5817
Change-Id: Ie30b07f35f7e41990fa352523427d86458291d4d
2022-12-08 15:42:59 +01:00
Oliver Smith 54a36bcb7d ansible/podman: install from debian repos
Podman is in the official debian repositories since debian 10, install
it from there instead of using a third-party repository.

Related: OS#5365
Change-Id: I01549915d2c8dfda5fa605a014a304229c3078f0
2022-12-08 13:04:31 +00:00
Oliver Smith 5d3fb63b3d jobs/README: modernize
Remove outdated debian 9 related information, update section on labels.

Change-Id: I6616f4bdacc90c295db7996855e9aa2b48172b43
2022-12-06 11:17:16 +01:00
Oliver Smith 3b5464d0ed jobs: retire osmocom-gerrit-debian* labels
Let the gerrit-binpkgs and gerrit-pipeline-result jobs use the
"osmocom-gerrit" label. Having the -debian10/11 label previously was
useful to make sure this doesn't run on an ancient python version that
fails on f-strings. But since the debian9 builders were retired, this is
not needed anymore. These are the only jobs that used these, so now the
labels in the README can be simplified (following patch).

Related: OS#5793
Change-Id: Ieee95d25e036dcd4869d89b10c281179024672e7
2022-12-06 11:17:16 +01:00
Oliver Smith fd7c88e992 jobs/update-osmo-ci: remove deb9 nodes
Related: OS#5793
Change-Id: Id2bf3c273848c1de12a3dce3bc007dd205bf4af7
2022-12-06 11:17:16 +01:00
Oliver Smith 9bdd99b2ff ansible/hosts: remove debian 9 lxcs
Related: OS#5793
Change-Id: I465d93e5254ba2f65796fcfb62ea1063a0eb72c6
2022-12-06 11:17:16 +01:00
Oliver Smith 0428da0f6d jobs/osmo-gsm-tester virtual: fix permissions
The docker container creates the trial dir and some files inside of it
as root, therefore the rm -rf trial-* line fails. Add logic to fix the
permissions before attempting to remove old trial-* and when the script
exits.

Related: OS#5793
Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62
2022-12-02 10:50:07 +01:00
Oliver Smith d5e0fe011d jobs/osmo-gsm-tester virtual: send mails on error
Change-Id: If91644a3dfea1af259f7a511a7784cf32d8d23ea
2022-12-01 16:41:10 +01:00
Oliver Smith 23cf9b4b05 jobs/osmo-gsm-tester: remove old test result early
The virtual osmo-gsm-tester has been failing for a long time, but the
test results were still green. This was because the job failed before it
removed old test results, and so those were used. Remove the old results
as early as possible to prevent this in the future.

Change-Id: I23f2f7b24fe41bbded2e05abbe6ea5e717b88e9e
2022-12-01 15:53:30 +01:00
Oliver Smith 4bd7da1c9d jobs/osmo-gsm-tester virtual: fix opts desciption
The default value is what it says in the line above, not empty.

Change-Id: I5ce8a47b43525dcca6bf54184a48f11b0c87c19e
2022-12-01 15:37:18 +01:00
Oliver Smith d3321f9434 jobs/osmo-gsm-tester virtual: don't limit to deb9
Related: OS#5793
Change-Id: I8e7ffa65b4ff6d1816ad167367b0f6ff8c00e64b
2022-12-01 15:04:38 +01:00
Oliver Smith ce5875fd07 jobs/osmo-gsm-tester virtual: fix docker img
Build the docker image right before using it, instead of building it in
another jenkins job update-osmo-ci-on-slaves via
osmo-ci-docker-rebuild.sh.

The logic in osmo-ci-docker-rebuild.sh was broken. I didn't realize at
the time that this image is only used for the virtual osmo-gsm-tester,
not the physical ones. But only the machines running the physical
osmo-gsm-tester have the /var/tmp/osmo-gsm-tester/state path. The
virtual osmo-gsm-tester isn't running on these machines but on generic
jenkins nodes.

Building the image right before using it makes sense for this job, as it
is the only user of the image. If it was already built from the same
Dockerfile, a cached version is used.

Fix for:
  Unable to find image 'osmocom-build/osmo-gsm-tester:latest' locally

Fixes: 9139e76b ("osmo-ci-docker-rebuild: don't always build osmo-gsm-tester")
Change-Id: Icad9459de1d3a3a4e65ecacf7f903433bb504cc9
2022-12-01 15:04:38 +01:00
Oliver Smith cc7af6cd5a jobs/osmo-gsm-tester virtual: use literal style
Use literal style instead of folded style in the shell argument of
osmo-gsm-tester_virtual as otherwise new lines behave unintuitively.

Related: https://yaml-multiline.info/
Change-Id: I862a0ed24bae2c713e857a459797e1a978df0560
2022-12-01 15:04:38 +01:00
Oliver Smith 3307a90691 jobs/osmo-gsm-tester virtual: fix default branch
Change it to "master" instead of "origin/master" to prepare for building
the docker image right before running it. The Makefile from
docker-playground.git picks up the OSMO_GSM_TESTER_BRANCH environment
variable and expects it to be in that format.

Change-Id: I4ad1ce71fd5b5b57a65267e0be51755f7495b07d
2022-12-01 15:04:38 +01:00
Oliver Smith 92b636d295 jobs/osmo-gsm-tester: clone from gerrit git url
Use the gerrit git url instead of the gitea one so we don't have a
sync delay.

Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure
Change-Id: I586fdd55ded6c3776cacd6760d88aa455da22990
2022-12-01 15:04:38 +01:00
Oliver Smith 6bb5f4ce84 hosts: update coverity-slaves
Remove the deb9 lxcs as they are being retired, and add two deb11 lxcs.
Coverity is quite big with 1.2 GiB, so deploying and upgrading this
takes some time. Having it on two hosts should be enough.

Related: OS#5793
Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0
2022-12-01 13:08:38 +01:00
Oliver Smith b0f36fe227 ansible/coverity: extract into subdirectory
The tarball provided by coverity doesn't have the same version in the
name as in the directory inside the tarball.

Tarball:
	cov-analysis-linux64-2022.06.tar.gz
Directory:
	cov-analysis-linux64-2022.6.0

Work around this by extracting it into a subdirectory and using glob to
match the directory name.

Related: OS#5793
Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b
2022-12-01 13:08:28 +01:00
Oliver Smith 8125b33b9a ansible: coverity: update version to 22.06
Coverity doesn't make the old version available for download and will
probably deprecate the previous version at some point. I'm about to
install it on new hosts, so upgrade to the latest version while at it.

Related: OS#5793
Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4
2022-12-01 13:08:07 +01:00
Oliver Smith fe8bc324d9 jobs/master-builds: more binaries ssh credentials
Make the binaries_ftp.osmocom.org ssh credentials available to more jobs
that need them.

Related: OS#5798
Change-Id: I4f719c6daba06dcfadd252a4030293bdc0e26337
2022-12-01 10:30:13 +01:00
Oliver Smith 2c6f249934 jobs/osmocom-release-tarballs: use any node
Prepare to retire build2-deb9build-ansible. With changes in the script,
it doesn't need a persistent workspace anymore, it skips building source
tarballs if they exist on the remote server.

Depends: docker-playground I4b8c149c9cdbe7c613eea5d9be15794de5e5ddce
Related: OS#5793
Change-Id: If56614caaa9c0c44419af596451d48c1970e9014
2022-11-30 17:46:57 +01:00
Oliver Smith 4546478c64 jobs/osmocom-release-tarballs: update clone url
Use gerrit.osmocom.org so we don't have a delay.

Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure
Change-Id: I4391016fda1584fa7d423521802458dca9b1b7ec
2022-11-30 17:46:57 +01:00
Oliver Smith 5f0876d674 jobs: don't limit to debian9
Related: OS#5793
Change-Id: Idcbbf766928964c4896aef7c6687ea7003203427
2022-11-30 17:46:57 +01:00
Oliver Smith 0aad1883f1 jobs: don't set node where it doesn't make sense
Remove the node attribute as these can run on any node. I've configured
the three deb11 nodes with "Usage: Use this node as much as possible"
instead of previously "Only build jobs with label expression matching
this node", so simply not specifying a node is now possible. Previously
it wouldn't have any node to run on as all of them were configured that
way.

Related: OS#5793
Change-Id: I2d67daf1cc7930649d097af23c18990cc3ae55fd
2022-11-30 17:46:57 +01:00
Oliver Smith 521b83ba3a scripts/osmocom-build-old…: skip openbsc 1.4.{0,1}
Don't attempt to build openbsc 1.4.0 and 1.4.1 in the
osmocom-build-old-tags-against-master job, as it fails to build with a
modern gcc with a potential null pointer dereference warning that gets
treated as error. This was fixed in 1.4.2 with openbsc patch
I93d816a20ba208e9fd32a1fc172a78ccd326e1ba.

A more modern gcc gets used, as this job gets changed to not only run on
jenkins nodes with debian 9 installed, but also more modern versions.
This job does not run in docker, and since it still passes it doesn't
seem worth changing that now.

Related: OS#5793
Change-Id: Ibf4b66195fbd70a68d63929b156a9aac54a699bc
2022-11-30 17:46:43 +01:00
Oliver Smith aa13c6e302 jobs: new naming scheme for ftp.osmocom.org keys
Use new ssh keys for ftp.osmocom.org with consistent naming scheme. It
was not possible to use @ in the ID name for new IDs, so I've used an
underscore instead.

Change-Id: Id0cf70e70944cf1a1963e0046b1470a0485c05f8
2022-11-30 13:03:09 +01:00
Oliver Smith 96f25bf519 jobs/master-builds: use binaries ssh credentials
Allow overriding the ssh agent credentials per repository, and use
binaries_ftp.osmocom.org where needed. Use docs_ftp.osmocom.org instead
of 97634b9d-a867-4f6d-825d-1da99813e93d so it's clear what the key is
for. I generated a new one with the new ID.

Fixes: OS#5798
Change-Id: I821968e09aaac3f6f6178de33fc909f81cb4abcb
2022-11-30 12:56:47 +01:00
Oliver Smith 989fb2ca58 jobs/update-osmo-ci: add build2-deb11build-ansible
Change-Id: Ief90b38d0a92f27c7ec37ffeb09dd3595b9d0baf
2022-11-29 11:42:11 +01:00
Oliver Smith e7c3edc144 jobs/update-osmo-ci: order nodes alphabetically
Make it easier to compare the list with:
https://jenkins.osmocom.org/jenkins/computer/

Change-Id: I6e132c5768bf09271ffcfe8eec8311ff5d7e28df
2022-11-29 11:40:41 +01:00
Oliver Smith 935d742837 jobs/master-builds: pysim: don't use deb9 lxc
Don't require the debian 9 lxc anymore for publishing docs, the ssh key
problem that made this necessary has been solved.

Closes: OS#5767
Change-Id: Ia4ee524db059a978bedc1d92804fb59d7513d2cb
2022-11-28 15:10:31 +01:00
Oliver Smith 310859b21a jobs/master-builds: don't only use debian 9 lxcs
Change-Id: I62bf0b968103724ec676900de6cee65fdb00b9e4
2022-11-28 15:09:33 +01:00
Oliver Smith 40ced5a1a0 jobs/master-builds: pass ssh agent sock to docker
Pass the ssh agent to docker for master builds, so we can publish
manuals and other files generated during the builds. This used to work
with the .ssh directory where each lxc had its own key. But we are
changing that to have the keys in jenkins and use the ssh agent, so it
works without additional configuration when adding new nodes/lxcs (such
as the two deb11 lxcs we just added).

Change-Id: I6dc1fd5d7e81ec135f805562608f06cf03a1baeb
2022-11-28 15:09:33 +01:00
Oliver Smith ffd4e39873 jobs/gerrit: don't only use debian 9 lxcs
Change-Id: I2d14bffb09439e031dec3ab3633a36710434a229
2022-11-28 14:38:52 +01:00
Oliver Smith 5d184fe869 jobs/update-osmo-ci: update list of nodes
* remove host2-deb9build
* add {host2,build3}-deb11build-ansible

Change-Id: I79bbb84cd19df7838a30a954ffa47a2a62517f77
2022-11-28 14:32:08 +01:00
Oliver Smith 1a3ee20141 ansible/jenkins: add gerrit ssh key to known_hosts
Add the key to known hosts to prevent host key verification failed
errors when attempting to use the gerrit API from jenkins (to post
review comments) or when attempting to clone over ssh from gerrit (as
we do for some reason apparently).

Change-Id: I50981f201c5ca1425e30677b2578491f5111fc0c
2022-11-28 14:13:34 +01:00
Oliver Smith 9fbcd1c35b ansible/install-poky-sdk: install more depends
Install missing depends file and gcc, and sort the list alphabetically
while at it.

Fixes: OS#5794
Change-Id: Ia0530859d65818e55498bc97af139b8773445dcf
2022-11-28 14:10:50 +01:00
Harald Welte f04bfa8cc5 ansible: add {host2,build3}-deb11build-ansible
The playbook currently doesn't deploy, see https://osmocom.org/issues/5794

Change-Id: I15439bb85c1c03a96231ea195d6ad1679a0a1af1
2022-11-28 12:30:21 +01:00
Oliver Smith 1263d6e0b9 obs/srcpkg: open5gs: download all subprojects
With recent changes in open5gs, building the source packages we
generated fails:
[   45s] ../lib/metrics/meson.build:52:4: ERROR: Automatic wrap-based subproject downloading is disabled
[   45s] dh_auto_configure: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu returned exit code 1

Fix this by downloading all subprojects. This is now possible as I added
a meson.build file to the prometheus-client-c repository that open5gs
uses: https://github.com/open5gs/prometheus-client-c/pull/2

Change-Id: If3910b520382b177a77b216c93771ea88414723d
2022-11-21 16:48:35 +01:00