Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 1000147 2023-01-25 08:10:03 +00:00 committed by Gerrit Code Review
parent 63e55e30db
commit d17d1dcf86
1 changed files with 18 additions and 0 deletions

View File

@ -33,6 +33,24 @@
"message": "Not sure if it suits our processes to answer here, but since I didn\u0027t see a specific issue for this:\n\nDo we also want this check for single statement blocks inside if-else statements with the \u0027else\u0027 or (macro-induced) (for-)loops (e.g. llist_for_each_entry)? Not sure how easy it is to add those checks, but I have just noticed they don\u0027t yet exist.",
"revId": "9e24272311712b9d49a9ac0073bfc466c5402e81",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "dc4cb9f1_af7d3b83",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2023-01-25T08:10:03Z",
"side": 1,
"message": "The checkpatch script we use comes from the linux kernel. So far we\u0027ve only made adjustments if\n* it\u0027s a trivial change (e.g. of the error string), or\n* to fix complaints that shouldn\u0027t be an error in the Osmocom code bases, e.g. https://gerrit.osmocom.org/c/osmo-ci/+/24918\n\nOther than that we only do config changes to enable / disable existing checks as in this patch. Developing entire new checks is a bit of work and doesn\u0027t seem like a good use of time, unless they would save us a lot of trouble down the road.",
"parentUuid": "48164bba_a9bedfb3",
"revId": "9e24272311712b9d49a9ac0073bfc466c5402e81",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}