mirror of https://gerrit.osmocom.org/osmo-ci
56 lines
2.2 KiB
Plaintext
56 lines
2.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "233e08ee_e37a1ddb",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-01-19T11:18:54Z",
|
|
"side": 1,
|
|
"message": "I thought this was already enabled!",
|
|
"revId": "9e24272311712b9d49a9ac0073bfc466c5402e81",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "48164bba_a9bedfb3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000229
|
|
},
|
|
"writtenOn": "2023-01-24T22:30:39Z",
|
|
"side": 1,
|
|
"message": "Not sure if it suits our processes to answer here, but since I didn\u0027t see a specific issue for this:\n\nDo we also want this check for single statement blocks inside if-else statements with the \u0027else\u0027 or (macro-induced) (for-)loops (e.g. llist_for_each_entry)? Not sure how easy it is to add those checks, but I have just noticed they don\u0027t yet exist.",
|
|
"revId": "9e24272311712b9d49a9ac0073bfc466c5402e81",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "dc4cb9f1_af7d3b83",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000147
|
|
},
|
|
"writtenOn": "2023-01-25T08:10:03Z",
|
|
"side": 1,
|
|
"message": "The checkpatch script we use comes from the linux kernel. So far we\u0027ve only made adjustments if\n* it\u0027s a trivial change (e.g. of the error string), or\n* to fix complaints that shouldn\u0027t be an error in the Osmocom code bases, e.g. https://gerrit.osmocom.org/c/osmo-ci/+/24918\n\nOther than that we only do config changes to enable / disable existing checks as in this patch. Developing entire new checks is a bit of work and doesn\u0027t seem like a good use of time, unless they would save us a lot of trouble down the road.",
|
|
"parentUuid": "48164bba_a9bedfb3",
|
|
"revId": "9e24272311712b9d49a9ac0073bfc466c5402e81",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |