mirror of https://gerrit.osmocom.org/libosmocore
Neels Hofmeyr
82c9a0ec19
Prepare for the implementation of splitting SQN increments in SEQ and an IND part; particularly to clearly show where the changes in auth/milenage_test's expectations originate. Rationale: the source of UMTS auth vectors, for us usually OsmoHLR, typically stores the last used SQN, not the next one to be used. Particularly with the upcoming fix of the SQN scheme, this change is important: the next SQN will depend on which entity asks for it, because each auth consumer may have a particular slot in the IND part of SQN. It does not make sense to store the next SQN, because we will not know which consumer that will be for. The milenage_test has always calculated a tuple for SQN == 34. To account for the increment now happening before calculating a tuple, lower the test_aud->sqn by one to 0x21 == 33, so that it is still calculating for SQN == 34. Because we are no longer incrementing SQN after the tuple is generated, milenage_test's expected output after doing an AUTS resync to 31 changes to the next SQN = 32, the SQN used for the generated tuple. (BTW, a subsequent patch will illustrate AUTS in detail.) osmo-auc-gen now needs to pass the user requested SQN less one, because the SQN will be incremented befor generating the auth vector. Also the SQN remains the same after generating, so SQN output needs less decrementing. Note that the expected output for osmo-auc-gen_test remains unchanged, hence the same input arguments (particularly -s <sqn> and -A <auts>) still produce the same results. Note: osmo-hlr regression tests will require adjustments when this patch is merged, because it must now pass desired_sqn - 1 instead of just desired_sqn. See osmo-hlr change-id I4ec5a578537acb1d9e1ebfe00a72417fc3ca5894 . Related: OS#1968 Change-Id: Iadf43f21e0605e9e85f7e8026c40985f7ceff1a3 |
||
|---|---|---|
| .. | ||
| codec | ||
| coding | ||
| ctrl | ||
| gb | ||
| gsm | ||
| sim | ||
| vty | ||
| Makefile.am | ||
| application.c | ||
| backtrace.c | ||
| bitcomp.c | ||
| bits.c | ||
| bitvec.c | ||
| conv.c | ||
| crc16.c | ||
| crcXXgen.c.tpl | ||
| fsm.c | ||
| gsmtap_util.c | ||
| logging.c | ||
| logging_gsmtap.c | ||
| logging_syslog.c | ||
| loggingrb.c | ||
| macaddr.c | ||
| msgb.c | ||
| msgfile.c | ||
| panic.c | ||
| plugin.c | ||
| prim.c | ||
| rate_ctr.c | ||
| rbtree.c | ||
| select.c | ||
| serial.c | ||
| signal.c | ||
| socket.c | ||
| stat_item.c | ||
| statistics.c | ||
| stats.c | ||
| stats_statsd.c | ||
| strrb.c | ||
| timer.c | ||
| timer_gettimeofday.c | ||
| utils.c | ||
| write_queue.c | ||