osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Remove direct logging 

Drop perror() calls from GSMTAP code: it's application job to do the
proper logging - library code should not write to stdout/stderr
directly.

Change-Id: Ifa149e65d76c6e64fda2946725c16672233aff2e
This commit is contained in:
Max 2017-01-04 19:55:51 +01:00
parent b1edd16e75
commit edc8db21fa
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/gsmtap_util.c
View File

@ -286,11 +286,9 @@ static int gsmtap_wq_w_cb(struct osmo_fd *ofd, struct msgb *msg)
rc = write(ofd->fd, msg->data, msg->len);
if (rc < 0) {
perror("writing msgb to gsmtap fd");
return rc;
}
if (rc != msg->len) {
perror("short write to gsmtap fd");
return -EIO;
}
@ -308,7 +306,6 @@ static int gsmtap_sink_fd_cb(struct osmo_fd *fd, unsigned int flags)
rc = read(fd->fd, buf, sizeof(buf));
if (rc < 0) {
perror("reading from gsmtap sink fd");
return rc;
}
/* simply discard any data arriving on the socket */