Patch Set 1:
I can confirm that the same warning appears
when compiling with clang-4.0:
warning: suggest braces around initialization
of subobject [-Wmissing-braces]
Patch-set: 1
Reviewer: Vadim Yanitskiy <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=0
Patch Set 1:
I created a new issue in redmine to track this problem so we don't need to fix further related issues. https://osmocom.org/issues/2332
Patch-set: 1
Reviewer: Pau Espin Pedrol <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=0
Patch Set 1:
The point is having a build of libosmocore with -Wall and -Werror in order to have a clean build log and no new warnings.
This is the only compiler bug with the current running jenkins setup, and it's not changing lots of stuff or behaviour, so I'd like this to go in so we can push the whole patchset and enable -Wall -Werror.
Patch-set: 1
Patch Set 1: Code-Review-1
What's the point of accommodating for compiler bugs? There're too many of those to change the code for each one of them. The proper fix would be to update compiler to version which has this bug fixed.
Patch-set: 1
Reviewer: Max <1000006@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1
Pau Espin Pedrol