From edc8db21fa4fec3a87d7892d219ae26135858e9c Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 4 Jan 2017 19:55:51 +0100 Subject: [PATCH] Remove direct logging Drop perror() calls from GSMTAP code: it's application job to do the proper logging - library code should not write to stdout/stderr directly. Change-Id: Ifa149e65d76c6e64fda2946725c16672233aff2e --- src/gsmtap_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c index 66abdf177..ab4a28eb9 100644 --- a/src/gsmtap_util.c +++ b/src/gsmtap_util.c @@ -286,11 +286,9 @@ static int gsmtap_wq_w_cb(struct osmo_fd *ofd, struct msgb *msg) rc = write(ofd->fd, msg->data, msg->len); if (rc < 0) { - perror("writing msgb to gsmtap fd"); return rc; } if (rc != msg->len) { - perror("short write to gsmtap fd"); return -EIO; } @@ -308,7 +306,6 @@ static int gsmtap_sink_fd_cb(struct osmo_fd *fd, unsigned int flags) rc = read(fd->fd, buf, sizeof(buf)); if (rc < 0) { - perror("reading from gsmtap sink fd"); return rc; } /* simply discard any data arriving on the socket */