osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 8 

Patch Set 8: Code-Review-1

(3 comments)

Patch-set: 8
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 1000005 2022-08-17 00:48:15 +00:00 committed by Gerrit Code Review
parent eb1a367089
commit e6410cbf54
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
577f20e7fe9f8a17ab3505ad2b983189390e8cfc Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "dd93c751_9be04fe6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 1000005
},
"writtenOn": "2022-08-17T00:48:15Z",
"side": 1,
"message": "the code added in https://gerrit.osmocom.org/c/libosmocore/+/28992 should move to this function, as indicated below",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "dda0b532_5a697daa",
"filename": "src/socket.c",
"patchSetId": 8
},
"lineNbr": 208,
"author": {
"id": 1000005
},
"writtenOn": "2022-08-17T00:48:15Z",
"side": 1,
"message": "(this doc is wrong)",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "16eeb34d_42c05fa7",
"filename": "src/socket.c",
"patchSetId": 8
},
"lineNbr": 211,
"author": {
"id": 1000005
},
"writtenOn": "2022-08-17T00:48:15Z",
"side": 1,
"message": "if you use an implementation like this here, we don\u0027t need to add osmo_sockaddr_strs_to_str() at all and save a lot of dynamic allocations:\n\n\n struct osmo_strbuf sb \u003d { ... };\n if (i !\u003d 1)\n OSMO_STRBUF_PRINTF(sb, \"(\");\n for (...) {\n struct osmo_sockaddr_str ss;\n if (i)\n OSMO_STRBUF_PRINTF(sb, \"|\");\n osmo_sockaddr_str_from_str2(\u0026ss, hosts[i]);\n OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_FMT, OSMO_SOCKADDR_STR_FMT_ARGS(\u0026ss));\n }\n if (i !\u003d 1)\n OSMO_STRBUF_PRINTF(sb, \")\");\n return sb.chars_needed;",
"revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}