From e6410cbf5433913f09194762b12bb462c4448582 Mon Sep 17 00:00:00 2001
From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Date: Wed, 17 Aug 2022 00:48:15 +0000
Subject: [PATCH] Update patch set 8

Patch Set 8: Code-Review-1

(3 comments)

Patch-set: 8
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1
---
 577f20e7fe9f8a17ab3505ad2b983189390e8cfc | 55 ++++++++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 577f20e7fe9f8a17ab3505ad2b983189390e8cfc

diff --git a/577f20e7fe9f8a17ab3505ad2b983189390e8cfc b/577f20e7fe9f8a17ab3505ad2b983189390e8cfc
new file mode 100644
index 000000000..316940364
--- /dev/null
+++ b/577f20e7fe9f8a17ab3505ad2b983189390e8cfc
@@ -0,0 +1,55 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "dd93c751_9be04fe6",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 8
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-08-17T00:48:15Z",
+      "side": 1,
+      "message": "the code added in https://gerrit.osmocom.org/c/libosmocore/+/28992 should move to this function, as indicated below",
+      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "dda0b532_5a697daa",
+        "filename": "src/socket.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 208,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-08-17T00:48:15Z",
+      "side": 1,
+      "message": "(this doc is wrong)",
+      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "16eeb34d_42c05fa7",
+        "filename": "src/socket.c",
+        "patchSetId": 8
+      },
+      "lineNbr": 211,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-08-17T00:48:15Z",
+      "side": 1,
+      "message": "if you use an implementation like this here, we don\u0027t need to add osmo_sockaddr_strs_to_str() at all and save a lot of dynamic allocations:\n\n\n  struct osmo_strbuf sb \u003d { ... };\n  if (i !\u003d 1)\n      OSMO_STRBUF_PRINTF(sb, \"(\");\n  for (...) {\n      struct osmo_sockaddr_str ss;\n      if (i)\n         OSMO_STRBUF_PRINTF(sb, \"|\");\n      osmo_sockaddr_str_from_str2(\u0026ss, hosts[i]);\n      OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_FMT, OSMO_SOCKADDR_STR_FMT_ARGS(\u0026ss));\n   }\n  if (i !\u003d 1)\n      OSMO_STRBUF_PRINTF(sb, \")\");\n  return sb.chars_needed;",
+      "revId": "577f20e7fe9f8a17ab3505ad2b983189390e8cfc",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}
\ No newline at end of file