Update patch set 10

Patch Set 10:

(1 comment)

Patch-set: 10
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}

d8a3e4d3903e6d11a07d052495e222b6f12558da

@@ -16,6 +16,24 @@
       "message": "why this change? where is hdr.cmsg now set?",
       "revId": "d8a3e4d3903e6d11a07d052495e222b6f12558da",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "19033120_dff70a0e",
+        "filename": "src/core/osmo_io_poll.c",
+        "patchSetId": 10
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 1000004
+      },
+      "writtenOn": "2024-02-23T13:55:06Z",
+      "side": 1,
+      "message": "hdr.cmsg is not set at all anywhere in this code path.  hdr.cmsg is now a zero-length array at the end of struct iofd_msghdr.  If hdr is allocated dynamically on the heap, we can use talloc_zero_size to include the desired cmsg size.  Howve, here \u0027hdr\u0027 is on the stack, so we also need to put the cmsg space on the stack which this line above is doing.  There is no need to initialzie it, as the cmsg is an *output* parameter from recvmsg to us, and not input data we pass to ot.\n\niofd_handle_recv() processes the data, and afterwards the data on the stack is released once we exit the scope of this function.",
+      "parentUuid": "af152d24_f00699e6",
+      "revId": "d8a3e4d3903e6d11a07d052495e222b6f12558da",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }