mirror of https://gerrit.osmocom.org/libosmocore
Update patch set 10
Patch Set 10: Code-Review+1 (2 comments) Patch-set: 10 Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1, 773c8dff935853ce345cc6188f43007abf4c4d36 Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
parent
4252c9ae6c
commit
352838a37c
|
@ -106,6 +106,24 @@
|
|||
"revId": "4e289a9ff84904e1e5144942ab77d03a93dfe39c",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "92615ee1_81208eba",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2024-02-23T13:28:35Z",
|
||||
"side": 1,
|
||||
"message": "yay! this looks much better from architectural point of view imho.",
|
||||
"parentUuid": "540843c4_f78524db",
|
||||
"revId": "4e289a9ff84904e1e5144942ab77d03a93dfe39c",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "af152d24_f00699e6",
|
||||
"filename": "src/core/osmo_io_poll.c",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 69,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2024-02-23T13:28:35Z",
|
||||
"side": 1,
|
||||
"message": "why this change? where is hdr.cmsg now set?",
|
||||
"revId": "d8a3e4d3903e6d11a07d052495e222b6f12558da",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue