osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} 

Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04
Related: SYS#5713
This commit is contained in:
Vadim Yanitskiy 2021-11-09 13:59:20 +03:00
parent d6b00591f7
commit 52a5c112f1
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/vty/stats_vty.c
View File

@ -312,8 +312,8 @@ DEFUN(cfg_no_stats_reporter_statsd, cfg_no_stats_reporter_statsd_cmd,
srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name);
if (!srep) { if (!srep) {
vty_out(vty, "%% No statsd logging active%s", vty_out(vty, "%% There is no such statsd reporter with name '%s'%s",
VTY_NEWLINE); name ? name : "", VTY_NEWLINE);
return CMD_WARNING; return CMD_WARNING;
} }
@ -366,8 +366,8 @@ DEFUN(cfg_no_stats_reporter_log, cfg_no_stats_reporter_log_cmd,
srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name);
if (!srep) { if (!srep) {
vty_out(vty, "%% No log reporting active%s", vty_out(vty, "%% There is no such log reporter with name '%s'%s",
VTY_NEWLINE); name ? name : "", VTY_NEWLINE);
return CMD_WARNING; return CMD_WARNING;
} }

5
tests/stats/stats_vty_test.vty
View File

@ -203,6 +203,11 @@ stats_vty_test(config)# no stats reporter log log-zoo
stats_vty_test(config)# show running-config stats_vty_test(config)# show running-config
... !(foo|bar|zoo) ... !(foo|bar|zoo)
stats_vty_test(config)# no stats reporter statsd statsd-foo
% There is no such statsd reporter with name 'statsd-foo'
stats_vty_test(config)# no stats reporter log log-zoo
% There is no such log reporter with name 'log-zoo'
stats_vty_test(config)# stats interval 1337 stats_vty_test(config)# stats interval 1337
stats_vty_test(config)# show running-config stats_vty_test(config)# show running-config