osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

ctrl: Remove the param parameter as it was never used/implemented

This commit is contained in:
Holger Hans Peter Freyther 2014-05-15 15:45:55 +02:00 committed by Harald Welte
parent c08c55186f
commit 50059bb64f
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openbsc/include/openbsc/control_cmd.h
View File

@ -66,7 +66,6 @@ struct ctrl_cmd_struct {
struct ctrl_cmd_element { struct ctrl_cmd_element {
const char *name; const char *name;
const char *param;
struct ctrl_cmd_struct strcmd; struct ctrl_cmd_struct strcmd;
int (*set)(struct ctrl_cmd *cmd, void *data); int (*set)(struct ctrl_cmd *cmd, void *data);
int (*get)(struct ctrl_cmd *cmd, void *data); int (*get)(struct ctrl_cmd *cmd, void *data);
@ -125,7 +124,6 @@ static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *_data
CTRL_HELPER_VERIFY_RANGE(cmdname, min, max) \ CTRL_HELPER_VERIFY_RANGE(cmdname, min, max) \
static struct ctrl_cmd_element cmd_##cmdname = { \ static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \ .name = cmdstr, \
.param = NULL, \
.get = &get_##cmdname, \ .get = &get_##cmdname, \
.set = &set_##cmdname, \ .set = &set_##cmdname, \
.verify = &verify_##cmdname, \ .verify = &verify_##cmdname, \
@ -154,7 +152,6 @@ static int set_##cmdname(struct ctrl_cmd *cmd, void *_data) \
CTRL_HELPER_SET_STRING(cmdname, dtype, element) \ CTRL_HELPER_SET_STRING(cmdname, dtype, element) \
static struct ctrl_cmd_element cmd_##cmdname = { \ static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \ .name = cmdstr, \
.param = NULL, \
.get = &get_##cmdname, \ .get = &get_##cmdname, \
.set = &set_##cmdname, \ .set = &set_##cmdname, \
.verify = NULL, \ .verify = NULL, \
@ -166,7 +163,6 @@ static int set_##cmdname(struct ctrl_cmd *cmd, void *data); \
static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data); \ static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data); \
static struct ctrl_cmd_element cmd_##cmdname = { \ static struct ctrl_cmd_element cmd_##cmdname = { \
.name = cmdstr, \ .name = cmdstr, \
.param = NULL, \
.get = &get_##cmdname, \ .get = &get_##cmdname, \
.set = &set_##cmdname, \ .set = &set_##cmdname, \
.verify = &verify_##cmdname, \ .verify = &verify_##cmdname, \

2
openbsc/src/libctrl/control_cmd.c
View File

@ -142,8 +142,6 @@ int ctrl_cmd_exec(vector vline, struct ctrl_cmd *command, vector node, void *dat
command->reply = "Value failed verification."; command->reply = "Value failed verification.";
goto out; goto out;
} }
} else if (cmd_el->param) {
LOGP(DCTRL, LOGL_NOTICE, "Parameter verification unimplemented, continuing without\n");
} }
ret = cmd_el->set(command, data); ret = cmd_el->set(command, data);
goto out; goto out;