osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 7 

Patch Set 7:

(1 comment)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"msuraev replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"msuraev replied on the change"}
This commit is contained in:
Gerrit User 1000159 2022-08-13 09:14:41 +00:00 committed by Gerrit Code Review
parent e5475362f7
commit 16c6269046
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
91a6c0d567d9097545c25cebc142f75860ef0e21
View File

@ -16,6 +16,24 @@
"message": "This all looks wrong to me, or I\u0027m missing soemthing.\nSo you have a sockaddr_storage, which has size enough to contain whatever. Let\u0027s say it has ss_family\u003dAF_UNSPEC; so you call osmo_sockaddr_guess_unspec() on it.\n\nThen, osmo_sockaddr_guess_unspec() calls osmo_sockaddr_str_from_in6_addr() on it, which should convert fine no matter the random contents in the struct, since any possible value is acceptable in there.\n\nSo you end up handling AD_UNSPEC as AF_INET6, printing random stuff which may not be correct.",
"revId": "91a6c0d567d9097545c25cebc142f75860ef0e21",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "befb4ad9_399120e4",
"filename": "src/sockaddr_str.c",
"patchSetId": 7
},
"lineNbr": 389,
"author": {
"id": 1000159
},
"writtenOn": "2022-08-13T09:14:41Z",
"side": 1,
"message": "Not \"random stuff\" but the content withdots or colons which passed through osmo_sockaddr_guess_unspec(). The random stuff would still likely get AF_UNSPEC and won\u0027t be converted/printed. As the comment says: we relax restrictions, we do not remove them completely.",
"parentUuid": "e33a20a3_838eba20",
"revId": "91a6c0d567d9097545c25cebc142f75860ef0e21",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}