Update patch set 7

Patch Set 7: Code-Review-2

(1 comment)

Patch-set: 7
Label: Code-Review=-2
This commit is contained in:
Gerrit User 1000074 2022-08-12 11:50:31 +00:00 committed by Gerrit Code Review
parent ef799cf252
commit e5475362f7
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e33a20a3_838eba20",
"filename": "src/sockaddr_str.c",
"patchSetId": 7
},
"lineNbr": 389,
"author": {
"id": 1000074
},
"writtenOn": "2022-08-12T11:50:31Z",
"side": 1,
"message": "This all looks wrong to me, or I\u0027m missing soemthing.\nSo you have a sockaddr_storage, which has size enough to contain whatever. Let\u0027s say it has ss_family\u003dAF_UNSPEC; so you call osmo_sockaddr_guess_unspec() on it.\n\nThen, osmo_sockaddr_guess_unspec() calls osmo_sockaddr_str_from_in6_addr() on it, which should convert fine no matter the random contents in the struct, since any possible value is acceptable in there.\n\nSo you end up handling AD_UNSPEC as AF_INET6, printing random stuff which may not be correct.",
"revId": "91a6c0d567d9097545c25cebc142f75860ef0e21",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}