osmocom
/
libosmo-abis
mirror of https://gerrit.osmocom.org/libosmo-abis
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2: Code-Review+1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 445257506c8d83d3cc4030d91b41762f532cd884
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010 2024-02-24 13:10:14 +00:00 committed by Gerrit Code Review
parent fde720cb2b
commit b763c39d6c
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
8bc2e31961bc038b79f078a6c1931e9d1dea280f Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d762b6f1_8228f661",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 22,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-24T13:10:14Z",
"side": 1,
"message": "This commit (https://gerrit.osmocom.org/c/libosmo-abis/+/30280) does not introduce the regression itself; it does enable the keepalive feature by default. The buggy logic was added in `I5e7425958472aa5d758e09bfbefc7d7d37bf6f5f` (https://gerrit.osmocom.org/c/libosmo-abis/+/14565). And so the bug is present since 0.7.0 (Jun 2019).",
"range": {
"startLine": 22,
"startChar": 38,
"endLine": 22,
"endChar": 79
},
"revId": "8bc2e31961bc038b79f078a6c1931e9d1dea280f",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}