osmocom
/
libosmo-abis
mirror of https://gerrit.osmocom.org/libosmo-abis
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000074 2024-01-08 14:48:16 +00:00 committed by Gerrit Code Review
parent 28ee4ec80b
commit 3667a650fa
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
c4ea374e4af902458f247da2a04c38205d5e1447
View File

@ -70,6 +70,24 @@
"parentUuid": "715fa8b9_ac317fc1",
"revId": "c4ea374e4af902458f247da2a04c38205d5e1447",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "a6c5bf5e_87c60a0b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2024-01-08T14:48:16Z",
"side": 1,
"message": "If \"#include \"bctoolbox/port.h\"\" happens in some public header of ortp.h, then:\n- Yes, it\u0027s a public dependency and it\u0027s part of the public API of the library\n- Yes, it\u0027s like libosmocore and ortp.\n\n\u003e Whatever ortp is using is the internal details of ortp\nIf it\u0027s ina public header, it\u0027s not internal details. Internal details means private header or .c files.\n\n\u003e they may switch to some other library any day.\nThat would break its ABI/API.",
"parentUuid": "0a225624_9fbf8bad",
"revId": "c4ea374e4af902458f247da2a04c38205d5e1447",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}