Commit Graph

1638 Commits

Author SHA1 Message Date
Jeff Morriss 4fdc3c3cc2 Create, and start using, file name preferences.
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).

svn path=/trunk/; revision=43228
2012-06-13 01:13:12 +00:00
Bill Meier 128c4266a0 Attempt to fix display of "eoe macfilter header".
Among other things: fix incorrect 'display' value in several hf[] entries.
(See XXX coments in source for further details).
Attempt to fix use of incorrect value in hf[] entry 'display' fields


svn path=/trunk/; revision=43149
2012-06-07 20:16:28 +00:00
Jeff Morriss 8204b904b3 Fix Coverity 702421: Handle the possibility that fvalue_to_string_repr()
may return NULL.

svn path=/trunk/; revision=43114
2012-06-05 15:20:31 +00:00
Alexis La Goutte 7174762b51 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=43088
2012-06-04 22:25:10 +00:00
Pascal Quantin 797b83c838 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7322 :
Add a missing break in packet-bpkmattr.c (CID 280484)

svn path=/trunk/; revision=43007
2012-06-02 19:15:07 +00:00
Guy Harris 533f70aca2 No more GIOP plugins, so get rid of the directory for the former plugins.
svn path=/trunk/; revision=42978
2012-06-01 17:08:32 +00:00
Anders Broman ffec8d8a78 Make packet-coseventcomm.c a bultin dissector
svn path=/trunk/; revision=42976
2012-06-01 15:58:30 +00:00
Anders Broman a8e8234831 Make packet-coseventcomm.c a bultin dissector
svn path=/trunk/; revision=42974
2012-06-01 15:57:05 +00:00
Bill Meier 3d4b3f2784 Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if Makefile.common is changed
svn path=/trunk/; revision=42972
2012-06-01 14:44:35 +00:00
Bill Meier 1caa79ad80 Windows: Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if Makefile.common is changed
ToDo: ditto for Makefile.am ?

svn path=/trunk/; revision=42971
2012-06-01 14:08:12 +00:00
Anders Broman c8625796f1 Make the cosnaming dissector a builtin dissector.
svn path=/trunk/; revision=42968
2012-06-01 12:27:04 +00:00
Anders Broman b42bbc2cd6 Make the tango dissector a builtin dissector.
svn path=/trunk/; revision=42967
2012-06-01 10:31:34 +00:00
Anders Broman 5959f75518 parlay changes to Cmake
svn path=/trunk/; revision=42965
2012-06-01 09:04:28 +00:00
Anders Broman 5ef6c6d08a Make the parlay dissector a buil tin dissector.
svn path=/trunk/; revision=42964
2012-06-01 08:48:31 +00:00
Anders Broman d98be8ecf6 Dissable -Werror
svn path=/trunk/; revision=42928
2012-05-30 20:51:36 +00:00
Anders Broman 224daf8cd4 Forgot to change the name to giop
svn path=/trunk/; revision=42927
2012-05-30 19:51:54 +00:00
Anders Broman d8b0471ded Add files to use 'new plugin build style'
svn path=/trunk/; revision=42924
2012-05-30 19:01:29 +00:00
Bill Meier 78a170a506 Cleanup whitespace;
Reformat hf[] entries.

svn path=/trunk/; revision=42748
2012-05-21 16:12:56 +00:00
Bill Meier a729320b0a Init some variables to prevent scan-build "Function call argument is an uninitialized value" messages.
(Not actually a bug due to the way the code works ?)

svn path=/trunk/; revision=42747
2012-05-21 15:56:26 +00:00
Guy Harris 944ae5ae49 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42590
2012-05-11 20:02:52 +00:00
Guy Harris 0adedfaaee Show m2m.fch_burst_tlv_value in decimal.
svn path=/trunk/; revision=42589
2012-05-11 19:53:43 +00:00
Guy Harris 0fb9759eec Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Add hf[] entries for some fields that didn't have them.

svn path=/trunk/; revision=42588
2012-05-11 19:27:59 +00:00
Guy Harris 4217008691 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42587
2012-05-11 19:22:25 +00:00
Guy Harris 90f564717f Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Clean up indentation.

svn path=/trunk/; revision=42586
2012-05-11 19:20:23 +00:00
Guy Harris 7962b11c0f Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

Also, fix the type of what appears to be a 24-bit integral field
(cut-and-pasteo?).

svn path=/trunk/; revision=42585
2012-05-11 19:08:31 +00:00
Guy Harris 774028e5fc Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42584
2012-05-11 18:57:51 +00:00
Guy Harris 0e1de63173 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42583
2012-05-11 18:54:32 +00:00
Guy Harris ccb24a5ab7 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42582
2012-05-11 18:52:36 +00:00
Gerald Combs dedd0eadd0 Better fixes for the last commit.
svn path=/trunk/; revision=42529
2012-05-10 00:21:40 +00:00
Gerald Combs 4d30e72575 Fix a few scan-build warnings.
svn path=/trunk/; revision=42528
2012-05-09 23:08:47 +00:00
Bill Meier 1783543e92 AFAICT '#include sys/types.h' is not needed for these files.
svn path=/trunk/; revision=42446
2012-05-05 21:29:13 +00:00
pascal 48f4ae6e3b From Nhi Nguyen:
OPC UA bytestring node id decoding is wrong
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7226

svn path=/trunk/; revision=42437
2012-05-05 04:57:40 +00:00
Anders Broman 2311c797b2 From Gabor Somlai:
Decoding DOCSIS 3.0 Isolation DATA frames (FC_TYPE=10).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7214

svn path=/trunk/; revision=42382
2012-05-02 10:49:03 +00:00
Guy Harris 66ee0608c7 The message length isn't needed in cmd_sched_rep() - it's just the
containing packet length, so if we go past it, we'll get an exception
thrown.  Get rid of it.

The answer to "Should msglen be returned instead of offset?" is "no" -
the command dissectors return the new offset.

Get rid of an unused - and unnecessary - variable.

svn path=/trunk/; revision=42367
2012-04-30 23:03:51 +00:00
Gerald Combs c40f94895d Fix a couple of clang warnings and adjust capitalization.
svn path=/trunk/; revision=42358
2012-04-30 20:15:46 +00:00
Chris Maynard 7655cb2f5a Initialize u32RecDataLen to 0 to avoid a clang warning and in the event it never gets initialized in either dissect_IODWriteReqHeader_block() or dissect_IODReadReqHeader_block().
svn path=/trunk/; revision=42325
2012-04-28 18:50:20 +00:00
Jeff Morriss 6aa32cb03a As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.

svn path=/trunk/; revision=42300
2012-04-27 19:45:35 +00:00
Anders Broman 8a4268505b Fix Malformed packet AMS for Read Device Info Read State Request.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6710

check if data exists.

svn path=/trunk/; revision=42292
2012-04-27 14:13:06 +00:00
Jakub Zawadzki aec21991ec Fix value of "Error in Parameter API"
References: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753#c3

svn path=/trunk/; revision=42285
2012-04-27 08:41:44 +00:00
Jakub Zawadzki 8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Anders Broman b1b0af6e66 From Pascal Quantin:
Fix Bug 6793  Some WiMAX messages decoded incorrectly

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6793

svn path=/trunk/; revision=42045
2012-04-13 13:02:57 +00:00
Jakub Zawadzki 8fca2eb7e5 Add missing consts.
svn path=/trunk/; revision=42004
2012-04-10 10:20:20 +00:00
Jakub Zawadzki a3aa2b7d7c Add missing consts in opcua plugin.
svn path=/trunk/; revision=42000
2012-04-09 20:06:27 +00:00
Jeff Morriss 75c3c92f19 Add a "-build" argument to checkAPIs.pl. Use that argument when building
from makefiles (and thus from the buildbot).

The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.

As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.

svn path=/trunk/; revision=41943
2012-04-04 20:46:49 +00:00
Stig Bjørlykke 1fd4eaaa88 Removed unused pdu_length in pdu_burst_decoder to avoid a warning from clang.
svn path=/trunk/; revision=41794
2012-03-27 06:57:39 +00:00
Stig Bjørlykke caf4761202 Added a check for a valid pointer to avoid a warning from clang.
svn path=/trunk/; revision=41793
2012-03-27 06:57:30 +00:00
Jeff Morriss 90df1a9d94 Set eol-style to native (just to make these files readable on *NIX).
svn path=/trunk/; revision=41654
2012-03-19 01:46:24 +00:00
Bill Meier 2df5dc3d53 From Reinhard Speyerer: Fix several misspellings/typos in Wireshark
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6967

svn path=/trunk/; revision=41645
2012-03-18 22:24:24 +00:00
Bill Meier 605dea0486 CVARSDLL hasn't been used (is undefined) for a while....
svn path=/trunk/; revision=41180
2012-02-24 16:23:38 +00:00
Jeff Morriss bc57b2c8b4 From Wido Kelling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6819 :
Patch to fix channelproperty Maintanance decode.

svn path=/trunk/; revision=40943
2012-02-09 19:02:28 +00:00