Commit Graph

1638 Commits

Author SHA1 Message Date
Anders Broman 8e97665863 Add *.sbr files to the clean target.
svn path=/trunk/; revision=40761
2012-01-29 20:03:39 +00:00
Bill Meier 48ca3d4742 Use GSlice API instead of GMemChunk API for some memory allocation.
svn path=/trunk/; revision=40547
2012-01-16 19:05:32 +00:00
Bill Meier 49eff359e1 Fix a typo in an error message.
svn path=/trunk/; revision=40546
2012-01-16 18:12:18 +00:00
Alexis La Goutte 125725fb0c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=40475
2012-01-13 16:37:21 +00:00
Alexis La Goutte e3d0d4bd8f Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=40474
2012-01-13 16:37:04 +00:00
Anders Broman 160d5ad55f From Yi Zhang:
DSG_DA_TO_DSID_ASSOCIATION_DA/DSID is not correctly parsed in DOCSIS MDD packet.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6725

svn path=/trunk/; revision=40450
2012-01-13 06:34:07 +00:00
Anders Broman 21c58470e4 From Yi Zhang:
The DCD_CLID_BCAST_ID TLV is not supported in DOCSIS plugin.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6724

svn path=/trunk/; revision=40449
2012-01-13 06:29:03 +00:00
Chris Maynard 5debb5c5e3 Fix memory leaks involving tvb_get_string[z]().
svn path=/trunk/; revision=40312
2011-12-28 16:36:57 +00:00
Bill Meier ee3936cd48 (Trivial) remove commented out calls to tvb_free().
svn path=/trunk/; revision=40202
2011-12-14 18:40:03 +00:00
Bill Meier d57950889e tvb_free() can (now) be called from plugins on Windows
svn path=/trunk/; revision=40201
2011-12-14 18:33:00 +00:00
Jörg Mayer 5a04ff0438 Fix:
trunk/plugins/profinet/packet-pn-rt.c: In function ‘IsDFP_Frame’:
trunk/plugins/profinet/packet-pn-rt.c:182:9: error: ‘u8SFCycleCounter’ undeclared (first use in this function)
trunk/plugins/profinet/packet-pn-rt.c:182:9: note: each undeclared identifier is reported only once for each function it appears in


svn path=/trunk/; revision=40063
2011-12-01 14:35:29 +00:00
Anders Broman 819f2fd1ac packet-dcerpc-pn-io.c:8735: warning: unused variable 'iSubFrameLen'
packet-dcerpc-pn-io.c:8734: warning: unused variable 'iTotalLen'

svn path=/trunk/; revision=40061
2011-12-01 06:35:02 +00:00
Anders Broman 28b32b9b81 From Wido Kelling:
Enhancements to profinet decoding (IEC 61158) V2.3.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6605

svn path=/trunk/; revision=40058
2011-12-01 05:58:55 +00:00
Alexis La Goutte 022a45e0d9 From c.David via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6527
corba dissector generator improvement 

Patch 2 : create a defaulf field hf_operationrequest which provides the requested operation on both the resquest and the reply messages.

From me : 
Regenerate GIOP Plugins

svn path=/trunk/; revision=40038
2011-11-29 19:36:53 +00:00
Alexis La Goutte 557a841313 From c.David via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6527
corba dissector generator improvement 

Patch 1 : field names is used in dissection instead of "enum value" which is not clear

From me : 
Regenerate GIOP Plugins

svn path=/trunk/; revision=40037
2011-11-29 19:22:35 +00:00
Alexis La Goutte 9eb1835a10 Regenerate GIOP dissector plugins (after change in generator !) for fix Warning found by Clang (>100 !)
svn path=/trunk/; revision=39934
2011-11-18 12:39:35 +00:00
Alexis La Goutte 331fa3af93 Regenerate GIOP dissector plugins (after change in generator !) with following commmands :
:~/wireshark/tools$ ../idl2wrs ../idl/cosnaming.idl > ../plugins/giop/packet-cosnaming.c
:~/wireshark/tools$ ../idl2wrs ../idl/coseventcomm.idl > ../plugins/giop/packet-coseventcomm.c
:~/wireshark/tools$ ../idl2wrs ../idl/parlay/Parlay.idl > ../plugins/giop/packet-parlay.c
:~/wireshark/tools$ ../idl2wrs ../idl/tango.idl > ../plugins/giop/packet-tango.c 

For packet-cosnaming.c, only some white return change
For packet-parley.c, lot of change but only the functions is not in the same order...?! (Order change in 17911)

svn path=/trunk/; revision=39932
2011-11-18 12:34:16 +00:00
Chris Maynard f20ad40ea9 Append a path-separator to the plugins directory so xcopy doesn't get confused as to whether it's copying each plugin to a file or a directory. I.e., hopefully to avoid this situation:
Does wireshark-gtk2\plugins\1.7.1-SVN-39918 specify a file name
or directory name on the target
(F = file, D = directory)?


svn path=/trunk/; revision=39922
2011-11-18 01:08:20 +00:00
Guy Harris e600a12538 OK, *that's* what Clang Cat was going on about:
packet-dcerpc-pn-io.c:8438:17: warning: Although the value
	stored to 'prm_flag2' is used in the enclosing expression, the
	value is never actually read from 'prm_flag2'

OK, thanks for telling me that, technically,

	prm_flag1 = prm_flag2 = 0;

can be implemented by storing the 0 into prm_flag1 directly rather than
storing 0 into prm_flag2 and copying it to prm_flag1.  Yes, you can haz
cheeseburger.

I guess it would matter if we were actually depending on some
side-effect of fetching prm_flag2, but we're not.  Rewrite this one to
squelch the complaint.

svn path=/trunk/; revision=39841
2011-11-15 05:37:56 +00:00
Bill Meier 7ad9251beb Fix some additional [-Wunused-but-set-variable]
Fix some spelling typos

svn path=/trunk/; revision=39805
2011-11-12 19:17:21 +00:00
Anders Broman 0f0f260fb4 fix [-Wunused-but-set-variable]
svn path=/trunk/; revision=39802
2011-11-12 11:49:37 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 94e9c99b3f Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.
svn path=/trunk/; revision=39490
2011-10-20 14:30:27 +00:00
Bill Meier cca6984ab9 Do some more conversions of proto_tree_add_item() 'encoding' arg
(previously missed).

svn path=/trunk/; revision=39450
2011-10-18 00:17:48 +00:00
Bill Meier 782cc6e3c3 Convert plugin files proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).

svn path=/trunk/; revision=39429
2011-10-15 19:58:31 +00:00
Bill Meier 9eb54292d3 Convert 'encoding' parameter of certain proto_tree_add_item() calls in plugins/*:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in an earlier SVN)

svn path=/trunk/; revision=39329
2011-10-10 00:53:55 +00:00
Bill Meier 02065b0981 Convert 'encoding' parameter of certain proto_tree_add_item() calls in plugin dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39292
2011-10-06 14:46:34 +00:00
Bill Meier ef8009abe3 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
    FT_BYTES
    FT_IPV6
    FT_IPXNET
    FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39262
2011-10-05 01:00:06 +00:00
Guy Harris c33cad6b43 More white space cleanup.
We need the PDU length to find stuff at the end; use
tvb_reported_length(), *not* tvb_length(), to get it, so we're not
confused by a snapshot length.  Rename it "pdu_len" to make that clear.

svn path=/trunk/; revision=39162
2011-09-26 21:48:54 +00:00
Guy Harris 8e7403464e The fragment data is almost certainly not a text string, so don't make
it an FT_STRING.

svn path=/trunk/; revision=39160
2011-09-26 20:46:09 +00:00
Guy Harris a15d409cbf Use ENC_ values in proto_tree_add_item() calls.
Get rid of the code that attempts to deal with the FCS; if the
link-layer dissector hasn't removed the FCS, either:

	1) the link-layer dissector is buggy and should be fixed;

or

	2) the link-layer dissector doesn't know whether there's an FCS
	   and you have to tell it by setting a preference (and if there
	   is no such preference, one needs to be added).

The code in question was causing errors when the link-layer dissector
was removing the FCS when it's known to be present, as it should do.

Get rid of 4-space tabs in favor of spaces.

svn path=/trunk/; revision=39158
2011-09-26 20:33:35 +00:00
Stig Bjørlykke 5359494b1f Second try to move crc routines to libwsutil.
This time keep the tvb routines in epan.

Now we can use common crc routines outside epan.

svn path=/trunk/; revision=38810
2011-08-31 09:00:54 +00:00
Stig Bjørlykke 71f903b956 Revert r38800, as the crc routines contains some tvb functions.
svn path=/trunk/; revision=38803
2011-08-30 14:17:40 +00:00
Stig Bjørlykke 4132d40e50 Move all crc routines to libwsutil.
This way we can use the crc routines in wiretap.

svn path=/trunk/; revision=38800
2011-08-30 13:46:42 +00:00
Jörg Mayer 8b8025c5d0 Add a comment about the uncommented glib deprecated warnings.
svn path=/trunk/; revision=38403
2011-08-08 09:39:30 +00:00
Jörg Mayer 553c565699 mate_grammar.lemon:
- Fix a bug my previous patch introduced.

mate/:
- Unset G_DISABLE_DEPRECATED for the mate files.

CMakeLists.txt
configure.in:
- Build with -DG_DISABLE_DEPRECATED so further usage of
  deprecated glib functions will be detected.

svn path=/trunk/; revision=38393
2011-08-07 18:35:36 +00:00
Jörg Mayer c15ff441c6 Replace deprecated glib functions.
In order to compile the whole project with -DG_DISABLE_DEPRECATED
the mate plugin needs to replace its usage of GMemChunk.
All other places should be clean.

svn path=/trunk/; revision=38392
2011-08-07 18:15:45 +00:00
Bill Meier 869b51db0e Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38321
2011-08-03 16:06:00 +00:00
Stig Bjørlykke 8c48b5f932 Make it compile.
svn path=/trunk/; revision=38254
2011-07-29 10:53:51 +00:00
Guy Harris eaecea41a3 Get rid of non-ASCII characters.
Clean up white space.

Clean up capitalization a bit.

svn path=/trunk/; revision=38253
2011-07-29 10:28:29 +00:00
Michael Tüxen c6b79979c2 Get it compiling.
svn path=/trunk/; revision=38250
2011-07-29 07:24:15 +00:00
Anders Broman bbf4437af0 From Wido Kelling:
Add Dissection of newly released PNIO IEC 61158 Version 2.3.
From me use ENC_BIG_ENDIAN.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6154

svn path=/trunk/; revision=38249
2011-07-29 05:36:57 +00:00
Bill Meier f161dc95fa Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38150
2011-07-21 19:10:10 +00:00
Guy Harris c34b796445 Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
representation.  Use it rather than a raw 0x10.

Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".

Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.

Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().

Clean up white space.

svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Anders Broman 8e4aa22fa0 From Kluchnikov Ivan:
Decoding Phy Synchronization Field in wimax DL-MAP and Compressed DL-MAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6068

svn path=/trunk/; revision=37921
2011-07-06 15:39:25 +00:00
Anders Broman 42dcd2af62 From Guido Reismueller:
This patch includes alle modem capabilities from DOCSIS 3.0
Until now only modem capabilities 1-12 where implemented.
Now all capabilities 1-40 are included.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6070

svn path=/trunk/; revision=37892
2011-07-04 20:34:04 +00:00
Anders Broman cdfadace98 From Kluchnikov Ivan:
Update wimax DCD Message mac version values.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6069

svn path=/trunk/; revision=37891
2011-07-04 15:04:50 +00:00
Anders Broman d6fda1f1f5 From Kluchnikov Ivan:
Wrong length of items in wimax Compressed DL-MAP and UL-MAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6067

svn path=/trunk/; revision=37890
2011-07-04 14:57:12 +00:00
Anders Broman 4257e61b6c From Kluchnikov Ivan:
Wireshark cannot decode wimax compressed DL-MAP without FCH burst.
Function is_down_link use the base station address (bs_address), which is set
in function dissect_wimax_fch_decoder.
Changed function is_down_link, it use packet_info->p2p_dir for check if packet
is downlink. 
packet_info->p2p_dir set in GSMTAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6066

svn path=/trunk/; revision=37889
2011-07-04 14:33:22 +00:00
Anders Broman 3826755b0a From Roland Knall:
implement a named dissector for the PN/IO sub-protocol for
Profinet, as well as a heuristic dissector ("pn_io"), other protocols can
attach too.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6062

svn path=/trunk/; revision=37882
2011-07-03 19:25:34 +00:00
Stig Bjørlykke 8443bbbf75 Replace all strerror() with g_strerror().
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812
2011-06-28 09:00:11 +00:00
Anders Broman f2c3e81b4a Remove theinterlinki plugin dir as it's now a builtin dissector.
svn path=/trunk/; revision=37611
2011-06-08 05:23:17 +00:00
Anders Broman afb0e8b434 From Michael Mann:
Make interlink built-in dissector (from plugin).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6005

svn path=/trunk/; revision=37610
2011-06-08 05:20:43 +00:00
Anders Broman 6ad93d0bd9 Remove the sercosiii plugin dir as it's now a builtin dissector.
svn path=/trunk/; revision=37608
2011-06-08 04:55:29 +00:00
Anders Broman d8e1b0d3d5 Move packet-sercosiii.c to be a builtin dissector.
svn path=/trunk/; revision=37597
2011-06-07 20:33:26 +00:00
Anders Broman 2bc6ecf4c1 From Michael Mann:
I made 2 changes when merging the source into a single file:
1. Changed filtername to "siii" to match display filter fields (was quicker
than changing all display filter fields to "sercosiii"
2. Converted the "ett_siii arrays" to a single value.   Each subtree doesn't
need its own ett_ value.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5990

svn path=/trunk/; revision=37574
2011-06-06 19:45:51 +00:00
Chris Maynard 87e588c336 Add SVN Id and GPL. Minor whitespace cleanup.
svn path=/trunk/; revision=37412
2011-05-26 16:03:29 +00:00
Anders Broman 39adb6e303 Add the possibillity of adding custom extra dist files.
svn path=/trunk/; revision=37411
2011-05-26 14:44:12 +00:00
Bill Meier 7062abeb00 Don't assign a value to a variable which is then never used: Coverity 1160 [UNUSED]
svn path=/trunk/; revision=37290
2011-05-19 14:11:01 +00:00
Jörg Mayer 2b3167dcf9 Fix another old style function declaration warning
svn path=/trunk/; revision=37281
2011-05-19 05:08:42 +00:00
Gerald Combs b223e99e5a get_host_ipaddr() was returning numeric addresses in host byte order
and hostnames in network byte order. Have it return everything in
network byte order.

svn path=/trunk/; revision=36873
2011-04-26 17:13:37 +00:00
Chris Maynard cfca66f6e1 Remove const qualifier to name, abbrev and blurb to pacify the buildbots.
svn path=/trunk/; revision=36860
2011-04-26 01:06:25 +00:00
Guy Harris 34f8f7e77d Get rid of some unnecessary casts that just provoke uninteresting
warnings.

More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".

svn path=/trunk/; revision=36856
2011-04-25 21:20:47 +00:00
Guy Harris d6fdc37988 More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".

svn path=/trunk/; revision=36855
2011-04-25 21:19:54 +00:00
Guy Harris 61fcd3200b Assume the tags are mallocated, so they're properly aligned. Cast away
the warnings.

svn path=/trunk/; revision=36816
2011-04-22 17:05:28 +00:00
Jeff Morriss 1229678a46 Use the return value of proto_item_add_subtree(): put the filter masks in their own subtree (as it appears was intended).
svn path=/trunk/; revision=36811
2011-04-22 14:48:10 +00:00
Alexis La Goutte 2fc740d7d1 Fix (latest) Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36802
2011-04-22 13:11:52 +00:00
Alexis La Goutte ed3a223400 From http://www.wireshark.org/lists/wireshark-dev/201104/msg00231.html
Always use the returned tree value of proto_tree_add_subtree (and not the item!)

svn path=/trunk/; revision=36801
2011-04-22 13:07:11 +00:00
Alexis La Goutte 83aea790d4 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36772
2011-04-21 16:01:03 +00:00
Alexis La Goutte 0c598a950d Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36756
2011-04-21 13:33:04 +00:00
Alexis La Goutte ab38454697 Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36754
2011-04-21 13:32:11 +00:00
Jörg Mayer 4b87a3d770 CID 1161: Not really used variable
svn path=/trunk/; revision=36725
2011-04-19 21:20:15 +00:00
Jörg Mayer 8efd127f31 CID 1162: Not really used variable
svn path=/trunk/; revision=36724
2011-04-19 21:15:58 +00:00
Anders Broman 67900c23be Fix Unused varaiable warnings.
CID 1163 - 1166

svn path=/trunk/; revision=36675
2011-04-17 09:34:38 +00:00
Bill Meier e07cb22a47 Rework whitespace.
svn path=/trunk/; revision=36583
2011-04-12 14:33:30 +00:00
Bill Meier c424bd7c83 Don't assign to a proto_item * if the value won't be used: Coverity 1158 & 1159.
svn path=/trunk/; revision=36581
2011-04-12 13:27:08 +00:00
Bill Meier e3f4dc17a9 localtime() can return a NULL ptr.
svn path=/trunk/; revision=36580
2011-04-12 13:21:32 +00:00
Gerald Combs 3e44421764 Either remove or use unused values found by Coverity. Fixes CIDs
1169-1172.

svn path=/trunk/; revision=36500
2011-04-06 18:59:36 +00:00
Chris Maynard 735b61500c Don't dereference a NULL pointer. Fixes CID 426.
svn path=/trunk/; revision=36424
2011-03-31 18:00:26 +00:00
Anders Broman 645cfe9ef2 Add a missing break.
CID 487

svn path=/trunk/; revision=36403
2011-03-29 21:20:36 +00:00
Anders Broman ce248d9ea9 Add a missing break.
CID 488

svn path=/trunk/; revision=36402
2011-03-29 21:11:26 +00:00
Anders Broman 2b81b097e5 Add a missing break.
CID 490

svn path=/trunk/; revision=36401
2011-03-29 21:08:34 +00:00
Anders Broman bc0fbb792a Added FALLTHRU comment to avoid a "missing break" warning.
CID 489

svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
Martin Mathieson 7356320a2a Don't assign proto_item pointers that are not used.
Coverity 1174

svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
Chris Maynard 10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
Bill Meier 7c41d527fd Removed uneeded 'continue'.
Fixes Coverity 815 ("UNREACHABLE").

svn path=/trunk/; revision=36367
2011-03-27 14:34:19 +00:00
Bill Meier 78c5c20d08 Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;
Also:
  - Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being
    done on an already hidden item).
  - Minor indentation cleanup;

svn path=/trunk/; revision=36315
2011-03-24 21:19:39 +00:00
Bill Meier b9331456e9 Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;
svn path=/trunk/; revision=36312
2011-03-24 17:37:07 +00:00
Bill Meier 24b8d23fb4 Don't assign to a proto_item* if the value isn't to be used: Coverity 1173;
Also:
  - Fix 2 cases of an item attached to the wrong subtree;
  - "localize" & rename some variable definitions;
  - Minor indentation cleanup.


svn path=/trunk/; revision=36310
2011-03-24 16:03:12 +00:00
Stig Bjørlykke cb56e84556 Removed unused parameter to parseServiceNodeId.
Coverity 596.

svn path=/trunk/; revision=36283
2011-03-23 08:03:02 +00:00
Stig Bjørlykke 888880eb25 Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst.
Coverity 535.

svn path=/trunk/; revision=36282
2011-03-23 07:34:00 +00:00
Ronnie Sahlberg 875abf1deb dont assign to a proto_item* unless we are going to use the value
coverity 1157

svn path=/trunk/; revision=36276
2011-03-23 05:18:26 +00:00
Stig Bjørlykke 1f108b02a0 Allocate correct size of range.
Coverity 718.

svn path=/trunk/; revision=36262
2011-03-22 18:58:32 +00:00
Jeff Morriss 3621346c20 Fix a typo
svn path=/trunk/; revision=36249
2011-03-22 13:49:07 +00:00
Ronnie Sahlberg 7191538bcc Coverity 1167
Dont assign tlv_item unless we need to dereference it.
Also push the variable deeper into the scope where it is used isntead of function wide scope.


svn path=/trunk/; revision=36243
2011-03-22 09:55:33 +00:00
Ronnie Sahlberg 3037db8904 Coverity 1168
Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree.


svn path=/trunk/; revision=36242
2011-03-22 09:47:34 +00:00
Ronnie Sahlberg ea9e664fc9 Coverity 420
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.



svn path=/trunk/; revision=36238
2011-03-22 09:05:26 +00:00
Stig Bjørlykke a774994572 Added some casts to fix coverity 325.
svn path=/trunk/; revision=36228
2011-03-21 18:33:18 +00:00
Guy Harris 7dfd6b1e09 From Roland Knall <rknall [AT] gmail.com>: allow heuristic subdissectors
for SERCOS III packets.

svn path=/trunk/; revision=36214
2011-03-20 00:47:18 +00:00
Stephen Fisher a62a37fbbe From Roland Knall via bug #5726: Adding a dissector registration, so the
dissector may be called by other dissectors.


svn path=/trunk/; revision=36055
2011-02-24 21:47:37 +00:00