osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Add a "-build" argument to checkAPIs.pl. Use that argument when building 

from makefiles (and thus from the buildbot).

The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.

As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.

svn path=/trunk/; revision=41943
This commit is contained in:
Jeff Morriss 2012-04-04 20:46:49 +00:00
parent 02e0b847f1
commit 75c3c92f19
68 changed files with 80 additions and 76 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile.am
View File

@ -1029,7 +1029,7 @@ dumpabi:
$(MAKE) -C wsutil dumpabi
checkapi_local:
$(PERL) tools/checkAPIs.pl \
$(PERL) tools/checkAPIs.pl -build \
$(TSHARK_TAP_SRC) \
$(wireshark_SOURCES)
# $(EXTRA_wireshark_SOURCES)

2
Makefile.nmake
View File

@ -1182,7 +1182,7 @@ install-all: install-generated-files
cd ..
checkapi_local:
$(PERL) tools/checkAPIs.pl \
$(PERL) tools/checkAPIs.pl -build \
$(wireshark_SOURCES) \
$(TSHARK_TAP_SRC) \
# $(EXTRA_wireshark_SOURCES)

2
asn1/camel/Makefile.nmake
View File

@ -28,6 +28,6 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
asn1/h225/Makefile.nmake
View File

@ -28,6 +28,6 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
asn1/h235/Makefile.nmake
View File

@ -28,6 +28,6 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
asn1/h450/Makefile.nmake
View File

@ -28,7 +28,7 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
asn1/mpeg-pes/Makefile.nmake
View File

@ -28,6 +28,6 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
asn1/q932/Makefile.nmake
View File

@ -28,6 +28,6 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
asn1/qsig/Makefile.nmake
View File

@ -28,6 +28,6 @@ include Makefile.common
include ../Makefile.inc.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl \
$(PERL) ../../tools/checkAPIs.pl -build \
$(PROTOCOL_NAME).cnf \
packet-$(PROTOCOL_NAME)-template.c

2
codecs/Makefile.am
View File

@ -45,6 +45,6 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) ../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../tools/checkAPIs.pl -g abort -g termoutput -build \
G711a/G711adecode.c \
G711u/G711udecode.c

2
codecs/Makefile.nmake
View File

@ -36,6 +36,6 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../tools/checkAPIs.pl -g abort -g termoutput -build \
G711a/G711adecode.c \
G711u/G711udecode.c

2
epan/Makefile.am
View File

@ -327,4 +327,4 @@ dumpabi: all abi-descriptor.xml
cd .libs; ln -sf libwireshark_*.abi.tar.gz libwireshark.abi.tar.gz
checkapi:
$(PERL) ../tools/checkAPIs.pl -g termoutput $(LIBWIRESHARK_SRC)
$(PERL) ../tools/checkAPIs.pl -g termoutput -build $(LIBWIRESHARK_SRC)

2
epan/Makefile.nmake
View File

@ -333,4 +333,4 @@ dtd_grammar.c: $(LEMON)\lemon.exe $(LEMON)\lempar.c dtd_grammar.lemon
$(LEMON)\lemon t=$(LEMON)\lempar.c dtd_grammar.lemon
checkapi:
$(PERL) ../tools/checkAPIs.pl -g termoutput $(LIBWIRESHARK_SRC)
$(PERL) ../tools/checkAPIs.pl -g termoutput -build $(LIBWIRESHARK_SRC)

2
epan/crypt/Makefile.am
View File

@ -50,5 +50,5 @@ EXTRA_DIST = \
Makefile.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(LIBAIRPDCAP_SRC)

2
epan/crypt/Makefile.nmake
View File

@ -27,5 +27,5 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(LIBAIRPDCAP_SRC)

2
epan/dfilter/Makefile.am
View File

@ -81,6 +81,6 @@ grammar.c : $(LEMON)/lemon$(EXEEXT) $(srcdir)/$(LEMON)/lempar.c $(srcdir)/gramma
(rm -f grammar.c grammar.h ; false)
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(GENERATOR_FILES) \
$(NONGENERATED_C_FILES)

2
epan/dfilter/Makefile.nmake
View File

@ -67,6 +67,6 @@ $(LEMON)\lemon.exe:
cd ../epan/dfilter
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(GENERATOR_FILES) \
$(NONGENERATED_C_FILES)

2
epan/dissectors/Makefile.am
View File

@ -143,6 +143,6 @@ MAINTAINERCLEANFILES = \
Makefile.in
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build \
$(ALL_DISSECTORS_SRC) $(DISSECTOR_INCLUDES) \
packet-dcerpc-nt.c

2
epan/dissectors/Makefile.nmake
View File

@ -115,6 +115,6 @@ maintainer-clean: distclean
rm -f $(GENERATED_FILES)
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build \
$(ALL_DISSECTORS_SRC) $(DISSECTOR_INCLUDES) \
packet-dcerpc-nt.c

2
epan/ftypes/Makefile.am
View File

@ -47,5 +47,5 @@ EXTRA_DIST = \
Makefile.nmake
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(NONGENERATED_C_FILES)

2
epan/ftypes/Makefile.nmake
View File

@ -29,5 +29,5 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(NONGENERATED_C_FILES)

2
epan/wslua/Makefile.am
View File

@ -116,7 +116,7 @@ init.lua: template-init.lua make-init-lua.pl ../ftypes/ftypes.h ../../wiretap/wt
$(PERL) $(srcdir)/make-init-lua.pl $(top_srcdir) $(srcdir)/template-init.lua > init.lua
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
init_wslua.c \
register_wslua.c \
taps_wslua.c \

2
epan/wslua/Makefile.nmake
View File

@ -84,7 +84,7 @@ init.lua: template-init.lua make-init-lua.pl ../ftypes/ftypes.h ../../wiretap/wt
$(PERL) make-init-lua.pl "../.." template-init.lua > init.lua
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(MODULES) \
init_wslua.c \
register_wslua.c \

2
epan/wspython/Makefile.nmake
View File

@ -27,5 +27,5 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g termoutput -build \
$(LIBWSPYTHON_OBJECTS)

2
plugins/asn1/Makefile.am
View File

@ -124,4 +124,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/asn1/Makefile.nmake
View File

@ -102,4 +102,4 @@ maintainer-clean: distclean
checkapi:
# TODO: Fix api's :)
# $(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
# $(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/docsis/Makefile.am
View File

@ -127,4 +127,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/docsis/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/easy_codec/Makefile.nmake
View File

@ -65,4 +65,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/ethercat/Makefile.am
View File

@ -126,4 +126,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/ethercat/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/giop/Makefile.am
View File

@ -67,7 +67,7 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build \
packet-cosnaming.c \
packet-coseventcomm.c \
packet-tango.c \

2
plugins/giop/Makefile.nmake
View File

@ -52,7 +52,7 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build \
packet-cosnaming.c \
packet-coseventcomm.c \
packet-tango.c \

2
plugins/gryphon/Makefile.am
View File

@ -128,4 +128,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/gryphon/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/irda/Makefile.am
View File

@ -126,4 +126,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/irda/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/m2m/Makefile.am
View File

@ -126,4 +126,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/m2m/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/mate/Makefile.am
View File

@ -146,4 +146,4 @@ mate_grammar.c : mate_grammar.lemon mate.h mate_util.h $(LEMON)/lemon$(EXEEXT)
(rm -f grammar.c grammar.h ; false)
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/mate/Makefile.nmake
View File

@ -134,4 +134,4 @@ $(LEMON)\lemon.exe:
cd ../plugins/mate
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/opcua/Makefile.am
View File

@ -128,4 +128,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/opcua/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/profinet/Makefile.am
View File

@ -126,4 +126,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/profinet/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/stats_tree/Makefile.am
View File

@ -58,4 +58,4 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(TAP_SRC) $(TAP_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(TAP_SRC) $(TAP_INCLUDES)

2
plugins/stats_tree/Makefile.nmake
View File

@ -55,4 +55,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(TAP_SRC) $(TAP_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(TAP_SRC) $(TAP_INCLUDES)

2
plugins/tpg/Makefile.am
View File

@ -76,4 +76,4 @@ http-parser.c: http.tpg $(TPG)/tpg.pl $(TPG)/TPG.pm
$(PERL) -I$(TPG) $(TPG)/tpg.pl http.tpg
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/tpg/Makefile.nmake
View File

@ -66,4 +66,4 @@ $(LEMON)\lemon.exe:
cd ../plugins/mate
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/unistim/Makefile.am
View File

@ -128,4 +128,4 @@ EXTRA_DIST = \
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/unistim/Makefile.nmake
View File

@ -101,4 +101,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/wimax/Makefile.am
View File

@ -126,7 +126,7 @@ EXTRA_DIST = \
CMakeLists.txt
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build \
$(DISSECTOR_SRC) \
$(DISSECTOR_INCLUDES) \
$(DISSECTOR_SUPPORT_SRC)

2
plugins/wimax/Makefile.nmake
View File

@ -101,7 +101,7 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build \
$(DISSECTOR_SRC) \
$(DISSECTOR_INCLUDES) \
$(DISSECTOR_SUPPORT_SRC)

2
plugins/wimaxasncp/Makefile.am
View File

@ -146,4 +146,4 @@ wimaxasncpdir = $(pkgdatadir)/wimaxasncp
checkapi:
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

2
plugins/wimaxasncp/Makefile.nmake
View File

@ -114,4 +114,4 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)
$(PERL) ../../tools/checkAPIs.pl -g abort -g termoutput -build $(DISSECTOR_SRC) $(DISSECTOR_INCLUDES)

8
tools/checkAPIs.pl
View File

@ -1324,7 +1324,7 @@ sub checkAddTextCalls($$)
$okay_add_text_count++;
}
# Then count how many proto_tree_add_*() calls there are
while (${$fileContentsRef} =~ m/ \W proto_tree_add_[a-z]+ \W* \( /gox) {
while (${$fileContentsRef} =~ m/ \W proto_tree_add_[a-z0-9]+ \W* \( /gox) {
$add_xxx_count++;
}
@ -1633,6 +1633,7 @@ my $check_value_string_array_null_termination = 1; # default: enabled
my $machine_readable_output = 0; # default: disabled
my $check_hf = 1; # default: enabled
my $debug_flag = 0;
my $buildbot_flag = 0;
my $result = GetOptions(
'group=s' => \@apiGroups,
@ -1640,6 +1641,7 @@ my $result = GetOptions(
'check-value-string-array-null-termination!' => \$check_value_string_array_null_termination,
'Machine-readable' => \$machine_readable_output,
'nohf' => \$check_hf,
'build' => \$buildbot_flag,
'debug' => \$debug_flag
);
if (!$result) {
@ -1730,7 +1732,9 @@ while ($_ = $ARGV[0])
# print STDERR "Found APIs with embedded tvb_get_ptr() calls in ".$filename.": ".join(',', @foundAPIs)."\n"
#}
#checkAddTextCalls(\$fileContents, $filename);
if (! $buildbot_flag) {
checkAddTextCalls(\$fileContents, $filename);
}
# Brute force check for value_string arrays which are missing {0, NULL} as the final (terminating) array entry
if ($check_value_string_array_null_termination) {

4
ui/Makefile.am
View File

@ -62,11 +62,11 @@ endif # HAVE_DOXYGEN
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../tools/checkAPIs.pl -g deprecated-gtk -build \
$(WIRESHARK_UI_SRC)
checkapi-todo:
$(PERL) ../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(WIRESHARK_UI_SRC)
EXTRA_DIST = \

4
ui/Makefile.nmake
View File

@ -72,9 +72,9 @@ doxygen: doxygen.cfg doxygen-run doxygen.chm
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../tools/checkAPIs.pl -g deprecated-gtk -build \
$(WIRESHARK_UI_SRC)
checkapi-todo:
$(PERL) ../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(WIRESHARK_UI_SRC)

4
ui/cli/Makefile.am
View File

@ -79,11 +79,11 @@ endif # HAVE_DOXYGEN
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk -build \
$(TSHARK_TAP_SRC)
checkapi-todo:
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(TSHARK_TAP_SRC)
EXTRA_DIST = \

4
ui/cli/Makefile.nmake
View File

@ -65,9 +65,9 @@ maintainer-clean: distclean
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk -build \
$(TSHARK_TAP_SRC)
checkapi-todo:
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(TSHARK_TAP_SRC)

4
ui/gtk/Makefile.am
View File

@ -92,12 +92,12 @@ endif # HAVE_DOXYGEN
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk -build \
$(WIRESHARK_CLEAN_LIBGTKUI_SRC) \
capture_if_details_dlg_win32.c
checkapi-todo:
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(WIRESHARK_GTK_SRC) \
$(WIRESHARK_TAP_SRC) \
capture_if_details_dlg_win32.c

4
ui/gtk/Makefile.nmake
View File

@ -178,11 +178,11 @@ doxygen: doxygen.cfg doxygen-run doxygen.chm
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk -build \
$(WIRESHARK_CLEAN_LIBGTKUI_SRC) \
$(WIRESHARK_TAP_SRC)
checkapi-todo:
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(WIRESHARK_CLEAN_LIBGTKUI_SRC) \
$(WIRESHARK_TAP_SRC)

4
ui/qt/Makefile.am
View File

@ -89,13 +89,13 @@ endif # HAVE_DOXYGEN
checkapi: checkapi-base checkapi-todo
checkapi-base:
$(PERL) ../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../tools/checkAPIs.pl -g deprecated-gtk -build \
$(WIRESHARK_GTK_SRC) \
$(WIRESHARK_TAP_SRC) \
capture_if_details_dlg_win32.c
checkapi-todo:
$(PERL) ../tools/checkAPIs.pl -M -g deprecated-gtk-todo \
$(PERL) ../tools/checkAPIs.pl -M -g deprecated-gtk-todo -build \
$(WIRESHARK_GTK_SRC) \
$(WIRESHARK_TAP_SRC) \
capture_if_details_dlg_win32.c

2
ui/win32/Makefile.nmake
View File

@ -36,5 +36,5 @@ distclean: clean
maintainer-clean: distclean
checkapi:
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk \
$(PERL) ../../tools/checkAPIs.pl -g deprecated-gtk -build \
$(WIRESHARK_WIN32_SRC)

2
wiretap/Makefile.am
View File

@ -102,4 +102,4 @@ dumpabi: all abi-descriptor.xml
checkapi:
## 'abort' checking disabled for now pending resolution of existing use of g_assert & g_error
## $(PERL) ../tools/checkAPIs.pl -g abort -g termoutput $(NONGENERATED_C_FILES) $(GENERATOR_FILES)
$(PERL) ../tools/checkAPIs.pl -g termoutput $(NONGENERATED_C_FILES) $(GENERATOR_FILES)
$(PERL) ../tools/checkAPIs.pl -g termoutput -build $(NONGENERATED_C_FILES) $(GENERATOR_FILES)

2
wiretap/Makefile.nmake
View File

@ -78,4 +78,4 @@ maintainer-clean: distclean
checkapi:
## 'abort' checking disabled for now pending resolution of existing use of g_assert & g_error
## $(PERL) ../tools/checkAPIs.pl -g abort -g termoutput $(NONGENERATED_C_FILES) $(GENERATOR_FILES)
$(PERL) ../tools/checkAPIs.pl -g termoutput $(NONGENERATED_C_FILES) $(GENERATOR_FILES)
$(PERL) ../tools/checkAPIs.pl -g termoutput -build $(NONGENERATED_C_FILES) $(GENERATOR_FILES)

2
wsutil/Makefile.am
View File

@ -138,6 +138,6 @@ dumpabi: all abi-descriptor.xml
checkapi:
# $(PERL) ../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../tools/checkAPIs.pl -g termoutput \
$(PERL) ../tools/checkAPIs.pl -g termoutput -build \
$(LIBWSUTIL_SRC)
# file_util.c unicode-utils.c

2
wsutil/Makefile.nmake
View File

@ -56,6 +56,6 @@ maintainer-clean: distclean
checkapi:
## $(PERL) ../tools/checkAPIs.pl -g abort -g termoutput \
$(PERL) ../tools/checkAPIs.pl -g termoutput \
$(PERL) ../tools/checkAPIs.pl -g termoutput -build \
$(LIBWSUTIL_SRC) \
# file_util.c unicode-utils.c