Commit graph

8124 commits

Author SHA1 Message Date
Stig Bjørlykke
67261c278c Comment out unused code.
svn path=/trunk/; revision=23891
2007-12-16 20:27:55 +00:00
Anders Broman
8b342ea896 Update comments.
svn path=/trunk/; revision=23889
2007-12-16 17:43:10 +00:00
Anders Broman
e39e24d262 Add a few more bits.
svn path=/trunk/; revision=23888
2007-12-16 17:42:35 +00:00
Stig Bjørlykke
fa34d46851 From Fulko Hew:
1/ patches to support the libpcap/SITA format 'WTAP_ENCAP_SITA'.
2/ patches to the LAPB dissector to accept MLP (Multi-link protocol)
   (although MLP dissection has _not_ been added (yet)).
3/ New protocol dissectors for:
   a) SITA's WAN layer 0 status header,
   b) An airline protocol ALC,
   c) An airline (and other industry) protocol UTS.

These patches are submitted as a set since the new protocol dissectors are not
useful without the libpcap/SITA related changes, and there is no point in
having those changes without the additional dissectors.

This fixes bug/enhancement 2016.

svn path=/trunk/; revision=23885
2007-12-16 14:21:37 +00:00
Stig Bjørlykke
0238daecf6 From Jim Young:
Fixed reading uat personal files before global files.

This fixes bug 2070.

svn path=/trunk/; revision=23883
2007-12-16 13:17:37 +00:00
Sake Blok
4f05930abe Big 2104 - From Benn Bollay:
This patch adds a heuristic dissector to the ethernet trailer under the
keystring "eth.trailer".  This allows for other protocol plugins which coopt
the ethernet trailer for their own devices to register for trailer traffic
without requiring any further changes to the executable.


svn path=/trunk/; revision=23880
2007-12-16 00:35:34 +00:00
Sake Blok
8f7d4aff96 Fixes the "follow tcp stream" output when there are frames missing in the
capture file that were actually on the wire. The reassembly code waited for 
the gaps to be filled in by retransmissions, which would never come.

With this fix all acknowledged data will be output with "[xxx bytes missing in 
capture file]" inserted in every gap.


svn path=/trunk/; revision=23878
2007-12-15 23:25:05 +00:00
Guy Harris
4b2ce71547 Get rid of another non-ASCII character.
svn path=/trunk/; revision=23877
2007-12-15 19:36:25 +00:00
Martin Mathieson
b54b6b4af0 Fix preference text (SDP isn't only carried over SIP).
svn path=/trunk/; revision=23876
2007-12-15 18:26:21 +00:00
Graeme Lunt
9c6ac3835f Revised DAP dissector using latest asn2wrs features (requiring fewer changes the ASN.1 module) and table-driven operations.
svn path=/trunk/; revision=23875
2007-12-15 15:21:25 +00:00
Graeme Lunt
7a5f960bb7 Add missing proto_get_id
svn path=/trunk/; revision=23874
2007-12-15 15:17:07 +00:00
Jaap Keuter
4c8455b1fd Clean up header field info comments.
svn path=/trunk/; revision=23872
2007-12-15 13:21:05 +00:00
Jaap Keuter
74cf6511fb Cleanup call_dissector / call_dissector_only
svn path=/trunk/; revision=23871
2007-12-15 13:20:17 +00:00
Anders Broman
16341e7365 - Add col info.
- Small bugfix (duplicated tree info).
- Dissect first few bits for more NAL units

svn path=/trunk/; revision=23870
2007-12-15 13:06:35 +00:00
Stig Bjørlykke
a6b218a489 Fixed comments.
svn path=/trunk/; revision=23869
2007-12-14 23:40:42 +00:00
Anders Broman
0d6f59f859 Some more dissection added.
svn path=/trunk/; revision=23868
2007-12-14 21:27:18 +00:00
Jaap Keuter
574dfb7f8c From Zbigniew Kopek:
Here are additional DHCP Suboptions for Option 43 introduced in new eDOCSIS
Cable Laboratories documentation:
( http://www.cablemodem.com/downloads/specs/CM-SP-eDOCSIS-I13-070803.pdf )
Also display suboptions for Option 43 for OpenCable devices.

svn path=/trunk/; revision=23867
2007-12-14 20:14:15 +00:00
Gerald Combs
4bf02de80a Wlancap enhancements and fixes from Solomon Peachy.
svn path=/trunk/; revision=23865
2007-12-14 19:10:01 +00:00
Jörg Mayer
0c797861ba Warning fixes: function declaration isn’t a prototype
svn path=/trunk/; revision=23862
2007-12-14 15:14:40 +00:00
Jörg Mayer
6869154121 If we implement new style dissectors, register them as such.
svn path=/trunk/; revision=23861
2007-12-14 14:58:28 +00:00
Stephen Fisher
5b1372aeff Fix compilation on Unix (unused variable passed to function)
svn path=/trunk/; revision=23859
2007-12-13 22:47:42 +00:00
Anders Broman
38f23ab4e6 Finish dissection of
- NAL unit - Sequence parameter set
- NAL unit - Picture parameter set
for the trace I have and also dissect those NAL units in the RTP stream.
For "elements coded as ue(v), me(v), or se(v) are Exp-Golomb-coded" only ue(v) is implemented.

svn path=/trunk/; revision=23858
2007-12-13 21:20:52 +00:00
Jörg Mayer
7303115b86 Replace // comments
svn path=/trunk/; revision=23856
2007-12-13 11:37:03 +00:00
Jörg Mayer
3c397a3459 Add airopeek dissector
svn path=/trunk/; revision=23855
2007-12-13 11:33:53 +00:00
Jörg Mayer
160d7b71af Update a comment about some flags
svn path=/trunk/; revision=23853
2007-12-12 23:59:31 +00:00
Jörg Mayer
68a28c4a97 The extra bytes seem to go away if I call wlan_datapad instead
of wlan.

svn path=/trunk/; revision=23852
2007-12-12 23:26:39 +00:00
Jörg Mayer
a1af5ede6f Beginnings of airopeek remote capture support.
The metainformation is not yet decoded, also, there
are problems with QoS frames (extra bytes).

svn path=/trunk/; revision=23851
2007-12-12 23:03:44 +00:00
Anders Broman
4d01fd05cb tvbuff.c - fix abug if reading last byte in tvb
Further H.264 decoding in SDP

svn path=/trunk/; revision=23847
2007-12-12 21:50:14 +00:00
Tomas Kukosa
a76ff82d70 - register RFC 2198 as RTP dynamic payload type "red"
- display dynamic payload type names inside RFC 2198

svn path=/trunk/; revision=23846
2007-12-12 10:51:09 +00:00
Gerald Combs
3254a8f9cb Don't free memory that we're going to use later.
svn path=/trunk/; revision=23841
2007-12-11 21:17:55 +00:00
Tomas Kukosa
2ce05b41eb strings registered to dissector table have to be allocated permanently
svn path=/trunk/; revision=23838
2007-12-11 09:33:09 +00:00
Jaap Keuter
6016eab0bf From Jim Young:
Attached is a patch to packet-vlan.c to add "summary info" to the protocol tree.

svn path=/trunk/; revision=23837
2007-12-11 07:42:36 +00:00
Stephen Fisher
1479f03673 Make the EtherNet/IP (Industrial Protocol) I/O dissection a new type
of dissector that rejects packets it doesn't recognize (on udp port
2222).


svn path=/trunk/; revision=23836
2007-12-11 04:33:08 +00:00
Stig Bjørlykke
36c9b397d7 uint16_t -> guint16
uint32_t -> guint32

svn path=/trunk/; revision=23835
2007-12-10 22:22:15 +00:00
Stig Bjørlykke
5a1bb85a2c Mark some pinfo unused to make it compile.
svn path=/trunk/; revision=23833
2007-12-10 22:18:53 +00:00
Anders Broman
92e1ee3721 Decode more of H264 info in SDP.
svn path=/trunk/; revision=23832
2007-12-10 21:25:32 +00:00
Ronnie Sahlberg
9a3eeab4ee add some more names for Query/Set path info levels and add empty stubs
for these blobs


svn path=/trunk/; revision=23831
2007-12-10 21:16:17 +00:00
Jaap Keuter
1f272d5f5e From Masatake YAMATO:
This dissector supports version 3.0 of the dlm (Distributed Lock Manager) protocol.
Actual implementation for the protocol is in linux kernel. See files under linux/fs/dlm/.

svn path=/trunk/; revision=23828
2007-12-10 19:02:43 +00:00
Anders Broman
70aa312f01 Add OID:s related to H264.
svn path=/trunk/; revision=23827
2007-12-10 18:25:44 +00:00
Stig Bjørlykke
d450d9fe4e Added option to turn off SEQ/ACK analysis.
Moved some resend expert infos to correct entry.
Small fix in seq/ack analysis for report/notificacion.

svn path=/trunk/; revision=23825
2007-12-10 11:17:48 +00:00
Tomas Kukosa
1e794fc494 ANSI TCAP regenerated and tested with -T -X asn2wrs options
asn2wrs has -T (tagged types support) and -X (new BER sttructures) default behavior
remove all -T and -X usage

svn path=/trunk/; revision=23823
2007-12-10 08:35:41 +00:00
Gerald Combs
b7d8f269b2 Make sure we don't try to allocate a negative number.
svn path=/trunk/; revision=23820
2007-12-10 03:12:11 +00:00
Guy Harris
b2f28fb370 Get rid of non-ASCII character in a value_string table. (They might
upset MSVC++ if the wrong code page is selected, and there's no
guarantee that all forms of output of dissected packets are in any
particular character encoding.)

svn path=/trunk/; revision=23819
2007-12-09 21:10:25 +00:00
Anders Broman
e5f48395f1 Move the routines tvb_skip_wsp() to tvbuff.c
svn path=/trunk/; revision=23818
2007-12-09 17:41:16 +00:00
Jaap Keuter
006d1c446e From Márton Németh:
When an ISOCHRONOUS URB was captured the packet-usb.c does not handle it.
Case URB_ISOCHRONOUS was added at two different places to handle it also.

svn path=/trunk/; revision=23817
2007-12-09 10:59:09 +00:00
Jörg Mayer
1621df1080 Warning fix:
- No comma after last element in enum

Fix:
- Call new_dissector_register for new style dissector.

svn path=/trunk/; revision=23808
2007-12-08 17:45:02 +00:00
Stephen Fisher
f4fcd1b146 Fix TiVoConnect dissector, seemingly broken since rev 18415.
svn path=/trunk/; revision=23807
2007-12-08 09:15:23 +00:00
Gerald Combs
be6e31fa44 Register the "samr.nt_password" preference as obsolete.
svn path=/trunk/; revision=23794
2007-12-07 18:50:41 +00:00
Gerald Combs
fcadd9d59f Fix a typo.
svn path=/trunk/; revision=23793
2007-12-07 18:47:03 +00:00
Martin Mathieson
a73c7817f6 Fix build by creating dissect function that tcp_dissect_pdus(). My Windows build didn't miss the mismatched return type...
svn path=/trunk/; revision=23791
2007-12-07 13:26:15 +00:00
Martin Mathieson
f33ca55e00 Make stun2 over udp a new-style dissector, so that it can reject stun frames on the standard port they share (and let the heuristic dissector for stun run). Otherwise I needed to set UDP to try heuristic dissectors first or disable stun2 altogether...
svn path=/trunk/; revision=23789
2007-12-07 00:23:16 +00:00
Tomas Kukosa
1bef58264a fix field attributes handling for tagged types
regenerate involved dissectors

svn path=/trunk/; revision=23783
2007-12-06 11:23:35 +00:00
Guy Harris
a3d7a2c66f Squelch a warning about a variable getting clobbered by a longjmp.
svn path=/trunk/; revision=23780
2007-12-06 08:22:16 +00:00
Anders Broman
325b335505 fixe http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2064 GSM_MAP decodes SendRoutingInfov2 incorrectly
- Add TYPE_ATTR for RoutingInfo ( Fixes the choice problem).
- Dissect ExternalSignalInfo
- Use subtree for AddressStrings

svn path=/trunk/; revision=23776
2007-12-05 21:58:58 +00:00
Anders Broman
437bfb9910 Remove debug code.
svn path=/trunk/; revision=23775
2007-12-05 20:49:46 +00:00
Anders Broman
d639aace72 Insert asn1 code for SendRoutingInfov2 and update template
Partly fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2064 GSM_MAP decodes SendRoutingInfov2 incorrectly

svn path=/trunk/; revision=23774
2007-12-05 20:16:02 +00:00
Jeff Morriss
20a98a36f3 From Cliff Romash: TMR is not a mandatory parameter on an ANSI IAM but USI is.
svn path=/trunk/; revision=23773
2007-12-05 19:55:40 +00:00
Guy Harris
ad1d82b541 Include <glib.h> to declare g_vsnprintf().
svn path=/trunk/; revision=23768
2007-12-05 10:35:37 +00:00
Guy Harris
3af2d0708a Use g_vsnprintf(), not vsprintf(), for safety's sake.
svn path=/trunk/; revision=23766
2007-12-05 10:30:38 +00:00
Guy Harris
61eeae5de2 Clean up indentation.
Use G_GINT64_MODIFIER for gint64 and guint64 values.  Use "u", rather
than "d", for unsigned values.  Put whitespace in the proper place in
format strings.

svn path=/trunk/; revision=23762
2007-12-05 09:43:20 +00:00
Guy Harris
35fc0e7187 Make the "protocol" field big enough to hold the 3-character
null-terminated string that the format item used when scanning says it
is - i.e., 4 "char"s, including the null terminator.

(Thanks and a tip of the hat to "gcc (GCC) 3.3.5 (propolice)" on OpenBSD
4.2 for finding this.)

svn path=/trunk/; revision=23761
2007-12-05 09:31:05 +00:00
Guy Harris
9aa28e3176 At least on some LP64 platforms (such as OpenBSD 4.2 on x86-64),
PRI[dux]64 use "ll", but gint64 and guint64 are "long" and "unsigned
long", not "long long" or "unsigned long long", and the compiler warns
about using "%ll[doux]" with "long" or "unsigned long".  Use
G_GINT64_MODIFIER instead.

svn path=/trunk/; revision=23760
2007-12-05 09:05:52 +00:00
Ronnie Sahlberg
d55f6955d6 the GSS Checksum in secure onc-rpc contains the same blobs as GSS Tokens
does.

make wireshark decode these blobs


svn path=/trunk/; revision=23759
2007-12-05 08:37:51 +00:00
Mike Duigou
cb3f7e3f7d svn path=/trunk/; revision=23758 2007-12-05 04:20:21 +00:00
Guy Harris
f43601180c Only define oid_get_default_mib_path() if we have libsmi.
Explicitly mark it as having no arguments.

svn path=/trunk/; revision=23754
2007-12-04 19:39:09 +00:00
Gerald Combs
0fa29bb1ea Add an oid_get_default_mib_path() function, and use it to display the MIB
path in About->Folders.

svn path=/trunk/; revision=23753
2007-12-04 18:43:40 +00:00
Greg Morris
6c87d3d49e Display textual explanation for printer and job values from RFC 2911.
svn path=/trunk/; revision=23752
2007-12-04 16:33:48 +00:00
Stig Bjørlykke
0f0c02bbae Duplicate packet # -> Retransmission #
svn path=/trunk/; revision=23751
2007-12-04 14:04:37 +00:00
Tomas Kukosa
08bbd29c71 Support for RPCAP features in GUI (from Boris Misenov, see Bug 1366)
- retrieving the list of remote PCAP interfaces
  - password authentication support
  - UDP data fransfer
  - packet sampling (available in WinPcap 4.x)
  etc.

fix problem if non-default rpcap port is used

svn path=/trunk/; revision=23750
2007-12-04 11:19:29 +00:00
Jaap Keuter
852d928901 Make mpeg2ts over UDP possible. Heuristic and Decode as.
svn path=/trunk/; revision=23743
2007-12-04 07:11:38 +00:00
Jaap Keuter
f4c89beb21 Remove superfluous buffer allocation.
svn path=/trunk/; revision=23742
2007-12-04 06:50:11 +00:00
Anders Broman
95d422156a Use common code for ASCII -> tvb.
svn path=/trunk/; revision=23741
2007-12-04 06:00:02 +00:00
Ronnie Sahlberg
8686381c19 get rid of GTree and use emem trees instead
svn path=/trunk/; revision=23738
2007-12-04 03:28:04 +00:00
Ronnie Sahlberg
ee6c98b8b2 update to new signature for string keyed trees
svn path=/trunk/; revision=23737
2007-12-04 03:27:27 +00:00
Ronnie Sahlberg
b153578afa rework how emem trees indexed by strings so that traversing the tree
will traverse the entries in the lexical order of the key.

add a flag to lookup/insert for strings to specify whether a case 
insensitive key should be used instead of a (default) case sensitive 
key.


svn path=/trunk/; revision=23736
2007-12-04 03:26:50 +00:00
Ronnie Sahlberg
643705ac5d reverse previous patch
svn path=/trunk/; revision=23735
2007-12-04 02:09:37 +00:00
Ronnie Sahlberg
75eacd9ad5 remove the use of GTrees and replace these with emem trees instead
svn path=/trunk/; revision=23734
2007-12-04 01:45:17 +00:00
Ronnie Sahlberg
c20bb13d67 for nested trees, teach emem about which nodes contain a pointer to a
subtree and which nodes that contain a pointer to user data

teach emem to be able to traverse nested trees


svn path=/trunk/; revision=23733
2007-12-04 01:44:05 +00:00
Guy Harris
04938c7926 Reserve 20 bits for expert "event groups", to leave room for more.
Shuffle the expert severities down, and note that we have only 8 bits
available for FI_ flags unless you shrink the set of event groups and
shuffle them and the expert severities up.

svn path=/trunk/; revision=23731
2007-12-04 01:26:02 +00:00
Ronnie Sahlberg
0c09ac97f6 #if out a function that is only used when building with glib 2 or later
svn path=/trunk/; revision=23730
2007-12-04 00:56:11 +00:00
Guy Harris
ce635c2310 Severities are unsigned.
svn path=/trunk/; revision=23727
2007-12-03 23:02:09 +00:00
Guy Harris
ebd47f95d1 Make the flags field a guint32, to make it clear that it's 32 bits.
Move the expert information bits to the top of that field, to avoid
collisions (we had a collision with the 0x00000004 bit).

svn path=/trunk/; revision=23726
2007-12-03 22:48:49 +00:00
Ronnie Sahlberg
60c561e2bd add tree traversal functions
svn path=/trunk/; revision=23725
2007-12-03 22:47:23 +00:00
Anders Broman
b414c81f1f Fetch all fmtp parameters.
svn path=/trunk/; revision=23724
2007-12-03 22:40:04 +00:00
Anders Broman
063c688bc0 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2057
The tag for PSTNTermination is [95].

svn path=/trunk/; revision=23723
2007-12-03 22:22:25 +00:00
Ronnie Sahlberg
b10403f13e add end of line to the last line of the file
svn path=/trunk/; revision=23718
2007-12-03 21:54:27 +00:00
Ronnie Sahlberg
830da048fc mark two unused parameters as _U_
svn path=/trunk/; revision=23717
2007-12-03 21:52:57 +00:00
Stig Bjørlykke
b958a1a124 Mark pinfo as unused.
svn path=/trunk/; revision=23713
2007-12-03 21:33:56 +00:00
Anders Broman
20b383c1b1 Dissect RTP payload of H.264 and SDP profile-leve-id for H.264.
svn path=/trunk/; revision=23709
2007-12-03 20:14:42 +00:00
Graeme Lunt
a58643173d Revised P7 dissector to use #.TABLE directive to generate tables for the ROS dissector from
the [ABSTRACT] OPERATIONS definitions in the ASN.1 file.


svn path=/trunk/; revision=23707
2007-12-03 19:32:28 +00:00
Graeme Lunt
5d8693069d Support table-based dissection of ROS operations.
This simplifies the generation of dissectors for ROS-based protocols using the asn2wrs #.TABLE directive.

See the P7 dissector for an example.


svn path=/trunk/; revision=23706
2007-12-03 19:29:24 +00:00
Jeff Morriss
aabf0f25d1 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2059 : reassemble XUDTS, too
svn path=/trunk/; revision=23705
2007-12-03 18:12:25 +00:00
Jeff Morriss
757b5e13e6 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2063 : there's only 1 octet of FSN in non-ANSI COO/COA's.
svn path=/trunk/; revision=23704
2007-12-03 17:32:02 +00:00
Martin Mathieson
8a311e2320 Add "soap" -> "http" mapping.
svn path=/trunk/; revision=23703
2007-12-03 15:47:08 +00:00
Tomas Kukosa
0ba8976eb7 fix confusion in tag handling
svn path=/trunk/; revision=23702
2007-12-03 13:48:45 +00:00
Martin Mathieson
b8ef070e84 My compiler (I think wrongly) says that fnum could be used uninitialised.
svn path=/trunk/; revision=23701
2007-12-03 12:22:13 +00:00
Ulf Lamping
34250e0617 add libwireshark.def
svn path=/trunk/; revision=23692
2007-11-30 22:01:52 +00:00
Stig Bjørlykke
ecdb4359d2 From Florent DROUIN:
I just add a test for the index, to check we are in the element table.

This fixes bug 2051.

svn path=/trunk/; revision=23688
2007-11-30 16:01:08 +00:00
Stig Bjørlykke
8286c9a645 From Florent DROUIN:
There is a new check for the length, and the reported_length is added to the
offset, instead of the "theorical" length of the element.

This fixes bug 2052.

svn path=/trunk/; revision=23687
2007-11-30 15:55:28 +00:00
Tomas Kukosa
f9fae482f5 define ssl_debug_flush() for disabled debug
svn path=/trunk/; revision=23683
2007-11-30 12:41:23 +00:00
Tomas Kukosa
187864ff8f setup SRTP stream if MIKEY is detected in OLC
svn path=/trunk/; revision=23682
2007-11-30 12:37:30 +00:00
Tomas Kukosa
b19d4c9e42 use g_strconcat() which should be faster instead of g_strdup_printf()
svn path=/trunk/; revision=23681
2007-11-30 11:46:13 +00:00
Tomas Kukosa
aab2bf936e - fix warnings in prefs.c
- do not flush SSL debug output after each message but only once per packet

svn path=/trunk/; revision=23680
2007-11-30 11:12:55 +00:00
Tomas Kukosa
6caaafbb6d Next few improvements to speed up startup about 10%.
- use GTree instead of GList for preference module lists

svn path=/trunk/; revision=23679
2007-11-30 09:22:01 +00:00
Gerald Combs
36f0b417ea Add a directory argument and some default directories to "configure
--with-libsmi".

svn path=/trunk/; revision=23676
2007-11-30 00:45:12 +00:00
Stig Bjørlykke
c068f9acf2 From Jens Braeuer (bug 1999):
This patchs adds the 
- requested check of tlv_len at top of the disection-loop
- length check for fields w/ variable length (expert_add_info_format)

svn path=/trunk/; revision=23673
2007-11-29 17:25:36 +00:00
Tomas Kukosa
a5ca7ec384 hide implementation of module list
(it makes easier change from GList to GTree as we have many modules now and GList implementation is slow for searching)

svn path=/trunk/; revision=23669
2007-11-29 07:52:52 +00:00
Tomas Kukosa
7f4df19970 fix GLIB 1.x compatibility
svn path=/trunk/; revision=23668
2007-11-29 07:48:12 +00:00
Anders Broman
b1370e46d0 Didier Gautheron:
Only call ether_to_str(), get_ether_name() if the tree is visible, they are slow.

svn path=/trunk/; revision=23666
2007-11-29 06:29:20 +00:00
Anders Broman
87503b059e Didier Gautheron:
Call subdissectors preference for retransmitted frames.

svn path=/trunk/; revision=23665
2007-11-29 06:28:07 +00:00
Bill Meier
b69928928f From Didier Gautheron: Fix for Bug #1862: JPEG (JFIF) packet always malformed
svn path=/trunk/; revision=23662
2007-11-29 00:01:09 +00:00
Bill Meier
b436aeaf5f From Didier Gautheron: Bug #2042: Move constants initialisation at compile time.
svn path=/trunk/; revision=23659
2007-11-28 22:44:37 +00:00
Bill Meier
6d4dda3327 From Didier Gautheron: Bug #2040: Fix up goto at compilation time in gencode.c
svn path=/trunk/; revision=23658
2007-11-28 22:37:33 +00:00
Bill Meier
437b861f47 Fropm Anders: Broman: Fix for bug #2041
svn path=/trunk/; revision=23655
2007-11-28 22:13:50 +00:00
Anders Broman
5935bf73a4 Didier Gautheron:
icmp dissector must call subdissectors even if tree is NULL

svn path=/trunk/; revision=23653
2007-11-28 21:44:40 +00:00
Bill Meier
7f9585782d Fixes for Windows build w/o ZLIB
svn path=/trunk/; revision=23651
2007-11-28 20:06:21 +00:00
Bill Meier
48bb4deed1 (Somewhat academic): Fix fread related bug (when using GTK1).
svn path=/trunk/; revision=23650
2007-11-28 19:53:36 +00:00
Jaap Keuter
fe11aff158 From Brian W. Antoine:
The Packet decoder for CFM has a couple of small bugs.
1) The frame rate for CCM's is wrong for rate=4, it's shown as 1ms and it should be shown as 1s.
2) The flags display for a LTM packet has the wrong title for bit 7.  It should be UseFDBonly, not RDI.

svn path=/trunk/; revision=23649
2007-11-28 18:59:37 +00:00
Stephen Fisher
2463784fbd Fix filename in comment at top (it's .asm not .c)
svn path=/trunk/; revision=23647
2007-11-28 17:43:42 +00:00
Gerald Combs
f07871ac79 Use guints instead of guint8s for counters.
svn path=/trunk/; revision=23646
2007-11-28 15:55:50 +00:00
Tomas Kukosa
1a001629bd try to fix *nix build environment
in accordance with asm_utils.c/asm_utils_win32_x86.asm used in Win32

svn path=/trunk/; revision=23645
2007-11-28 14:39:51 +00:00
Tomas Kukosa
ff7c20938e Various changes with focus to startup speedup
The startup timeout on Win32 is reduced to 80% without assembler and to 50% with assembler usage (which is optional)
proto.c
 - do not look up in filed tree and inserts in two steps but do it at once
 - next few small speedups
 - some often called elementary functions can be optionally implemented in assembler
 - dispart some functions to see more exact result from profiling
packet-tpnc.c
 - do not reallocate memory for each filed

svn path=/trunk/; revision=23643
2007-11-28 10:18:16 +00:00
Stig Bjørlykke
60686647d2 Fixed a possible infinite loop.
svn path=/trunk/; revision=23642
2007-11-28 09:30:10 +00:00
Ronnie Sahlberg
c79cf40b3b update to most recent wkssvc.idl from the samba4 repository
svn path=/trunk/; revision=23641
2007-11-28 06:21:28 +00:00
Ronnie Sahlberg
5fceae6ecb we must include glib.h so we know what gchar and gsize is
svn path=/trunk/; revision=23635
2007-11-28 01:21:33 +00:00
Ronnie Sahlberg
722ab30a62 we must include config.h or else NEED_G_ASCII_STRCASECMP_H will never be
defined

we must also include g_ascii_strcasecmp.h from the parent directory


svn path=/trunk/; revision=23634
2007-11-28 01:20:46 +00:00
Stig Bjørlykke
111cedfc75 - Added SEQ/ACK analysis for reports and notifications.
- Identify ack type in COL_INFO.
- No analysis when in error packets.
- Some cleanup in hf_ names.

svn path=/trunk/; revision=23630
2007-11-27 22:54:15 +00:00
Anders Broman
95d8c7e2da Apply yet another of the optimization patches:
- Only call functions if they are needed or once.

svn path=/trunk/; revision=23628
2007-11-27 21:24:39 +00:00
Anders Broman
eeab60b75f Apply yet another of the optimization patches:
- Remove a spurious volatile.

svn path=/trunk/; revision=23627
2007-11-27 21:23:45 +00:00
Gerald Combs
e679376996 From Sam Leffler: Add support for IEEE80211_RADIOTAP_XCHANNEL.
svn path=/trunk/; revision=23625
2007-11-27 20:03:43 +00:00
Gerald Combs
e8fd375630 Fixes from Sam Leffler:
In capture_sync.c: Don't clobber the DLT value.

  In packet-cops.c (modified by me): Instead of adding an item as a static,
  mis-cast FT_UINT16 to the tree, add it as an FT_NONE.

  In packet-802.11.c: Add the right address to the tree.

svn path=/trunk/; revision=23624
2007-11-27 19:57:35 +00:00
Guy Harris
9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Michael Tüxen
d00e6fe59e Fix from Stephen Fisher for bug 2028.
svn path=/trunk/; revision=23621
2007-11-27 17:46:55 +00:00
Jeff Morriss
7b5c60314c Don't attach to any TCP/UDP ports if we weren't able to load the database--and thus the hf_ entries (which are required for dissection).
svn path=/trunk/; revision=23620
2007-11-27 16:08:24 +00:00
Stig Bjørlykke
5fa904e278 Added tvb_get_ephemeral_faked_unicode and tvb_get_ephemeral_stringz
to epan/libwireshark.def

svn path=/trunk/; revision=23619
2007-11-27 11:21:12 +00:00
Guy Harris
7a4eb3eb35 Check for AVPs with a list of values and a type that's not a 32-bit or
shorter integral type.  Fixes bug 2027.

Rename the "bytes" pointer to "octetstring", and initialize it in a
fashion that makes it clearer that it points to the first of the basic
types, to make it clearer that it's for OctetString.

svn path=/trunk/; revision=23615
2007-11-27 01:41:42 +00:00
Gerald Combs
7731b882f2 From Tuomas Maattanen: Fix a .11e QBSS IE endian error.
svn path=/trunk/; revision=23614
2007-11-27 01:02:03 +00:00
Gerald Combs
1064a1df35 Make sure we fully initialize a struct. Fixes bug 2021.
svn path=/trunk/; revision=23613
2007-11-27 00:36:41 +00:00
Jeff Morriss
1cd46ec7be Get rid of the global data structures populated by wiretap/mpeg-audio but
used by the mpeg-audio dissector: instead keep the data inside the wiretap
module and add accessor functions.  I think this should fix
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677 and anyway it's
cleaner.

svn path=/trunk/; revision=23612
2007-11-26 23:06:07 +00:00
Jeff Morriss
309f7503e5 Get rid of C++/C99 style comments--not all compilers support them
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
Stig Bjørlykke
86f278dda7 Use the offset and length for the interesting data.
svn path=/trunk/; revision=23607
2007-11-26 18:51:24 +00:00
Jeff Morriss
dd0a4750b0 s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows.
svn path=/trunk/; revision=23605
2007-11-26 18:35:37 +00:00
Jeff Morriss
c5ab162b37 gcc-4.1.1 thinks 'retval' might not get set inside the TRY(). Initialize it.
svn path=/trunk/; revision=23603
2007-11-26 17:28:12 +00:00
Stig Bjørlykke
a26ea5739a Use correct offset for subtree in dissect_spoolss_relstr.
svn path=/trunk/; revision=23602
2007-11-26 17:03:12 +00:00
Stig Bjørlykke
e5461f3307 From Kai Blin:
Dissect the PRINTER_INFO structure in the SpoolssEnumPrinters call.

From me:
Add the level info to COL_INFO.

svn path=/trunk/; revision=23600
2007-11-26 16:38:26 +00:00
Sebastien Tandel
d580971f07 Update error handling of UDP Light Illegal Checksum value 0
* change expert group from PI_MALFORMED to PI_CHECKSUM (as it should be!!!).
  * set item hf_udp_checksum_[good|bad] as generated


svn path=/trunk/; revision=23599
2007-11-26 14:42:38 +00:00
Sebastien Tandel
6c4f9f0479 iUpdate error handling of UDP Light Illegal Checksum value 0
* Adding PI_MALFORMED expert field for this case.
  * Adding an error string in COL_INFO.


svn path=/trunk/; revision=23598
2007-11-26 14:30:40 +00:00
Gerald Combs
3697704b62 Fix bug 2019: The SMB dissector was dereferencing a NULL pointer.
svn path=/trunk/; revision=23593
2007-11-25 23:08:09 +00:00
Stig Bjørlykke
4e9892cbfd Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23590
2007-11-25 21:30:57 +00:00
Stig Bjørlykke
a2b5cf9528 Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23589
2007-11-25 21:30:33 +00:00
Jaap Keuter
054ed14e67 Header field array and whitespace cleanup.
svn path=/trunk/; revision=23588
2007-11-25 19:20:32 +00:00
Sake Blok
9f829f4ba2 Bug 1997 From Timo Teras:
Patch to do the following:
1) Dissect CIE Lists in NHRP Extensions
2) Dissect original NHRP packet in Error Indication
3) Support for Cisco NAT extensions
4) Support for Cisco NHRP Traffic Indication packet


svn path=/trunk/; revision=23587
2007-11-25 18:10:01 +00:00
Graeme Lunt
a7dec11ce6 Changes suggested/provided by Anders so that fewer changes are required to the ASN modules.
Also includes the MSAccessProtocol.asn to generate defines for the operation numbers.


svn path=/trunk/; revision=23586
2007-11-25 17:46:42 +00:00
Jaap Keuter
f4054ad148 Based on suggestion from Stig Bjørlykke. Add CRC tree even when CRC is missing.
svn path=/trunk/; revision=23584
2007-11-25 15:36:38 +00:00
Stig Bjørlykke
6f1ab30f2f From Joe Eykholt:
Show content even if the trailer is missing.

From me:
Add proto_tree_set_appendix for the checksum and EOF.

svn path=/trunk/; revision=23581
2007-11-25 12:15:02 +00:00
Stig Bjørlykke
82041ad3b6 Set an initial value to make gcc 4.1.3 20070929 (prerelease) on Ubuntu happy.
svn path=/trunk/; revision=23580
2007-11-25 02:20:41 +00:00
Stig Bjørlykke
6341d80f07 From Graham Bloice:
Show correct TCP segment data (and length) when multiple pdus.

svn path=/trunk/; revision=23572
2007-11-24 23:04:49 +00:00
Stig Bjørlykke
0cb8d7e554 From Alex Burlyga:
It looks like in dissect_nfs_open_claim_delegate_cur4() instead of dissection
stateid we are doing something wierd and dissecting uint64 instead(remnants of 
rfc3010 where stateid was 64 bit number?). We already have function for
dissecting stateids, so just a matter of making a different call. 

From me:
Also deleted the hf_nfs_stateid4_delegate_stateid entry.

svn path=/trunk/; revision=23571
2007-11-24 22:45:57 +00:00
Stig Bjørlykke
6c090a68bf From J. Bruce Fields:
Add basic support for NFSv4.1, as of about draft 13 of the current spec.
The protocol is not completely finished yet, and future patches will be
needed to bring it up to date.

From me:
- Add a check for valid pointers in nfsv4_operation_ett
- Always increase offset when calling dissect_nfs_devices4
- Added a default case in dissect_rpc_secparms4

svn path=/trunk/; revision=23570
2007-11-24 22:09:01 +00:00
Gerald Combs
7d5b4af5d0 Make sure h225_pi is never NULL.
svn path=/trunk/; revision=23568
2007-11-24 19:13:54 +00:00
Jeff Morriss
330c9d0b4b Fix crash reported in http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2014 : when adding fragments to the linked list of end fragments, don't check the TSN of the begin fragment--it may not be there. Looks like a cut-n-pasteo.
svn path=/trunk/; revision=23567
2007-11-24 17:56:46 +00:00
Anders Broman
0d92db6781 Export classes from ROS - hopfully without breaking stuff.
svn path=/trunk/; revision=23566
2007-11-24 17:39:31 +00:00
Jeff Morriss
29cb0d329b Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2011 : check SSN in both Called and Calling addresses even when we know the direction of the messages
svn path=/trunk/; revision=23564
2007-11-24 15:43:39 +00:00
Jeff Morriss
8058db81b9 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2006 : use 0xffffff (reserved value) for unset xLRs
svn path=/trunk/; revision=23563
2007-11-24 15:38:19 +00:00
Sake Blok
9b6f806089 This patch adds (ten) temporary coloring rules which will only live until Wireshark is
quit. Temporary coloring filters can be set by:

- pressing <ctrl>-<digit> will create a conversation coloring filter based on the
  addresses of the currently selected packet (order TCP/UDP/IP/Ethernet)
  This can also be achieved from the "View|Colorize Conversation" menu.

- Rightclicking on a packet in the packet-list will give the option to
  "Colorize Conversation" just as "Conversation Filter" does.

- Rightclicking on an item in the packet-detail-list will give the option to
  "Colorize with filter" which works similar to "Apply as filter"

Temporary filters can be cleared from the same menus or by pressing <ctrl>-<space>.

This patch also adds an item to the above mentioned menu's to add a permanent color filter
in the same way.


The colors for the temporary coloring rules are now hardcoded as I do not know
how to change the color of menu-items and therefore I chose to use icons to
show the actual color of each of the ten temporary coloring rules. Is it at all
possible to have different menu items in different colors?

One other way of solving this is to recreate the icons on the fly after changing
the colors. I will have a look into that once it is clear whether I can use 
different colors within the menu structure.


svn path=/trunk/; revision=23560
2007-11-24 11:38:16 +00:00
Gerald Combs
118f23a08a Catch a bad bLength, which may cause a loop. Fixes bug 2012.
svn path=/trunk/; revision=23557
2007-11-23 23:31:21 +00:00
Gerald Combs
4510d63626 Fix bug 2007 (a loop in IPv6).
svn path=/trunk/; revision=23555
2007-11-23 20:15:28 +00:00
Guy Harris
38ab1b8e7a Set the usual properties on packet-wps.[ch].
svn path=/trunk/; revision=23553
2007-11-23 18:48:49 +00:00
Stig Bjørlykke
2ad24805fe No $Id:$ in new files?
svn path=/trunk/; revision=23551
2007-11-23 18:29:00 +00:00
Guy Harris
5586f6764a Include packet-wps.h, so it's part of the source tarball.
svn path=/trunk/; revision=23550
2007-11-23 18:25:39 +00:00
Stig Bjørlykke
d6f0b0c2af From Jens Braeuer:
Added support for Wifi Simple Config aka Wifi Protected Setup

From me:
Added standard copyright header to packet-wps

svn path=/trunk/; revision=23549
2007-11-23 17:48:28 +00:00
Stig Bjørlykke
5e1ffde520 Moved check for empty choice to make it work correctly.
svn path=/trunk/; revision=23548
2007-11-23 12:22:22 +00:00
Stephen Fisher
3b46983e9f Make previously removed ethertype preference obsolete. For inclusion in
0.99.7 release.


svn path=/trunk/; revision=23545
2007-11-22 19:02:31 +00:00
Stig Bjørlykke
92682d51de Added handling of octet-aligned data according to direct_reference.
Implemented handling of ber_callback for tagged type octet-aligned
and arbitrary.  Renamed some functions.

svn path=/trunk/; revision=23539
2007-11-21 23:33:13 +00:00
Sake Blok
ceaeb1f977 Bug 1994: From Keith Mercer :
This bugfix is focused only in the Sender ID TLV segment of code.  This was to
address the possibility that the Sender ID TLV may not have a Management
Address Domain, and/or a Management Address.  This bug was discovered when
testing the dissector using CFM-enabled Netopia modems.


svn path=/trunk/; revision=23534
2007-11-21 20:33:50 +00:00
Gerald Combs
f3fdef83d6 Don't try to overwrite read-only memory. Fixes bug 2001.
svn path=/trunk/; revision=23529
2007-11-21 17:00:24 +00:00
Tomas Kukosa
7c48c9ab80 more SSL debug info concerning conversation and ssl_session
svn path=/trunk/; revision=23528
2007-11-21 14:10:55 +00:00
Michael Tüxen
928bebeb01 Update to draft-ietf-rserpool-common-param-15.txt. (Will
be published soon...)

svn path=/trunk/; revision=23520
2007-11-20 21:21:56 +00:00
Gerald Combs
13a01fef37 Add a bounds check in order to try to fix bug #1998.
svn path=/trunk/; revision=23517
2007-11-20 19:17:19 +00:00
Gerald Combs
dfb104544f Add relative start time, duration, and average data rate (bps) columns
to the conversation lists. Move the "copy" button down to the button bar
in order to free up some real estate. Add an nstime_cmp() function. Clean
up code in a few places.

svn path=/trunk/; revision=23516
2007-11-20 18:35:41 +00:00
Jeff Morriss
be81aa150e Reindent some to improve readability
svn path=/trunk/; revision=23510
2007-11-20 16:51:14 +00:00
Gerald Combs
e11ec68f93 Update some comments and whitespace.
svn path=/trunk/; revision=23509
2007-11-20 16:46:11 +00:00
Tomas Kukosa
7eb5048da9 fix tag handling inside snmp trap
svn path=/trunk/; revision=23508
2007-11-20 13:55:39 +00:00
Stephen Fisher
1ab4398a47 Introduce use of the new FT_EBCDIC field type as a second display of
text fields (data & sqlstatement).  Also fix the options on the FT_STRINGZ
items - change them to FT_STRING and change BASE_DEC to BASE_NONE.


svn path=/trunk/; revision=23505
2007-11-19 21:28:17 +00:00
Mike Duigou
a8a69a14f6 From Yaniv kaul:
Adds const declarations to req_resp_hdrs_do_reassembly() and re-orders some actions to occur after tests which may decide that the actions were not required.


svn path=/trunk/; revision=23504
2007-11-19 21:28:08 +00:00
Stephen Fisher
849e628334 Introduce a new field type called FT_EBCDIC. This field works the same as
FT_STRING, except that it converts the data from the packet from EBCDIC
to ASCII for display in Wireshark.


svn path=/trunk/; revision=23503
2007-11-19 21:27:01 +00:00
Jeff Morriss
53faa469bd Detect reneged acks or at least retransmissions after an ack was seen. Mark
them with an expert info (PI_WARN).

Change "Duplicate TSN" expert info to "Retransmitted TSN" and make it PI_NOTE
instead of PI_WARN.

Change "More than 100 TSNs gap-acked" expert info to PI_WARN (from PI_NOTE).

Frame numbers (and count of retransmissions) are unsigned, display them that way.

svn path=/trunk/; revision=23502
2007-11-19 20:34:57 +00:00
Stig Bjørlykke
8fc83d2cf3 Improved "BER Error" messages to be more uniform.
svn path=/trunk/; revision=23501
2007-11-19 20:23:49 +00:00
Martin Mathieson
38d450159f Only show direction field when its set to a valid value.
svn path=/trunk/; revision=23498
2007-11-19 19:04:19 +00:00
Stig Bjørlykke
9233fa7578 Second try to not stop processing if length==0 in choice.
svn path=/trunk/; revision=23497
2007-11-19 17:46:11 +00:00
Gerald Combs
cec11effb5 Fix an infinite loop, and be more paranoid about looping in general.
svn path=/trunk/; revision=23496
2007-11-19 17:33:59 +00:00
Stig Bjørlykke
cf5aa9d616 Added port range.
Added a dissector assert on inconsistent data.
Do not align retransmission or duplicate acknowledgement data in COL_INFO.
Removed several _U_ for used variables.
Re-indented some if-blocks.

svn path=/trunk/; revision=23492
2007-11-19 07:31:56 +00:00
Stig Bjørlykke
c787b310eb Added port range.
svn path=/trunk/; revision=23491
2007-11-19 07:26:53 +00:00
Stig Bjørlykke
f5b14b2f89 Initialize credentials.
svn path=/trunk/; revision=23490
2007-11-19 07:26:10 +00:00
Stig Bjørlykke
77e69e06e1 Reverted r23485 and r23486, this was not a correct fix.
svn path=/trunk/; revision=23489
2007-11-19 07:25:06 +00:00
Stig Bjørlykke
c3d985077e And dump internal ber fields for empty choice field.
svn path=/trunk/; revision=23486
2007-11-18 16:40:20 +00:00
Stig Bjørlykke
ddc4d639ba As proposed by Martin Peylo:
Do not stop processing if the length of a choice has the (illegal)
value of zero.

svn path=/trunk/; revision=23485
2007-11-18 16:20:51 +00:00
Ulf Lamping
7e98b70b3f fix bug 1459: make the filter string "ip.version == 6" possible, by adding a "pseudo" field
svn path=/trunk/; revision=23483
2007-11-18 08:16:49 +00:00
Martin Mathieson
970854aa6d Add ppp.direction field.
svn path=/trunk/; revision=23481
2007-11-17 22:08:27 +00:00
Graeme Lunt
cbba688f44 Comment out dissect_ascii_tpkt to keep the buildbot happy.
svn path=/trunk/; revision=23480
2007-11-17 18:22:49 +00:00