Commit Graph

8124 Commits

Author SHA1 Message Date
Jeff Morriss f136a90eff Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2206 : don't write into COL_INFO unless we've checked that it's there first.
svn path=/trunk/; revision=24125
2008-01-17 21:40:33 +00:00
Jeff Morriss 9b495c1007 epan (libwireshark) uses getservbyport() which, at least on Solaris, is in libsocket so add libsocket (and libnsl) to libwireshark_la_LIBADD
svn path=/trunk/; revision=24121
2008-01-17 18:42:19 +00:00
Jeff Morriss ed88c589b0 Add support for DLT_SCCP (SCCP without MTP2, MTP3, or any pseudo-header).
svn path=/trunk/; revision=24119
2008-01-17 17:55:38 +00:00
Stig Bjørlykke 7fc046ab67 Hmmm. The previous ansi_tcap.cnf did not make valid code.
I hope this fix is correct...

svn path=/trunk/; revision=24118
2008-01-17 09:20:17 +00:00
Stig Bjørlykke 15a5557a3d Changed some variable types to make it compile.
svn path=/trunk/; revision=24117
2008-01-16 20:49:50 +00:00
Stig Bjørlykke 7629966a00 - Removed some unused variables in asn1 dissectors
- Fixed last parameter to cry_cipher_open() in pkcs12

svn path=/trunk/; revision=24116
2008-01-16 20:41:23 +00:00
Stig Bjørlykke 3590fc0713 Changed to checksum_good and checksum_bad to align with other dissectors.
svn path=/trunk/; revision=24115
2008-01-16 19:16:30 +00:00
Jaap Keuter 90674d7c9e Print the string to STDOUT regardless of the value of tree.
svn path=/trunk/; revision=24114
2008-01-16 18:39:32 +00:00
Martin Mathieson 511197bf71 - Display some sctpprim parameters
- Parse sctpprim v3 properly now
- Add wtp protocol name

svn path=/trunk/; revision=24113
2008-01-16 14:19:45 +00:00
Jaap Keuter 2e0f8088c3 From Jim Young:
This patch provides a new RTP Player preferences dialog.  It allows one to
select the maximum number of visable channels in the RTP Player window.  The
default is four (4) channels which is the maximum number of usable channels 
that the RTP Player can display and still have access to the bottom row buttons 
on a 1024*768 resolution display.  Specifying a value less than 1 or greater than 
10 will be result in the RTP Player displaying the default 4 channels.

svn path=/trunk/; revision=24112
2008-01-16 07:36:34 +00:00
Bill Meier c0ef7ab1ad Add ':' to some labels to prevent assembler warning messages
svn path=/trunk/; revision=24110
2008-01-16 04:04:24 +00:00
Stig Bjørlykke f60062dccc Call post dissectors with call_dissector_only() to avoid an extra Data entry
if post dissectors are disabled, as pointed out by LEGO.

svn path=/trunk/; revision=24109
2008-01-15 23:31:37 +00:00
Stig Bjørlykke 01b304a6b7 Moved a G_GINT64_CONSTANT to a more correct position.
svn path=/trunk/; revision=24108
2008-01-15 23:25:40 +00:00
Stig Bjørlykke c6ac2fd721 Fixed a small issue reporting corresponding package num for retransmitted
reports and notifications.

svn path=/trunk/; revision=24107
2008-01-15 22:32:34 +00:00
Anders Broman 5bbef7d0c0 Use G_GINT64_CONSTANT(hope it makes the OS X build bot happy).
Unused variables fix to camel.

svn path=/trunk/; revision=24106
2008-01-15 22:23:57 +00:00
Anders Broman 7e572a34c0 Use G_GINT64_CONSTANT(hope it makes the build bot happy).
svn path=/trunk/; revision=24105
2008-01-15 22:07:29 +00:00
Anders Broman a49fc8640c Use G_GINT64_MODIFIER hope it makes the build bot happy.
Probbably needed in x2ap as well (needs asn2wrs support or .cnf magic).

svn path=/trunk/; revision=24104
2008-01-15 21:57:50 +00:00
Jeff Morriss fdfaebccd1 Include dirent.h if we have it (to fix glib-1 compile: it needed DIR).
svn path=/trunk/; revision=24100
2008-01-15 19:39:31 +00:00
Jeff Morriss b128029ac4 Oops, glib's iconv stuff is in glib >= 2, not just glib > 2
svn path=/trunk/; revision=24099
2008-01-15 19:24:27 +00:00
Jeff Morriss 5ebba98529 The glib iconv routines are new to glib-2 so #ifdef around them to get glib-1 builds going again. I started to merge in using the regular iconv routines (if we don't have glib-2 but we HAVE_CONV) but the code rapidly got ugly with all the #ifdef's; it could be done but it's probably not worth the effort/ugliness.
svn path=/trunk/; revision=24098
2008-01-15 18:37:48 +00:00
Anders Broman 6cb56fba71 make per_constrained_integer handle 64bits needed for X2AP.
svn path=/trunk/; revision=24097
2008-01-15 17:59:43 +00:00
Anders Broman 0c454791f5 From Neil Piercy:
Dissect RRC NAS Message PDUs.

svn path=/trunk/; revision=24095
2008-01-15 06:54:30 +00:00
Stig Bjørlykke a2d1e9005d This patch adds support for configuration profiles, which can be used to
configure and use more than one set of preferences and configuration files.

This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A.  It's also possible to start wireshark
and tshark with a named profile by using the "-C ProfileName" option.
A new status pane in the main window will show the current profile.

The configuration files currently stored in the Profiles are:
- Preferences
- Capture Filters
- Display Filters
- Coloring Rules
- Disabled Protocols
- User Accessible Tables

The recent data are by design not added to the profile.

Planned future enhancements:
- make a more convenient function to switch between profiles
- add a "clone profile" button to copy an existing profile
- make the profiles list active and accept return as OK
- save users "Decode as" in the profile
- make new, clone and deletion of profiles more secure
- make some of the recent values available in the profile

This patch also fixes:
- setting default status pane sizes
- a bug setting status pane for packets when not having main lower pane.

svn path=/trunk/; revision=24089
2008-01-14 16:40:23 +00:00
Stig Bjørlykke b0c8583de7 Fixed a guint64 compile issue with a Sun C 5.8 compiler.
Fixed a tree placement.

svn path=/trunk/; revision=24086
2008-01-14 09:51:22 +00:00
Stig Bjørlykke 8b4e80384a Fixed a few "statement not reached" warnings and a "assignment type mismatch" warning.
svn path=/trunk/; revision=24085
2008-01-14 09:39:55 +00:00
Tomas Kukosa 2df94e1092 add ssl_debug_flush() at the end of initialization
svn path=/trunk/; revision=24084
2008-01-14 09:34:26 +00:00
Anders Broman aa81806094 Update package name from IANA's list.
svn path=/trunk/; revision=24078
2008-01-13 17:03:06 +00:00
Anders Broman 02c27c89f0 transactionId wasn't processed for:
SegmentReply/transactionId
TransactionReply/transactionId
TransactionPending/transactionId
Fixes bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2165

svn path=/trunk/; revision=24077
2008-01-13 16:07:52 +00:00
Graeme Lunt 8563c02137 Basic support for the LDAP start_tls extended operation and fix to match up extended operation arguments and results.
svn path=/trunk/; revision=24076
2008-01-13 14:12:47 +00:00
Graeme Lunt abdadc9eae Support for keylists for protocols that use start_tls - where SSL is negotiated at some point during a conversation and cannot be assumed on the basis of the port number alone.
Also dissection of Distinguished Names.


svn path=/trunk/; revision=24075
2008-01-13 14:10:02 +00:00
Jaap Keuter e7f4e2d6e5 From Michael Earnhart:
Patch to add cdp Power_request and Power_available fields
This added the support for the 0x0019 and 0x001a power_request and power_available fields.

Submitted patch slightly modified to present summary line and make more robust.

svn path=/trunk/; revision=24074
2008-01-13 11:56:39 +00:00
Sake Blok 6ff98095fe From Martin Peylo (bug 2184), fix for:
The current dissection of GeneralizedTime in packet-ber does not consider all
the possibilities how this field can be constructed.

According to ITU-T X.680 this field can be encoded as
YYYYMMDDhhmmss([\.,]f{1,3})?(([+-]hhmm)|Z)?
This is a regex-like expression where each letter except the literal 'Z'
represents an ASCII encoded digit.

So far only the first 14 digits are dissected and the 15th character is put
into parentheses. This may not show all available information.



svn path=/trunk/; revision=24071
2008-01-12 12:06:56 +00:00
Stephen Fisher aee504c8f5 Fix Windows warning/error: integral size mismatch
Then fix comparison of signed/unsigned warning/error


svn path=/trunk/; revision=24070
2008-01-12 06:38:09 +00:00
Jeff Morriss 01df06d697 The Windows compiler thinks that doing return(func_that_returns_void()) in a function that itself returns void is "'void' function returning a value". So don't do that.
svn path=/trunk/; revision=24068
2008-01-11 21:06:00 +00:00
Anders Broman 0b28f14940 Fix up some display filter names:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1852

svn path=/trunk/; revision=24065
2008-01-11 07:29:27 +00:00
Jaap Keuter 7def8e7b3e From Yukiyo Akisada:
This modifications are for the new protocol support.
HSE protocol was defined at Fieldbus Foundation <http://www.fieldbus.org/>.

svn path=/trunk/; revision=24064
2008-01-11 07:28:01 +00:00
Jeff Morriss d7fb23f849 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2111 : After verifying that there's enough TVB for the smallest possible message, also verify that the length parameter in the message is at least that big.
svn path=/trunk/; revision=24063
2008-01-10 23:16:59 +00:00
Jaap Keuter 3bca993c0b Fix for bug 2187.
Don't cast so rigorously that you loose the mantissa.

svn path=/trunk/; revision=24062
2008-01-10 22:27:28 +00:00
Jeff Morriss 3be6284ef3 From Andy Chu: A dissector for China Mobile Point to Point (cmpp) protocol,
it's the SMS protocol used in China.

From me: some code cleanup and convert it from a plugin to a regular
dissector.

svn path=/trunk/; revision=24060
2008-01-10 21:23:53 +00:00
Richard van der Hoff c7f1d0b579 add some comments re desirability of renaming fields
svn path=/trunk/; revision=24059
2008-01-10 16:43:48 +00:00
Richard van der Hoff 1350d63c1e From Chris Maynard (bug 1852):
These packet-g*.c files all have display filter issues:

1) packet-gryphon.c: PROTOABBREV is "gryphon", but display filter fields are
prefixed with only "gryph".

2) packet-gmrp.c: PROTOABBREV is "gmrp", but display filter fields are prefixed
with "garp".

3) packet-gssapi.c: PROTOABBREV is "gss-api", but display filter fields are
prefixed with "gssapi".

4) packet-gvrp.c: PROTOABBREV is "gvrp", but display filter fields are prefixed
with "garp", most of which conflict with packet-gmrp.c's display filter fields.




svn path=/trunk/; revision=24058
2008-01-10 16:35:54 +00:00
Bill Meier addba66749 Use glib equivalent of ntohs
svn path=/trunk/; revision=24056
2008-01-10 14:42:55 +00:00
Guy Harris aa2d38ffb3 pinfo->pseudo_header can and should be assumed to be non-null by a
dissector.  This fixes Coverity CID 238 (as we *were* assuming it was
non-null in one statement, and then only checking it later).

Set pinfo->p2p_dir to one of P2P_DIR_RECV or P2P_DIR_SENT, as it's
supposed to be, not to a Boolean value, and explain the basis on which
it's being set.

svn path=/trunk/; revision=24055
2008-01-10 09:40:15 +00:00
Ronnie Sahlberg 7e919ef623 add support for qpi level 516 : posix acl
svn path=/trunk/; revision=24052
2008-01-09 23:10:17 +00:00
Jeff Morriss d06b283bb9 dissect_e164_cc(): when the address is BCD coded, don't increment cc_offset just to get the 2nd octet of the address (because cc_offset is used later as the offset where the CC starts).
svn path=/trunk/; revision=24050
2008-01-09 22:25:47 +00:00
Jeff Morriss 52fcbb6ed8 Display the Country Code information in a subtree of the digits (to make it obvious that it's a subfield). Add #defines for the NAI and NP values and use them rather than hex values. Initial the 'np' variable to clean up a warning.
svn path=/trunk/; revision=24049
2008-01-09 22:01:57 +00:00
Anders Broman 1b73351c8d From Shmulik Bezalel:
Present the country code description gsmmap and SCCP.
Added small ASN1 bugfix - missing EXPORTS used by gsmmap.asn(Handle older ver).

svn path=/trunk/; revision=24048
2008-01-09 21:14:01 +00:00
Anders Broman 555355cef3 In case of QoS Information, Length field is missing.
svn path=/trunk/; revision=24047
2008-01-09 20:49:33 +00:00
Jeff Morriss db8bae4fb2 When searching for EOC (because we have an indefinite length) don't stop searching just because we ran out of TVB (thus assuming that the EOC is just beyond the end of the message). Instead, try to keep going which will throw an exception (ReportedBoundsError). I had a packet which was missing the EOC (probably programmer error) and Wirshark was reporting BoundsError (Packet size limited during capture) instead of ReportedBoundsError (Malformed Packet); this patch fixes that.
svn path=/trunk/; revision=24046
2008-01-09 17:06:25 +00:00
Martin Mathieson d786333ab2 #ifdef DEBUG around left-over printfs. Should these just be deleted?
svn path=/trunk/; revision=24045
2008-01-09 16:21:03 +00:00