osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
23475 commits 23 branches 0 tags 1.3 GiB
Commit graph

8124 commits

Author SHA1 Message Date
Tomas Kukosa
27a531e06a more sophisticated H245 OLC handling focusing on more reliable T.38 establishment 
svn path=/trunk/; revision=24043
 2008-01-09 13:30:31 +00:00
Martin Mathieson
4dd5de365b Explicitly check for missing NULL terminator on RTCP BYE reason string (this bug has been seen on 2 stacks now...). 
Fixes bug 2180.

svn path=/trunk/; revision=24042
 2008-01-09 12:39:14 +00:00
Jaap Keuter
ddc87cf31b From Steve Karg: 
Wireshark decodes a BACnet ReadRange Ack packet as malformed. The packet itself
is valid as checked with the BACnet 135-2004 specification.

svn path=/trunk/; revision=24039
 2008-01-09 09:34:19 +00:00
Anders Broman
196fcc1932 Make ANSI IS-637-A Teleservice - "ansi_637_tele" and 
ANSI IS-637-A Transpor t- "ansi_637_trans" callable by name.

svn path=/trunk/; revision=24037
 2008-01-09 06:45:32 +00:00
Stig Bjørlykke
6d4a2e7ebf Changed email address for Gerald from zing.org to wireshark.org 
in a lot of files, which I suppose is correct.

svn path=/trunk/; revision=24034
 2008-01-08 22:54:51 +00:00
Anders Broman
785913fff3 From Shmulik Bezalel: 
Add support for ucs2 on ussd string.
(Changing the font from Lucida console to Arial dissplaed all chars correctly).

svn path=/trunk/; revision=24030
 2008-01-08 05:29:38 +00:00
Anders Broman
48d17b4c2f From Shmulik Bezalel: 
Add support for ucs2 on ussd string.
(Changing the font from Lucida console to Arial dissplaed all chars correctly).

svn path=/trunk/; revision=24029
 2008-01-08 05:18:36 +00:00
Stig Bjørlykke
e63c643cb2 Add a cast. 
svn path=/trunk/; revision=24028
 2008-01-07 23:00:09 +00:00
Stig Bjørlykke
8959e6f766 From Balint Reczey (bug 2146): 
Make it possible to write Lua dissectors that use TCP reassembly.

svn path=/trunk/; revision=24026
 2008-01-07 21:24:23 +00:00
Stig Bjørlykke
e14c703106 From Jim Young (bug 2162): 
Patch for epan/emem.c functions ep_strndup() and se_strndup() to stop valgrind
message "invalid read of size 1".

svn path=/trunk/; revision=24023
 2008-01-07 20:44:32 +00:00
Anders Broman
6bcc12eabb More Generic parameters. 
svn path=/trunk/; revision=24022
 2008-01-07 19:16:26 +00:00
Anders Broman
95f17aafe0 Fix Missing -z proto,colinfo,ip,gtp.teid_cp and -z proto,colinfo,ip,gtp.teid_data 
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2136
Copy paseto..

svn path=/trunk/; revision=24021
 2008-01-07 19:15:43 +00:00
Anders Broman
8a9aa4642b Clear up the decoding of 
"USSD-DataCodingScheme ::= OCTET STRING (SIZE (1))
	-- The structure of the USSD-DataCodingScheme is defined by
	-- the Cell Broadcast Data Coding Scheme as described in
	-- TS 3GPP TS 23.038 [25]"
Partly in responce to
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2158

svn path=/trunk/; revision=24019
 2008-01-06 21:55:30 +00:00
Jaap Keuter
e2ca71beae Allocate enough space to make proper NULL terminated string in uat_unesc (bug 2169) and uat_unbinstring, 
svn path=/trunk/; revision=24017
 2008-01-06 13:09:33 +00:00
Jaap Keuter
d3b3178186 Fix for bug 2026: 
Clean up RTP header extension code. Remove duplicate raw presentation.

svn path=/trunk/; revision=24016
 2008-01-06 11:49:32 +00:00
Anders Broman
de16039c51 Get rid of dissect_ber_boolean_value() and change the signature of 
dissect_ber_boolean() to return a value and update asn2wrs to generate the new signature.
Regenerate all BER dissectors.

svn path=/trunk/; revision=24015
 2008-01-04 16:21:07 +00:00
Anders Broman
73fee653de Get rid of ber_last_created_item(). (Final?) 
svn path=/trunk/; revision=24010
 2008-01-04 13:39:24 +00:00
Anders Broman
bf7150a834 Get rid of ber_last_created_item(). 
svn path=/trunk/; revision=24009
 2008-01-04 12:53:29 +00:00
Anders Broman
a6d82ae12e Get rid of ber_last_created_item(). 
svn path=/trunk/; revision=24008
 2008-01-04 12:39:52 +00:00
Anders Broman
a67838484c Get rid of ber_created_item(). 
svn path=/trunk/; revision=24007
 2008-01-03 17:49:59 +00:00
Anders Broman
370f87d9be Build x2ap and s1ap - needs more work, untested as no traces available yet. 
svn path=/trunk/; revision=24006
 2008-01-03 14:45:36 +00:00
Anders Broman
f437f27567 Add s1ap - needs more work, untested as no traces available yet. 
svn path=/trunk/; revision=24005
 2008-01-03 14:44:26 +00:00
Tomas Kukosa
3523d6c825 get rid of get_ber_last_created_item() 
svn path=/trunk/; revision=24002
 2008-01-03 13:20:10 +00:00
Tomas Kukosa
e6e926d5f1 get rid of get_ber_last_created_item() 
svn path=/trunk/; revision=24001
 2008-01-03 13:07:17 +00:00
Anders Broman
d38d7348e0 Wrong string used in g_hash_table_lookup(). 
Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2154

svn path=/trunk/; revision=24000
 2008-01-03 13:00:56 +00:00
Anders Broman
99946861ca - MAP-MS-DataTypes.asn Add Id 
- Camel fix bug "bug in CAMEL ApplyCharging message."
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1719
- get rid of ber_last_created_item()
- add decoding of ServiceInteractionIndicatorsTwo items

svn path=/trunk/; revision=23999
 2008-01-03 11:12:38 +00:00
Tomas Kukosa
5c4f961f6e fix warning: mark unused parameter 
svn path=/trunk/; revision=23998
 2008-01-03 10:07:14 +00:00
Tomas Kukosa
dbd3a37c8c fix error if GNUTLS is not available 
svn path=/trunk/; revision=23997
 2008-01-03 09:32:12 +00:00
Martin Mathieson
e7b7a51f0f Fix warnings (seen under linux + GCC 3.4.6) 
svn path=/trunk/; revision=23996
 2008-01-03 09:01:17 +00:00
Tomas Kukosa
b762ddcf7b From Ales Kocourek 
- add ability to read server private key from encrypted PKCS#12 file
- use 0.0.0.0|any|ANY as a wildcard IP address (e.g. if one certificate is used in more servers)

svn path=/trunk/; revision=23995
 2008-01-03 08:24:33 +00:00
Tomas Kukosa
f5614d71cd set actx->created_item for object identifier type 
svn path=/trunk/; revision=23994
 2008-01-03 08:19:27 +00:00
Tomas Kukosa
0d9cbb0384 register into h245.gef.name table which is already implemented 
svn path=/trunk/; revision=23993
 2008-01-03 08:18:11 +00:00
Tomas Kukosa
a8e80e0cc9 put capability parameters into a table 
svn path=/trunk/; revision=23992
 2008-01-03 08:14:28 +00:00
Jaap Keuter
870c4f0dcb Fix for Bug 2156: 
Correct T bit mask.

svn path=/trunk/; revision=23991
 2008-01-03 07:29:34 +00:00
Anders Broman
fe35806343 Add decoding of most of the generic parameters from H.241 and 3gpp. 
svn path=/trunk/; revision=23987
 2008-01-02 14:05:16 +00:00
Stig Bjørlykke
1bdcd82f19 Mark some unused parameters with _U_. 
Added a missing return value.

svn path=/trunk/; revision=23986
 2008-01-02 11:34:35 +00:00
Tomas Kukosa
b1e1b232aa dissect some capability parameters 
svn path=/trunk/; revision=23985
 2008-01-02 11:09:36 +00:00
Tomas Kukosa
884e30a0ed update Generic Extensible Framework in H.245 
- call subdissector for parameter names
- call subdissector for booleanArray and unsignedMin values

svn path=/trunk/; revision=23984
 2008-01-02 11:07:44 +00:00
Martin Mathieson
ee8673b457 Also show duplicate IP address in info column. 
svn path=/trunk/; revision=23983
 2008-01-02 10:35:20 +00:00
Graeme Lunt
c68b8c3d6f An X.420 message store attribute and an X.420 heading extension. 
svn path=/trunk/; revision=23982
 2008-01-02 09:36:38 +00:00
Graeme Lunt
0c7876ca39 Revised X.420 dissector using separate ASN.1 modules and making the bare minimum changes to those modules that asn2wrs requires. 
Also supports the X.420 message store attributes, used over P7.


svn path=/trunk/; revision=23981
 2008-01-02 09:34:34 +00:00
Graeme Lunt
8a0e3ffb37 Additional EXPORTS for X.420 attributes and general fixes. 
svn path=/trunk/; revision=23980
 2008-01-02 09:30:45 +00:00
Graeme Lunt
cad42d9103 Additional EXPORTS (for X.420 dissector) and a message store (P7) attribute. 
svn path=/trunk/; revision=23979
 2008-01-02 09:29:04 +00:00
Anders Broman
6f5a53b789 Add more debug info. 
svn path=/trunk/; revision=23977
 2007-12-30 00:03:10 +00:00
Anders Broman
88b269d724 Fix indentation somewhat. 
svn path=/trunk/; revision=23976
 2007-12-30 00:02:25 +00:00
Stig Bjørlykke
74f01ee7c6 Initialize se_value to avoid a warning. 
svn path=/trunk/; revision=23972
 2007-12-29 11:29:36 +00:00
Anders Broman
779e204759 Handle se(v) encoding and minor bug fixes. 
svn path=/trunk/; revision=23971
 2007-12-29 09:55:02 +00:00
Anders Broman
afbb9dd6d1 Make dplay compile on Windows. 
svn path=/trunk/; revision=23970
 2007-12-29 09:53:48 +00:00
Sake Blok
173fe99eb5 Fix for bug 2068 from Jim Young: 
After a new display filter macro (dfmacro) has been defined, the first attempt
to use the dfmacro will result in a crash of Wireshark when the closing "}"
character is entered into the "Filter:" text entry field.


svn path=/trunk/; revision=23969
 2007-12-29 09:12:29 +00:00
Stephen Fisher
3f944ed30b Add preliminary dissector for network protocol used by Microsoft DirectPlay. 
From Kai Blin via bug #2134.


svn path=/trunk/; revision=23968
 2007-12-29 05:40:43 +00:00
Guy Harris
9a9dd48fa2 According to draft-ietf-pce-pcep-09, the LOAD-BALANCING object has no 
TLVs, and has a fixed length; fix the dissector for it to check for an
exact length and not to look for TLVs.

svn path=/trunk/; revision=23967
 2007-12-29 00:57:51 +00:00
Jaap Keuter
3f431f9dfb Have a filled COL_INFO, even if tree is NULL 
svn path=/trunk/; revision=23966
 2007-12-29 00:55:01 +00:00
Guy Harris
39dfc7b4db Rename packet-pce.c to packet-pcep.c to match the protocol name. 
svn path=/trunk/; revision=23965
 2007-12-28 23:08:48 +00:00
Guy Harris
a930d7df28 The protocol is the "Path Computation Element communication Protocol", 
or PCEP; use that rather than PCE, as per a suggestion in bug 1870.

svn path=/trunk/; revision=23964
 2007-12-28 23:05:22 +00:00
Stig Bjørlykke
3fe2bbe38f Fetch ObjectName and its relative oid_info before handling an eventual error 
value, so we have valid values to put in the VarBind entry.  Include the error
note text as the label.

This should fix bug 2144.

svn path=/trunk/; revision=23962
 2007-12-28 22:19:33 +00:00
Tomas Kukosa
487792b348 save RTP in 16-bit linear PCM instead of 8-bit G.711 u-Law 
(preparation for more codecs support via codec plugins)

svn path=/trunk/; revision=23961
 2007-12-28 13:01:55 +00:00
Guy Harris
3963febfa1 Clean up indentation some more. 
Don't pass an argument if the argument is overwritten before being used;
make it a local variable instead.

Combine the header and contents of an object into a single tree, as per
a suggestion in bug 1870.

Clean up some flag displays, and put fields into the protocol tree in
the order in which they appear in the packet.

svn path=/trunk/; revision=23960
 2007-12-28 11:23:23 +00:00
Tomas Kukosa
7529f33437 support for additionally SIZE constrained Typereference 
the support is only semiautomated as this feature does not occur very often
use this feature for the TBCD-STRING in the H.225 dissector

svn path=/trunk/; revision=23958
 2007-12-28 10:42:44 +00:00
Jaap Keuter
cec1f884e9 Add submission port dissection. 
svn path=/trunk/; revision=23957
 2007-12-28 09:09:09 +00:00
Guy Harris
773e1d9b3f Indicate what the current versions of the I-Ds for PCE are; also point 
to some RFCS.

Get rid of an unused dissector table and unused dissector handle.

Add #defines for the object header length and the minimum lengths of
various objects.

Don't use DISSECTOR_ASSERT() to check the contents of a packet - it is
by definition a bug in a dissector if DISSECTOR_ASSERT() is called, and
making a dissector call DISSECTOR_ASSERT() if a value that could
conceivably appear in a packet does appear in a packet is introducing a
known bug into a dissector.

Add more length checks - and use checked lengths for items rather than
updating lengths incrementally.

Clean up indentation and a bunch of other stuff.

svn path=/trunk/; revision=23955
 2007-12-28 03:06:30 +00:00
Sake Blok
64e951145e Preserve can_desegment status when passing the decrypted ssl-data to a subdissector 
svn path=/trunk/; revision=23954
 2007-12-28 01:23:01 +00:00
Guy Harris
f004da7b19 Fix a comment to reflect two possible reasons for a bogus PDU length. 
svn path=/trunk/; revision=23953
 2007-12-27 21:06:47 +00:00
Jaap Keuter
551f6f475a Fix for bug 2141: 
Based on the analysis from Jim Young added some DISSECTOR_ASSERT calls to make sure
the dissection will procede through the packet data.

svn path=/trunk/; revision=23951
 2007-12-27 12:00:45 +00:00
Jaap Keuter
7e262d1ccb From Francis Dupont: 
DHCPv6 dissector is pretty old, i.e., it needs some updates (provided in the patch).
For instance, RFC 5007 (leasequery) is not taken into account.

svn path=/trunk/; revision=23950
 2007-12-27 10:38:03 +00:00
Sake Blok
9ad27ce239 Fix for bug 1586: When proxying a tcp connection (mostly used with ssl over an 
http proxy), let the proxied protocol take care of reassembly itself.


svn path=/trunk/; revision=23949
 2007-12-26 18:28:31 +00:00
Anders Broman
6fbf8be77d Build with assembler support (NASM). 
svn path=/trunk/; revision=23947
 2007-12-25 15:55:19 +00:00
Jaap Keuter
05b530033e Defining INTERFACE causes a clash with Win32 defines. Moving to ATTR_* 
svn path=/trunk/; revision=23946
 2007-12-24 16:27:27 +00:00
Jaap Keuter
c84621caba From Abhik Sarkar: 
In packet-gsm_sms.c, in function dis_field_ud_iei, it is assumed that the UDHL
must be greater than 2 (because it is expected that IEIa and IEIDLa will be 
one byte each and the rest will be IEIDa). 
However, there are some cases in which UDHL can be 2. For example, in 3GPP 23.048.

svn path=/trunk/; revision=23945
 2007-12-24 11:16:06 +00:00
Jaap Keuter
93ef681227 From Andreas St: 
In our communication systems, we make use of the RTP header extension to encode
signalling information in the form of a bit mask. To improve our debugging, we
extended the default RTP dissector to call back any subdissector registering
for a particular RTP payload type string. This allows to render the value of
the header extension in a different, more flexible way compared to the default
numeric representation, such as in form of a subtree.

svn path=/trunk/; revision=23943
 2007-12-23 20:10:57 +00:00
Stephen Fisher
6b15e7971f Fix warning/error on Windows buildbot with conversion from unsigned short to 
unsigned char at line 1958.


svn path=/trunk/; revision=23942
 2007-12-23 19:32:08 +00:00
Jaap Keuter
68e1ecc758 From Silvia Cristina Tejedor: 
New dissector for the protocol PCE

svn path=/trunk/; revision=23941
 2007-12-23 14:19:48 +00:00
Jaap Keuter
f37c29c2f5 Use proto functions i.s.o. manipulating node data directly. 
svn path=/trunk/; revision=23940
 2007-12-23 14:18:27 +00:00
Michael Tüxen
dc167cef52 Add handling of "Rejected due to security considerations" error cause. 
Reported by Holger Epper.

svn path=/trunk/; revision=23939
 2007-12-22 20:30:23 +00:00
Jaap Keuter
abe4e72137 Describe text only field as "Text Item", shown in status bar. 
Improve documentation headers.

svn path=/trunk/; revision=23938
 2007-12-22 10:47:26 +00:00
Stephen Fisher
9f3a1c549c From Peter via bug #1689: 
Patch to fix problem where compilation fails if you have libgcrypt installed
without gnutls.


svn path=/trunk/; revision=23937
 2007-12-21 23:02:00 +00:00
Stig Bjørlykke
382bedb6ca Added type=value to BuiltInDomainDefinedAttributes items. 
svn path=/trunk/; revision=23933
 2007-12-21 13:23:52 +00:00
Michael Tüxen
ec06660011 Fix the handling of error parameters. Reported by Holger Eppert. 
svn path=/trunk/; revision=23932
 2007-12-21 11:06:21 +00:00
Jaap Keuter
7a76c45b04 From Abhik Sarkar: 
This patch adds initial support for statistics to the SMPP dissector using the Stats Tree API.

svn path=/trunk/; revision=23931
 2007-12-21 08:16:47 +00:00
Gerald Combs
7a3bc302d9 Fix some casts. 
svn path=/trunk/; revision=23930
 2007-12-20 17:34:39 +00:00
Stig Bjørlykke
1dbf329466 Added Precedence and Importance to COL_INFO. 
svn path=/trunk/; revision=23929
 2007-12-20 14:18:38 +00:00
Stig Bjørlykke
1c68fd7a75 Added total retransmission time analysis field. 
svn path=/trunk/; revision=23924
 2007-12-19 11:25:47 +00:00
Martin Mathieson
2346d8280c Report duplicate IP addresses based on observed ARP requests & responses. 
Turned on by default (otherwise no-one will find it).

svn path=/trunk/; revision=23923
 2007-12-19 10:49:22 +00:00
Stig Bjørlykke
6f9241bca7 - Added first version of P_Mul sequence analysis. 
- Added expert info for Discard_Message_PDU.

svn path=/trunk/; revision=23922
 2007-12-19 10:05:42 +00:00
Stig Bjørlykke
88216b4940 Added total retransmission time analysis field. 
svn path=/trunk/; revision=23920
 2007-12-19 09:38:03 +00:00
Jaap Keuter
0eb257e087 No extended characters here please. 
svn path=/trunk/; revision=23918
 2007-12-18 22:43:29 +00:00
Jaap Keuter
38f3dff73b From Alex Burlyga: 
When parsing nfsv4 GETATTR reply in attribute fs_location wireshark displays incorrect content for the attribute value. It looks like instead of parsing as rpc arrays, value gets parsed as 
rpc linked list. This patch which fixes the problem
I also noticed that FATTR4_MOUNTED_ON_FILEID attribute is not getting parsed, so I added parsing for that as well.

svn path=/trunk/; revision=23917
 2007-12-18 22:41:25 +00:00
Tomas Kukosa
48eb58a0d4 do not align before enumerated extension 
svn path=/trunk/; revision=23916
 2007-12-18 10:15:31 +00:00
Tomas Kukosa
2dbe8bb2ac fix bug 2112 
svn path=/trunk/; revision=23915
 2007-12-18 09:51:49 +00:00
Guy Harris
255f856ec1 It appears that some fields in the Prism header might have a DID value 
of 0, and that appears to mean that they're not present.  Check for
that, as well as the status.

svn path=/trunk/; revision=23914
 2007-12-18 09:31:54 +00:00
Guy Harris
d51919864f Put radio information from a pseudo-header into its own protocol tree 
item, as is done for radio information in a Prism, AVS, or radiotap
header.

svn path=/trunk/; revision=23913
 2007-12-18 09:22:17 +00:00
Guy Harris
2def545803 Interpret the signal and noise values in an AVS header appropriately, as 
per the signal type (and as per a noise value of 0xffffffff meaning no
noise value was provided).

svn path=/trunk/; revision=23912
 2007-12-18 08:57:17 +00:00
Guy Harris
9198a2a166 Fold the Prism and AVS header dissectors into packet-ieee80211.c, and 
have them use least some of the radio-information fields, so that the
same field name can be used for multiple radio header types.  The AVS
header can supply the data rate in bits/second, so have that field be in
those units, and make it 64 bits to leave room for the future, Just In
Case.  Display it as Mb/s, however.

svn path=/trunk/; revision=23911
 2007-12-18 08:01:11 +00:00
Jörg Mayer
c2390c4ef7 Bugfix: Array overflow (found by gcc43) 
svn path=/trunk/; revision=23907
 2007-12-18 00:44:49 +00:00
Sake Blok
1d52172cd4 Bug 2116 - From Lawrence Reisler : 
During a regular Wireshark trace of UCP packets running over ethernet, I noted
that Wireshark said the login packet was malformed, even though it looked OK
and the server responded correctly.  After looking at the UCP protocol, it
became clear that Wireshark was parsing a type 60 message which only has one
Reserverd field (RES1) and expecting it to have two Reserved fields (RES1 and
RES2) like a type 61 message.  This is because it is using the same function to
parse both messages, and does not have a conditional for the type 60 field.



svn path=/trunk/; revision=23903
 2007-12-17 23:11:04 +00:00
Stephen Fisher
d00059d2bc From metatech: 
New dissector for RTMP(T) protocol

via bug #2078


svn path=/trunk/; revision=23902
 2007-12-17 20:43:38 +00:00
Jeff Morriss
407007d14a From Kaul: s/SERIAL_NUMBER_LENGTH/SCTP_SERIAL_NUMBER_LENGTH to fix a duplicate definition on Windows (not sure why Kaul is seeing that but oh well). 
svn path=/trunk/; revision=23899
 2007-12-17 19:25:16 +00:00
Tomas Kukosa
b433163b3f - use structure instead of many global variables for channel setup 
- move channel setup code to one function
- support RFC2198 dynamic payload type setup

svn path=/trunk/; revision=23898
 2007-12-17 12:16:38 +00:00
Stig Bjørlykke
3d7d0393b2 From RuudS: 
Patch to LUA to implement byte arrays.

This fixes bug 2110.

svn path=/trunk/; revision=23896
 2007-12-17 09:00:45 +00:00
Guy Harris
80039e2976 For captures on a Linux GRE interface, put a field into the protocol 
tree with the GRE protocol type value.

svn path=/trunk/; revision=23894
 2007-12-16 22:46:42 +00:00
Stig Bjørlykke
e29ba5decf From Timo Teras: 
The attached patch checks sll_hatype field type and if suggest capture on GRE
interface, the packet will be dissected using GRE dissector table. Also prints
physical addresses with length 4 as IPv4 addresses.

This fixes bug 2105.

svn path=/trunk/; revision=23892
 2007-12-16 21:04:08 +00:00