Commit Graph

80425 Commits

Author SHA1 Message Date
Uli Heilmeier c2f3b654f7 Manpage tshark: Add option '-A'
This commit adds option '-A' for rpcap authentication.

Fixes: wireshark/wireshark#16674
2021-04-10 07:32:08 +00:00
Gerald Combs bd123cadaf GitLab CI: Conditionally create C:\Development on Windows. 2021-04-10 07:14:18 +00:00
Donatas Saulys efb5e44539 epan: print leading zeroes for sub-second values. 2021-04-10 06:58:36 +00:00
Preston Hunt 7a2d5fe83e IEEE 802.11: add Ranging trigger type
When dissecting a Trigger Ranging Frame, show the Common Info type as
"Ranging" instead of "Unknown".
2021-04-10 06:41:00 +00:00
John Thacker 67301b471a qcustomplot: Fix some clang code analysis warnings
Two dead stores and a possible call of memcpy with a null
destination.
2021-04-09 17:30:20 -04:00
Pascal Quantin 3341067ca3 NGAP: upgrade dissector to v16.5.0 2021-04-09 18:22:14 +00:00
Pascal Quantin 9f3822ad7b X2AP: upgrade dissector to v16.5.0 2021-04-09 17:08:30 +00:00
Pascal Quantin 7ebd4dba7a S1AP: upgrade dissector to v16.5.0 2021-04-09 18:30:39 +02:00
Yuya Kawakami 861054fb83 epan: fix proto register bgp to make mp_[un]reach_nlri.safi available 2021-04-09 13:04:50 +00:00
Aurelien Aptel 33114aa38c smb2: add compress_data share flag
[MS-SMB2] v62 adds a compress_data flag in share flags.
2021-04-09 10:03:34 +00:00
Aurelien Aptel 5dfedb4997 smb2: update dissection of transport negotiate context
[MS-SMB2] v62 makes the reserved field a flags field with one possible
value
2021-04-09 10:03:34 +00:00
Preston Hunt 763d251589 IEEE 802.11: dissect VHT NDPA extended sta info
az D3.0 adds additional station information to the VHT Ranging NDP
Announcement frame.
2021-04-08 20:09:38 -07:00
Guy Harris 7de6b0822a pcapng: expand a comment and tweak the version test.
Drop in the comment from libpcap about version 1.2 (I wrote that
comment, and generously double-license it under the BSD license and the
GPL :-)).

Redo the version test as

    if (!({version is one we handle}))

to match the way it's done in libpcap.
2021-04-08 19:38:26 -07:00
Loris Degioanni 7894b1d0ea sysdig: a couple more fixes
- parse the number of system call arguments in a way that works for both V1 and V2 event blocks
- returned the correct error string when unable to read the nparams entry from a sysdig event block V2
2021-04-09 01:24:53 +00:00
Loris Degioanni cbbe660504 sysdig: implementation fixes
- make sure nparams is initialized
- validate block_total_length in the correct way for sysdig event blocks
2021-04-09 01:24:53 +00:00
Loris Degioanni 8c70dd8d17 sysdig: simplified the separate handling of the two different sysdig block types 2021-04-09 01:24:53 +00:00
Loris Degioanni fbe8d3a00f sysdig: support the most recent version of sysdig
Update the pcap-ng reader and sysdig event dissector to support the second version of the sysdig event block, which was introduced after Wireshark's original implementation
2021-04-09 01:24:53 +00:00
Gerald Combs b258f90ce5 GitLab CI: Try switching Windows builds back to Qt 5.15.1.
The Windows MR builder was recently migrated to a new machine and
updated to Qt 5.15.2. Since the migration merge request builds have
sometimes failed with

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(240,5): error MSB8066: Custom build for 'C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_de.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_en.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_es.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_fr.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_it.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_ja_JP.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_pl.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_ru.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_sv.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_uk.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\7345cb0fc1b52560d4d2bd48e83ff433\wireshark_zh_CN.qm.rule;C:\builds\wireshark\wireshark\build\CMakeFiles\9829b32238fa3bcc807b02099e4c1642\qtui_autogen.rule' exited with code -1073740940. [C:\builds\wireshark\wireshark\build\ui\qt\qtui_autogen.vcxproj]

Try switching back to Qt 5.15.1. If that doesn't work we might have to
un-migrate the runner.
2021-04-08 16:31:43 +00:00
Jirka Novak e462b2b1c2 RTP Player: Fixed issue with hanging the player at end of play on Windows
Changes:
- Fixed issue with hanging the player. The issue is in Qt - internal
  Mutex is locked when Qt calls outputStateChanged() and you can't call
  any other action on the audio object
- Fixed issue when play marker stream was running forever
- Removed !1855 because it introduces delay on play on Windows platform
2021-04-08 12:01:38 +00:00
Roman-Koshelev 33cdd795e8 STUN: Remove duplicate code 2021-04-08 07:52:03 +00:00
Thomas Dreibholz 9a41ec8697
Improved ASAP statistics. 2021-04-08 09:36:26 +02:00
Thomas Dreibholz 109de7891c
Changed group for ASAP Statistics. 2021-04-08 09:36:24 +02:00
Thomas Dreibholz 39fd3212b9
Added statistics group for RSerPool protocols. 2021-04-08 09:36:23 +02:00
Thomas Dreibholz 9587569f44
Added ASAP Statistics. 2021-04-08 09:36:21 +02:00
Sandip Mukherjee 9550944ef9 Added dissector changes in ptp for G.8275.2 Profile 2021-04-08 07:21:13 +00:00
Uli Heilmeier cd26f4bbb8 WSUG: Update print dialog
Update documentation to add optional header.
2021-04-07 05:40:50 +00:00
j.novak@netsystem.cz 2b072b8e76 RTP Stream Analysis: Process more streams than two, audio save removed 2021-04-07 05:40:09 +00:00
Gerald Combs fe7bf413fc GitLab CI: Clear our Windows build dependencies. 2021-04-06 16:52:43 -07:00
Gerald Combs 156737db0f GitLab CI: Add a Visual Studio code analysis step.
Add a Windows template.
2021-04-06 19:27:11 +00:00
Anders Broman 0d202254f8 PFCP: In UP Function Features dissect QUOAF bit. 2021-04-06 16:03:41 +00:00
Sebastien Henri f2091790a3 ieee80211: parse multiple TBTT in Reduced Neighbor Report
RNR can have multiple TBTTs; this is indicated by the TBTT Information
Count subfield, according to IEEE 802.11ai-2016 standard.

"The TBTT Information Count subfield is 4 bits in length and contains
the number of TBTT Information fields that are included in the Neighbor
AP Information field, minus one"

This commit adds parsing of all included TBTT subelements.
2021-04-06 14:54:55 +00:00
Sebastien Henri 6eb8a81d67 ieee80211: add 20 MHz PSD field in Reduced Neighbor Report
This commit adds the 20 MHz PSD field in Reduced Neighbor Report field,
as per Draft P802.11ax_D8.0, Table 9-281.
2021-04-06 14:54:55 +00:00
John Thacker d0088585b3 qcustomplot: Fix some warnings in upstream code
QPainter::HighQualityAntialiasing is obsolete and ignored
(https://doc.qt.io/qt-5/qpainter.html#RenderHint-enum) since
at least 5.6, so use Antialiasing instead, as indicated by the docs.
(https://doc.qt.io/archives/qt-5.6/qpainter.html#RenderHint-enum)

Explicitly cast a long to an int, like already done on line 21080.

Put in a break to suppress an overly aggressive fallthrough warning
on g++ (all values of an enum are tested, so it cannot actually fall
through.)
2021-04-06 07:43:55 -04:00
j.novak@netsystem.cz fe98c68224 RTP Player: UI improvements 2021-04-06 11:23:00 +00:00
Luis Colmenero 4d361cc7cb RTPS Fix locator port signedness
In rtps_util_add_multichannel_locator_list.
2021-04-05 21:37:10 +02:00
Martin Mathieson e06940d5a6 RTPS: Fix call to unsigned field for locator port 2021-04-05 19:53:14 +01:00
Luis Colmenero df5e4fe9aa RTPS: Fix missing port in LOCATOR_KIND_UDPV6
UDPv6 locators are missing the port field.
Modified rtps_util_add_locator_t so that UDPv6 locators interpret the
port, just as in the case for LOCATOR_KIND_UDPV4.
2021-04-05 13:55:51 +02:00
Martin Mathieson 059887e089 Clean up some cppcheck warnings. 2021-04-05 07:54:49 +00:00
John Thacker 69244cbb98 macos-setup: Update CMake, Qt, and Python
Update CMake (3.19.7), Qt (5.2.10), and Python (3.9.3) to later bugfix
versions of the current packages. CMake and Python have made tweaks in
the names of the binary packages that support different macOS versions.

Fixes downloading Python 3.9.2+ on macOS 11 after the package suffix
changed from -macos11.0.pkg to -macos11.pkg

Warn about the lack of Qt offline installers for version 5.15 and
greater.
2021-04-05 00:41:41 +00:00
Guy Harris d95213afb0 prefs: get rid of unused PREF_EFFECT_ flags.
Get rid of flags that are neither set nor tested.
2021-04-04 23:13:05 +00:00
Gerald Combs 4637111f6d GitLab CI: Make our MSBuild output more quiet. 2021-04-04 22:34:11 +00:00
Guy Harris 3231a33590 prefs: get rid of unused #define.
epan/prefs.h defines PREFERENCE_GROUPING, but nothing checks it, so
there's no point in defining it; it may have been checked when it was
added, but, if so, it's not checked any more, so remove it.
2021-04-04 21:47:53 +00:00
Gerald Combs 85b36ef4b6 GitLab CI: Switch to our new Windows runner. 2021-04-04 21:13:59 +00:00
Jim Young 56c540159d packet_list: Promptly reflect changes to frame.marked field
Add redrawVisiblePackets() to respond to user triggered event to
promptly trigger updates to the frame.marked field text when displayed
in the packet list.

Without this patch, if frame.marked is added as a custom column, updates
to the packet lists's frame.marked field text of packets will not be
immediately reflected in the packet list until some other event such as
adding a packet comment or ignoring a frame ultimately triggers
redrawVisiblePackets().
2021-04-04 17:18:13 +00:00
Nardi Ivan a97506d166 wslua_utils: fix a memory leak 2021-04-04 16:05:30 +00:00
Richard Sharpe 1dbd022c6b ieee80211: Improve the handling of the ISTA Availability bits field.
This change allows users to search the ISTA Availability bits with a
string like 'wlan.ranging.ista.availability_bits contains "11011"'.

Change-Id: I8bc0fbe1d6ffb61c749d8b48d773c3b86510c7f4
2021-04-03 16:26:15 -07:00
Martin Mathieson dff0f997de check_static.py check symbols that could be static.
As discussed at
https://www.wireshark.org/lists/wireshark-dev/202101/msg00056.html
2021-04-03 18:19:00 +00:00
John Thacker 35d47066b3 QCustomPlot: Update external library to version 2.1.0
QCustomPlot 2.1.0 was just released (Mar 29, 2021) and officially supports
Qt 5.12-6.0, which in order to support we've been patching it
internally. Update to this latest external version (after removing
the whitespace at the end of a bunch of lines internal to comments.)
(https://www.qcustomplot.com/index.php/download) Edited to include
the permission from the author Emanuel Eichhammer to use the GPLv2.
(Does someone need to ask if that permission applies to 2.1.0?)

Ping #17144 and #17163 but those bugs appear to still be here.
2021-04-03 17:56:01 +00:00
Martin Mathieson e83ee9b66a Add more common words to spelling dict. 2021-04-03 17:06:35 +00:00
Darius Davis 82b203dfee tvbtest: Test offsets returned by tvb_find on subsets.
This change extends tvbtest.c to validate the behavior of tvb_find_XXX and
tvb_ws_mempbrk_pattern_guint8 when used on subsets of composite tvbs (see issue
17245).

Without the fix for that issue, the test fails with:

13: Failed TVB=Subset of Composite Wrong offset for guint8:01, got 1, expected 0

With the fix, the test passes.
2021-04-03 15:12:20 +00:00