Commit Graph

83145 Commits

Author SHA1 Message Date
John Thacker ab347ea14e text2pcap: add regex
Add support in text2pcap for the regex mode added to "Import from
Hex Dump" in 3.6.0 The input and output indicators cannot (yet?)
be configured, and are set to the default of allowing any of "iI<"
for inbound and "oO>" for outbound. This reaches feature parity
between text2pcap and Import from Hex Dump, fixes #16724.
(There might be some more cleanups to do, including docs.)
2022-01-02 01:01:51 +00:00
Gerald Combs 6cdb86fbc7 Tools: Be more clear that we're matching the BSD 1-Clause license. 2022-01-01 15:25:21 -08:00
Roman Volkov b1bf0db069 mpeg table: add IDs for EIT schedule tables (0x50 - 0x6F) 2022-01-02 00:40:07 +02:00
João Valverde 12d39efdca Revert "epan: Initialize wiretap"
This reverts commit c15f2aadc1.

Crashes on exit. Needs more work.

Fixes #17821.
2022-01-01 16:23:04 +00:00
Roman Volkov 5ce73acf45 mpeg descriptor: update 0x50 to DVB BlueBook A038r14 2022-01-01 15:18:54 +00:00
Roman Volkov ee92914e10 mpeg descriptor: update 0x48 to DVB BlueBook A038r14 2022-01-01 15:18:54 +00:00
easonweii b90b4e5336 ISUP/BICC: Fixes parsing issues in some protocols.
Protocol parses some fields. As a result, the parsed result is inconsistent with the description in the protocol.
Register different fields in the BICC protocol and parse them separately.
The details are as follows:
1. Split the following fields in the ISUP protocol:
Continuity Indicator(isup.continuity_check_indicator)
End-to-end method indicator(isup.forw_call_end_to_end_method_indicator)
End-to-end method indicator(isup.backw_call_end_to_end_method_indicator)
End-to-end information indicator(isup.backw_call_end_to_end_information_indicator)
BICC indicator(isup.backw_call_isdn_user_part_indicator)
SCCP method indicator(isup.backw_call_sccp_method_indicator)
End-to-end information indicator(isup.forw_call_end_to_end_information_indicator)
BICC indicator(isup.forw_call_isdn_user_part_indicator)
BICC preference indicator(isup.forw_call_preferences_indicator)
SCCP method indicator(isup.forw_call_sccp_method_indicator)
2. Register the following fields in the BICC protocol again.
Continuity Check Indicator(bicc.continuity_check_indicator)
End-to-end method indicator(bicc.forw_call_end_to_end_method_indicator)
End-to-end method indicator(bicc.backw_call_end_to_end_method_indicator)
End-to-end information indicator(bicc.backw_call_end_to_end_information_indicator)
ISDN user part indicator(bicc.backw_call_isdn_user_part_indicator)
SCCP method indicator(bicc.backw_call_sccp_method_indicator)
End-to-end information indicator(bicc.forw_call_end_to_end_information_indicator)
ISDN user part indicator(bicc.forw_call_isdn_user_part_indicator)
ISDN user part preference indicator(bicc.forw_call_preferences_indicator)
SCCP method indicator(bicc.forw_call_sccp_method_indicator)
2022-01-01 14:06:21 +00:00
Stig Bjørlykke d8474fdee7 Happy New Year 2022 2022-01-01 14:08:38 +01:00
Gerald Combs 3cae0847fb Docs: Remove some Buildbot references. 2022-01-01 08:40:41 +00:00
Dario Lombardo b086e5192a extrememesh: check pinfo addresses before use.
Fix: #17777.
2022-01-01 08:25:31 +00:00
Gerald Combs 4e417b8e7c Windows: UTF-8 harder.
Set the process code page in wireshark.exe.manifest to UTF-8 as
described at

https://docs.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page

Make sure each of our command line resource files includes our main
manifest. Rename wiretap.rc to libwiretap.rc to match our other libraries.
2022-01-01 08:09:12 +00:00
Moshe Kaplan 67f05835ca Fix more repeated words throughout
Fixes more repeated words seen throughout
the code base.
2021-12-31 22:50:40 +00:00
Jakub Pawlowski 6930a2db83 BTHCI: add Major Device Class parser for LE Audio 2021-12-31 16:04:27 +00:00
John Thacker 4d7199d14b import_text: Add fake interface name to settings
Write and retrieve the interface name for "Import from Hex Dump"
to the settings file.
2021-12-31 15:49:21 +00:00
João Valverde 019bb06268 Docs: Add some content about different equality operators
Add information about the different kind of comparisons with
multiple fields to the wireshark-filter man page.

Add some minimal information to the user guide. It would be
nice to have a section dedicated to this with some examples.
2021-12-31 15:33:32 +00:00
João Valverde e724a4baf6 dfilter: Use ISO8601 as the default time format
Change from a default custom time representation to ISO8601.
All the existing formats are still supported for backward-
compatibility.

Before:

  Filter: frame.time == "2011-07-04 12:34:56"

  Constants:
  00000 PUT_FVALUE	"Jul  4, 2011 12:34:56.000000000" <FT_ABSOLUTE_TIME> -> reg#1
  (...)

After:

  Filter: frame.time == "2011-07-04 12:34:56"

  Constants:
  00000 PUT_FVALUE	"2011-07-04 12:34:56+0100" <FT_ABSOLUTE_TIME> -> reg#1
  (...)
2021-12-31 15:01:41 +00:00
Armin Felder e8e6a2c6df NTLMv2 dissector: skip target info for AUTHENTICATE_MESSAGE
if the NTLMv2 Message is of type AUTHENTICATE_MESSAGE,
there are no target fields, according to MS-NLMP 2.2.1.3,
Fixes #17817
2021-12-31 14:44:00 +00:00
Роман Донченко 777aaeda62 x509af: support dissecting public keys in RFC 7468 files 2021-12-31 14:14:09 +00:00
João Valverde a20f3649e8 arch-setup: Update requirements for user guides 2021-12-31 02:11:53 +00:00
Dario Lombardo 24403a9a35 rtmpt: limit the number of iterations in rtmpt_get_amf_length().
This prevents a infinite-loop caused by crafted packets.

Fix: #17813.
2021-12-30 22:14:37 +00:00
John Thacker 156a958d3f wsutil: Fix time zone handling.
Time zone handling was reversed, partially due to the tests having
it backwards.
2021-12-30 21:20:08 +00:00
Martin Mathieson d5cccc5398 MAC-NR: Add a bi-directional lcid field to filter on. 2021-12-30 21:19:51 +00:00
John Thacker b296db31a4 import_text: Allow setting interface name from GUI
Add the ability to set the interface name from the GUI
"Import from Hex Dump" just as with text2pcap. The last
feature for #16724 from the GUI side.
2021-12-30 14:10:04 -05:00
João Valverde 0047ca961f dfilter: Add support for entering time in UTC
Add the option to enter a filter with an absolute time
value in UTC. Otherwise the value is interpreted in
local time.

The syntax used is an "UTC" suffix, for example:

    frame.time == "Dec 31, 2002 13:55:31.3 UTC"

This also changes the behavior of "Apply Selected as filter".
Fields using a local time display type will use local time
and fields using UTC display type will be applied using UTC.

Fixes #13268.
2021-12-30 17:53:09 +00:00
John Thacker 42084c2d17 text2pcap: Move SHB and IDB setup to ui/text_import
Move the parameter setup to text_import, so that later it can
be called from the GUI, including the interface name. (This has
to be a separate function because these parameters need to be
set before the call to wtap_dump_open, which is different for
regular files vs temp files vs stdout.)
2021-12-30 17:05:06 +00:00
j.novak@netsystem.cz 6c9cb8f3fa Prefs/Extcap: Added support for password which is never stored on the disk 2021-12-30 16:03:15 +00:00
John Thacker 6d0bd4e8e1 text_import: Fix squished address line edits on MacOS
Add the same fix for Mac to the address line edits as the others.
2021-12-30 09:37:47 -05:00
Guy Harris 430bf3b6a4 kafka: have dissect_kafka_string_new() return the display string.
Instead of having it return the information needed to fetch the string
value, just have it return the string to use to display that string, as
that's all its only caller needs.

(Note that the display string has had control characters, etc. escaped,
which is what you want for text that appears in a string displayed in
the protocol details.)
2021-12-29 23:06:33 -08:00
John Thacker 021c25e22c text2pcap: Use standard log debug level
Remove the '-d' option from text2pcap, and move the two levels
of debug messages in text2pcap and text_import to either
LOG_LEVEL_DEBUG or LOG_LEVEL_NOISY as appropriate.
2021-12-30 01:17:06 +00:00
Gerald Combs 797c66cc4c NSIS: Complain about installing a 32-bit Wireshark on 64-bit Windows.
Show a warning messagebox if we're installing a 32-bit executable on
64-bit Windows.
2021-12-29 23:30:55 +00:00
Dario Lombardo ae9d3d1d4f kafka: remove compiler warnings.
1508 |     proto_item_append_text(header_ti, " (Key: %s)",
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1509 |                            tvb_get_string_enc(pinfo->pool, tvb, key_off, key_len, ENC_UTF_8));
      |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../epan/dissectors/packet-kafka.c:1501:18: note: ‘key_len’ was declared here
 1501 |     int key_off, key_len;
      |                  ^~~~~~~
../epan/dissectors/packet-kafka.c:1508:5: warning: ‘key_off’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 1508 |     proto_item_append_text(header_ti, " (Key: %s)",
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1509 |                            tvb_get_string_enc(pinfo->pool, tvb, key_off, key_len, ENC_UTF_8));
      |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../epan/dissectors/packet-kafka.c:1501:9: note: ‘key_off’ was declared here
 1501 |     int key_off, key_len;
      |         ^~~~~~~
2021-12-29 23:15:39 +00:00
Dario Lombardo 1abc6bd3b1 ci: run checks on all the commits in the current MR.
Fix: #16813.
2021-12-29 22:11:48 +00:00
Dario Lombardo 5e08fbef54 appveyor: drop win32 build.
Ref: #17779.
2021-12-29 19:32:11 +00:00
Gerald Combs 044c3a594b GitLab CI: Stop building 32-bit Windows Installer (.msi) packages.
The 32-bit Windows Installer / WiX / .msi packages make up a tiny
percentage of our downloads, and they take a non-trivial amount of time
to create. Stop building them. Ping #17779.
2021-12-29 18:19:11 +00:00
Gerald Combs 3c0198492d Kafka: Add back some code.
a03f43645d removed some code that set offset and length parameters. Add
it back.
2021-12-29 09:49:49 -08:00
Uli Heilmeier 5800b65a81 OpenVPN: Add P_CONTROL_HARD_RESET_CLIENT_V3 opcode
With https://github.com/OpenVPN/openvpn/blob/master/doc/tls-crypt-v2.txt
OpenVPN has introduced a new opcode.

Fixes: wireshark/wireshark#17806
2021-12-29 16:03:46 +00:00
João Valverde 60533a55ff wslog: Add WS_DEBUG_HERE() macro
Add a LOG_LEVEL_ECHO that is always active and always non-fatal.

Use that to implement a WS_DEBUG_HERE() macro for quick print outs
during debugging sessions.
2021-12-29 15:21:46 +00:00
John Thacker 15fa09e5e3 import_text: Move IPv6 header control, use QComboBox
In "Import from Hex Dump", change the control that determines
IPv4 versus IPv6 to a QComboBox, and move it into the grid of
options, in the IP option section.
2021-12-29 15:06:33 +00:00
John Thacker c1d7069a83 text_import: Only popup a warning about offsets the first time
Only warn about the parser getting an unexpected offset when
using OFFSET_NONE the first time. Use log warnings for subsequent
messages.

Strip off the whitespace/newline/colon from the offset when adding
it to the message, only output the offset number.
2021-12-29 14:45:10 +00:00
João Valverde 62c9f333f7 epan: More abs_time_to_str() cleanups
Use abs_time_to_str() to implement abs_time_secs_to_str().

Misc cleanups.
2021-12-29 13:50:21 +00:00
João Valverde 64572a11f9 dfilter: Use better error messages for absolute times 2021-12-29 02:25:38 +00:00
João Valverde 7e041118d8 epan: Add back ABSOLUTE_TIME_NTP_UTC representation
It is a special case the prints "NULL" if time is zero.
2021-12-29 00:30:17 +00:00
Christian Svensson 0d471d9fe9 sflow: Rename fields to match protocol specification
- Rename "Original packet length" to "Sampled header length"
 - Rename "Payload removed" to "Payload stripped"

Signed-off-by: Christian Svensson <blue@cmd.nu>
2021-12-28 21:57:21 +00:00
Guy Harris b38987573e text_import: use 4-space indentation for number_of_padding_bytes().
It's the only routine that doesn't use 4-space indentation.
2021-12-28 20:57:28 +00:00
Chuck Craft 9a9a754378 Qt: byteview mouse hover highlights not selects 2021-12-28 20:39:11 +00:00
Gerald Combs a03f43645d Kafka: Be more strict when dissecting varints.
The Kafka dissector uses the return value of tvb_get_varint to advance
the packet offset in many places. If tvb_get_varint fails it returns 0,
which means our offset isn't guaranteed to advance. Stop dissection
whenever that happens. Fixes #17811.
2021-12-28 19:06:10 +00:00
Dario Lombardo 1810ad641d github: bump msbuild version. 2021-12-28 18:49:24 +00:00
Dario Lombardo c3bbca8e73 github: update artifacts uploading. 2021-12-28 18:49:24 +00:00
John Thacker 44d27e975a text_import: Switch default IPv4 addresses to what text2pcap used
text2pcap used 10.1.1.1 and 10.2.2.2 for default IPv4 addresses,
and "Import From Hex Dump" used 1.1.1.1 and 2.2.2.2. The former
are a little bit better for defaults since they're RFC 1918
private IP addresses, so let's use them for the common code.
2021-12-28 11:00:46 -05:00
Jaap Keuter fb48954f26 Update model list based on libgphoto2 repo dated 27 dec 2021 2021-12-28 13:28:44 +00:00