84c08f1472
From Juha Siltanen :
...
When sorting a capture by protocol, some RTP packets are shown only as FLIP,
even though the dissection windows shows the RTP tree.
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5215 )
svn path=/trunk/; revision=34128
2010-09-15 21:17:35 +00:00
8421bbd8a3
Add more GUIManager code #ifdef:ed out.
...
The popups should be working now exept for protocol help.
Help with testing and cleaning up apreciated.
GTK 2.6 requred, I'll look into that too later if no one beats me to it.
svn path=/trunk/; revision=34127
2010-09-15 20:51:44 +00:00
c3beba4fd1
Bug #5127 from Guenter Strubreiter:
...
for avoiding doubled definition of a table needed also by a tcap subdissector
plugin a definition in libwirshark.def is needed:
isup_calling_partys_category_value
Me: Change extern to WS_VAR_IMPORT in header file
svn path=/trunk/; revision=34126
2010-09-15 20:29:31 +00:00
dcf1ce54da
Missed this one (check_col() removal)
...
svn path=/trunk/; revision=34125
2010-09-15 16:17:16 +00:00
a5532739d6
Remove a few more calls to check_col()
...
svn path=/trunk/; revision=34124
2010-09-15 16:16:23 +00:00
fbf198ae9b
Add expert info for timing adjustment control message, and tweak a label.
...
svn path=/trunk/; revision=34123
2010-09-15 15:52:30 +00:00
71fca3c87f
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 differently:
...
On Windows, rename inet_pton() to ws_inet_pton() so that builds on Vista or
later systems (that have inet_pton() natively) will still work on pre-Vista
systems.
svn path=/trunk/; revision=34122
2010-09-15 15:13:40 +00:00
4584a81149
Revert 34081 and 34093 in preparation for a cleaner fix.
...
svn path=/trunk/; revision=34121
2010-09-15 15:13:17 +00:00
2b52159449
Follow up to bug 5209 and rev 34115:
...
%hh is C99 so remove it from packet-ssl-utils and add it to the banned list
(similar to %ll) in checkAPIs.pl .
svn path=/trunk/; revision=34120
2010-09-15 14:10:25 +00:00
0583c64d8f
Clean up the icmp info column per discussion in bug #4014 .
...
Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE
in the proto_tree_add_item() calls for the identifier and sequence numbers.
svn path=/trunk/; revision=34119
2010-09-14 21:38:54 +00:00
31cf5ad237
Add more GUIManager code #ifdef:ed out
...
svn path=/trunk/; revision=34118
2010-09-14 20:50:03 +00:00
07c7d3046a
Remove duplicate register_all_protocol_handoffs entry
...
svn path=/trunk/; revision=34117
2010-09-14 16:03:34 +00:00
fe45005420
Bug #5211 from Guenter Strubreiter:
...
for writing a TCAP subdissector as a plugin some functions are needed in
libwireshark.def for export
svn path=/trunk/; revision=34116
2010-09-14 15:54:12 +00:00
436ab95472
From Cal Turney via bug 5209:
...
Decode of SETCLIENTID calls in the Windows x86 version fail with "[Dissector
bug, protocol NFS: STATUS_ACCESS_VIOLATION: dissector accessed an invalid
memory address]". This error occurs in packet-nfs.c in
dissect_nfs_clientaddr4() where vars 'protocol' and 'universal_ip_address' get
stepped on following the call to scanf(). The b1-b10 vars are declared as
quint8. While "hh" modifier used in the scanf() is documented in Linux to
correspond to an a signed/unsigned char arg, I cannot find a similar
designation in Windows (MSDN). The Windows C compiler interprets %hhu as
corresponding to a int16 rather than int8.
svn path=/trunk/; revision=34115
2010-09-14 15:43:19 +00:00
97d69446ea
From tieuthunhi:
...
Add new time source for Gigamon header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5210
svn path=/trunk/; revision=34114
2010-09-14 14:43:56 +00:00
14b9a4c56a
From Vincent Helfre:
...
Incorrect decoding of List of ARFCN in BCCH frequency list.
When the range 1024 is selected, it can happen that 2 bytes need to be read for
W1, and also for W2. In the current version, when W1 ends on a byte boundary,
W2 will get an incorrect value, since it will be truncated by 1 bit.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5214
svn path=/trunk/; revision=34113
2010-09-14 14:24:39 +00:00
7768145b5e
Add more GUIManager code #ifdef:ed out
...
svn path=/trunk/; revision=34112
2010-09-13 20:21:41 +00:00
4c74418400
Attempt to fix the stack overflow reported at
...
http://seclists.org/bugtraq/2010/Sep/87 .
Unfortunately no one from the NCNIPC pen test team has contacted us or
provided a sample capture so the fix hasn't been verified.
svn path=/trunk/; revision=34111
2010-09-13 18:49:55 +00:00
5a28b5317e
From Yaniv Kaul:
...
[PATCH] Add SSL cipher 'Transport Layer Security (TLS) Renegotiation Indication Extension' (RFC 5746)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5207
svn path=/trunk/; revision=34110
2010-09-13 16:51:10 +00:00
82ed2ba728
set_menu_sensitivity() is used only if MENUS_USE_UIMANAGER is defined,
...
so define it only if MENUS_USE_UIMANAGER is defined.
Clean up indentation.
svn path=/trunk/; revision=34109
2010-09-12 22:36:52 +00:00
9583a67e2d
Get rid of /* within comment, clean up white space.
...
svn path=/trunk/; revision=34108
2010-09-12 21:53:26 +00:00
6117e317c6
Remove deprecated check_col().
...
svn path=/trunk/; revision=34107
2010-09-12 19:29:05 +00:00
b1d1e4bda6
Add more GUIManager code #ifdef:ed out
...
svn path=/trunk/; revision=34106
2010-09-12 19:26:42 +00:00
bc8ce9e9e3
[Automatic manuf and enterprise-numbers update for 2010-09-12]
...
svn path=/trunk/; revision=34102
2010-09-12 15:03:34 +00:00
cfbd48b785
Decode SLL payloads using a dissector table based on sll.ltype.
...
The idea and the original patch came from Sebastian Reichel
<elektranox@gmail.com> in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594390
svn path=/trunk/; revision=34101
2010-09-12 01:13:42 +00:00
894941e532
Only check for 4 NOP in a row within a uint32 boundary.
...
svn path=/trunk/; revision=34100
2010-09-10 21:24:32 +00:00
633e4e324b
From Martin Peylo via bug 5198:
...
Added missing OIDs in CRMF (RFC 4211) dissector.
svn path=/trunk/; revision=34099
2010-09-10 21:22:29 +00:00
8d8c397852
Use absolute paths in link_directories.
...
svn path=/trunk/; revision=34098
2010-09-10 16:50:12 +00:00
f2e302eee0
Follow TCP and expand description for "NOP" and "EOL" options to "No-Operation (NOP)"
...
and "End of Options List (EOL)" respectively.
svn path=/trunk/; revision=34097
2010-09-10 16:48:00 +00:00
0e0641f079
Put the ": %u (multiply by %u)" back on the TCP window scaling option, so
...
users don't have to expand the tree to see the details that were there
before rev 34094.
svn path=/trunk/; revision=34096
2010-09-10 16:33:46 +00:00
f2e2be709a
Expand description for "NOP" and "EOL" options to "No-Operation (NOP)" and
...
"End of Options List (EOL)" respectively.
svn path=/trunk/; revision=34095
2010-09-10 16:23:58 +00:00
8d3e472866
Enhance the TCP option display for window scaling.
...
svn path=/trunk/; revision=34094
2010-09-10 16:12:17 +00:00
a81a10a63a
From BBA via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 :
...
Followup to 34081: move libwsutil _all_ the way forward so that our inet_pton
is always linked in before wsock32's. This means that our Windows-7 Win64
builds (on which there is a native inet_pton in wsock32) will still work on
pre-Vista Win64's.
svn path=/trunk/; revision=34093
2010-09-10 13:52:42 +00:00
aca8a4d989
Update dsfield ECN according to RFC3168.
...
svn path=/trunk/; revision=34092
2010-09-10 11:16:29 +00:00
11ee648da3
Add some hf blurbs (for fields whose description is an acronym)
...
svn path=/trunk/; revision=34091
2010-09-09 18:36:20 +00:00
8b7784d08e
Remove what appear to be two redundant lines of code (AFAIKT).
...
svn path=/trunk/; revision=34090
2010-09-09 17:30:35 +00:00
137054603c
Resolve another issue the Windows buildbots are having after rev 34084:
...
guint8 -> guint16 for th_flags variable in segment struct.
svn path=/trunk/; revision=34089
2010-09-09 15:46:40 +00:00
ff5cfee491
Turn the TCP timestamp option into a subtree to also show the option kind,
...
option length and values with proto_tree_add_item() intead of _add_text().
The options tree still shows the same information as before until the sub-
tree is expanded.
The goal is to do this with all TCP and IP options.
svn path=/trunk/; revision=34088
2010-09-08 23:10:52 +00:00
d968bc8b61
Mask out the header length from th_flags.
...
svn path=/trunk/; revision=34087
2010-09-08 21:25:14 +00:00
b17b2eb187
Make the Windows buildbot happy: guint8 -> guint16 for flags variable in
...
definition of tcp_analyze_sequence_number().
svn path=/trunk/; revision=34086
2010-09-08 21:11:45 +00:00
e12fc91a33
Minor correction to SVN revision 34084: we better only try up to the 9
...
available values in flags[], so we don't run past the end of the array
if one of the reserved flags is set.
svn path=/trunk/; revision=34085
2010-09-08 20:52:00 +00:00
dfacac4421
Expand the TCP flags to include the low nibble of the byte that has
...
the header length in the high nibble. The only new flag is nonce (NS);
the remaining three bits are still reserved.
svn path=/trunk/; revision=34084
2010-09-08 20:43:19 +00:00
4c6864b29b
From Frank Lahm via bug #5169 : Provide initial support for the undocumented
...
AFP FPSpotlightRPC call.
svn path=/trunk/; revision=34083
2010-09-08 19:01:41 +00:00
390927ce12
Follow up to rev 34073: Since "-b files:0" is no longer necessary to
...
override the default of turning on a multiple file ring buffer, require
a positive integer to be specified for the files value.
svn path=/trunk/; revision=34082
2010-09-08 18:47:14 +00:00
875c97aedf
Attempt to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 :
...
Move libwsutil forward in the list of Wireshark libraries so that our inet_pton
is always used.
svn path=/trunk/; revision=34081
2010-09-08 16:51:12 +00:00
e71daa1fc1
Revert revision 33780, because the checksum is only calculated
...
from the header and not the content.
svn path=/trunk/; revision=34080
2010-09-08 13:38:47 +00:00
c1a591cd37
Support negative values when viewing seconds with hours and minutes.
...
svn path=/trunk/; revision=34079
2010-09-08 10:29:06 +00:00
9562d30a13
Allow for proto_tree_add_item() with FT_ABSOLUTE_TIME and FT_RELATIVE_TIME
...
to have length == 4 (only seconds).
svn path=/trunk/; revision=34078
2010-09-08 09:33:53 +00:00
bc11261a75
From Yaniv Kaul via bug 5193:
...
Dissect NTLMSSP type 0x5 (DNS Forest name).
svn path=/trunk/; revision=34077
2010-09-08 09:24:53 +00:00
eb503df011
Do not report undecoded message to expert info for ReturnResult without result filed
...
svn path=/trunk/; revision=34076
2010-09-08 09:02:16 +00:00
Sake Blok