I tested your update ("wireshark -r foo.pcap" from a cmd window) and
found that it did not use the current folder for the next Open dialog
and didn't save the folder in recent. The attached patch prepends the
filename with the current folder.
From me: don't leak memory when doing it.
svn path=/trunk/; revision=33863
I try use diameters XML files as sources for my XSL transform by xslt and found
some typos. I attach patch for fixing it.
svn path=/trunk/; revision=33862
- Display current value in combo boxes (pixels_per_tick, etc) to always
match actual values being used to create graph;
- yscale combo box entries:
show values >= 1 sec as sec (not s000 ms);
- Determine max yscale label width properly as the largest of the
top or middle label lengths;
- Cleanup some indentation.
svn path=/trunk/; revision=33855
1. Incorrect specification of units: Should be ms & s not us and ms;
Bug introduced in SVN #33834.
2. Selecting 50ms as the yscale actually used 50us as the scale;
Bug introduced in SVN #30543.
svn path=/trunk/; revision=33854
EG: Non-event signal callback functions shouldn't
be directly used as event callback functions.
Replace use of deprecated "GtkSignalFunc";
Whitespace cleanup.
svn path=/trunk/; revision=33849
bootp dissector when dissecting packetcable MTA capabilities).
Limit the tlv_len to G_MAXUINT16 to prevent an integer overflow from causing us to
increment the working offset by 0 (thus causing us to loop).
svn path=/trunk/; revision=33846
and ^A as Edit->Select All.
Add more details about implementing Undo/Redo/Cut/Copy/Paste/Select All
in the comment for the placeholder items.
svn path=/trunk/; revision=33845
- Non-event signal callback functions should return void;
- Event signal callback had missing 'user_data' arg;
- Rename various symbols for clarity;
- Rename local functions with names of form gtk_...;
- Use gboolean where appropriate;
- Remove all 'exit(10)' statements;
- Whitespace;
- ...
svn path=/trunk/; revision=33843
Good ZigBee Beacon detected as malformed
In ZigBee 2006 the Tx-Offset is optional, while in the 2007 and
later versions, the Tx-Offset is a required value. Since both 2006 and
and 2007 versions have the same protocol version (2), we should treat
the Tx-Offset as well as the update ID as optional elements
svn path=/trunk/; revision=33842
current file name.
This fixes a crash after failing to allocate some massive number of bytes if
the file name did not contain a path--which is the case when doing
"wireshark -r myfile.pcap".
svn path=/trunk/; revision=33841
- Display current value in combo boxes (pixels_per_tick, etc) to always
match actual values being used to create graph;
- yscale combo box entries:
show ms values as ms (not x000 usecs);
show us values with unit "us" (not "ms");
- Determine max yscale label width properly as the largest of the
top or middle label lengths;
- Cleanup some indentation.
svn path=/trunk/; revision=33834
- all: filter_te_syntax_check_cb should have an (unused) 'gpointer user_data' arg;
- filter_dlg.c: filter_sel_list_cb user_data arg is unused;
svn path=/trunk/; revision=33828
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5067
From me: - Fix one bug;
- Add a comment about some code which doesn't display info
in COL_INFO as intended due to what seems to be a Wireshark bug in
tcp_dissect_pdus() when there are multiple records in a
TCP frame.
svn path=/trunk/; revision=33824
list and once with the old packet list.
Have Boolean variables for some of the predicates in
set_menus_for_selected_packet(), to clarify what they're testing.
Clean up indentation.
Add some comments for various issues.
(FYI, what "Restore the functionality of <Ctrl>A and <Ctrl>X to the
filter textbox." means, in the comment for the previous checkin, "don't
use <Ctrl>A or <Ctrl>X for our own purposes, so they work the same way
they do in other applications using GTK+"; the checkin changed some menu
items not to use <Ctrl>A and <Ctrl>X as accelerators.)
svn path=/trunk/; revision=33823
1. Restore the functionality of <Ctrl>A and <Ctrl>X to the filter textbox.
2. Assign intuitive shortcuts without consuming any new shortcut letters.
3. Add 'Un-Time Reference All Packets' to the menu.
4. Disallow the marking or ignoring of all packets in the capture.
5. Make the Mark/Ignore/Time Reference-related menu items context sensitive.
6. Add 'ref_time_count' to the capture_file structure
7. Utilize marked/ignored/ref_time_count vars to prevent needless looping thru
the entire packet list by exiting the loop when it becomes zero.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5115
svn path=/trunk/; revision=33817
