Fix multiple problems with UE IP address Pool Identity
* the length of the length field needs to be added to offset
* the length field is two bytes long
* the bitmask on the lenght field is wrong
* add "Length" to the description of the length field
* decode UE IP address Pool Identity as string
Decoding the field as string makes sense because it originates from
a DIAMETER attrbiute that would usually also be decoded as string.
Fixes a very small part of #11398.
The fields were incorrectly identified as error fields because Mangos,
the most popular open source emulator in 2009 incorrectly identified it
as such.
Reverse engineering of the client revealed that the fields were protocol
versions.
As well as misidentifying the field, the WOW_SERVER_TO_CLIENT version
also read the wrong field. The actual error field is the one that comes
after the protocol version field.
Correct packets are in Ember
WOW_CLIENT_TO_SERVER
03c130d3d6/src/login/grunt/client/LoginChallenge.h (L39)
WOW_SERVER_TO_CLIENT
03c130d3d6/src/login/grunt/server/LoginChallenge.h (L33)
As well as the Wiki
https://wowdev.wiki/Packets/Login/Vanilla#Challenge_packets
Move common fuzzing configuration items to .fuzz-ubuntu. Build using
Clang, which is what the Buildbot fuzzers did. Add jobs for fuzzing
using Valgrind and randpkt.
This reverts commit b258f90ce5, which was
an attempt to fix a CI build issue by changing our Qt version. That
didn't fix the issue. Switching from CMake 3.20 to 3.19.8 *did*, which
suggests that we've run into
https://gitlab.kitware.com/cmake/cmake/-/issues/21145
Add a -t option to tools/fuzz-test.sh which lets you specify a maximum
fuzz time.
Add an initial "fuzz-test" job which fuzzes test/captures/* for 5
minutes. To do: Fuzz longer using our capture menagerie and report
failures.
When button is pressed or triggered by shortcut, it opens same
window as before.
User can click small arrow next to button and it open menu with all
new actions e.g. Set/Add/Remove for RTP Player.
Documentation updated.
Rename the "docbook" job to "documentation". Make sure we can do syntax
highlighting and produce PDFs. Distribute the docs that we build. Allow
the job to be manually run if we don't update any documentation sources.
Code is NOT able to do VAD (Voice Activity Detection) so audio silence
(sequence of equal samples) nor noise are not recognized as silence. Just
missing RTP (Confort Noise, interupted RTP, ...) and muted streams are
recognized as silence for this feature.
User can control duration of shortest silence to skip.
Updated documentation.
Not initialized GUID in function dissect_rtps_submessages leads to
malformed packets due the nested submessage dissection functions
insert/reads it from a map.
Introduces a new bit "Cloud Discovery Service Announcer"
into the PID_VENDOR_BUILTIN_ENDPOINT_SET parameter
send with DATA(P) messages to indicate that the DATA(P) message is
coming from Cloud Discovery Service.
Build the wsar_html_zip instead of wsar_html and (re-)publish it at
https://www.wireshark.org/download/docs/. Move the doxygen_all job to
the daily schedule section.
N.B. Didn't find the spec for this, but the pipeline warning is as follows
Field 'RDMA Provider Type (RDMA_PRTYPE)' (nvme.cmd.get_logpage.identify.rcrd.tsas.rdma_prtype) has a conflicting entry in its value_string: 3 is at indices 2 (RoCE (v1)) and 4 (iWARP)
Gerald Combs
Vadim Yanitskiy