Patch Set 3:
> Could you elaborate, why root access was necessary for tests
> before?
root access was not necessary for tests before. But newly added ARM testing through qemu would usually require root access due to chroot and debootstrap requirements. However by using fakeroot and proot we can fake it and avoid requiring root access to run the new added parts.
Patch-set: 3
Label: Code-Review=0
Patch Set 3:
> doesn't require root access to run the tests
Could you elaborate, why root access was necessary for tests before?
Patch-set: 3
Reviewer: Max <1000006@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=0
Patch Set 3:
> Ok, but probably, this test will also fail a CPU without
> SSE support, because it's expected in the *.ok file.
Ah well, I realized now there's the "SSE" word in the output, but the way it checks is generic, I mean it works the same for ARM implementation since it uses the same API. We just need to get rid of the "SSE" strings in the .ok which may be misleading.
I am waiting to see if issue #2826 is resolved as "it's fine to have slightly different output", in which case I will simply create different .ok files and create different tests to be run using the same binary. If values of the output vector should be the same, then for sure we can use only 1 binary/test for all archs.
Patch-set: 3
Patch Set 3:
Ok, but probably, this test will also fail a CPU without
SSE support, because it's expected in the *.ok file.
This topic is probably for a separate commit ;)
Anyway, great to see how OsmoTRX becomes better!
Patch-set: 3
Reviewer: Vadim Yanitskiy <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=0
Patch Set 3:
> I think in general it makes sense to separate this test to several
> ones, enabling or disabling them for particular architecture,
> instead of disabling...
I'm disabling it for now due to a known bug (https://osmocom.org/issues/2826), but the test is written in a way that should work for any architecture.
Patch-set: 3
Patch Set 3:
I think in general it makes sense to separate this test to several
ones, enabling or disabling them for particular architecture,
instead of disabling...
Patch-set: 3
Uploaded patch set 3.
Patch-set: 3
Subject: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set
Commit: d47d71b9f9
Groups: d36ef2f57b
Patch Set 2: Verified-1
This commit needs to be sent to jenkins once this commit is merged: https://gerrit.osmocom.org/#/c/5759/ (I651e182dfd62ef4b88d013d8b5960ce7e3562ecf)
This way it will trigger build of ARM tests.
Patch-set: 2
Label: Verified=-1
Uploaded patch set 2.
Patch-set: 2
Subject: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set
Commit: 611b5653d9
Groups: d36ef2f57b
Uploaded patch set 1.
Patch-set: 1
Change-id: Iba3f4de008662805d8ffc46e1f473e407b088fb8
Subject: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set
Branch: refs/heads/master
Commit: 944d6091fe
Groups: d36ef2f57b
Pau Espin Pedrol