Update patch set 1

Browse Source

Patch Set 1:

I agree, using the term TX/RX "path" sounds better to me, but I tried to stick to UHD terminology.

 > Adding more command-line arguments is in-line with the current
 > "architecture" but becomes more and more clumsy and cumbersom - at
 > some point we have to introduce the libosmovty based config file
 > that we're talking about for years.  The question is whether we
 > should keep adding new argumetns, or simply refuse to do so until a
 > config file exists...

I agree that we should move to VTY, as it starts to be cumbersome to add more parameters and manage them. There's a ticket already created to do it: https://osmocom.org/issues/2183. Shall we increase priority? I or someone else can work on that at some point.
However, I still think having this RX/TX antenna support has more priority so let's merge it for now and drop all the parameters later.

Patch-set: 1

...

This commit is contained in:

Pau Espin Pedrol 2018-02-05 13:29:38 +00:00 committed by Gerrit Code Review

parent db1808bce2

commit 7d8cc3bc8c

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available