Commit Graph

7 Commits

Author SHA1 Message Date
Gerrit User 1000074 8e67abee28 Update patch set 1
Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1
2019-06-19 15:58:10 +00:00
Gerrit User 1000008 a3dbbdac2e Update patch set 1
Patch Set 1:

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000008 <1000008@035e6965-6537-41bd-912c-053f3cf69326>
2019-06-19 15:49:20 +00:00
Gerrit User 1000008 3f4fcbb0f4 Update patch set 1
Patch Set 1:

It seems to me that tail-recursion should be possible in python - at least from some comments on the web, but it's clearly not working here.

This might also have implications in conn_client (which calls itself) and recon_reader (which calls conn_client and is called by conn_client->ctrl_client).

conn_client is easily modified, should we pass-through the exception in recon_reader and then just catch it in conn_client and reconnect?

Patch-set: 1
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Reviewer: Gerrit User 1000008 <1000008@035e6965-6537-41bd-912c-053f3cf69326>
2019-06-19 15:44:22 +00:00
Gerrit User 1000074 20d8d56dc6 Update patch set 1
Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
2019-06-19 15:43:58 +00:00
Gerrit User 1000002 c27a637584 Update patch set 1
Patch Set 1: Verified+1

Build Successful 

https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-python-tests/161/ : SUCCESS'  --verified 1 --code-review 0

Patch-set: 1
Tag: jenkins-gerrit-trigger
Reviewer: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Label: Verified=+1
2019-06-19 15:40:36 +00:00
Gerrit User 1000002 0b61637f3d Update patch set 1
Patch Set 1:

Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-python-tests/161/

Patch-set: 1
Tag: jenkins-gerrit-trigger
CC: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
2019-06-19 15:39:17 +00:00
Gerrit User 1000008 5352159e28 Create change
Uploaded patch set 1.

Patch-set: 1
Change-id: Ic909e371771f3056cb87e18793fd4225ffb90a2c
Subject: osmo_trap2cgi.py: Don't recurse in ctrl_client()
Branch: refs/heads/master
Status: new
Topic: trap2cgi-fixes
Commit: 5869a38cd5
Tag: autogenerated:gerrit:newPatchSet
Groups: f52d4a63d9
Private: false
Work-in-progress: false
2019-06-19 15:39:09 +00:00